From nobody Sat Apr 18 09:23:42 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27653C43334 for ; Fri, 15 Jul 2022 03:01:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241240AbiGODB1 (ORCPT ); Thu, 14 Jul 2022 23:01:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241190AbiGODBX (ORCPT ); Thu, 14 Jul 2022 23:01:23 -0400 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80084.outbound.protection.outlook.com [40.107.8.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAE3B48C8D; Thu, 14 Jul 2022 20:01:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cV0XiJe2WDZsP3mfktQ6FkW9e2MyIQemfEtr7PNFCd8mLRBFhVNDQbg4ljd2p2FVP9SYBbmSFJAgLXhuXzyiNZX3RR4zzYtZojPLSZB/x9KT72H7xaibOjDzTt9Cx+T0x8hSwWYhKdP5yrhgftLX/JIZtzYIwq6jlTqGEqu3x/eHp5ph5bCT2kquecOjlVOsqr2CdCi4lvZnnc6cyXVn0hUXtrE5a+nWCJ+wpM02lptxf7JQIl0PjHB8MQwXiZAW+b1CU1HCgo0XU8KLXu6Tn1GJwN87cRzL9H0Cm0RxRmllYIwK2hhY4e/4zr9Vmw+l3UAWEUSrwRmw8DWcYd5J3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DEkzpSnvvSrT0u6PI1/8TnPGzwge9riiOLKhwoODTkI=; b=iVoPo5XTaEGZoQ7y9q0F8Y2Ux21k5xjVEn75Fzxxk8vq/VnrhQiITlVahvlWjm74zIeIUq1FTJtmMaFCVfNav8VD+IH6+SmkGXhoJn/GpE9Fsp4djDl5TrBn0pzMj4r2ujEHrn2N9IwVOovz7M/BTyUN2NjQz4WIEoQE+MIAKKmVzB95+GQEQc5dSkjsN/1QL2pVnZ9KG+KdtiNLG7HmO9UeKEJx2Au+V283m+Bo991jhUltKThF1yv18iCFgNRJkXGz2A9UKblFQ5vSe364ASenW/66RM1y10GlPT/zPL70jU6z9EvVy+UdhjXzyAaG6azi+nlhoNAmdClBkFg7dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DEkzpSnvvSrT0u6PI1/8TnPGzwge9riiOLKhwoODTkI=; b=EEv7T5mwiFDkFu9qsAMYjAkf6bn7NgBXT09qQgNOc4digXFhivNPQRTdr94ky+MOJJGqO5bNVboKp8y4pfTcdPgW2o76TgdZEUZn4NdYQeZFhwu0JGHj+W8G0OMgcQp/e+Q2L68Mypr12vz8fGpfadRakXIBsxt+N4mrDjqWYrQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) by VE1PR04MB6477.eurprd04.prod.outlook.com (2603:10a6:803:11e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Fri, 15 Jul 2022 03:01:19 +0000 Received: from AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::3cec:d61:3836:2826]) by AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::3cec:d61:3836:2826%5]) with mapi id 15.20.5438.017; Fri, 15 Jul 2022 03:01:19 +0000 From: Sherry Sun To: gregkh@linuxfoundation.org, jirislaby@kernel.org, michael@walle.cc Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com Subject: [PATCH 1/2] tty: serial: fsl_lpuart: correct the count of break characters Date: Fri, 15 Jul 2022 10:59:43 +0800 Message-Id: <20220715025944.11076-2-sherry.sun@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220715025944.11076-1-sherry.sun@nxp.com> References: <20220715025944.11076-1-sherry.sun@nxp.com> X-ClientProxiedBy: SG2PR01CA0163.apcprd01.prod.exchangelabs.com (2603:1096:4:28::19) To AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b9588dc2-19e2-4311-b24d-08da660e4a7b X-MS-TrafficTypeDiagnostic: VE1PR04MB6477:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fxx37VtK+pabZiBSZl3kly0bl7iagNrj0Epg1tpgfKCvAQ0YYO+TTPggg9SoxADJ6Us+7RkTcnEf23F3pwD3m+dO2XwAOOYU+7bKfFbWhFZ+KGlzGssUkuOljk3sCwve3suxSLIocvvqC9d9F/5GjaIVld0MwgLSW4sY7cttYhTu3xVaiH5wJZ3sdHouMkP/jr1pieyNdOMKNOGLow9YuC6Mm0jPQQDWl+6FRrfTvxcQxjuviz8OJkfMoH3tiQwKLa0ooxDXbsVF3iI5F2E58RY+BaBkroIwcXUf+OJoAeM4qmfLaCYQZnNORYPLICVXJ1OM3/xl68bo+ENG5V9cd1ePUhquVY0l9Lgo2RnPvx/xM7inbfy19QGIfqsneU9TQGgjtjWnKoxuz5xVUoRX1vgKGhnTNKilS6FRy+uuz4hrjlSFfcNZMtSxdz7Uy76t8Bfu+73MeSIVJtgo0Kjk8QBbv+Ssx7/WDf33QsjzJnwsrsU519hm39mO1vU0gbGqkOQ1CHDYKFuyK6mnAaEgc5EwkVwwOB777KtJpA7Q38zIuoG/vqahRdhmvPCNE4XxBLuZK8M/ZE0gggNEAu2Ezj/E9mdfVFmoOy7FbOem9mpEpREZ3NI4qNzxYcZYoe19l7+fPK9FXQWFdjdqc3ckJpch+KHFw4LZgeyG4qvQvLJLG7VmOkfsTbbKTBUIANX5cYrFvUjTbHTJJJHVx7FwaaY7oeE0FLYI6lU6ooazZKtcBbex/XZfs/j5/MW/QzUL0z8L4Gz2quSlE1ECgH2yonUlRJ5XQffJrDhJq0DofWocvKmz4SoDhCxLMEm4bxlA X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8404.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(396003)(136003)(346002)(39860400002)(376002)(8676002)(66946007)(66556008)(4326008)(26005)(5660300002)(38100700002)(83380400001)(1076003)(38350700002)(2906002)(2616005)(41300700001)(66476007)(6666004)(186003)(316002)(36756003)(52116002)(44832011)(6512007)(478600001)(8936002)(6486002)(86362001)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cXQSnROJlA/59WM95nOpbh6fKBa1pVk/s2C9/Is4BjZbXy0s4RGJ9CtMspDj?= =?us-ascii?Q?2qjG+mvnmoJoYNIH1B8WmLzwus33DzXwPz++bIFiC0tSvp8EiFq8OVvdLuFx?= =?us-ascii?Q?+OCSmwrY21biNu9pb6vabU4BkOpwde+YOsKN4YYpb0M17MjIc30tPJhP9Q/C?= =?us-ascii?Q?orpen434hWa7Ove3j7rynuvjdRbsWW7cTiGE4y1A5cms4qpC6ujGfrcvhat5?= =?us-ascii?Q?trXKmbizO0iHx/NlApR6BIICcQMHS5LXZkldN43kklfoIdZbgP4+7VPHTODy?= =?us-ascii?Q?zRNHW0NZeAOgMClyiZJGoj8b6CMcv5mTq+7tn7o2Wolb4w9wt965+ohYNr4L?= =?us-ascii?Q?P3t7H21bBg1PTNdHRdtA99yE0vdoz4Sa3eUBvUboHXD5wOitw0Mr9MHZ/4mN?= =?us-ascii?Q?h8WGA+XYJf27z9DFdT/Ue9J8T2mWkTjSrysn+C93GREsdrDEkwG9+pZFRG3A?= =?us-ascii?Q?OJAtkUbZ5nGxfHgorg06hmbNB6PTAZ84cYddFS7caRQdqHHV7sMUTU3dyrgK?= =?us-ascii?Q?ZzZT1va4k5tE6F/D9gDaQrO+RWmC4jT+JS+a9+MOOrFFc5edm6rRs6JGQReZ?= =?us-ascii?Q?CDiSyC8+NOAilEm1MJCZafArWbEVBShruSRdvUEqXHJK7+sqC27ap3ngwJM+?= =?us-ascii?Q?7Lj/j2aTGipURJf7fq+HOr44bXKgH3tQ21pmlJXqPjkOO/HXt8B3+3FGszQg?= =?us-ascii?Q?+Z9Bja6/RygRRXEPFtNEs2Pd4mYMI7yBh83w5TYywphJE75SHEAelQBitfwe?= =?us-ascii?Q?YNpek3S8uRtXwre9dqYyiYcc6rJj1GoLC40//tumgx/k42tWmh6Wv9i0G1h+?= =?us-ascii?Q?3b/q94KVu6T0SMrHt5UgkWyCXoTv4K8ItJ9XwfxUN8f53nSn+yrrXw5e5Ca7?= =?us-ascii?Q?RxLioYIFaeOeM/Poj2BroJvWjmSwrbxNEQR4c6a1w9y7+3we0k7uTmAYUfi+?= =?us-ascii?Q?WZ3RA6WBZTmUeCJ5oS5pzouqIK3cEPmZ7poGfqblZzGKqy61FBmJf5xuaWll?= =?us-ascii?Q?+gGEVa5vjiICorfFoF48VUct3CRHWBH67n+ZjA/sbCV9oGOwMR77vFt4Dnnt?= =?us-ascii?Q?B8Te0cr6Wz/zWtRcSn3RS+or7tY3+zVcXzHh0x8nKdlJj0AuPXL3cUK34h4g?= =?us-ascii?Q?VPeYOU9EgvNLinFfVnZWjagdv1AldnZmYcs2OFukYOFGVWYnqR/83g3Ub8VN?= =?us-ascii?Q?zQXVix7SfKM+CKbRi+C2GX0GtcX8+wytojbDTIiufw3LB9pZGbOd0Y4OG619?= =?us-ascii?Q?ctPAXzhyj0JvbcDS7cwRFrWCcpnrkD37pP5pvHBGG6BfiaA3vaU41/hnnbNB?= =?us-ascii?Q?lTGPhuuL9cfJkg82auvycT09BylMWwe4yz92lhN4/ZhCGVHFUJ87YlJdLvDr?= =?us-ascii?Q?WW8DrrJdsX6JHGsyiw8WzoBZMjdseTAPEgkgMShBd5oXyyIKbIijP34/sdd/?= =?us-ascii?Q?w9Mneud0ZOcmsu9+s0p2xHFm5+pVokebQZwf8IuRffeldLcMd+DmF+sEFrHR?= =?us-ascii?Q?M7mvbLGC6nuVx0V/1m1JS5FA++isqC5rXQqOw0W4WFNp6HwCS1N43MPzh2Yn?= =?us-ascii?Q?AWGVdex1wFcqMuASeigF6gJoahfThprirSMQ0tl9?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9588dc2-19e2-4311-b24d-08da660e4a7b X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 03:01:19.3104 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JcpQ904NRd3RAKqVKRSolkg+j/deWB5lpG9WcGx/y93K05bQRFr+UhHR9LjnLmF3uDIdy+FivZW/Gh8a032B7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6477 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The LPUART can't distinguish between a break signal and a framing error, so need to count the break characters if there is a framing error and received data is zero instead of the parity error. Fixes: 5541a9bacfe5 ("serial: fsl_lpuart: handle break and make sysrq work") Signed-off-by: Sherry Sun Reviewed-by: Michael Walle --- drivers/tty/serial/fsl_lpuart.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuar= t.c index fc7d235a1e27..b6365566a460 100644 --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -990,12 +990,12 @@ static void lpuart32_rxint(struct lpuart_port *sport) =20 if (sr & (UARTSTAT_PE | UARTSTAT_OR | UARTSTAT_FE)) { if (sr & UARTSTAT_PE) { + sport->port.icount.parity++; + } else if (sr & UARTSTAT_FE) { if (is_break) sport->port.icount.brk++; else - sport->port.icount.parity++; - } else if (sr & UARTSTAT_FE) { - sport->port.icount.frame++; + sport->port.icount.frame++; } =20 if (sr & UARTSTAT_OR) @@ -1010,12 +1010,12 @@ static void lpuart32_rxint(struct lpuart_port *spor= t) sr &=3D sport->port.read_status_mask; =20 if (sr & UARTSTAT_PE) { + flg =3D TTY_PARITY; + } else if (sr & UARTSTAT_FE) { if (is_break) flg =3D TTY_BREAK; else - flg =3D TTY_PARITY; - } else if (sr & UARTSTAT_FE) { - flg =3D TTY_FRAME; + flg =3D TTY_FRAME; } =20 if (sr & UARTSTAT_OR) --=20 2.17.1 From nobody Sat Apr 18 09:23:42 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73402C43334 for ; Fri, 15 Jul 2022 03:01:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241231AbiGODBh (ORCPT ); Thu, 14 Jul 2022 23:01:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241214AbiGODB0 (ORCPT ); Thu, 14 Jul 2022 23:01:26 -0400 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80088.outbound.protection.outlook.com [40.107.8.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93DCB4F65E; Thu, 14 Jul 2022 20:01:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n7Zkt0TouS+z3axqgDFYDmJuCvc3ZHbHrrsVjORTRqacQmUi8ARukfSUBB0n/tIWmU9DMcx2x/c4tofGvmIEUEZPRmUtGLRN0htFue0fOKpwjaocrGYI93kJgnXmKnunfk8VNlqr/qzzP+UF1WXAxS2Eg33pcKjTjbd92wymFhFyMM5H/mK3Y554pa+8x2ajDfkHwy+Y62QFXZL2IIfiTpunzmvGR4RRBZJdtvM6Wsf00OqiNPNiNWhdqD2SSV4tD6IdGEQ5sGuA/8qkW5HdIyHlVOW1XXL0K1sJQG8n+iETBJNvHATJvX5awOFx2TqQlDcqSVxyJCTDnQwpAP4hJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FAOkKDKrJ43+UWkV4T6XpVVbClR7ruNCx4AvwAtxs7Y=; b=P1X4BtyCOYAwoklTK78niPgFAcdq7JM44Wgw0GRQncukP8W66x+spFTDeoWt6vi3ZqHpPzhtxZljJANGmSc1lxipMjIYBhP15uA9jtJGQrMxdHtsKWIeHl2SLi355UqngaTTZBP6Vw0mzcDrFOHflptNWQq0XlwESh+pZBCgQHUHDZQsZKb53gwcFpi1kqbIt4953ofMDLtxgQlNc56AvXzYb2ee2ACapuEFK8mKrBBDIcM7s4dh3kMYdG2bvFOaai5QOqUpSw9/dXKvysJ49UHUd6DLbEbFIEkkvxatZLf848he7BK2sUwxHBazTuUkEAKjFDatvaueY01tCY9Ayw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FAOkKDKrJ43+UWkV4T6XpVVbClR7ruNCx4AvwAtxs7Y=; b=Q27RM9LLnTZmMdV8FwVjj/s7Uv0H6bkV5x5/9vdIo9SAd1tjgQuSq9W3gzmf4cFsgJiBLtXtNYS3gXmIZsffKRx62b1K70Mz14rAURJA60tsZuI8rrjBL5DjI1MrvOwWBOP5nZMtL871tHMsKFQVdMgItIUtJlfK3YhcB02aMVU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) by VE1PR04MB6477.eurprd04.prod.outlook.com (2603:10a6:803:11e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Fri, 15 Jul 2022 03:01:22 +0000 Received: from AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::3cec:d61:3836:2826]) by AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::3cec:d61:3836:2826%5]) with mapi id 15.20.5438.017; Fri, 15 Jul 2022 03:01:22 +0000 From: Sherry Sun To: gregkh@linuxfoundation.org, jirislaby@kernel.org, michael@walle.cc Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com Subject: [PATCH 2/2] tty: serial: fsl_lpuart: writing a 1 and then a 0 to trigger a break character Date: Fri, 15 Jul 2022 10:59:44 +0800 Message-Id: <20220715025944.11076-3-sherry.sun@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220715025944.11076-1-sherry.sun@nxp.com> References: <20220715025944.11076-1-sherry.sun@nxp.com> X-ClientProxiedBy: SG2PR01CA0163.apcprd01.prod.exchangelabs.com (2603:1096:4:28::19) To AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 74d5c18a-27a5-4f19-566f-08da660e4c51 X-MS-TrafficTypeDiagnostic: VE1PR04MB6477:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b7J44oENv+yTlcPhHfD0B2Fg5Lt0WxJydtCvMwZ4zLUi0rzaqG4KVXsIkCFQxsWgAFXv2qFgU/pZdEOu+VAX46Es5FKItGVwpS0eGIYlUAdGWZlfozoCyAUQ7EeHDPZ/uCUqx1WnAOm3a2/Xcbh+wyuCronQbSuCLmWeYSlupqbQS+mj+KXYcjBiiZRFFwJPhHErhTzdwdpR5bUIUplgRlKVBOZJ04WwItG6tletACRLVCjXl9RW7J81DDl4oZ85vgaSwtXZP91mDy0sfE6lJsJraAyONWDHybgRws2ku9gRH432XehK+nR/CfKpnmGKU5jH/qMjKMCY5CSITnwYJtoH8mMcnGb8zR49ylAPL9LAMplHoLqSGtPneeroDqvnAUrE5BzvLwLLBxP010tlDciFvXlCPi7CtMGhC+o128NPSGfFaAfZGFEuiYuZom+cVBBSQFo4D0kxDVer2USJzA3GUoHcsub2QImZHZifO3YaLNz26I5yj3TPDJshOpJHvDnewfof6eWjpJK+EQiJnxaGhCF7O9XqoQpUx/E+dpLvlmtYFuWlXwRiYwoWPcrj9SSbJCNGOf58O1wcM6Ztat9EkJz3DGafDZgPKfxBbOHo2KgAvB7QMg6xyeKZhs2H7iW8eZwmuGnT7G6FiQbU4FhGGh4mjGWA74WeXks2oDSlrfzKJ7a2CrHpH0Pg7YoySFMK6ulYg7XWz+W4ynnscMHkW1Ey7GOqmI4SdLlgVY4BOfe9Zx0/Ubp7CdKri3ZVvQpIGiOURREytD3wq/wDTJFC7y76gugX4ovU7qDQcahMm8MyhsT/jjX1lid/4Ajx X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8404.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(396003)(136003)(346002)(39860400002)(376002)(8676002)(66946007)(66556008)(4326008)(26005)(5660300002)(38100700002)(83380400001)(1076003)(38350700002)(2906002)(2616005)(41300700001)(66476007)(6666004)(186003)(316002)(36756003)(52116002)(44832011)(6512007)(478600001)(8936002)(6486002)(86362001)(6506007)(4744005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BZdkulLaGLTuVyukhULiCkG9M5nQu/R8Z4FE8/CGf9L+A4xUT8f0r4QJQ3x0?= =?us-ascii?Q?H0RqEhoa+Rd+xkYzCIs8bK7BmN1g6rF+FkA64fPce6AnKIPV0SOCD9ytO6Tx?= =?us-ascii?Q?dioa7cFToIqCIcHFFDCxti6Hlk5IQ6nKqSRRhIi9mbg6v8fc7f0XVTmocI+b?= =?us-ascii?Q?2Rl8pRcwwko+9Gg20jDTlx1F6WXcX6tJsPZX9cXIFTmgiktz7XKXcAI4uAAi?= =?us-ascii?Q?naDBMY3DFyNZKtjvapk1PilmFd6HHD0K+ziedj4FrpgKpjw9YX5iIOfvP4c4?= =?us-ascii?Q?WDJYJYHhMbfMAgDBgoeEJwN+J2p0zeQYAwXeKMMdN3Q0oyYFH6h/7FEA2yYN?= =?us-ascii?Q?wpY4YgWYLCjmMlRzDEZyd1bLZ1dW/NNfo5je9/4hkK8WtZrOcJfhT9Wv7UOy?= =?us-ascii?Q?god7oaPuchnimLflsBdkIBfIHC5wOTCW29rCSBYEdgh9KHwsqINwi+ajdeL4?= =?us-ascii?Q?2jD40qveXIoFfxcSU+1yUeIRTx8XAORtt0Udn9FKGaV4nl3tcwLmpwQTkrU0?= =?us-ascii?Q?dFrefHT7ASpPvcflYavVArheJHPzyZAVlWELWaeVNAmggOIG8hYFaUZx6Pz8?= =?us-ascii?Q?lQYhWd8//hTmRkHrcxP1pUkD8rnappSKiRL5C0Yi/7Y5aM7X9VWzotZ28Ps3?= =?us-ascii?Q?Phz5gpsgIxkS/V+ILaCvxsBJHByB6nBcfzyid5vUS2ZseIYecgRjz1EzF7FR?= =?us-ascii?Q?oGC9lBcjoRS2SVYfF6TuOzZnSkLp7N3fgNbJOFRFMXu7rUu0D9bwK5Wn5rdF?= =?us-ascii?Q?gpZ90LmBeusaHErm1eDWooE4rNghGAS1NXE0cDRH3X49MepcpY0DQlFq8Uy8?= =?us-ascii?Q?FKBsKw7VC3NqxT9k5NBr3D+hrZ4wMzIGGx1GsPXJdT67AR9qZrQjWnn+2K5C?= =?us-ascii?Q?wABqQK+xZp5IsVuSJ3dWm27RIiaRaaAOXoJWRr0SjWa62h+cB8AUMovN29K9?= =?us-ascii?Q?RYHLMyue1jyCXmxEB91tch+taxBOFCqOrne/gOrTsWRXX69Jhys5kQWK60jm?= =?us-ascii?Q?FgwMJfqYSbz6784lZhk5cADplxVwpMPLVy47q09ljVhf/6LQWCibd6mdHboq?= =?us-ascii?Q?c6XhXN2suIETgiBaglC3QTszuokTUo3+0K94CRi+3hByeL5FDYFgwi5jbyp4?= =?us-ascii?Q?GeuaErLkr7yEotUANSgKafzS4RiPeAYh4hrL5Kmk5Y9QKHj19b+1Qd2HwQnI?= =?us-ascii?Q?AKKA3fk/rmqQIXVIKoMsHk83tBxF1EHSLoQD3rFhdzR9v98MjXUlFKgvniTL?= =?us-ascii?Q?f07qn9/BZThNmgtm3f87ntptTpzven8IpnVSgzdOSuoq24eyNppiTu3ROnTd?= =?us-ascii?Q?A+WAS4kckeoSC9dtBNACuCNOexSVfD62SHzoVG0vvrjOLx/XkfCUc5egN0/J?= =?us-ascii?Q?y+37mjLN9mqho+gUFXe4hSvGvFbbveQ4S7SrWUwQ3ArY3Is1+xF/+IEw8N0R?= =?us-ascii?Q?xNObS0S9y3vspmdGZ6uouem5PlLMzVrtv+6TfhYZCDJhCIuqGy489ViNQ9bL?= =?us-ascii?Q?MnO9ue4zzsShqZWg9XL/E+RI1hh6oacVMdOZGrwKNwDuIgJcHSUwQIr+9fpl?= =?us-ascii?Q?vE5kU57hAiE9UX1pmxqFx9kGZAoIlaSkGmngDefy?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74d5c18a-27a5-4f19-566f-08da660e4c51 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 03:01:22.5457 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JAx8MqOqX+o92VkI1Rj1LiHnRwm48RReYhgqJ8vFl2y9iVEtC6zuVrLFwob26diuUgm+b8VtEnS9LwUQBgVuiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6477 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" According to the lpuart reference manual, need to writing a 1 and then a 0 to the UARTCTRL_SBK field queues a break character in the transmit data stream. Only writing a 1 cannot trigger the break character, so fix it. Fixes: 380c966c093e ("tty: serial: fsl_lpuart: add 32-bit register interfac= e support") Signed-off-by: Sherry Sun --- drivers/tty/serial/fsl_lpuart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuar= t.c index b6365566a460..8a4aae7dbd99 100644 --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -1486,7 +1486,7 @@ static void lpuart32_break_ctl(struct uart_port *port= , int break_state) temp =3D lpuart32_read(port, UARTCTRL) & ~UARTCTRL_SBK; =20 if (break_state !=3D 0) - temp |=3D UARTCTRL_SBK; + lpuart32_write(port, temp | UARTCTRL_SBK, UARTCTRL); =20 lpuart32_write(port, temp, UARTCTRL); } --=20 2.17.1