From nobody Sat Apr 18 11:01:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C9AAC43334 for ; Thu, 14 Jul 2022 11:39:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238635AbiGNLjl (ORCPT ); Thu, 14 Jul 2022 07:39:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229551AbiGNLjj (ORCPT ); Thu, 14 Jul 2022 07:39:39 -0400 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2088.outbound.protection.outlook.com [40.107.92.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FB6325E81 for ; Thu, 14 Jul 2022 04:39:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n35ylgnDDvXCkuWTodn/Riwt5+iE/bXl3REYPzA2y3YlCsTF6pJe/6JfL3HYjJfYm137+V6La7VadRL+Mjj3emEgctY+faSUOWmGFEGFzCf+Bzj8SZuqL+fSjecCCzA0fTk5iEtsK40vIYKQPErhny6zq7lE0poP2K4avC3JofLZYXhgkJzgTf9ZmwRUysJx1PKTJQLRU66TKyk1eOiYtvCDUusOPURtWTkUzwMxPDs4JNxbrZbLTB/t57DkIfXL/GpfztxbeXYVayB9tidNwHGdpVsZDMbNo26oEXHgzwvvMNOtp9NZytkxAXsb6L64tcFDA1dO+nzq6iW9g6fllg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bo/fueSfex7i2u/z5nflWqJD11bsY91JZasHE5xKXxY=; b=fRUMaCco3wWy5Ju+XcYWYnQp7MhuT4Qqe2osSDkJNRyw3LCEZJNzv4XvHZkMYdg8ZR2Xh/LSUKoExxtGW9OfiorR3UJN8UvfuAbTiq7+3nBRz92pwmaDLT1nWdaB3gSPEpxKlsfxk9Nae+BT1IH++okb3RRMLpkld96Ptu1JFc3NYfCiHmla+hT4YxTiEYU74P7rEvxzFnw6f6wc3CVjZVoImrBKn/T7wK8m3Tj3SyTsIOU3F5f8gASkOEfd9XPEjWokxU7bSqmBvyLETzptG8rlq3O8Ba46cGBeDRzehN3PuP3/d9qXZmmnsM/hSKZt064/IagxPItmS4dBD37Nbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.234) smtp.rcpttodomain=lists.linux-foundation.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bo/fueSfex7i2u/z5nflWqJD11bsY91JZasHE5xKXxY=; b=gwMUqx+ghbC3edqfp175mbItkckgXIkXkuqejDJEJ8646Y30W8+0+jOJTJdMV8fTNjNGB7jV8i8qZAQ9dlvQNyAO2S9YoOyGU+mfEhskqbi7Jj3XmHNH66Hd+Qbr2LIt9dek0Yu8iDs2fBzBZbxdpSOp7/n25Pnj6sx4hXfG6kwVpYkLO/LvQ/6aBGLsERzaudi/gvx8G7B8U/ruFQSfTjdstXX1RTbRy5r3XbTAy/7vrtgD1ACaZbVcnCf5olGrCiOzBSrTcFWBIa6HoOYv5OoC23qDx7yCONPq/tkAzESXp9tDtfi9e4t7XLf7wv19PT2SPNMJ6tk4Td6wMlGJgQ== Received: from MW4PR04CA0071.namprd04.prod.outlook.com (2603:10b6:303:6b::16) by DM4PR12MB5135.namprd12.prod.outlook.com (2603:10b6:5:392::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Thu, 14 Jul 2022 11:39:36 +0000 Received: from CO1NAM11FT059.eop-nam11.prod.protection.outlook.com (2603:10b6:303:6b:cafe::2b) by MW4PR04CA0071.outlook.office365.com (2603:10b6:303:6b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Thu, 14 Jul 2022 11:39:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.234) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.234 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.234; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.234) by CO1NAM11FT059.mail.protection.outlook.com (10.13.174.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5438.12 via Frontend Transport; Thu, 14 Jul 2022 11:39:35 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by DRHQMAIL101.nvidia.com (10.27.9.10) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Thu, 14 Jul 2022 11:39:35 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Thu, 14 Jul 2022 04:39:34 -0700 Received: from vdi.nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server id 15.2.986.26 via Frontend Transport; Thu, 14 Jul 2022 04:39:32 -0700 From: Eli Cohen To: , , , CC: , , , Eli Cohen Subject: [PATCH 1/2] vdpa/mlx5: Implement susupend virtqueue callback Date: Thu, 14 Jul 2022 14:39:26 +0300 Message-ID: <20220714113927.85729-2-elic@nvidia.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220714113927.85729-1-elic@nvidia.com> References: <20220714113927.85729-1-elic@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 661fb715-a2cc-45b8-7d29-08da658d8739 X-MS-TrafficTypeDiagnostic: DM4PR12MB5135:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QtleZ8+0noWtkMfd69V+9cWh9DwSJivNjYbuRDZnarWOpxvwpb6zDzRyd5ECPnRyxFDzHKuLemvEV52R1sH212hUCyFESbegeJOrd/yPXLz3gmkKjDY07qOf67I4YZVhU4zuqOe0hxN+wsqOMEjweXj2YFw/u2iN2jQzSdUS7kP53FcgbfHMUoixgpIB4U/fh+mL25y4D/CZRnfYCZMurqTJUzY7wdqWPXsuUwfJl/BmhQSMRN/GQc/12/mGgbDKu0xFRFvAOEB5YS/5e6rnlUBq6OJBBcVIwCdBXR4/F2UG4RV5akvBpIdXKKXZrniohsBjtWO4umbWl1xKcFC+bZSS8nmX/JVxPSmyfInLXYh+QMZt4zzU6jHXEyYnnNHmEi8zG7/1htg4NtiUmleZtNJtoKKYRoR93azt6AWy2MZGQjS4Ur4HmfmjJcV8EfKNascskj8myKxr4dVoCNM8qJBytZ4tNljBVP0TIu5bvNYZiITWYmdyLqq2AFN9b5k3k+FEqjy7r7O0gAAXkSmKOPOAmYHVKgTevcRIFU+KrjlQBZwrp2bL/ZAGuln8h4bm2igOVqXX0f1saHizIo2kUAWyNNPZgaYJlx8Od0Qp5bV0YoIfQJwBCLO9xW9SVAC+kL2pFKLr/9qvxyV4NPzFwqvMdme17a1kZ63z/WlUEojEDp18HbHH0tRpnudEbtlXtCDU2GiHZ6UtfNTlFLJLz4pqM5DNsMd3R4A91I2ggMCk/Gx9ytunupDnxixzQ/xGNhq6SGarfqFwiAPKzjmiS1N0HxcyYTSLkFxNig1y/iFDpyq7CXtsBNw2GCdQRL1Io9SmyDRfFJxthXQ0cmpeRbptNyd8loenmt/pKEfe6xY= X-Forefront-Antispam-Report: CIP:12.22.5.234;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:InfoNoRecords;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(376002)(396003)(136003)(46966006)(36840700001)(40470700004)(54906003)(26005)(7696005)(110136005)(36860700001)(8676002)(4326008)(316002)(70586007)(70206006)(36756003)(41300700001)(478600001)(2906002)(2616005)(6666004)(83380400001)(336012)(1076003)(186003)(426003)(47076005)(5660300002)(86362001)(40460700003)(81166007)(8936002)(40480700001)(356005)(82310400005)(107886003)(82740400003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 11:39:35.8426 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 661fb715-a2cc-45b8-7d29-08da658d8739 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[12.22.5.234];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT059.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5135 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Implement the suspend callback allowing to suspend the virtqueues so they stop processing descriptors. This is required to allow to query a consistent state of the virtqueue while live migration is taking place. Signed-off-by: Eli Cohen --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 83 ++++++++++++++++++++++++++++-- include/linux/mlx5/mlx5_ifc_vdpa.h | 8 +++ 2 files changed, 88 insertions(+), 3 deletions(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5= _vnet.c index e85c1d71f4ed..d0fff559ca15 100644 --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c @@ -164,6 +164,7 @@ struct mlx5_vdpa_net { bool setup; u32 cur_num_vqs; u32 rqt_size; + bool nb_registered; struct notifier_block nb; struct vdpa_callback config_cb; struct mlx5_vdpa_wq_ent cvq_ent; @@ -895,6 +896,7 @@ static int create_virtqueue(struct mlx5_vdpa_net *ndev,= struct mlx5_vdpa_virtque if (err) goto err_cmd; =20 + mvq->fw_state =3D MLX5_VIRTIO_NET_Q_OBJECT_STATE_INIT; kfree(in); mvq->virtq_id =3D MLX5_GET(general_obj_out_cmd_hdr, out, obj_id); =20 @@ -922,6 +924,7 @@ static void destroy_virtqueue(struct mlx5_vdpa_net *nde= v, struct mlx5_vdpa_virtq mlx5_vdpa_warn(&ndev->mvdev, "destroy virtqueue 0x%x\n", mvq->virtq_id); return; } + mvq->fw_state =3D MLX5_VIRTIO_NET_Q_OBJECT_NONE; umems_destroy(ndev, mvq); } =20 @@ -1121,6 +1124,20 @@ static int query_virtqueue(struct mlx5_vdpa_net *nde= v, struct mlx5_vdpa_virtqueu return err; } =20 +static bool is_valid_state_change(int oldstate, int newstate) +{ + switch (oldstate) { + case MLX5_VIRTIO_NET_Q_OBJECT_STATE_INIT: + return newstate =3D=3D MLX5_VIRTIO_NET_Q_OBJECT_STATE_RDY; + case MLX5_VIRTIO_NET_Q_OBJECT_STATE_RDY: + return newstate =3D=3D MLX5_VIRTIO_NET_Q_OBJECT_STATE_SUSPEND; + case MLX5_VIRTIO_NET_Q_OBJECT_STATE_SUSPEND: + case MLX5_VIRTIO_NET_Q_OBJECT_STATE_ERR: + default: + return false; + } +} + static int modify_virtqueue(struct mlx5_vdpa_net *ndev, struct mlx5_vdpa_v= irtqueue *mvq, int state) { int inlen =3D MLX5_ST_SZ_BYTES(modify_virtio_net_q_in); @@ -1130,6 +1147,12 @@ static int modify_virtqueue(struct mlx5_vdpa_net *nd= ev, struct mlx5_vdpa_virtque void *in; int err; =20 + if (mvq->fw_state =3D=3D MLX5_VIRTIO_NET_Q_OBJECT_NONE) + return 0; + + if (!is_valid_state_change(mvq->fw_state, state)) + return -EINVAL; + in =3D kzalloc(inlen, GFP_KERNEL); if (!in) return -ENOMEM; @@ -1992,6 +2015,7 @@ static void mlx5_vdpa_set_vq_ready(struct vdpa_device= *vdev, u16 idx, bool ready struct mlx5_vdpa_dev *mvdev =3D to_mvdev(vdev); struct mlx5_vdpa_net *ndev =3D to_mlx5_vdpa_ndev(mvdev); struct mlx5_vdpa_virtqueue *mvq; + int err; =20 if (!mvdev->actual_features) return; @@ -2005,8 +2029,16 @@ static void mlx5_vdpa_set_vq_ready(struct vdpa_devic= e *vdev, u16 idx, bool ready } =20 mvq =3D &ndev->vqs[idx]; - if (!ready) + if (!ready) { suspend_vq(ndev, mvq); + } else { + err =3D modify_virtqueue(ndev, mvq, MLX5_VIRTIO_NET_Q_OBJECT_STATE_RDY); + if (err) { + mlx5_vdpa_warn(mvdev, "modify VQ %d to ready failed (%d)\n", idx, err); + ready =3D false; + } + } + =20 mvq->ready =3D ready; } @@ -2733,6 +2765,37 @@ static int mlx5_vdpa_get_vendor_vq_stats(struct vdpa= _device *vdev, u16 idx, return err; } =20 +static void mlx5_vdpa_cvq_suspend(struct mlx5_vdpa_dev *mvdev) +{ + struct mlx5_control_vq *cvq; + + if (!(mvdev->actual_features & BIT_ULL(VIRTIO_NET_F_CTRL_VQ))) + return; + + cvq =3D &mvdev->cvq; + cvq->ready =3D false; +} + +static int mlx5_vdpa_suspend(struct vdpa_device *vdev) +{ + struct mlx5_vdpa_dev *mvdev =3D to_mvdev(vdev); + struct mlx5_vdpa_net *ndev =3D to_mlx5_vdpa_ndev(mvdev); + struct mlx5_vdpa_virtqueue *mvq; + int i; + + down_write(&ndev->reslock); + mlx5_notifier_unregister(mvdev->mdev, &ndev->nb); + ndev->nb_registered =3D false; + flush_workqueue(ndev->mvdev.wq); + for (i =3D 0; i < ndev->cur_num_vqs; i++) { + mvq =3D &ndev->vqs[i]; + suspend_vq(ndev, mvq); + } + mlx5_vdpa_cvq_suspend(mvdev); + up_write(&ndev->reslock); + return 0; +} + static const struct vdpa_config_ops mlx5_vdpa_ops =3D { .set_vq_address =3D mlx5_vdpa_set_vq_address, .set_vq_num =3D mlx5_vdpa_set_vq_num, @@ -2763,6 +2826,7 @@ static const struct vdpa_config_ops mlx5_vdpa_ops =3D= { .get_generation =3D mlx5_vdpa_get_generation, .set_map =3D mlx5_vdpa_set_map, .free =3D mlx5_vdpa_free, + .suspend =3D mlx5_vdpa_suspend, }; =20 static int query_mtu(struct mlx5_core_dev *mdev, u16 *mtu) @@ -2828,6 +2892,7 @@ static void init_mvqs(struct mlx5_vdpa_net *ndev) mvq->index =3D i; mvq->ndev =3D ndev; mvq->fwqp.fw =3D true; + mvq->fw_state =3D MLX5_VIRTIO_NET_Q_OBJECT_NONE; } for (; i < ndev->mvdev.max_vqs; i++) { mvq =3D &ndev->vqs[i]; @@ -2902,13 +2967,21 @@ static int event_handler(struct notifier_block *nb,= unsigned long event, void *p switch (eqe->sub_type) { case MLX5_PORT_CHANGE_SUBTYPE_DOWN: case MLX5_PORT_CHANGE_SUBTYPE_ACTIVE: + down_read(&ndev->reslock); + if (!ndev->nb_registered) { + up_read(&ndev->reslock); + return NOTIFY_DONE; + } wqent =3D kzalloc(sizeof(*wqent), GFP_ATOMIC); - if (!wqent) + if (!wqent) { + up_read(&ndev->reslock); return NOTIFY_DONE; + } =20 wqent->mvdev =3D &ndev->mvdev; INIT_WORK(&wqent->work, update_carrier); queue_work(ndev->mvdev.wq, &wqent->work); + up_read(&ndev->reslock); ret =3D NOTIFY_OK; break; default: @@ -3062,6 +3135,7 @@ static int mlx5_vdpa_dev_add(struct vdpa_mgmt_dev *v_= mdev, const char *name, =20 ndev->nb.notifier_call =3D event_handler; mlx5_notifier_register(mdev, &ndev->nb); + ndev->nb_registered =3D true; mvdev->vdev.mdev =3D &mgtdev->mgtdev; err =3D _vdpa_register_device(&mvdev->vdev, max_vqs + 1); if (err) @@ -3093,7 +3167,10 @@ static void mlx5_vdpa_dev_del(struct vdpa_mgmt_dev *= v_mdev, struct vdpa_device * struct mlx5_vdpa_net *ndev =3D to_mlx5_vdpa_ndev(mvdev); struct workqueue_struct *wq; =20 - mlx5_notifier_unregister(mvdev->mdev, &ndev->nb); + if (ndev->nb_registered) { + mlx5_notifier_unregister(mvdev->mdev, &ndev->nb); + ndev->nb_registered =3D false; + } wq =3D mvdev->wq; mvdev->wq =3D NULL; destroy_workqueue(wq); diff --git a/include/linux/mlx5/mlx5_ifc_vdpa.h b/include/linux/mlx5/mlx5_i= fc_vdpa.h index 4414ed5b6ed2..9becdc3fa503 100644 --- a/include/linux/mlx5/mlx5_ifc_vdpa.h +++ b/include/linux/mlx5/mlx5_ifc_vdpa.h @@ -150,6 +150,14 @@ enum { MLX5_VIRTIO_NET_Q_OBJECT_STATE_ERR =3D 0x3, }; =20 +/* This indicates that the object was not created or has already + * been desroyed. It is very safe to assume that this object will never + * have so many states + */ +enum { + MLX5_VIRTIO_NET_Q_OBJECT_NONE =3D 0xffffffff +}; + enum { MLX5_RQTC_LIST_Q_TYPE_RQ =3D 0x0, MLX5_RQTC_LIST_Q_TYPE_VIRTIO_NET_Q =3D 0x1, --=20 2.35.1 From nobody Sat Apr 18 11:01:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20F88C43334 for ; Thu, 14 Jul 2022 11:39:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239039AbiGNLjp (ORCPT ); Thu, 14 Jul 2022 07:39:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229551AbiGNLjm (ORCPT ); Thu, 14 Jul 2022 07:39:42 -0400 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2042.outbound.protection.outlook.com [40.107.244.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17AA25B068 for ; Thu, 14 Jul 2022 04:39:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fKgXmTQThgY6+yUTAw02xcA5BMiv3I4/zWODl1kei0xnqivN85TDiwm/Ii/jt1v6ljstvWn7AS1cOpgobLJWN+jLtLpReqzKfnk9+VmaEywYUYbGS066wg2XEY9RUpx28Kb1wlv9qunzB+h7yfsz0cBdJ2EToz+Mn4KA4wb7D2IRnuZxKcSvtSULjpU6Tl6Ut4wNjVjT4UsTjUgzFuqNm22++/iM3f24aEcF4CJFBU1t6d5XXXRY8LZ3391VccEEKDKxIRviu3rGXUtMqlq5e0TKxXpr5d06fq+nW4dbnK0HLPhGQfDWn1EJ3VesZbcXq5/urCHuCqTKqjzSkH98Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5oFO1rNzknZZToXxXUnl8+S7wkT2qbMZF/sY+eavt+w=; b=SpTh74ZiFeNqvfYO9GyPeBeVYZ9fSztp5gkLx/012t2eLrGQ5NfcAOrRvPqf8iqrJSWzEJR5dC697RuY5+Ow86Das54o1D8/NyayvPWHwd0chSTKHXcSFHh+2UnrEAJ3Y0KVdVvQ0j4XOuE+qzP341qkaeSs5clcRdJm17orqsrS1hV/1o+oF+Lb6nGQcMK2MWA4K42jPQYxtT0H5AqrS2B2btjSNVs6DWfBoXDfVdBrK4bwYxO8/XcpBIbhDUYwBFXYob+FqFQvaZq8xVgvCoUb08UGVjmWgC1IMxf59fOOI0pHwEMYu0UEEG3aGdsesXc2xfQejTpGisEk7d6CHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.234) smtp.rcpttodomain=lists.linux-foundation.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5oFO1rNzknZZToXxXUnl8+S7wkT2qbMZF/sY+eavt+w=; b=aV2AL+SFlGYyfIXAWTRjn0/WtaWwocYBCKRMpxRaWjTUprkd2DueRyLoUS1fDKTEuevCLG4bPi2lmzY0uNiZ/i3Oml+vTxzl3e5tTmoJ+ZtE6Ilc2PYpgGkd0N8bDJu9vrSpTKL3g5C9gxdHpUMVL/wr4IApFIo9ARUZ2QT3DxNjtL4vaoj++QA3F35L8l+nRl3cn7t7Grgy3NqUTM9MKR2FYh+9Lg/iYAMH7JCCizxgllUAii7G0NA3tpt8MXq6Lh1Kk+j/6Z42erQsQ7vJiA69DEU0CyQqlsoJw+OcfBoKmYggFNsifroAdGlxmA1FMj4zFvAH6LXwJctTqnvTbw== Received: from MW4PR04CA0294.namprd04.prod.outlook.com (2603:10b6:303:89::29) by DM4PR12MB6135.namprd12.prod.outlook.com (2603:10b6:8:ac::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Thu, 14 Jul 2022 11:39:39 +0000 Received: from CO1NAM11FT023.eop-nam11.prod.protection.outlook.com (2603:10b6:303:89:cafe::75) by MW4PR04CA0294.outlook.office365.com (2603:10b6:303:89::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14 via Frontend Transport; Thu, 14 Jul 2022 11:39:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.234) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.234 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.234; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.234) by CO1NAM11FT023.mail.protection.outlook.com (10.13.175.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5438.12 via Frontend Transport; Thu, 14 Jul 2022 11:39:38 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by DRHQMAIL101.nvidia.com (10.27.9.10) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Thu, 14 Jul 2022 11:39:37 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Thu, 14 Jul 2022 04:39:36 -0700 Received: from vdi.nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server id 15.2.986.26 via Frontend Transport; Thu, 14 Jul 2022 04:39:34 -0700 From: Eli Cohen To: , , , CC: , , , Eli Cohen Subject: [PATCH 2/2] vdpa/mlx5: Support different address spaces for control and data Date: Thu, 14 Jul 2022 14:39:27 +0300 Message-ID: <20220714113927.85729-3-elic@nvidia.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220714113927.85729-1-elic@nvidia.com> References: <20220714113927.85729-1-elic@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b6e68212-d4b5-4212-b4cb-08da658d88d9 X-MS-TrafficTypeDiagnostic: DM4PR12MB6135:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o4ydo2u0ZcJtSWaRYBBLRyweW56hKvZ9H/Fgk2z2LY7dCIYvw1sBFYpOs0o6UpXc5CZ4255f25mrdFBRnSQVVjQbBLHeG7c2uSqsUgc32mkwgl7mlV8UDltUrk9n+eSODyO3LWrB9NjRrlxAFaWbpqxTyN6umaqFlg37HF/fCkK6oVCfRsE1q8PEvash9Vsq5ZJJOJP1mwHltULoMC0ClhEc9I2eVzjsIJRscZtvcJ1k7TyujobF5ca+PCgVFeIXkvo1tc5OtS71le0FDM0ZKcGPdBHrqV+nVDVHIcpBhKgTEXStowYDu164fl0DNwdgZ0T1FWb9si8lsDIgs/1+8g8dB207xt7xc4ux8cgyurKzJT/7ZAQrOSD0L8t7FD0N4JHjnBMvGKoDYFjWZwk+CvqeiTX6vsZ0pgWizIeDuhESwFzsGBoVslR0q6YCdvdR+3GKuRkUes23Dg+fEDFXi9XhUc7A7mZbRjEFCxM3ZR2SiYi7TKjxqgo8h8ajZoeOvTEbc2pwXAgA63Z3QBNXmN0BKlD42tPhpExI+h/Z8i2x8ty2HQDrsRA4qvwD+2iBvwodMcl5hVGDYfu/JdBVJHgaqDfaciValtRyZiRGWRUqYf6g3Q98u/tCSGmty6abMhbs6lfBTT0Ta50yJLzRJRuxHxAXIbfrrJ5OqYHzmC4wa2SGEYxAuA/giyvo8NMswCeD1ir552wWyvVfe8eIKbwe47LtZDKVxnke4Aavu5w4AiDGGIcnUhrq4JoXPmonOkq8LCtm7Lj8PqzN8ZmwL/eX1VwvBHlMf4F/3Ncgj2ujYSbHH/c8f8rThczbSFw8gDqFh5tyJ8kI5xB++2yEIUuISyKgWJw5r0aaofT8djc= X-Forefront-Antispam-Report: CIP:12.22.5.234;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:InfoNoRecords;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(396003)(39860400002)(376002)(46966006)(40470700004)(36840700001)(356005)(86362001)(70206006)(2616005)(478600001)(47076005)(6666004)(70586007)(4326008)(186003)(41300700001)(426003)(36860700001)(54906003)(8676002)(110136005)(1076003)(81166007)(107886003)(36756003)(316002)(82740400003)(40460700003)(2906002)(5660300002)(83380400001)(82310400005)(8936002)(7696005)(336012)(40480700001)(26005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 11:39:38.6172 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b6e68212-d4b5-4212-b4cb-08da658d88d9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[12.22.5.234];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT023.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6135 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Partition virtqueues to two different address spaces: one for control virtqueue which is implemented in software, and one for data virtqueues. Based-on: <20220526124338.36247-1-eperezma@redhat.com> Signed-off-by: Eli Cohen --- drivers/vdpa/mlx5/core/mlx5_vdpa.h | 11 ++++ drivers/vdpa/mlx5/net/mlx5_vnet.c | 88 ++++++++++++++++++++++++++---- 2 files changed, 88 insertions(+), 11 deletions(-) diff --git a/drivers/vdpa/mlx5/core/mlx5_vdpa.h b/drivers/vdpa/mlx5/core/ml= x5_vdpa.h index 44104093163b..6af9fdbb86b7 100644 --- a/drivers/vdpa/mlx5/core/mlx5_vdpa.h +++ b/drivers/vdpa/mlx5/core/mlx5_vdpa.h @@ -70,6 +70,16 @@ struct mlx5_vdpa_wq_ent { struct mlx5_vdpa_dev *mvdev; }; =20 +enum { + MLX5_VDPA_DATAVQ_GROUP, + MLX5_VDPA_CVQ_GROUP, + MLX5_VDPA_NUMVQ_GROUPS +}; + +enum { + MLX5_VDPA_NUM_AS =3D MLX5_VDPA_NUMVQ_GROUPS +}; + struct mlx5_vdpa_dev { struct vdpa_device vdev; struct mlx5_core_dev *mdev; @@ -85,6 +95,7 @@ struct mlx5_vdpa_dev { struct mlx5_vdpa_mr mr; struct mlx5_control_vq cvq; struct workqueue_struct *wq; + unsigned int group2asid[MLX5_VDPA_NUMVQ_GROUPS]; }; =20 int mlx5_vdpa_alloc_pd(struct mlx5_vdpa_dev *dev, u32 *pdn, u16 uid); diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5= _vnet.c index d0fff559ca15..834023e8e073 100644 --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c @@ -2127,9 +2127,14 @@ static u32 mlx5_vdpa_get_vq_align(struct vdpa_device= *vdev) return PAGE_SIZE; } =20 -static u32 mlx5_vdpa_get_vq_group(struct vdpa_device *vdpa, u16 idx) +static u32 mlx5_vdpa_get_vq_group(struct vdpa_device *vdev, u16 idx) { - return 0; + struct mlx5_vdpa_dev *mvdev =3D to_mvdev(vdev); + + if (is_ctrl_vq_idx(mvdev, idx)) + return MLX5_VDPA_CVQ_GROUP; + + return MLX5_VDPA_DATAVQ_GROUP; } =20 enum { MLX5_VIRTIO_NET_F_GUEST_CSUM =3D 1 << 9, @@ -2543,6 +2548,15 @@ static void mlx5_vdpa_set_status(struct vdpa_device = *vdev, u8 status) up_write(&ndev->reslock); } =20 +static void init_group_to_asid_map(struct mlx5_vdpa_dev *mvdev) +{ + int i; + + /* default mapping all groups are mapped to asid 0 */ + for (i =3D 0; i < MLX5_VDPA_NUMVQ_GROUPS; i++) + mvdev->group2asid[i] =3D 0; +} + static int mlx5_vdpa_reset(struct vdpa_device *vdev) { struct mlx5_vdpa_dev *mvdev =3D to_mvdev(vdev); @@ -2561,7 +2575,9 @@ static int mlx5_vdpa_reset(struct vdpa_device *vdev) ndev->mvdev.cvq.completed_desc =3D 0; memset(ndev->event_cbs, 0, sizeof(*ndev->event_cbs) * (mvdev->max_vqs + 1= )); ndev->mvdev.actual_features =3D 0; + init_group_to_asid_map(mvdev); ++mvdev->generation; + if (MLX5_CAP_GEN(mvdev->mdev, umem_uid_0)) { if (mlx5_vdpa_create_mr(mvdev, NULL)) mlx5_vdpa_warn(mvdev, "create MR failed\n"); @@ -2599,26 +2615,63 @@ static u32 mlx5_vdpa_get_generation(struct vdpa_dev= ice *vdev) return mvdev->generation; } =20 -static int mlx5_vdpa_set_map(struct vdpa_device *vdev, unsigned int asid, - struct vhost_iotlb *iotlb) +static int set_map_control(struct mlx5_vdpa_dev *mvdev, struct vhost_iotlb= *iotlb) +{ + u64 start =3D 0ULL, last =3D 0ULL - 1; + struct vhost_iotlb_map *map; + int err =3D 0; + + spin_lock(&mvdev->cvq.iommu_lock); + vhost_iotlb_reset(mvdev->cvq.iotlb); + + for (map =3D vhost_iotlb_itree_first(iotlb, start, last); map; + map =3D vhost_iotlb_itree_next(map, start, last)) { + err =3D vhost_iotlb_add_range(mvdev->cvq.iotlb, map->start, + map->last, map->addr, map->perm); + if (err) + goto out; + } + +out: + spin_unlock(&mvdev->cvq.iommu_lock); + return err; +} + +static int set_map_data(struct mlx5_vdpa_dev *mvdev, struct vhost_iotlb *i= otlb) { - struct mlx5_vdpa_dev *mvdev =3D to_mvdev(vdev); - struct mlx5_vdpa_net *ndev =3D to_mlx5_vdpa_ndev(mvdev); bool change_map; int err; =20 - down_write(&ndev->reslock); - err =3D mlx5_vdpa_handle_set_map(mvdev, iotlb, &change_map); if (err) { mlx5_vdpa_warn(mvdev, "set map failed(%d)\n", err); - goto err; + return err; } =20 if (change_map) err =3D mlx5_vdpa_change_map(mvdev, iotlb); =20 -err: + return err; +} + +static int mlx5_vdpa_set_map(struct vdpa_device *vdev, unsigned int asid, + struct vhost_iotlb *iotlb) +{ + struct mlx5_vdpa_dev *mvdev =3D to_mvdev(vdev); + struct mlx5_vdpa_net *ndev =3D to_mlx5_vdpa_ndev(mvdev); + int err; + + down_write(&ndev->reslock); + if (mvdev->group2asid[MLX5_VDPA_DATAVQ_GROUP] =3D=3D asid) { + err =3D set_map_data(mvdev, iotlb); + if (err) + goto out; + } + + if (mvdev->group2asid[MLX5_VDPA_CVQ_GROUP] =3D=3D asid) + err =3D set_map_control(mvdev, iotlb); + +out: up_write(&ndev->reslock); return err; } @@ -2796,6 +2849,18 @@ static int mlx5_vdpa_suspend(struct vdpa_device *vde= v) return 0; } =20 +static int mlx5_set_group_asid(struct vdpa_device *vdev, u32 group, + unsigned int asid) +{ + struct mlx5_vdpa_dev *mvdev =3D to_mvdev(vdev); + + if (group >=3D MLX5_VDPA_NUMVQ_GROUPS) + return -EINVAL; + + mvdev->group2asid[group] =3D asid; + return 0; +} + static const struct vdpa_config_ops mlx5_vdpa_ops =3D { .set_vq_address =3D mlx5_vdpa_set_vq_address, .set_vq_num =3D mlx5_vdpa_set_vq_num, @@ -2825,6 +2890,7 @@ static const struct vdpa_config_ops mlx5_vdpa_ops =3D= { .set_config =3D mlx5_vdpa_set_config, .get_generation =3D mlx5_vdpa_get_generation, .set_map =3D mlx5_vdpa_set_map, + .set_group_asid =3D mlx5_set_group_asid, .free =3D mlx5_vdpa_free, .suspend =3D mlx5_vdpa_suspend, }; @@ -3055,7 +3121,7 @@ static int mlx5_vdpa_dev_add(struct vdpa_mgmt_dev *v_= mdev, const char *name, } =20 ndev =3D vdpa_alloc_device(struct mlx5_vdpa_net, mvdev.vdev, mdev->device= , &mlx5_vdpa_ops, - 1, 1, name, false); + MLX5_VDPA_NUMVQ_GROUPS, MLX5_VDPA_NUM_AS, name, false); if (IS_ERR(ndev)) return PTR_ERR(ndev); =20 --=20 2.35.1