From nobody Sat Apr 18 11:02:34 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 616C3C433EF for ; Thu, 14 Jul 2022 10:03:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237604AbiGNKDb (ORCPT ); Thu, 14 Jul 2022 06:03:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237452AbiGNKD3 (ORCPT ); Thu, 14 Jul 2022 06:03:29 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B2B35018C for ; Thu, 14 Jul 2022 03:03:28 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id a5so1823382wrx.12 for ; Thu, 14 Jul 2022 03:03:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZVR4QvVnWBYeVB+iXIwMI+B8KQ5U2fMKvAXlIuNGVgk=; b=gBxiXRfaKyTZYwQXKxd95PSTZJ8U3isr4j6eMkW12m5Gr0F5rAZxorcyu9c5nboh48 xZMdsvhMWfBEtT1sJ/eibvDU2CHtDdZMBOBLqQVkfubHg+nQSEiLRwvRKPf/aJHMq6Yu 5VOP9BkucjdA3fBIzA+okSB2X8stFOBBvHI7EB2c0mMc6AVs8nU2xJXgoNePx6Ujtp21 JX1ydSMC5UY0eLLqpfbQ8FdXwdJc+Bzi6zw9SpmAAkjiZx3pgvD1H8i9jcGzfHav6ghS RhcOTfaQI6u9+3OJyg4TDtsMRbKXrIQcP7yCSfSXgHfPFcdlOXLx5X87sPiwLwMRlmyJ 4POA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZVR4QvVnWBYeVB+iXIwMI+B8KQ5U2fMKvAXlIuNGVgk=; b=CIRZ0wnecJvk+MOm/hYHa9XuJ/xZTEVXeYxm9Ij6HpRnhIqWkg4OHQVeZeWLZmLG8e iIKI2MY+xRP4KSX6MDk7W7dh5BbfX6yYVciEVwdUfGAzkPuQNnpXeL1YA5sXkvXbRODX hy/uebeB23zkLoRFp1nJUaYjLGvznDJt9KkDRuAPki87re9bMwXZL6W6teYgOnAX3qp3 1bB6DUmYgJRxjhHxdcwhqrj5iggFV/CdW7ImSKBJry2U578716mfQVgkJgqLMv8yuZV8 lrGyGp3xhJwxrU4f2LjhCI5H4yQrmLJcnNSYrsYHkHygDTEgyaFB5W7qaW+VMg5kVMyC cACA== X-Gm-Message-State: AJIora/6AzByUpzHmPIlY0pDlVVV+fCURiaowpLk3oUlw7pdD96G4nlo LHfgUzp+LTy64PujhJe1YMHMXYPcT8W0GsFq X-Google-Smtp-Source: AGRyM1t9tNgPpIxXmhLGc3c+A2Y86UdmgdxoECL9gDZ/MzRtO+1ATq97eGB6dv9z5+rV7A0CW00nrg== X-Received: by 2002:adf:e94c:0:b0:21d:81f4:7de2 with SMTP id m12-20020adfe94c000000b0021d81f47de2mr7656872wrn.338.1657793006927; Thu, 14 Jul 2022 03:03:26 -0700 (PDT) Received: from rainbowdash.office.codethink.co.uk ([167.98.27.226]) by smtp.gmail.com with ESMTPSA id p15-20020a5d68cf000000b0021d20461bbbsm1053856wrw.88.2022.07.14.03.03.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jul 2022 03:03:26 -0700 (PDT) From: Ben Dooks To: linux-kernel@vger.kernel.org, bpf@vger.kernel.org Cc: Sudip Mukherjee , Jude Onyenegecha , Ben Dooks Subject: [PATCH] bpf: fix check against plain integer v 'NULL' Date: Thu, 14 Jul 2022 11:03:22 +0100 Message-Id: <20220714100322.260467-1-ben.dooks@sifive.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" When checking with sparse, btf_show_type_value() is causing a warning about checking integer vs NULL when the macro is passed a pointer, due to the 'value !=3D 0' check. Stop sparse complaining about any type-casting by adding a cast to the typeof(value). This fixes the following sparse warnings: kernel/bpf/btf.c:2579:17: warning: Using plain integer as NULL pointer kernel/bpf/btf.c:2581:17: warning: Using plain integer as NULL pointer kernel/bpf/btf.c:3407:17: warning: Using plain integer as NULL pointer kernel/bpf/btf.c:3758:9: warning: Using plain integer as NULL pointer Signed-off-by: Ben Dooks Acked-by: Yonghong Song --- kernel/bpf/btf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c index eb12d4f705cc..9a6e5f71bbd2 100644 --- a/kernel/bpf/btf.c +++ b/kernel/bpf/btf.c @@ -1108,7 +1108,8 @@ __printf(2, 3) static void btf_show(struct btf_show *= show, const char *fmt, ...) */ #define btf_show_type_value(show, fmt, value) \ do { \ - if ((value) !=3D 0 || (show->flags & BTF_SHOW_ZERO) || \ + if ((value) !=3D (__typeof__(value))0 || \ + (show->flags & BTF_SHOW_ZERO) || \ show->state.depth =3D=3D 0) { \ btf_show(show, "%s%s" fmt "%s%s", \ btf_show_indent(show), \ --=20 2.35.1