From nobody Sat Apr 18 14:13:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B85C0C43334 for ; Wed, 13 Jul 2022 07:58:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234988AbiGMH6n (ORCPT ); Wed, 13 Jul 2022 03:58:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234964AbiGMH6i (ORCPT ); Wed, 13 Jul 2022 03:58:38 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C226965F3 for ; Wed, 13 Jul 2022 00:58:36 -0700 (PDT) Received: from pd956d63d.dip0.t-ipconnect.de ([217.86.214.61] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1oBXGR-0000L8-TX; Wed, 13 Jul 2022 09:58:31 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser , Dan Carpenter Subject: [PATCH] staging: r888eu: use dynamic allocation for efuse buffer Date: Wed, 13 Jul 2022 09:58:04 +0200 Message-Id: <20220713075804.140986-1-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use kmalloc to allocate the efuse buffer in ReadAdapterInfo8188EU and free it on exit. This is better than using a 512 byte array on the stack. It's ok to drop the __aligned(4) qualifier. kmalloc aligns to ARCH_KMALLOC_MINALIGN, this is at least 8 bytes. Suggested-by: Dan Carpenter Suggested-by: Larry Finger Signed-off-by: Martin Kaiser Acked-by: Larry Finger --- drivers/staging/r8188eu/hal/usb_halinit.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8= 188eu/hal/usb_halinit.c index 8902dda7b8d8..421fe7c40390 100644 --- a/drivers/staging/r8188eu/hal/usb_halinit.c +++ b/drivers/staging/r8188eu/hal/usb_halinit.c @@ -926,7 +926,7 @@ void ReadAdapterInfo8188EU(struct adapter *Adapter) { struct eeprom_priv *eeprom =3D &Adapter->eeprompriv; struct led_priv *ledpriv =3D &Adapter->ledpriv; - u8 efuse_buf[EFUSE_MAP_LEN_88E] __aligned(4); + u8 *efuse_buf; u8 eeValue; int res; =20 @@ -937,7 +937,10 @@ void ReadAdapterInfo8188EU(struct adapter *Adapter) =20 eeprom->bautoload_fail_flag =3D !(eeValue & EEPROM_EN); =20 - memset(efuse_buf, 0xFF, sizeof(efuse_buf)); + efuse_buf =3D kmalloc(EFUSE_MAP_LEN_88E, GFP_KERNEL); + if (!efuse_buf) + return; + memset(efuse_buf, 0xFF, EFUSE_MAP_LEN_88E); =20 if (!(eeValue & BOOT_FROM_EEPROM) && !eeprom->bautoload_fail_flag) { rtl8188e_EfusePowerSwitch(Adapter, true); @@ -957,6 +960,7 @@ void ReadAdapterInfo8188EU(struct adapter *Adapter) Hal_ReadThermalMeter_88E(Adapter, efuse_buf, eeprom->bautoload_fail_flag); =20 ledpriv->bRegUseLed =3D true; + kfree(efuse_buf); } =20 static void ResumeTxBeacon(struct adapter *adapt) --=20 2.30.2