From nobody Sat Apr 18 15:43:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD2A0C43334 for ; Tue, 12 Jul 2022 18:34:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233684AbiGLSeD (ORCPT ); Tue, 12 Jul 2022 14:34:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229800AbiGLSeC (ORCPT ); Tue, 12 Jul 2022 14:34:02 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AF5BBDBB4 for ; Tue, 12 Jul 2022 11:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:In-Reply-To:References; bh=fHgrQHCc655FJdPY9x1bi0PKduTmHmcw0it6E+N218Y=; b=XlC5k9uRWiremsaPvGS7ESW3hA oNqmGAnAr7nNLazIs8RZvLUmArQgsfeI59rHHactAUdcpd3OHq2oNueDQeQ8WXeU4FowwzpgRSZ4E dZKDCdlDTyqNcuIXThuSALyFAwTRw8QHxDe9f9WxXXbr3hVUaahOCBOjODw5ntjtJYn2C8iOeZhLG XqBdDJURMP+XYKFykdbLqGTTFfkjMDoGyoVHXWI1UZm48sQWr04a7WDdask6S9akqJv3yjsur9z+L TlCLmPH036fn5ycNN6M6APUq/jZdAkh/MhwRgQEDCTMymHj/YhIN/dwdrpYZ/C3uul3Q8XqM70mR7 O4VO/2VQ==; Received: from [2601:1c0:6280:3f0::a6b3] (helo=casper.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBKho-007C5w-3h; Tue, 12 Jul 2022 18:33:57 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Vijendar Mukunda , Mark Brown , alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai Subject: [PATCH -next] ASoC: amd: fix Jadeite kconfig warning and build errors Date: Tue, 12 Jul 2022 11:33:48 -0700 Message-Id: <20220712183348.31046-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since SND_SOC_ES8316 has a hard dependency on I2C and since 'select' does not follow any dependency chains, SND_SOC_AMD_ST_ES8336_MACH also needs to have a hard dependency on I2C. Fixes a kconfig warning and subsequent build errors: WARNING: unmet direct dependencies detected for SND_SOC_ES8316 Depends on [n]: SOUND [=3Dy] && !UML && SND [=3Dy] && SND_SOC [=3Dy] && I= 2C [=3Dn] Selected by [y]: - SND_SOC_AMD_ST_ES8336_MACH [=3Dy] && SOUND [=3Dy] && !UML && SND [=3Dy]= && SND_SOC [=3Dy] && SND_SOC_AMD_ACP [=3Dy] && ACPI [=3Dy] && (I2C [=3Dn] = || COMPILE_TEST [=3Dy]) sound/soc/codecs/es8316.c:866:1: warning: data definition has no type or st= orage class 866 | module_i2c_driver(es8316_i2c_driver); sound/soc/codecs/es8316.c:866:1: error: type defaults to =E2=80=98int=E2=80= =99 in declaration of =E2=80=98module_i2c_driver=E2=80=99 [-Werror=3Dimplic= it-int] sound/soc/codecs/es8316.c:866:1: warning: parameter names (without types) i= n function declaration sound/soc/codecs/es8316.c:857:26: warning: =E2=80=98es8316_i2c_driver=E2=80= =99 defined but not used [-Wunused-variable] 857 | static struct i2c_driver es8316_i2c_driver =3D { Fixes: f94fa8405801 ("ASoC: amd: enable machine driver build for Jadeite pl= atform") Signed-off-by: Randy Dunlap Cc: Vijendar Mukunda Cc: Mark Brown Cc: alsa-devel@alsa-project.org Cc: Jaroslav Kysela Cc: Takashi Iwai --- sound/soc/amd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/soc/amd/Kconfig +++ b/sound/soc/amd/Kconfig @@ -28,7 +28,7 @@ config SND_SOC_AMD_ST_ES8336_MACH select SND_SOC_ACPI if ACPI select SND_SOC_ES8316 depends on SND_SOC_AMD_ACP && ACPI - depends on I2C || COMPILE_TEST + depends on I2C help This option enables machine driver for Jadeite platform using es8336 codec.