From nobody Sat Apr 18 15:43:54 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 964E8C43334 for ; Tue, 12 Jul 2022 16:38:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232686AbiGLQil (ORCPT ); Tue, 12 Jul 2022 12:38:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229823AbiGLQie (ORCPT ); Tue, 12 Jul 2022 12:38:34 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B65AE1032 for ; Tue, 12 Jul 2022 09:38:32 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id h14-20020a1ccc0e000000b0039eff745c53so5146351wmb.5 for ; Tue, 12 Jul 2022 09:38:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BXuXiklFcl+vK0kmoMLD007iJW5hMW9mAc7xKGHZhfc=; b=Vro/dFbucTFTfY+imZQ1WkqMIYTcCBhqfgdDiw/JxxWQ4P0kgHI1akI7oBBajJOTcy fbxA1sjcXfsXZLM99JJDrF61XuA+Yt9jfRPrRvI3zXRuuGT7veCBHYlrtDqUdAQ+D5c1 cMitPM2+JPJEXy7DL12czQV+/2Sn+56Qdjx8V6cX8gMRHKptYtO03R1BLJtLKAddLq+L WV3lRDp5jE6pKPVhtV8QTqOEKc52tvlJWaM3udCW28xwQLzT7c42ozqDXTuGjKOWOBVa ho9d/HjLRIza73WOIfqiULK1bQG7PxQh9nnVHAkg4U2TDMLuy79CM6fiq8BlTjB2WWyg Wr0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BXuXiklFcl+vK0kmoMLD007iJW5hMW9mAc7xKGHZhfc=; b=HfuU9SPwQpR0HAkJAc6aaGLodvirmXRVdZFjUGbuWVJsJ/fotp75uUzeThv1zMcOa4 33XPXCmXA5C++TrakgZFCy8DpT7NBtsod3opPXecrg/fHWoRHUbjX7H+U0VMyHbTmpDF v1WYMFDSbHQYuvXe5WGD/JLUnCZeI/layOP1h2Bx1sv4CDdG42nH/GM6N3mOb942/J4E CoTGzR1Bcyr02Ds5+2A9XpyhzCOmyCLu+hpk8xOQu4mxNl2Nb9DqFrfZqonOduBn8dXU YpiBD5qEXNPY34SwU6ym8x1CnmvX7JF2MCPf+8lSh0VuToFWyfABvzo6RuLWg+ntZZOb aKwA== X-Gm-Message-State: AJIora+GoEOUYd6DQlJuH0dGu+5l00wFTeQK/sGwD7X2d9Yfr8WAuMji c802FH7Y9OUFxnZ71PRLdmj6HQ== X-Google-Smtp-Source: AGRyM1tb4EZs5ZikIvKJ/L8Kuec2ek3EENJV7eDH3jpkwW7n1kyTihutuzdDuVWp/U0dOXQ1AV41Lw== X-Received: by 2002:a05:600c:354e:b0:3a1:9ddf:468d with SMTP id i14-20020a05600c354e00b003a19ddf468dmr4841011wmq.145.1657643911325; Tue, 12 Jul 2022 09:38:31 -0700 (PDT) Received: from localhost.localdomain (host-78-150-47-22.as13285.net. [78.150.47.22]) by smtp.gmail.com with ESMTPSA id s14-20020a5d424e000000b0021d4d6355efsm8623751wrr.109.2022.07.12.09.38.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 09:38:30 -0700 (PDT) From: Sudip Mukherjee To: Tudor Ambarus , Pratyush Yadav , Michael Walle , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Cc: greentime.hu@sifive.com, jude.onyenegecha@sifive.com, william.salmon@sifive.com, adnan.chowdhury@sifive.com, ben.dooks@sifive.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH 1/3] mtd: spi-nor: extend no_sfdp_flags to use u16 Date: Tue, 12 Jul 2022 17:38:21 +0100 Message-Id: <20220712163823.428126-2-sudip.mukherjee@sifive.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220712163823.428126-1-sudip.mukherjee@sifive.com> References: <20220712163823.428126-1-sudip.mukherjee@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Currently no_sfdp_flags is u8 and all the bits have been used. Extend it to use u16 so that we can add more support. Signed-off-by: Sudip Mukherjee --- drivers/mtd/spi-nor/core.c | 2 +- drivers/mtd/spi-nor/core.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index ce5d69317d46c..e5f7691c5bd40 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -2335,7 +2335,7 @@ static void spi_nor_no_sfdp_init_params(struct spi_no= r *nor) { struct spi_nor_flash_parameter *params =3D nor->params; struct spi_nor_erase_map *map =3D ¶ms->erase_map; - const u8 no_sfdp_flags =3D nor->info->no_sfdp_flags; + const u16 no_sfdp_flags =3D nor->info->no_sfdp_flags; u8 i, erase_mask; =20 if (no_sfdp_flags & SPI_NOR_DUAL_READ) { diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h index 61886868cd022..58fbedc94080f 100644 --- a/drivers/mtd/spi-nor/core.h +++ b/drivers/mtd/spi-nor/core.h @@ -501,7 +501,7 @@ struct flash_info { #define NO_CHIP_ERASE BIT(7) #define SPI_NOR_NO_FR BIT(8) =20 - u8 no_sfdp_flags; + u16 no_sfdp_flags; #define SPI_NOR_SKIP_SFDP BIT(0) #define SECT_4K BIT(1) #define SPI_NOR_DUAL_READ BIT(3) --=20 2.30.2 From nobody Sat Apr 18 15:43:54 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51722C43334 for ; Tue, 12 Jul 2022 16:38:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233226AbiGLQir (ORCPT ); Tue, 12 Jul 2022 12:38:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231289AbiGLQif (ORCPT ); Tue, 12 Jul 2022 12:38:35 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 159181168 for ; Tue, 12 Jul 2022 09:38:33 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id z12so11956398wrq.7 for ; Tue, 12 Jul 2022 09:38:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bsQn2grPS7xgXNrR8QS8Z/js+pIZTD+IK94HxJFk+rM=; b=Vc3tXNm7QiJjXb2PTQiQlCHYyKSpT4cw3gmMIXMXtLLDSS5+msg5QkSbx8OcZgwJWB 3sJNkhjVy3ykyph+owYKFX0NI7pd7Bshi6xOaJOKQjJSDOGAPkPDtiXBz7Oh7CPy99bf ckoBPbv0Jvu8rNIk/yiiPqlsOQViRLUEfEi3D6ecNMA90ETZK1V4dLgnEztbxQJxOiWy FVadpwlMlqMSvkfJEteuERDldYZRwrBuWgsKqcRriOp5P6eKeSVPQ+FJD8kOYqKlUiGE rbG2mpLuhM11eKznY/j1BC7Ep8pCGcjE/G025iFI8857+aIGwVIzj7KZ/1ZV4T2zVm0d DqBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bsQn2grPS7xgXNrR8QS8Z/js+pIZTD+IK94HxJFk+rM=; b=oEI577GXnzJSWIHnbSc53FPQQmiJh71yE6qUu+661WNkYODMiBmKNwppQYsTKHwImy 9rLu/CYwrY9dEqHosyxiOhWcRspm7b0UHZ358WIuAYknjXwI6y+AZ93b9rfchwWgebhY 20WGmbi0IwK9axLRXqvIrKz0RPwxTOpf44c2cqzinRTCeAe0+usQreSxf2kLc3aExU14 IkwmFT1fm6YoO4Ph8hpbyd7ZUXCJ1Z+1x1INLrnsp7b+C76Ztw/1hxB7Vym5y8wIaS3A LO74C8MjbLr1IIE+yL0/57tGPBD84ZIPWPUmCGftUVzEkPsW/F4Zs3i5TcyJnzTHr0v7 vuNw== X-Gm-Message-State: AJIora/H9MgalGtM/urjRuwRKtFBhATJ4Mok5xE+CWL5JdtS4vHRJnSZ IbPeBY5NcGmWVGk4N/t60IW6XA== X-Google-Smtp-Source: AGRyM1vnzhRsv1t/YSN1aTRxG2Afz1YPqX0pdQKi6vtLJh2KgUD2dcowzt9rE3HD+p/L7p/Z8YYmmQ== X-Received: by 2002:a5d:4889:0:b0:21b:293e:9e43 with SMTP id g9-20020a5d4889000000b0021b293e9e43mr22404241wrq.705.1657643912132; Tue, 12 Jul 2022 09:38:32 -0700 (PDT) Received: from localhost.localdomain (host-78-150-47-22.as13285.net. [78.150.47.22]) by smtp.gmail.com with ESMTPSA id s14-20020a5d424e000000b0021d4d6355efsm8623751wrr.109.2022.07.12.09.38.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 09:38:31 -0700 (PDT) From: Sudip Mukherjee To: Tudor Ambarus , Pratyush Yadav , Michael Walle , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Cc: greentime.hu@sifive.com, jude.onyenegecha@sifive.com, william.salmon@sifive.com, adnan.chowdhury@sifive.com, ben.dooks@sifive.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH 2/3] mtd: spi-nor: add support for Quad Page Program to no_sfdp_flags Date: Tue, 12 Jul 2022 17:38:22 +0100 Message-Id: <20220712163823.428126-3-sudip.mukherjee@sifive.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220712163823.428126-1-sudip.mukherjee@sifive.com> References: <20220712163823.428126-1-sudip.mukherjee@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Some flash chips which does not have a SFDP table can support Quad Input Page Program. Enable it in hwcaps if defined. Signed-off-by: Sudip Mukherjee --- drivers/mtd/spi-nor/core.c | 5 +++++ drivers/mtd/spi-nor/core.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index e5f7691c5bd40..e299fc8fdd3d4 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -2375,6 +2375,11 @@ static void spi_nor_no_sfdp_init_params(struct spi_n= or *nor) spi_nor_set_pp_settings(¶ms->page_programs[SNOR_CMD_PP_8_8_8_DTR], SPINOR_OP_PP, SNOR_PROTO_8_8_8_DTR); } + if (no_sfdp_flags & SPI_NOR_QUAD_PP) { + params->hwcaps.mask |=3D SNOR_HWCAPS_PP_1_1_4; + spi_nor_set_pp_settings(¶ms->page_programs[SNOR_CMD_PP_1_1_4], + SPINOR_OP_PP_1_1_4, SNOR_PROTO_1_1_4); + } =20 /* * Sector Erase settings. Sort Erase Types in ascending order, with the diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h index 58fbedc94080f..dde636bdb1a7c 100644 --- a/drivers/mtd/spi-nor/core.h +++ b/drivers/mtd/spi-nor/core.h @@ -462,6 +462,7 @@ struct spi_nor_fixups { * SPI_NOR_OCTAL_READ: flash supports Octal Read. * SPI_NOR_OCTAL_DTR_READ: flash supports octal DTR Read. * SPI_NOR_OCTAL_DTR_PP: flash supports Octal DTR Page Program. + * SPI_NOR_QUAD_PP: flash supports Quad Input Page Program. * * @fixup_flags: flags that indicate support that can be discovered via= SFDP * ideally, but can not be discovered for this particular= flash @@ -509,6 +510,7 @@ struct flash_info { #define SPI_NOR_OCTAL_READ BIT(5) #define SPI_NOR_OCTAL_DTR_READ BIT(6) #define SPI_NOR_OCTAL_DTR_PP BIT(7) +#define SPI_NOR_QUAD_PP BIT(8) =20 u8 fixup_flags; #define SPI_NOR_4B_OPCODES BIT(0) --=20 2.30.2 From nobody Sat Apr 18 15:43:54 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C220C43334 for ; Tue, 12 Jul 2022 16:38:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232717AbiGLQiw (ORCPT ); Tue, 12 Jul 2022 12:38:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229657AbiGLQig (ORCPT ); Tue, 12 Jul 2022 12:38:36 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B0F92AD2 for ; Tue, 12 Jul 2022 09:38:34 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id z12so11956448wrq.7 for ; Tue, 12 Jul 2022 09:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JKhfBSF99cGeRL5/E+3ybugh2cH4mwS43tAxuhC31f0=; b=WalzjrJan0GdgXNc+jcedb6CZZSxb19MlR0FEDV27T/Eh8Ph077HshjmYEqrScbLL3 qPM+GPV5cwfOzw3e+PjdwKlOrveJCRAx64fSOLw2K30sPDOmGTWWH0mOyeULI6D1vlXc nmplU2PWoRNhO7oTEeUdGBw/M/k63v0IvscKOeDCEb/bDl5chzlY/4VdN01eyJbeDC2g ABrpGv+eAQ4kbtdQAB8XJ8kyKz/SM5ztbP0R9UqLkWRPSEmzNw2gc2KOa+Mu2/F33PxG 5RguZuynrkpFFDgEsTRWYJXhJ6EMEXBsZWHzrosOoUi9aPxq+1jW1x9xnhGT7rJpivgx NTxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JKhfBSF99cGeRL5/E+3ybugh2cH4mwS43tAxuhC31f0=; b=6zqs0oP83THMPHdNYq6Q4oZ0VP1TtzBWnD2xsYays4z7nEEm3CA/UAnm5mWKV64QuT SImWJp+0ZQGtoRrvn0Gj3kaZTf1aWerq87mY/YOZk2X5VOAFhu7OfJVGjhtkRGtArT9Q dU5lE17OhrxaEBcaMlPEV3y7yUmFhPvlneVBpWU5hRQHC87IQh41EoaalgYbvpqAa/Cr Y2w23hg+DBNpyJVpEnnIr7Mc93/0crQFCdhGyy/rf1SjRt6Y10SR1nVrJ4ikywY3DB1I dmX8MCQFjdA5xql/zGb7JuxcXCuaUXSeobDNGyh+a0XmeASWdLTPFRQ1ipZVcy8ApHu5 g0Cw== X-Gm-Message-State: AJIora8Rt45fLAYOdSkUG17vAlAPM7vMsrBmlqDTfDYgO07Rb3B2sfXG Gnbn2TVWh9dCYyTwZTtb3QtpcA== X-Google-Smtp-Source: AGRyM1ufviadNLw6BfOV8sOAMFzMPgwFnfwUzwRqtK79s7nSUqOHQuOz0PRmE30FEk4ryAtWtjTjZA== X-Received: by 2002:adf:d1cf:0:b0:21d:a2cd:522d with SMTP id b15-20020adfd1cf000000b0021da2cd522dmr13120142wrd.383.1657643912986; Tue, 12 Jul 2022 09:38:32 -0700 (PDT) Received: from localhost.localdomain (host-78-150-47-22.as13285.net. [78.150.47.22]) by smtp.gmail.com with ESMTPSA id s14-20020a5d424e000000b0021d4d6355efsm8623751wrr.109.2022.07.12.09.38.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 09:38:32 -0700 (PDT) From: Sudip Mukherjee To: Tudor Ambarus , Pratyush Yadav , Michael Walle , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Cc: greentime.hu@sifive.com, jude.onyenegecha@sifive.com, william.salmon@sifive.com, adnan.chowdhury@sifive.com, ben.dooks@sifive.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH 3/3] mtd: spi-nor: issi: is25wp256: Enable Quad Input Page Program Date: Tue, 12 Jul 2022 17:38:23 +0100 Message-Id: <20220712163823.428126-4-sudip.mukherjee@sifive.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220712163823.428126-1-sudip.mukherjee@sifive.com> References: <20220712163823.428126-1-sudip.mukherjee@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The flash chip is25wp256 supports Quad Input Page Program. Enable it in its no_sfdp_flags flags. Signed-off-by: Sudip Mukherjee --- drivers/mtd/spi-nor/issi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/spi-nor/issi.c b/drivers/mtd/spi-nor/issi.c index 3c7d51d2b0509..9a04b03bebe0b 100644 --- a/drivers/mtd/spi-nor/issi.c +++ b/drivers/mtd/spi-nor/issi.c @@ -71,7 +71,8 @@ static const struct flash_info issi_nor_parts[] =3D { { "is25wp128", INFO(0x9d7018, 0, 64 * 1024, 256) NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { "is25wp256", INFO(0x9d7019, 0, 64 * 1024, 512) - NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | + SPI_NOR_QUAD_PP) FIXUP_FLAGS(SPI_NOR_4B_OPCODES) .fixups =3D &is25lp256_fixups }, =20 --=20 2.30.2