From nobody Sat Apr 18 15:44:26 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B1DEC43334 for ; Tue, 12 Jul 2022 16:34:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234063AbiGLQen (ORCPT ); Tue, 12 Jul 2022 12:34:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234051AbiGLQeL (ORCPT ); Tue, 12 Jul 2022 12:34:11 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8459629CAA for ; Tue, 12 Jul 2022 09:34:09 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id z12so11939137wrq.7 for ; Tue, 12 Jul 2022 09:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jE26kz8uLkTSQmG0BFSrQuTDJo25o/aqMTxY60BA87o=; b=QIfK3LMHQAAiBrxqfYZoLMYn/I5LnR167Bvk75Kzzm7glu3CnnWflBthGnVxpPXsvH FFfLtZAyQwe2pG5VFkQpCwcSxURi5nBhsT8qDQLaf6eMIB/7/VzHvmrdIjRzanLAdbvf rt3yuhRvb3ftn70UVam1VUAFAyr8Kus6HFgko= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jE26kz8uLkTSQmG0BFSrQuTDJo25o/aqMTxY60BA87o=; b=Hw9Zn/MVSBBewH+S2J9ccqLmhtp4L2CIoMih/MAuGdSMsonMUNbumy8XRvj+DAqbag TB9YmSF1yQMOkNqz3bvEWjreMrzyjhrqhznQyV7UXLVd1dub0hGwfTj6wmYek0DM0fBa nk1IkNjXrsH2ae6U0KKd4e/GNUkxZ4VEXm266AgYppTkZnZctEgF4H1LhLqU+mDhdZmM /IT5ABbM33jf/0QuRGtEqXEpD/3beAtuqI1THw8/CSWnGotvAk2imxu/41/tI6cLNzSw BTcVKFgtZqdLL2UwAnHEnIvAFkk1CTz3k5TkBt4KxfCk43Y21UMsIS+afEA6axnhCMg/ x4dA== X-Gm-Message-State: AJIora9g/BKIpuyix15ngoQ9Iil8GpF81iIw2SDTGUcEvI7sOkuxWgpG 9MDJkRH3V4Hx8QkBV3YAg9csZA== X-Google-Smtp-Source: AGRyM1sX8eiouGb/oS1nfMSYyiXaIM3ieUoYGxmHF38hDy0MP1i/e/1eQdLeCX05rJW2O55lFT8ICg== X-Received: by 2002:a5d:6149:0:b0:21d:6ba7:6095 with SMTP id y9-20020a5d6149000000b0021d6ba76095mr22466762wrt.680.1657643647530; Tue, 12 Jul 2022 09:34:07 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-53-214.cust.vodafonedsl.it. [188.217.53.214]) by smtp.gmail.com with ESMTPSA id j16-20020a5d6050000000b0021db2dcd0aasm2321052wrt.108.2022.07.12.09.34.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 09:34:07 -0700 (PDT) From: Tommaso Merciai To: tommaso.merciai@amarulasolutions.com Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Jacopo Mondi , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 1/6] media: ov5693: count num_supplies using array_size Date: Tue, 12 Jul 2022 18:33:44 +0200 Message-Id: <20220712163349.1308540-2-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220712163349.1308540-1-tommaso.merciai@amarulasolutions.com> References: <20220712163349.1308540-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Instead of hardcode OV5693_NUM_SUPPLIES in a define is better use ARRAY_SIZE function to count the number of supplies from ov5693_supply_names array Signed-off-by: Tommaso Merciai Reviewed-by: Jacopo Mondi Reviewed-by: Daniel Scally --- Changes since v3: - Add reviewed-by tag, suggested by Jacopo, Krzysztof Changes since v4: - Add Daniel reviewed-by tag drivers/media/i2c/ov5693.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index 117ff5403312..f410333c4c67 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -127,11 +127,15 @@ #define OV5693_LINK_FREQ_419_2MHZ 419200000 #define OV5693_PIXEL_RATE 167680000 =20 -/* Miscellaneous */ -#define OV5693_NUM_SUPPLIES 2 - #define to_ov5693_sensor(x) container_of(x, struct ov5693_device, sd) =20 +static const char * const ov5693_supply_names[] =3D { + "avdd", /* Analog power */ + "dovdd", /* Digital I/O power */ +}; + +#define OV5693_NUM_SUPPLIES ARRAY_SIZE(ov5693_supply_names) + struct ov5693_reg { u32 reg; u8 val; @@ -352,11 +356,6 @@ static const s64 link_freq_menu_items[] =3D { OV5693_LINK_FREQ_419_2MHZ }; =20 -static const char * const ov5693_supply_names[] =3D { - "avdd", - "dovdd", -}; - static const char * const ov5693_test_pattern_menu[] =3D { "Disabled", "Random Data", --=20 2.25.1 From nobody Sat Apr 18 15:44:26 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80FD4C433EF for ; Tue, 12 Jul 2022 16:34:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234075AbiGLQeq (ORCPT ); Tue, 12 Jul 2022 12:34:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234305AbiGLQeN (ORCPT ); Tue, 12 Jul 2022 12:34:13 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9A8813DC8 for ; Tue, 12 Jul 2022 09:34:11 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id a5so11933758wrx.12 for ; Tue, 12 Jul 2022 09:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=REFGbYhE8dpEN5VkA7iNJtkkSRmeBAdrouvG3pc5rZ4=; b=AxwI3KThp/gT6ngSzdupUmlraPHHgO88D2ulxyRcgCNqTmHr9gW4EWQr3W5eatuZVQ wgXycyev3I6QJnrmslnno/F4DZTvXvNYDrBFiTLTpeyyl5p4OgWLL8/473drofkqxhSF jCZpM6MIsRpmFcToL/ZfyQ3aTqWJRBIFUJGfE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=REFGbYhE8dpEN5VkA7iNJtkkSRmeBAdrouvG3pc5rZ4=; b=HEj/c/V4LMx+VVNj5iezB9XJF8c56jV2E80SZAQ7NcaQtYZl1lpBSBCjTLKFJCOEWN Cv5KT1MRIeAuh1glIKbt1zMeB039NX5xPDIfoo6Dxl6s0wlD1+VrUPJoFE2nUNiv9Jme qtKhAATF3dGuQ8bT3Oz+v6R0lmwTNoMJVKiMewdESQIyq06QydBRlGKBfnnfXeZazFgk lvbS5fOCHdk/W02mnyGSJjvx6FrTsiaG8IqQX767tzTlUsHOJtT2rzVKzM+mEy06+Jer 8u7ZlQsX6o20DGOeGHVvcND43y9hL6fO8WVWecpqnlpjg9sZ254nK9BTOfGh5Z2SmQiI 7HnQ== X-Gm-Message-State: AJIora87GngA/vLYHrI3+NSLfljV06QQ/XaY44dSkv5kINzJPBQ8WxZe M0G4jmupaZ4FUIJh8wq/DN7QEg== X-Google-Smtp-Source: AGRyM1vHPboZMisVMS1fT8WrToIQiqBcYZqcf07kkb5lOnlgAdFIQv2fOKox/6JGcVDSSMmUVfvigA== X-Received: by 2002:a05:6000:2a4:b0:21d:8646:37f6 with SMTP id l4-20020a05600002a400b0021d864637f6mr22059252wry.661.1657643649501; Tue, 12 Jul 2022 09:34:09 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-53-214.cust.vodafonedsl.it. [188.217.53.214]) by smtp.gmail.com with ESMTPSA id j16-20020a5d6050000000b0021db2dcd0aasm2321052wrt.108.2022.07.12.09.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 09:34:09 -0700 (PDT) From: Tommaso Merciai To: tommaso.merciai@amarulasolutions.com Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Jacopo Mondi , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 2/6] media: ov5693: add dvdd into ov5693_supply_names array Date: Tue, 12 Jul 2022 18:33:45 +0200 Message-Id: <20220712163349.1308540-3-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220712163349.1308540-1-tommaso.merciai@amarulasolutions.com> References: <20220712163349.1308540-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add missing "dvdd" (Digital circuit power) entry into ov5693_supply_names array Signed-off-by: Tommaso Merciai Reviewed-by: Jacopo Mondi Reviewed-by: Daniel Scally --- Changes since v3: - Add reviewed-by tag, suggested by Jacopo, Krzysztof Changes since v4: - Add Daniel reviewed-by tag drivers/media/i2c/ov5693.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index f410333c4c67..9e84468d920e 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -132,6 +132,7 @@ static const char * const ov5693_supply_names[] =3D { "avdd", /* Analog power */ "dovdd", /* Digital I/O power */ + "dvdd", /* Digital circuit power */ }; =20 #define OV5693_NUM_SUPPLIES ARRAY_SIZE(ov5693_supply_names) --=20 2.25.1 From nobody Sat Apr 18 15:44:26 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BAAFC43334 for ; Tue, 12 Jul 2022 16:35:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233842AbiGLQfL (ORCPT ); Tue, 12 Jul 2022 12:35:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234384AbiGLQeS (ORCPT ); Tue, 12 Jul 2022 12:34:18 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C253627CE7 for ; Tue, 12 Jul 2022 09:34:13 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id r14so11975679wrg.1 for ; Tue, 12 Jul 2022 09:34:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ctpa/T2vVk1WErHGmcuqVVZ1P5/ZM5PQkEWqW8vXr7A=; b=CylXyQDI7NjZJJjGahP8/G+x1mwQdZyXU1fYlhjC5I+uzbIwEhCLjmEc+xJOEXf7Bc tRW4CZ/BQCYEKwyTayBWm+c1YPePeednwnGU4AOuP9vhrJZzEB5u1OsyscE8sn2LuV8N NcjprcgH3b8zWb+wimWqIP+Bpf7qFEm1gyCvQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ctpa/T2vVk1WErHGmcuqVVZ1P5/ZM5PQkEWqW8vXr7A=; b=IhZ4xHw3ZL7XTSNVc4Q5DpA0dUD37ZWIN0xuMU9SYMypt6Ar7jbugIGUCPtPaMUxkv KEWzZrQ7jY3qgcrICaunE8DQzuADE9C5MIWy5aKhKnOewdN6eIlbQABAUVmFlJEpdjwi 0/YltuDmzgFP5/DSK5JswBqCqK3E8Nv/yNj9HtehBv6vyvNwQFt9HDm7IbYa26N3YADY RVId7ZJlT/6CrgvTyYKjWIKMCSOG0jXOwUNCxXOB2AMkYfRy4KiweO79mtujE5DasQPI Ojtmb1rx8yBBztP6yACt8KsUddPiRtUl3IMecm7UsgkiDqQ3lWuvpBBdx9l9o6F6FWdA 9ndQ== X-Gm-Message-State: AJIora9Pk4XptZxHKRF3i0bAXmFCjVL2ZyJV/2Ho3JQp7M2gm1/qX9Jg 1lgvLFPHaD7HUimEgJgUcCMnCg== X-Google-Smtp-Source: AGRyM1u29k4IN2wgzOHnCdDeUpOtAD+K54m2KKU/q6uYaGIMJ+4h1Ier0c3zwV+m+j7TaLoaY4k7qQ== X-Received: by 2002:a5d:584e:0:b0:21c:ea0c:3734 with SMTP id i14-20020a5d584e000000b0021cea0c3734mr22283780wrf.420.1657643651827; Tue, 12 Jul 2022 09:34:11 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-53-214.cust.vodafonedsl.it. [188.217.53.214]) by smtp.gmail.com with ESMTPSA id j16-20020a5d6050000000b0021db2dcd0aasm2321052wrt.108.2022.07.12.09.34.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 09:34:11 -0700 (PDT) From: Tommaso Merciai To: tommaso.merciai@amarulasolutions.com Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Jacopo Mondi , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 3/6] media: ov5693: rename clk into xvclk Date: Tue, 12 Jul 2022 18:33:46 +0200 Message-Id: <20220712163349.1308540-4-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220712163349.1308540-1-tommaso.merciai@amarulasolutions.com> References: <20220712163349.1308540-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename clk pdata pointer into xvclk (system clock input). Same for clk_rate into xvclk_rate. This is more explicit Signed-off-by: Tommaso Merciai Reviewed-by: Jacopo Mondi --- Changes since v3: - Add reviewed-by tag, suggested by Jacopo, Krzysztof drivers/media/i2c/ov5693.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index 9e84468d920e..d2adc5513a21 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -157,7 +157,7 @@ struct ov5693_device { struct gpio_desc *reset; struct gpio_desc *powerdown; struct regulator_bulk_data supplies[OV5693_NUM_SUPPLIES]; - struct clk *clk; + struct clk *xvclk; =20 struct ov5693_mode { struct v4l2_rect crop; @@ -794,7 +794,7 @@ static void ov5693_sensor_powerdown(struct ov5693_devic= e *ov5693) =20 regulator_bulk_disable(OV5693_NUM_SUPPLIES, ov5693->supplies); =20 - clk_disable_unprepare(ov5693->clk); + clk_disable_unprepare(ov5693->xvclk); } =20 static int ov5693_sensor_powerup(struct ov5693_device *ov5693) @@ -804,7 +804,7 @@ static int ov5693_sensor_powerup(struct ov5693_device *= ov5693) gpiod_set_value_cansleep(ov5693->reset, 1); gpiod_set_value_cansleep(ov5693->powerdown, 1); =20 - ret =3D clk_prepare_enable(ov5693->clk); + ret =3D clk_prepare_enable(ov5693->xvclk); if (ret) { dev_err(ov5693->dev, "Failed to enable clk\n"); goto fail_power; @@ -1390,7 +1390,7 @@ static int ov5693_check_hwcfg(struct ov5693_device *o= v5693) static int ov5693_probe(struct i2c_client *client) { struct ov5693_device *ov5693; - u32 clk_rate; + u32 xvclk_rate; int ret =3D 0; =20 ov5693 =3D devm_kzalloc(&client->dev, sizeof(*ov5693), GFP_KERNEL); @@ -1408,16 +1408,16 @@ static int ov5693_probe(struct i2c_client *client) =20 v4l2_i2c_subdev_init(&ov5693->sd, client, &ov5693_ops); =20 - ov5693->clk =3D devm_clk_get(&client->dev, "xvclk"); - if (IS_ERR(ov5693->clk)) { + ov5693->xvclk =3D devm_clk_get(&client->dev, "xvclk"); + if (IS_ERR(ov5693->xvclk)) { dev_err(&client->dev, "Error getting clock\n"); - return PTR_ERR(ov5693->clk); + return PTR_ERR(ov5693->xvclk); } =20 - clk_rate =3D clk_get_rate(ov5693->clk); - if (clk_rate !=3D OV5693_XVCLK_FREQ) + xvclk_rate =3D clk_get_rate(ov5693->xvclk); + if (xvclk_rate !=3D OV5693_XVCLK_FREQ) dev_warn(&client->dev, "Found clk freq %u, expected %u\n", - clk_rate, OV5693_XVCLK_FREQ); + xvclk_rate, OV5693_XVCLK_FREQ); =20 ret =3D ov5693_configure_gpios(ov5693); if (ret) --=20 2.25.1 From nobody Sat Apr 18 15:44:26 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49984C43334 for ; Tue, 12 Jul 2022 16:34:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234114AbiGLQet (ORCPT ); Tue, 12 Jul 2022 12:34:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234388AbiGLQeS (ORCPT ); Tue, 12 Jul 2022 12:34:18 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10B702872B for ; Tue, 12 Jul 2022 09:34:17 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id d16so11915019wrv.10 for ; Tue, 12 Jul 2022 09:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ROC0BgtK/N+kzsuCvrmnTVmfs20tFROFRODZongU+to=; b=Zi2SdcL80G94C/94H/uEC9y0GdYUa3JuEkF2g+Zy55afvsfTlrtr9z33l7F+Na0VW1 2/AkZLTW+AN0e7TslzOclqC8DKUq/a3ACJyCllQfCMOYuBn+9O9bYcGGfoR7gp5AzqA1 inH6YvuknSOg8CklzFQZ5XUTpLWldzjetjOtA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ROC0BgtK/N+kzsuCvrmnTVmfs20tFROFRODZongU+to=; b=jAsIrS6FvgonB48SUAvv7OYAg2juoTrhuZTqzzA7+j/S/Iy1xvvBKMwbjAEXuILTCn JHain3TjH0tuOxHUw+HOe4VCXbhQkCA0MrD/2Ezwz2pEnoqCQB6MqXwDNIoT/3dS4BvC +ujqXLhxH7M7bP0N9Gvlhh0vDc/PVWLgiS72oqJDpBRFS6AOevRrelqK4WnQH18Wi7y2 tySi0J+wRtX1QtrOTrd0fZrrd0KKXMsGv7fyce1gSfZLQ1Ie5oif6gqP3T50SKGELwa9 wAuwXffNFaNLwaDjQ4ERMA9RymCIdtP5Q4BUMaqnBG+ee/Fz6/E0CcN0oqQa1LYhgpZp q9Rw== X-Gm-Message-State: AJIora8TH6lLxJsEmGpfwMOmn0MI6YO9QDTQNEy8RceHZPz9yqlYXLbg B8eS9hyBBRXmNWidNS6QJnir+g== X-Google-Smtp-Source: AGRyM1tnzV07IJXA3cVLN0Ve2xjeFMFieXv4fsSLQkxF158BaSiHY5fymewJYa2Lc+WZqQoOJSLevA== X-Received: by 2002:adf:e0c9:0:b0:21b:8271:2348 with SMTP id m9-20020adfe0c9000000b0021b82712348mr21782133wri.222.1657643655627; Tue, 12 Jul 2022 09:34:15 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-53-214.cust.vodafonedsl.it. [188.217.53.214]) by smtp.gmail.com with ESMTPSA id j16-20020a5d6050000000b0021db2dcd0aasm2321052wrt.108.2022.07.12.09.34.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 09:34:15 -0700 (PDT) From: Tommaso Merciai To: tommaso.merciai@amarulasolutions.com Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Jacopo Mondi , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 4/6] media: ov5693: add support for acpi clock-frequency prop Date: Tue, 12 Jul 2022 18:33:47 +0200 Message-Id: <20220712163349.1308540-5-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220712163349.1308540-1-tommaso.merciai@amarulasolutions.com> References: <20220712163349.1308540-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add support for ACPI-based platforms that specify the clock frequency by using the "clock-frequency" property instead of specifying a clock provider reference Signed-off-by: Tommaso Merciai Reviewed-by: Jacopo Mondi --- Changes since v2: - Fix commit body as suggested by Sakari, Jacopo - Add details to commit body as suggested by Jacopo - Move ov5693_check_hwcfg into ov5693_hwcfg - Fix xvclk_rate position as suggested by Jacopo - Use devm_clk_get_optional instead of devm_clk_get as suggested Jacopo Changes since v3: - Fix commit body as suggested by Jacopo - Add reviewed-by tags, suggested by Jacopo, Krzysztof Changes since v4: - Remove wrong Sakari reviewed-by tag, suggested by Krzysztof, Sakari - Revert ov5693_check_hwcfg function changes. Keep clk init on probe funct= ion as suggested by Sakari - Fix commit body - Fix commit msg drivers/media/i2c/ov5693.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index d2adc5513a21..701468267f20 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -1408,13 +1408,25 @@ static int ov5693_probe(struct i2c_client *client) =20 v4l2_i2c_subdev_init(&ov5693->sd, client, &ov5693_ops); =20 - ov5693->xvclk =3D devm_clk_get(&client->dev, "xvclk"); - if (IS_ERR(ov5693->xvclk)) { - dev_err(&client->dev, "Error getting clock\n"); - return PTR_ERR(ov5693->xvclk); + ov5693->xvclk =3D devm_clk_get_optional(&client->dev, "xvclk"); + if (IS_ERR(ov5693->xvclk)) + return dev_err_probe(&client->dev, PTR_ERR(ov5693->xvclk), + "failed to get xvclk: %ld\n", + PTR_ERR(ov5693->xvclk)); + + if (ov5693->xvclk) { + xvclk_rate =3D clk_get_rate(ov5693->xvclk); + } else { + ret =3D fwnode_property_read_u32(dev_fwnode(&client->dev), + "clock-frequency", + &xvclk_rate); + + if (ret) { + dev_err(&client->dev, "can't get clock frequency"); + return ret; + } } =20 - xvclk_rate =3D clk_get_rate(ov5693->xvclk); if (xvclk_rate !=3D OV5693_XVCLK_FREQ) dev_warn(&client->dev, "Found clk freq %u, expected %u\n", xvclk_rate, OV5693_XVCLK_FREQ); --=20 2.25.1 From nobody Sat Apr 18 15:44:26 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 479B2C43334 for ; Tue, 12 Jul 2022 16:34:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234331AbiGLQe5 (ORCPT ); Tue, 12 Jul 2022 12:34:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234440AbiGLQeW (ORCPT ); Tue, 12 Jul 2022 12:34:22 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DB9D22BF3 for ; Tue, 12 Jul 2022 09:34:21 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id bu1so10758289wrb.9 for ; Tue, 12 Jul 2022 09:34:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=klIuiYkZWbRMkCmGujIVKAt0cLr/WkyvgD6JQ+6Oul0=; b=UHGrVJVDRRTIjuwhoxPgsyuXY178AvoBZAt8tYmvGNAt3wUNp2eGbzAjSUO5CtIYWd v4k2Asy2bsfkKrfan8fTUdNaMHi1NErgamwFN98Y6IazN/uQYn7LWxYZENDlDSo0BCVN IGQifg6kLGBLEcl5SaOkTTQWGIPCoL9vbJ998= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=klIuiYkZWbRMkCmGujIVKAt0cLr/WkyvgD6JQ+6Oul0=; b=nQDivgVDYmx0r2aKsU45pTj0tgYt1ilT5PEzwElz0r+PLRw7pPZ1JujjWSnUvSx6kP Swvri6wsw1yKRIs8hZDAEaSH29l9mtpjkynpOCpBpAkRaWLORJTK9OYlP4PY8J4tNT95 TTL0k0Tcq9//ZNf9LoMnoKOttVyfVuatnx0PZBg6iw13RiuV7mQNZPVGy4xt9escuuw8 2ri85U0RTbNo/0rGZqtBuKVsEt8KC9zH0PcmfV0K3AfxwqTsK9og49+DXBEEtjl+NYR+ 1xJLjzDJt6C9D/PVWfuo/2dlvC6FbxCasUBu+LYY+fTDldYFqNLMweZxMXxxino2nmtH TAkw== X-Gm-Message-State: AJIora8mNPs3eakagy7g40Rzx3xArxJKd6W8KEsCSRt1dLVaFX2hPdLp aUnFqg3AMyvZCso81rAjlNh32g== X-Google-Smtp-Source: AGRyM1vgTK7sBIJDryunUP/xvoLs0aUC4aUgVkdYn/ZM/piu/xJB+SrFhOF0Vl4fRurfobrElcfxFA== X-Received: by 2002:a5d:5087:0:b0:21d:9925:e15a with SMTP id a7-20020a5d5087000000b0021d9925e15amr16372612wrt.43.1657643659728; Tue, 12 Jul 2022 09:34:19 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-53-214.cust.vodafonedsl.it. [188.217.53.214]) by smtp.gmail.com with ESMTPSA id j16-20020a5d6050000000b0021db2dcd0aasm2321052wrt.108.2022.07.12.09.34.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 09:34:19 -0700 (PDT) From: Tommaso Merciai To: tommaso.merciai@amarulasolutions.com Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Krzysztof Kozlowski , Daniel Scally , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 5/6] media: dt-bindings: ov5693: document YAML binding Date: Tue, 12 Jul 2022 18:33:48 +0200 Message-Id: <20220712163349.1308540-6-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220712163349.1308540-1-tommaso.merciai@amarulasolutions.com> References: <20220712163349.1308540-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add documentation of device tree in YAML schema for the OV5693 CMOS image sensor from Omnivision Signed-off-by: Tommaso Merciai Reviewed-by: Krzysztof Kozlowski --- Changes since v1: - Fix allOf position as suggested by Krzysztof - Remove port description as suggested by Krzysztof - Fix EOF as suggested by Krzysztof Changes since v2: - Fix commit body as suggested by Krzysztof Changes since v3: - Add reviewed-by tags, suggested by Jacopo, Krzysztof Changes since v4: - Remove wrong Sakari reviewed-by tag, suggested by Krzysztof, Sakari Changes since v5: - Remove dovdd-supply, avdd-supply, dvdd-supply from required properties as suggested by Jacopo .../bindings/media/i2c/ovti,ov5693.yaml | 103 ++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 104 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov5693= .yaml diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml b= /Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml new file mode 100644 index 000000000000..8974a2c746a7 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml @@ -0,0 +1,103 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (c) 2022 Amarulasolutions +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/ovti,ov5693.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Omnivision OV5693 CMOS Sensor + +maintainers: + - Tommaso Merciai + +description: | + The Omnivision OV5693 is a high performance, 1/4-inch, 5 megapixel, CMOS + image sensor that delivers 2592x1944 at 30fps. It provides full-frame, + sub-sampled, and windowed 10-bit MIPI images in various formats via the + Serial Camera Control Bus (SCCB) interface. + + OV5693 is controlled via I2C and two-wire Serial Camera Control Bus (SCC= B). + The sensor output is available via CSI-2 serial data output (up to 2-lan= e). + +allOf: + - $ref: /schemas/media/video-interface-devices.yaml# + +properties: + compatible: + const: ovti,ov5693 + + reg: + maxItems: 1 + + clocks: + description: + System input clock (aka XVCLK). From 6 to 27 MHz. + maxItems: 1 + + dovdd-supply: + description: + Digital I/O voltage supply, 1.8V. + + avdd-supply: + description: + Analog voltage supply, 2.8V. + + dvdd-supply: + description: + Digital core voltage supply, 1.2V. + + reset-gpios: + description: + The phandle and specifier for the GPIO that controls sensor reset. + This corresponds to the hardware pin XSHUTDN which is physically + active low. + maxItems: 1 + +required: + - compatible + - reg + - clocks + - port + +unevaluatedProperties: false + +examples: + - | + #include + #include + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + ov5693: camera@36 { + compatible =3D "ovti,ov5693"; + reg =3D <0x36>; + + reset-gpios =3D <&gpio2 RK_PB1 GPIO_ACTIVE_LOW>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&cif_clkout_m0>; + + clocks =3D <&cru SCLK_CIF_OUT>; + assigned-clocks =3D <&cru SCLK_CIF_OUT>; + assigned-clock-rates =3D <19200000>; + + avdd-supply =3D <&vcc_1v8>; + dvdd-supply =3D <&vcc_1v2>; + dovdd-supply =3D <&vcc_2v8>; + + rotation =3D <90>; + orientation =3D <0>; + + port { + ucam_out: endpoint { + remote-endpoint =3D <&mipi_in_ucam>; + data-lanes =3D <1 2>; + link-frequencies =3D /bits/ 64 <450000000>; + }; + }; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index 66bffb24a348..5a7881ee15e1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14767,6 +14767,7 @@ M: Daniel Scally L: linux-media@vger.kernel.org S: Maintained T: git git://linuxtv.org/media_tree.git +F: Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml F: drivers/media/i2c/ov5693.c =20 OMNIVISION OV5695 SENSOR DRIVER --=20 2.25.1 From nobody Sat Apr 18 15:44:26 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D381C433EF for ; Tue, 12 Jul 2022 16:34:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233423AbiGLQex (ORCPT ); Tue, 12 Jul 2022 12:34:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234453AbiGLQeX (ORCPT ); Tue, 12 Jul 2022 12:34:23 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CDD425C7D for ; Tue, 12 Jul 2022 09:34:22 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id a5so11934611wrx.12 for ; Tue, 12 Jul 2022 09:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=89nMQY6HYa205yz8a9PXVreqJnhbEp/5UjZ/0K+ojBk=; b=Sbj3OenGDNgca8fxaKSwwSFWyjuRmCOQNHQsUJmiQ5hzLNGBtB5VD5qu3THqAUtZ9Y WyOtO/ZU2yIesrCXN6g6Fa5e6Sgdqt/KoXgplKkXuLGt63KAraOSxBk6hQm2HGUQe3hx jbfzYNUMS4IodFAzhJKmwS/eqtnmvsjUpRmXM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=89nMQY6HYa205yz8a9PXVreqJnhbEp/5UjZ/0K+ojBk=; b=kDxge87iKfi/wQ3rRGJeJ0yyRjrqnkyAlXmxjUmGfQHrdz/mK1f3gCRJeqCUTL5zcQ fOFBKCPy/amCo4yp59Tp8ZpKhhcnCIpb2egAIOzHALuJ4GL/EOkQNMh249BZ6t9fokRM +L/2gmrve4s9Ai+SW22ZBGRVl4XmTU8pj2WoNvyhkbontW5FtANv+WZiScRswi7Rw216 xO7B+YPTUBExDZh7KeotdKH8JO9pligz9MiZke1+MmflxG+JTLo5d2vfIgoe+owztNgS wIZhRzlhQ54iDjnwZUvdY07E0hIxQcD9RPtgbd+qMvWee6+zw8beLOGD3dbbOzfKlI2S aIbQ== X-Gm-Message-State: AJIora8Ar8/N0reCSdqespsf6OeASMdLMF1l8VmzbyFGwiBg1uSCgzHg rk5PXt5316kdDJ3PzXlR7qOojA== X-Google-Smtp-Source: AGRyM1vpE0g2EPdx1v6ZXFwl0FZwWK05OYeD6gB+mPU8ZvzyMwQc1WUVBry6G63zOCENCNZijoHsoQ== X-Received: by 2002:a5d:4c49:0:b0:21d:6df5:beb7 with SMTP id n9-20020a5d4c49000000b0021d6df5beb7mr23158622wrt.286.1657643661957; Tue, 12 Jul 2022 09:34:21 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-53-214.cust.vodafonedsl.it. [188.217.53.214]) by smtp.gmail.com with ESMTPSA id j16-20020a5d6050000000b0021db2dcd0aasm2321052wrt.108.2022.07.12.09.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 09:34:21 -0700 (PDT) From: Tommaso Merciai To: tommaso.merciai@amarulasolutions.com Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Jacopo Mondi , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 6/6] media: ov5693: add ov5693_of_match, dts support Date: Tue, 12 Jul 2022 18:33:49 +0200 Message-Id: <20220712163349.1308540-7-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220712163349.1308540-1-tommaso.merciai@amarulasolutions.com> References: <20220712163349.1308540-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add ov5693_of_match. Device tree support Signed-off-by: Tommaso Merciai Reviewed-by: Jacopo Mondi Reviewed-by: Daniel Scally --- Changes since v2: - Change patch order 7 -> 6 as suggested by Sakari - Add missing signed-off as suggested by Jacopo Changes since v3: - Add reviewed-by tags, suggested by Jacopo, Krzysztof Changes since v4: - Remove wrong Sakari reviewed-by tag, suggested by Krzysztof, Sakari - Add Daniel reviewed-by tag drivers/media/i2c/ov5693.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index 701468267f20..82a9b2de7735 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -1533,10 +1533,17 @@ static const struct acpi_device_id ov5693_acpi_matc= h[] =3D { }; MODULE_DEVICE_TABLE(acpi, ov5693_acpi_match); =20 +static const struct of_device_id ov5693_of_match[] =3D { + { .compatible =3D "ovti,ov5693", }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(of, ov5693_of_match); + static struct i2c_driver ov5693_driver =3D { .driver =3D { .name =3D "ov5693", .acpi_match_table =3D ov5693_acpi_match, + .of_match_table =3D ov5693_of_match, .pm =3D &ov5693_pm_ops, }, .probe_new =3D ov5693_probe, --=20 2.25.1