From nobody Sat Sep 21 21:33:24 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BBE4CCA480 for ; Tue, 12 Jul 2022 11:12:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232155AbiGLLMy (ORCPT ); Tue, 12 Jul 2022 07:12:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229994AbiGLLMj (ORCPT ); Tue, 12 Jul 2022 07:12:39 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06A24B027F; Tue, 12 Jul 2022 04:12:32 -0700 (PDT) X-UUID: 9e5b2f1a387d4dc287fd44c71d5ece6d-20220712 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.8,REQID:49c6bc5c-cb56-4591-bcf2-8030d7c29445,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACT ION:release,TS:-5 X-CID-META: VersionHash:0f94e32,CLOUDID:ae4ac332-b9e4-42b8-b28a-6364427c76bb,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: 9e5b2f1a387d4dc287fd44c71d5ece6d-20220712 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1276785255; Tue, 12 Jul 2022 19:12:27 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Tue, 12 Jul 2022 19:12:26 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Tue, 12 Jul 2022 19:12:26 +0800 From: Bo-Chen Chen To: , , , , , , , , , CC: , , , , , , , , , , , , , , Bo-Chen Chen Subject: [PATCH v14 10/10] drm/mediatek: Use cached audio config when changing resolution Date: Tue, 12 Jul 2022 19:12:23 +0800 Message-ID: <20220712111223.13080-11-rex-bc.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20220712111223.13080-1-rex-bc.chen@mediatek.com> References: <20220712111223.13080-1-rex-bc.chen@mediatek.com> MIME-Version: 1.0 X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When the audio is playing, we need to use the original configuration to set the audio instead of using new configuration. Therefore, use the cached audio configuration during a resolution switch to avoid loss of sound. Signed-off-by: Jitao Shi Signed-off-by: Bo-Chen Chen Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dp.c | 54 ++++++++++--------------------- 1 file changed, 17 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/m= tk_dp.c index fa7bb102a105..32fb7be374ed 100644 --- a/drivers/gpu/drm/mediatek/mtk_dp.c +++ b/drivers/gpu/drm/mediatek/mtk_dp.c @@ -104,7 +104,7 @@ struct mtk_dp_audio_cfg { struct mtk_dp_info { u32 depth; enum dp_pixelformat format; - struct mtk_dp_audio_cfg audio_caps; + struct mtk_dp_audio_cfg audio_cur_cfg; struct mtk_dp_timings timings; }; =20 @@ -1858,9 +1858,7 @@ static bool mtk_dp_edid_parse_audio_capabilities(stru= ct mtk_dp *mtk_dp, struct mtk_dp_audio_cfg *cfg) { struct cea_sad *sads; - int sad_count; - int i; - bool ret =3D false; + int ret; =20 if (mtk_dp_is_edp(mtk_dp)) return false; @@ -1871,36 +1869,16 @@ static bool mtk_dp_edid_parse_audio_capabilities(st= ruct mtk_dp *mtk_dp, dev_err(mtk_dp->dev, "EDID not found!\n"); return false; } - sad_count =3D drm_edid_to_sad(mtk_dp->edid, &sads); - mutex_unlock(&mtk_dp->edid_lock); =20 - if (sad_count <=3D 0) { + ret =3D drm_edid_to_sad(mtk_dp->edid, &sads); + mutex_unlock(&mtk_dp->edid_lock); + if (ret <=3D 0) { drm_info(mtk_dp->drm_dev, "The SADs is NULL\n"); return false; } - - for (i =3D 0; i < sad_count; i++) { - int sample_rate, word_length; - - /* Only PCM supported at the moment */ - if (sads[i].format !=3D HDMI_AUDIO_CODING_TYPE_PCM) - continue; - - sample_rate =3D drm_cea_sad_get_sample_rate(&sads[i]); - word_length =3D - drm_cea_sad_get_uncompressed_word_length(&sads[i]); - if (sample_rate <=3D 0 || word_length <=3D 0) - continue; - - cfg->channels =3D sads[i].channels; - cfg->word_length_bits =3D word_length; - cfg->sample_rate =3D sample_rate; - ret =3D true; - break; - } kfree(sads); =20 - return ret; + return true; } =20 static void mtk_dp_train_change_mode(struct mtk_dp *mtk_dp) @@ -2081,13 +2059,13 @@ static int mtk_dp_training(struct mtk_dp *mtk_dp) =20 mtk_dp->audio_enable =3D mtk_dp_edid_parse_audio_capabilities(mtk_dp, - &mtk_dp->info.audio_caps); + &mtk_dp->info.audio_cur_cfg); if (mtk_dp->audio_enable) { - mtk_dp_audio_setup(mtk_dp, &mtk_dp->info.audio_caps); + mtk_dp_audio_setup(mtk_dp, &mtk_dp->info.audio_cur_cfg); mtk_dp_audio_mute(mtk_dp, false); } else { - memset(&mtk_dp->info.audio_caps, 0, - sizeof(mtk_dp->info.audio_caps)); + memset(&mtk_dp->info.audio_cur_cfg, 0, + sizeof(mtk_dp->info.audio_cur_cfg)); } =20 return 0; @@ -2491,6 +2469,9 @@ static void mtk_dp_bridge_atomic_disable(struct drm_b= ridge *bridge, if (mtk_dp_plug_state(mtk_dp)) { drm_dp_dpcd_writeb(&mtk_dp->aux, DP_SET_POWER, DP_SET_POWER_D3); usleep_range(2000, 3000); + } else { + memset(&mtk_dp->info.audio_cur_cfg, 0, + sizeof(mtk_dp->info.audio_cur_cfg)); } =20 mtk_dp_video_mute(mtk_dp, true); @@ -2701,18 +2682,17 @@ static int mtk_dp_audio_hw_params(struct device *de= v, void *data, struct hdmi_codec_params *params) { struct mtk_dp *mtk_dp =3D dev_get_drvdata(dev); - struct mtk_dp_audio_cfg cfg; =20 if (!mtk_dp->enabled) { pr_err("%s, DP is not ready!\n", __func__); return -ENODEV; } =20 - cfg.channels =3D params->cea.channels; - cfg.sample_rate =3D params->sample_rate; - cfg.word_length_bits =3D 24; + mtk_dp->info.audio_cur_cfg.channels =3D params->cea.channels; + mtk_dp->info.audio_cur_cfg.sample_rate =3D params->sample_rate; + mtk_dp->info.audio_cur_cfg.word_length_bits =3D 24; =20 - mtk_dp_audio_setup(mtk_dp, &cfg); + mtk_dp_audio_setup(mtk_dp, &mtk_dp->info.audio_cur_cfg); =20 return 0; } --=20 2.18.0