From nobody Sun Apr 19 00:26:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF9B4C433EF for ; Fri, 8 Jul 2022 01:31:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236981AbiGHBbm (ORCPT ); Thu, 7 Jul 2022 21:31:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236954AbiGHBbk (ORCPT ); Thu, 7 Jul 2022 21:31:40 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 763DB72EDB for ; Thu, 7 Jul 2022 18:31:38 -0700 (PDT) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2681VU1E033076; Thu, 7 Jul 2022 20:31:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1657243890; bh=OPU/FEXF1OZ7e78AGxI45y2Hs2e8lTo+nO3wH3PsGX0=; h=From:To:CC:Subject:Date; b=NgNkGcIaYslilGN4cxX95HuLpUHX538oCWMvT+rft15HcX9UlnaEb4Eo8kKtKG/H9 s+3or0tlJEZixAwK/wI4WwRz9OMsmMeG03xFsmSf9rljp9aeB3O8j2Pz8NCuKIJFQl 5LN9xUuWMGJ6U9ydSDOe3BOdbknKcVfsmCQsRqkE= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2681VUo9040305 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 7 Jul 2022 20:31:30 -0500 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Thu, 7 Jul 2022 20:31:29 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Thu, 7 Jul 2022 20:31:29 -0500 Received: from ubuntu.ent.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2681VQfb045825; Thu, 7 Jul 2022 20:31:27 -0500 From: Matt Ranostay To: CC: Matt Ranostay , Mark Brown , Nishanth Menon Subject: [PATCH] regmap: add WARN_ONCE when invalid mask is provided to regmap_field_init() Date: Thu, 7 Jul 2022 18:31:25 -0700 Message-ID: <20220708013125.313892-1-mranostay@ti.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In regmap_field_init() when a invalid mask is provided it still initializes with any warnings. An example of this is when the LSB is greater than MSB a mask of zero is produced. WARN_ONCE() is not ideal for this but requires less changes to core regmap code. Cc: Mark Brown Cc: Nishanth Menon Signed-off-by: Matt Ranostay --- drivers/base/regmap/regmap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 4cf59e10d01b..0caa5690c560 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -1298,6 +1298,9 @@ static void regmap_field_init(struct regmap_field *rm= _field, rm_field->reg =3D reg_field.reg; rm_field->shift =3D reg_field.lsb; rm_field->mask =3D GENMASK(reg_field.msb, reg_field.lsb); + + WARN_ONCE(rm_field->mask =3D=3D 0, "invalid empty mask defined\n"); + rm_field->id_size =3D reg_field.id_size; rm_field->id_offset =3D reg_field.id_offset; } --=20 2.36.1