From nobody Sun Apr 19 05:32:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96C8CCCA47B for ; Tue, 5 Jul 2022 21:01:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232294AbiGEVBy (ORCPT ); Tue, 5 Jul 2022 17:01:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230061AbiGEVBt (ORCPT ); Tue, 5 Jul 2022 17:01:49 -0400 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 200A6E76 for ; Tue, 5 Jul 2022 14:01:49 -0700 (PDT) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 593A742442 for ; Tue, 5 Jul 2022 21:01:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1657054907; bh=bQMwaeYKMT6usnwDyo75UwU6twU1bHQlELRjvpkCaBs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lK1lQTBf8Tbaa1/LDM+pOCGZOUWU0jDHdZUI8aomWLnlYPFkws2WHrFbJzmg7vrL/ Uo6Fdp5RdJ/9PVssQQTRd/XJZaGIy6v59KxeSPAtoMEdkb1gogVEdL9JPzQsy8Mb36 qVXcw3CRVe2nfP9r9Gdn6ho0CwnrK0AwPcR68p2xnreM4TmxunH8Xdf27KPHIUG9yc HERR+Uts/3wm1dGXYxEzW++XElnWNUBXKYxij4Pt6S357pyPMfdqBcY5Iyv1nkT9kQ yZTokfs+ChLQ90BPp+sBMy7mjKq5illHZtVY7yQDzRaBMYpkv2d6sqtJ9b10MOBh9n iNYfdbx0agCkA== Received: by mail-wm1-f69.google.com with SMTP id n18-20020a05600c501200b003a050cc39a0so5737532wmr.7 for ; Tue, 05 Jul 2022 14:01:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bQMwaeYKMT6usnwDyo75UwU6twU1bHQlELRjvpkCaBs=; b=ofZcEDKG3PJOMXZEwlvsGA9aCmlpyRMOk33bZ+NNSwR90QH40QrwGX8LoEyUPWkHz0 56kAQ3oRRnGq4sJ0oTxpNDBXr2FIfUeryOBhVOwobEbvDsamLI+ATEgQrNQLlnuIARWo vqek7EB/2ce3X7I4qptpsX2/ymfhOrDEyIAb7LvHWHlB9zfqkJmP3Tw81Cdx9mnBA+Ja 1yD2r1KYc8kJRo7WcfL8x/n956IgY0+G0Iv+sDR9BcHEn46QNCaRLyBg1vksPJiJupSG aH0fvlt+re34gaN8Nousf1HL6yNXoptLxxSKo9FqUajmJazPPw8vCPb/BturhfJKoA8S EZlA== X-Gm-Message-State: AJIora9BuDgtG6JLXdzsu7RRq9cdoM2A70tQ//D4xmd0mXDo//FQI7/S yJHZvH140dcdJM6Zqob54hQg74HXzeYpn0W21uf6vjlPns79OnhM85dgPfaKvKiP4CoxMQAuqui y9s5JyJSWiYX4N2TpTQOKPPXX+nM/Wa7bgny2xYEu5Q== X-Received: by 2002:a05:600c:3caa:b0:394:8fb8:716 with SMTP id bg42-20020a05600c3caa00b003948fb80716mr39682333wmb.105.1657054906775; Tue, 05 Jul 2022 14:01:46 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tZxXj9wYCQn8xRiwSdoNr+XF9lf5AtfECiLDauDGWvaTlvbMHbvHq3GJc+TGPSmAuxJVR2KQ== X-Received: by 2002:a05:600c:3caa:b0:394:8fb8:716 with SMTP id bg42-20020a05600c3caa00b003948fb80716mr39682293wmb.105.1657054906543; Tue, 05 Jul 2022 14:01:46 -0700 (PDT) Received: from stitch.. (80.71.140.73.ipv4.parknet.dk. [80.71.140.73]) by smtp.gmail.com with ESMTPSA id r15-20020a0560001b8f00b0021d74906683sm2517667wru.28.2022.07.05.14.01.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 14:01:46 -0700 (PDT) From: Emil Renner Berthing To: linux-kernel@vger.kernel.org Cc: Pavel Machek , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Vincent Pelletier , Bin Meng , Aurelien Jarno , Ron Economos , Qiu Wenbo , Geert Uytterhoeven , Stephen L Arnold , Jianlong Huang , Mark Kettenis , Sven Schwermer , Andy Shevchenko , David Abdurachmanov , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH v1 1/4] leds: pwm-multicolor: Don't show -EPROBE_DEFER as errors Date: Tue, 5 Jul 2022 23:01:40 +0200 Message-Id: <20220705210143.315151-2-emil.renner.berthing@canonical.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220705210143.315151-1-emil.renner.berthing@canonical.com> References: <20220705210143.315151-1-emil.renner.berthing@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" When requesting a PWM it might return -EPROBE_DEFER if it hasn't probed yet. This is not an error, so just propagate the -EPROBE_DEFER without logging anything. There is already dev_err_probe for exactly this situation. Fixes: 9fa2762110dd ("leds: Add PWM multicolor driver") Signed-off-by: Emil Renner Berthing Reviewed-by: Geert Uytterhoeven --- drivers/leds/rgb/leds-pwm-multicolor.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/leds/rgb/leds-pwm-multicolor.c b/drivers/leds/rgb/leds= -pwm-multicolor.c index 45e38708ecb1..eb67b89d28e9 100644 --- a/drivers/leds/rgb/leds-pwm-multicolor.c +++ b/drivers/leds/rgb/leds-pwm-multicolor.c @@ -72,8 +72,7 @@ static int iterate_subleds(struct device *dev, struct pwm= _mc_led *priv, pwmled =3D &priv->leds[priv->mc_cdev.num_colors]; pwmled->pwm =3D devm_fwnode_pwm_get(dev, fwnode, NULL); if (IS_ERR(pwmled->pwm)) { - ret =3D PTR_ERR(pwmled->pwm); - dev_err(dev, "unable to request PWM: %d\n", ret); + ret =3D dev_err_probe(dev, PTR_ERR(pwmled->pwm), "unable to request PWM= \n"); goto release_fwnode; } pwm_init_state(pwmled->pwm, &pwmled->state); --=20 2.37.0 From nobody Sun Apr 19 05:32:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F146C43334 for ; Tue, 5 Jul 2022 21:02:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232297AbiGEVCE (ORCPT ); Tue, 5 Jul 2022 17:02:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231196AbiGEVBy (ORCPT ); Tue, 5 Jul 2022 17:01:54 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B528C63FC for ; Tue, 5 Jul 2022 14:01:53 -0700 (PDT) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 25E4040AAA for ; Tue, 5 Jul 2022 21:01:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1657054910; bh=/+iqepEXJiQtf1kCLKBlcRYR4nyv6+zJPzgNc4qYD7Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=g4kb8ffXrChQNTrnBkWO9Mf/+fE85kbkiMknN2qIy7l95lrpHiMEyN/OWjhPtZNG7 q5aIxyMdbpfXa161CRF0NbcSUMNyEiHrMkGZI/VTmNdZcuX+LYvUHSE2eFcA7NxAF7 +Ep+EWR5jk2KZYS1a5Mml4ZIz7+d207zvz4Nn4doizvcowzLX7e0YdL8q6iT7aqGMR VTFvLnJCP5e9QiZ9tNEdW9kqOacSUdZEtZ5o8hB0jmJbFzT416BOyTvS6BVu2nfGQc e5ZWldI7/vpjEnIz2DrQ4yqIk1wj5qJzgcmJ4Zh9F23fiku9MxWCHuBkF4B8PspKo1 yMe7BiFvRzHvQ== Received: by mail-wm1-f69.google.com with SMTP id h125-20020a1c2183000000b003a0374f1eb8so9381177wmh.8 for ; Tue, 05 Jul 2022 14:01:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/+iqepEXJiQtf1kCLKBlcRYR4nyv6+zJPzgNc4qYD7Q=; b=zxirtKzcT7JjxYz3X5c+aVOaUjvAtCptzFn6Cm8V9kv1tn8dTVczJvXnuLEK5r3wY/ C6Z6TJvY0c2LvvQ0PcLV3HVuLJZ2n8f0SUskYBnjjU3ld0LAS7qjCxjeH/zHNGEeZXBx KeJqLteG9RshuytXOEAfMFtnVwaDbc83fLk8R8a2KqzhX3lUxr4t4cnkiUEgenwRDJUF vxDH39MB/pDfuCdj/A9WLx3KTKKHhWMu3swtGuiK2esJhbrGqLxHK1he7nOio/zYhiEU k+3mQQ9h3ChSV3xyswGWpYvVavgGdqvBYnVp2MZhRjD4Q3LNihNA+sQ3jKCgHj2DgpJ9 T8RA== X-Gm-Message-State: AJIora9MzKpa7OX8I+yyUFviPMS8v5LPvyVa1XrI5MW/jJU9wZ7mffTo CJlb9X39GeiXXp4uOpVXPKTWrmNTL9koRDaQjS0aykFHTgRm6pHTx3YuM7N+y1iLy6EQ7B8hS8I WWiGHlUTyV/5P+3VWffVK97WzW+LtwNvdW2ERbYBcEg== X-Received: by 2002:a5d:5f05:0:b0:21b:8ca0:6d3d with SMTP id cl5-20020a5d5f05000000b0021b8ca06d3dmr33987905wrb.382.1657054907934; Tue, 05 Jul 2022 14:01:47 -0700 (PDT) X-Google-Smtp-Source: AGRyM1voNkjmJLsItk4qX2FcCqMMV0I2vwoygxRWgEn1u2iRJAbKSZJmuQVNG8KjvMDWpNkZS4aZLA== X-Received: by 2002:a5d:5f05:0:b0:21b:8ca0:6d3d with SMTP id cl5-20020a5d5f05000000b0021b8ca06d3dmr33987869wrb.382.1657054907727; Tue, 05 Jul 2022 14:01:47 -0700 (PDT) Received: from stitch.. (80.71.140.73.ipv4.parknet.dk. [80.71.140.73]) by smtp.gmail.com with ESMTPSA id r15-20020a0560001b8f00b0021d74906683sm2517667wru.28.2022.07.05.14.01.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 14:01:47 -0700 (PDT) From: Emil Renner Berthing To: linux-kernel@vger.kernel.org Cc: Pavel Machek , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Vincent Pelletier , Bin Meng , Aurelien Jarno , Ron Economos , Qiu Wenbo , Geert Uytterhoeven , Stephen L Arnold , Jianlong Huang , Mark Kettenis , Sven Schwermer , Andy Shevchenko , David Abdurachmanov , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH v1 2/4] dt-bindings: leds: pwm-multicolor: Add active-low property Date: Tue, 5 Jul 2022 23:01:41 +0200 Message-Id: <20220705210143.315151-3-emil.renner.berthing@canonical.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220705210143.315151-1-emil.renner.berthing@canonical.com> References: <20220705210143.315151-1-emil.renner.berthing@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add the active-low property to LEDs that are part of a multicolor LED just like the regular PWM LEDs have. Signed-off-by: Emil Renner Berthing Reviewed-by: Geert Uytterhoeven Reviewed-by: Rob Herring --- .../devicetree/bindings/leds/leds-pwm-multicolor.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yam= l b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml index 6625a528f727..8d614eaf5c5e 100644 --- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml +++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml @@ -33,6 +33,10 @@ properties: =20 pwm-names: true =20 + active-low: + description: For PWMs where the LED is wired to supply rather = than ground. + type: boolean + color: true =20 required: --=20 2.37.0 From nobody Sun Apr 19 05:32:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53DE1CCA47B for ; Tue, 5 Jul 2022 21:02:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231196AbiGEVCJ (ORCPT ); Tue, 5 Jul 2022 17:02:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232307AbiGEVCA (ORCPT ); Tue, 5 Jul 2022 17:02:00 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1437BA180 for ; Tue, 5 Jul 2022 14:01:55 -0700 (PDT) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 42B4040AA0 for ; Tue, 5 Jul 2022 21:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1657054913; bh=EI3mxEAHkgT2vU1OOl7PeFFTw9+zwdjdFkAEZQkp71M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LaSU8BF0aYfbkMCz++6iGei0YEOwNfhMl3BGSA7twFo6c+avOkeBdCsf2a7KUAMhj Yt53V4c8kYpRlhRtx3V40tFrvpNQNJdlsRrZM+W2hcwtHQb3WHEp1nersbr1pwmHT8 6BKeRSKskxgxnYlJnLz66eNc2WwLd/qzsxd07Mjbm7+jlLf2pH/nSZIXZC7zG09tE2 TJGx823quiVK2bvfNqtGDXA6yoaNe1IjQDOjIfOm78JVYlQXQEK6zUgIm6bJvY5tAY xeWSj6ekFbMJjKALeISBbX1zAdWX4ZrfL51ZzZAO/bBpkFuY6y0RIklc8PMUUEibgC nYVBrxrH8ZJYA== Received: by mail-wm1-f70.google.com with SMTP id m17-20020a05600c3b1100b003a04a2f4936so7285949wms.6 for ; Tue, 05 Jul 2022 14:01:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EI3mxEAHkgT2vU1OOl7PeFFTw9+zwdjdFkAEZQkp71M=; b=71Lbp7osnMIlz35tLJwTcyeorjPmGqboJAf6AODDRh4SitnK0iqAqHbD+Kj1kXYiPb xB1qqeAAMBAY4zUJS7VadUMiXqsbJeRgHXnGTPr7BB9qQ0GnkuPuZTQ2zKj9oFLpKuXD 2G4WYRqHdUfWylxRnsM1oK5EugoLt2uCi+PZlCP1SYLG7fJ0ylhDclkl1jZAnf2BMLad Vrf2n0AP6NxjQdk8UJylmCuwOWJZVV9SI53ZaN0RLP2qKL+oLJAIaxiMwGLiQgWVlWGN T0C4kRPqez5qsfh6WHuDjl3G/Fnu2od+QdUV03XshPRF/cm5Uog+jJYhkZgvVBnRbQ82 NX4g== X-Gm-Message-State: AJIora+1wG43ZKnr74r/nOpvNUnznWEO+LYUyeqtJvCsSg/AXBPENPl5 ftKaMi8o+3cJnMH+sy/DeXsEAq8E8Q6Ybm4tDZXepwPiBu+gwtD01uDQQViPPXXBAn20qsbqWS+ UgnIECByckAwmp83bMA9L5/Bh7OTYSljLTWGTISgL/w== X-Received: by 2002:a05:6000:1445:b0:21b:a919:7d3 with SMTP id v5-20020a056000144500b0021ba91907d3mr33143895wrx.545.1657054909214; Tue, 05 Jul 2022 14:01:49 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tpGtr585A4zBiBrqeprE38gSsAvDrw/l/xt/heeVYnerThl9ghX7+cZz4Gy93kTP7evrM9SQ== X-Received: by 2002:a05:6000:1445:b0:21b:a919:7d3 with SMTP id v5-20020a056000144500b0021ba91907d3mr33143858wrx.545.1657054908987; Tue, 05 Jul 2022 14:01:48 -0700 (PDT) Received: from stitch.. (80.71.140.73.ipv4.parknet.dk. [80.71.140.73]) by smtp.gmail.com with ESMTPSA id r15-20020a0560001b8f00b0021d74906683sm2517667wru.28.2022.07.05.14.01.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 14:01:48 -0700 (PDT) From: Emil Renner Berthing To: linux-kernel@vger.kernel.org Cc: Pavel Machek , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Vincent Pelletier , Bin Meng , Aurelien Jarno , Ron Economos , Qiu Wenbo , Geert Uytterhoeven , Stephen L Arnold , Jianlong Huang , Mark Kettenis , Sven Schwermer , Andy Shevchenko , David Abdurachmanov , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH v1 3/4] leds: pwm-multicolor: Support active-low LEDs Date: Tue, 5 Jul 2022 23:01:42 +0200 Message-Id: <20220705210143.315151-4-emil.renner.berthing@canonical.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220705210143.315151-1-emil.renner.berthing@canonical.com> References: <20220705210143.315151-1-emil.renner.berthing@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add support for LEDs wired up to light when the PWM output is low, just like the regular PWM LEDs. Signed-off-by: Emil Renner Berthing Reviewed-by: Geert Uytterhoeven --- drivers/leds/rgb/leds-pwm-multicolor.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/leds/rgb/leds-pwm-multicolor.c b/drivers/leds/rgb/leds= -pwm-multicolor.c index eb67b89d28e9..da9d2218ae18 100644 --- a/drivers/leds/rgb/leds-pwm-multicolor.c +++ b/drivers/leds/rgb/leds-pwm-multicolor.c @@ -19,6 +19,7 @@ struct pwm_led { struct pwm_device *pwm; struct pwm_state state; + bool active_low; }; =20 struct pwm_mc_led { @@ -45,6 +46,9 @@ static int led_pwm_mc_set(struct led_classdev *cdev, duty *=3D mc_cdev->subled_info[i].brightness; do_div(duty, cdev->max_brightness); =20 + if (priv->leds[i].active_low) + duty =3D priv->leds[i].state.period - duty; + priv->leds[i].state.duty_cycle =3D duty; priv->leds[i].state.enabled =3D duty > 0; ret =3D pwm_apply_state(priv->leds[i].pwm, @@ -76,6 +80,7 @@ static int iterate_subleds(struct device *dev, struct pwm= _mc_led *priv, goto release_fwnode; } pwm_init_state(pwmled->pwm, &pwmled->state); + pwmled->active_low =3D fwnode_property_read_bool(fwnode, "active-low"); =20 ret =3D fwnode_property_read_u32(fwnode, "color", &color); if (ret) { --=20 2.37.0 From nobody Sun Apr 19 05:32:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18BB3C433EF for ; Tue, 5 Jul 2022 21:02:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232456AbiGEVCM (ORCPT ); Tue, 5 Jul 2022 17:02:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232366AbiGEVCB (ORCPT ); Tue, 5 Jul 2022 17:02:01 -0400 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DBF017A98 for ; Tue, 5 Jul 2022 14:01:58 -0700 (PDT) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 05A8D42448 for ; Tue, 5 Jul 2022 21:01:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1657054912; bh=AoMSkRbSsal7DXav6tHJCoGyFX+s+KqI3+R+nsluk4Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=r4ipIkMB/SfIsygquOfPs3RGoXlFuxrUuoUT/xoY4wzHC0oP0psVEqcic+0sQy63n 7VFmKBOcU5gaDAyLdKAy20qo9yCy/o9Y/oy5VXJtnp5FD+NYNFhcRZjGDcUYeBQ8YF YNudFpllua1i7eOgz0HOVyavp6CNEjWR3zEqrPt5zxgweZ4km+MXZd3wx33LkRim0i 2AQV3D1n1Q+Jr+3CIWjq6Gsdx6iKnPV8hKmI3oLZZDefihxfmB8PgR7ow7+nDHJJWl BbuAoz+etMxtQRdeJvcjIBnsokXzJ5q6eElOeqHIImfjN4eSGYP9EUwI3NmWWJvmjP oJVrzCm/bFY2w== Received: by mail-wm1-f71.google.com with SMTP id j19-20020a05600c191300b003a048196712so7293948wmq.4 for ; Tue, 05 Jul 2022 14:01:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AoMSkRbSsal7DXav6tHJCoGyFX+s+KqI3+R+nsluk4Y=; b=PU9ptF7Vz5SnMSL0T89DyDd6l4chYCslLzYszc4VDPxtGXIHWhUXHx8fy4vnxl2tR3 s6wg8m28igtm6iF3yotEr7+Hk68G/A6jTmCkY3hm7UWJmyJXU0SOS16bq+sG2nqAoRqk GE09ofZQy6aDVMKOB6jwH9+f4ozoq48uThkvbdePlujqDUx9mPzAvw18sAQp7eNb5jTG 9hXDIiBkWy1p9i6yoUeEIs2Q/TitDfCjdde/PgL4e+wCLEEXkvYiFlsLVZicCTGe8Nvq quiInUThZ/LtVmgZvU9WHG0kYjP9f9fOWxivegwBhlbgWG7XXOFxywtRQ+qWRIIYzISJ xjyw== X-Gm-Message-State: AJIora+FULv4a4eWCejiyJl2bpESKjR0PSx2VKFTd+uL5iFJVoBVDnxN aPi21dZej1Rc4uDfr2tG4hRgSzQvFgHuYnlGQQFgQm8eDXP8wb9Uk/KfOgt07EsAK8D3aQZ39Tj i8EEZdbZKzDz9kVBH0UwvNzBZj9sgt2QeK0Ml/jgAWA== X-Received: by 2002:a5d:64ad:0:b0:21b:b412:a34b with SMTP id m13-20020a5d64ad000000b0021bb412a34bmr34737448wrp.161.1657054910461; Tue, 05 Jul 2022 14:01:50 -0700 (PDT) X-Google-Smtp-Source: AGRyM1utl+vdlW/hT+y0u8P/5xgHHhGX/aEi5Iu3pv5PVf+eB3fFB+ZuQGqJZ0/RfxSFhjz/+hEgCA== X-Received: by 2002:a5d:64ad:0:b0:21b:b412:a34b with SMTP id m13-20020a5d64ad000000b0021bb412a34bmr34737424wrp.161.1657054910311; Tue, 05 Jul 2022 14:01:50 -0700 (PDT) Received: from stitch.. (80.71.140.73.ipv4.parknet.dk. [80.71.140.73]) by smtp.gmail.com with ESMTPSA id r15-20020a0560001b8f00b0021d74906683sm2517667wru.28.2022.07.05.14.01.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 14:01:50 -0700 (PDT) From: Emil Renner Berthing To: linux-kernel@vger.kernel.org Cc: Pavel Machek , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Vincent Pelletier , Bin Meng , Aurelien Jarno , Ron Economos , Qiu Wenbo , Geert Uytterhoeven , Stephen L Arnold , Jianlong Huang , Mark Kettenis , Sven Schwermer , Andy Shevchenko , David Abdurachmanov , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH v1 4/4] riscv: dts: sifive unmatched: Add PWM controlled LEDs Date: Tue, 5 Jul 2022 23:01:43 +0200 Message-Id: <20220705210143.315151-5-emil.renner.berthing@canonical.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220705210143.315151-1-emil.renner.berthing@canonical.com> References: <20220705210143.315151-1-emil.renner.berthing@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This adds the two PWM controlled LEDs to the HiFive Unmatched device tree. D12 is just a regular green diode, but D2 is an RGB diode with 3 PWM inputs controlling the three different colours. Signed-off-by: Emil Renner Berthing Acked-by: Pavel Machek Reviewed-by: Geert Uytterhoeven Tested-by: Ron Economos --- .../boot/dts/sifive/hifive-unmatched-a00.dts | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/ris= cv/boot/dts/sifive/hifive-unmatched-a00.dts index c4ed9efdff03..beaefe74755a 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts @@ -4,6 +4,8 @@ #include "fu740-c000.dtsi" #include #include +#include +#include =20 /* Clock frequency (in Hz) of the PCB crystal for rtcclk */ #define RTCCLK_FREQ 1000000 @@ -44,6 +46,46 @@ gpio-poweroff { compatible =3D "gpio-poweroff"; gpios =3D <&gpio 2 GPIO_ACTIVE_LOW>; }; + + led-controller-1 { + compatible =3D "pwm-leds"; + + led-d12 { + pwms =3D <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; + active-low; + color =3D ; + max-brightness =3D <255>; + label =3D "d12"; + }; + }; + + led-controller-2 { + compatible =3D "pwm-leds-multicolor"; + + multi-led { + color =3D ; + max-brightness =3D <255>; + label =3D "d2"; + + led-red { + pwms =3D <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; + active-low; + color =3D ; + }; + + led-green { + pwms =3D <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; + active-low; + color =3D ; + }; + + led-blue { + pwms =3D <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; + active-low; + color =3D ; + }; + }; + }; }; =20 &uart0 { --=20 2.37.0