From nobody Sun Apr 19 07:17:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A28E5C43334 for ; Tue, 5 Jul 2022 09:52:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232626AbiGEJwH (ORCPT ); Tue, 5 Jul 2022 05:52:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232372AbiGEJvQ (ORCPT ); Tue, 5 Jul 2022 05:51:16 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC51113F82 for ; Tue, 5 Jul 2022 02:49:59 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id d5so10517121plo.12 for ; Tue, 05 Jul 2022 02:49:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dNuDujWN9W1g88kKFQJS4fnKwCoQVZmV8mz8Iq8FU/s=; b=BhBQ9g2q9M0kZORA2LG2XIzUp7lCMhxIe5kQhvGIfqCVFNtnBWDtCYi/aSXCzPCe+u h7jocr2l1u+4Q9JnBf5J1ZCcBrmAQLy5ZgF4zxXobx7Ao8I6L3VqPN06HBr5kSTu020e Z0j+PaSP/GSURTlhhrzZfoMoYnUuzneOYqxu0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dNuDujWN9W1g88kKFQJS4fnKwCoQVZmV8mz8Iq8FU/s=; b=2V91ym7gncnBDF+c9ORN0oSKMn2V3n/X/nZb4kAm1tVO49M2zTZ0WaOBoHK3xxjhNs QoT1eyC88W4Wu/zjXoTtk8aY6RaRue/325oNrqQwHkZCGF3ESE93uW0C0jXLMzG1lx04 rGvm3LTP032ynNA0zxHZAqQbigN1QvVypCfOzZpw4uk2bzItC99T/vE3RZApObNjMhoJ VTrSoLHRCFLpjS/GhSDFoloEf0Zy4SxD1rHYbgMWftRd1F9WDeygvOwEll8uvA/ZA74K iqTaBcAvWhMJlsx9y0rm3nn9dLU4/AojENk0FlGaJzqOFzarBKJrXpqRIdyOxqLBpVEb Uw+g== X-Gm-Message-State: AJIora8gNOm9o2lJ+F7+XUwXCcg3BFinbaLJGSmJ7CrOkYJPy6EuTkja k8r/8OSwP/4rz5wJupgpdw/I7w== X-Google-Smtp-Source: AGRyM1srUa7NyStt9XxdcLUu8TEjpzpM9KcuxS4p7FiTh2jnPnLRDGAc5YssLWz/O7Tg/YLTswEFOA== X-Received: by 2002:a17:903:41c4:b0:16a:1fda:579f with SMTP id u4-20020a17090341c400b0016a1fda579fmr40995717ple.169.1657014599029; Tue, 05 Jul 2022 02:49:59 -0700 (PDT) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:c921:5fa9:6620:638]) by smtp.gmail.com with ESMTPSA id j8-20020a17090a060800b001ed1444df67sm12002232pjj.6.2022.07.05.02.49.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 02:49:58 -0700 (PDT) From: Hsin-Yi Wang To: "Rafael J . Wysocki" Cc: Kevin Hilman , Ulf Hansson , Len Brown , Pavel Machek , Greg Kroah-Hartman , Thierry Strudel , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , Pin-yen Lin Subject: [PATCH] PM: domains: Ensure genpd_debugfs_dir exists before remove Date: Tue, 5 Jul 2022 17:49:47 +0800 Message-Id: <20220705094946.827697-1-hsinyi@chromium.org> X-Mailer: git-send-email 2.37.0.rc0.161.g10f37bed90-goog MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" genpd_debug_remove() may be indirectly called from others while genpd_debugfs_dir is not yet set. Make sure genpd_debugfs_dir exists before remove the sub components, otherwise components under /sys/kernel/debug may be accidentally removed. Fixes: 718072ceb211 ("PM: domains: create debugfs nodes when adding power d= omains") Signed-off-by: Hsin-Yi Wang --- An example: scpsys_probe() in drivers/soc/mediatek/mtk-pm-domains.c indirectly calls genpd_debug_remove() on probe fail, causing /sys/kernel/debug/usb to be removed. --- drivers/base/power/domain.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 3e86772d5fac5..5a2e0232862e0 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -222,6 +222,9 @@ static void genpd_debug_remove(struct generic_pm_domain= *genpd) { struct dentry *d; =20 + if (!genpd_debugfs_dir) + return; + d =3D debugfs_lookup(genpd->name, genpd_debugfs_dir); debugfs_remove(d); } --=20 2.37.0.rc0.161.g10f37bed90-goog