From nobody Sat Sep 21 21:26:56 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE964C433EF for ; Mon, 4 Jul 2022 02:58:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230219AbiGDC64 (ORCPT ); Sun, 3 Jul 2022 22:58:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbiGDC6y (ORCPT ); Sun, 3 Jul 2022 22:58:54 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AE752AE0; Sun, 3 Jul 2022 19:58:53 -0700 (PDT) Received: from dggpeml500022.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Lbr790KjpzkWlS; Mon, 4 Jul 2022 10:56:53 +0800 (CST) Received: from dggpeml500008.china.huawei.com (7.185.36.147) by dggpeml500022.china.huawei.com (7.185.36.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 4 Jul 2022 10:58:23 +0800 Received: from huawei.com (10.67.175.34) by dggpeml500008.china.huawei.com (7.185.36.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 4 Jul 2022 10:58:23 +0800 From: Ren Zhijie To: , , , , CC: , , , , "Ren Zhijie" Subject: [PATCH -next] scsi: ufs: ufs-mediatek: Fix build error Date: Mon, 4 Jul 2022 10:56:32 +0800 Message-ID: <20220704025632.235968-1-renzhijie2@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.175.34] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500008.china.huawei.com (7.185.36.147) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If CONFIG_PM is not set, make ARCH=3Darm64 CROSS_COMPILE=3Daarch64-linux-gnu-, will be failed, like = this: drivers/ufs/host/ufs-mediatek.c: In function =E2=80=98ufs_mtk_runtime_suspe= nd=E2=80=99: drivers/ufs/host/ufs-mediatek.c:1435:8: error: implicit declaration of func= tion =E2=80=98ufshcd_runtime_suspend=E2=80=99; did you mean =E2=80=98ufs_mt= k_runtime_suspend=E2=80=99? [-Werror=3Dimplicit-function-declaration] ret =3D ufshcd_runtime_suspend(dev); ^~~~~~~~~~~~~~~~~~~~~~ ufs_mtk_runtime_suspend drivers/ufs/host/ufs-mediatek.c: In function =E2=80=98ufs_mtk_runtime_resum= e=E2=80=99: drivers/ufs/host/ufs-mediatek.c:1450:9: error: implicit declaration of func= tion =E2=80=98ufshcd_runtime_resume=E2=80=99; did you mean =E2=80=98ufs_mtk= _runtime_resume=E2=80=99? [-Werror=3Dimplicit-function-declaration] return ufshcd_runtime_resume(dev); ^~~~~~~~~~~~~~~~~~~~~ ufs_mtk_runtime_resume At top level: drivers/ufs/host/ufs-mediatek.c:1444:12: error: =E2=80=98ufs_mtk_runtime_re= sume=E2=80=99 defined but not used [-Werror=3Dunused-function] static int ufs_mtk_runtime_resume(struct device *dev) ^~~~~~~~~~~~~~~~~~~~~~ drivers/ufs/host/ufs-mediatek.c:1430:12: error: =E2=80=98ufs_mtk_runtime_su= spend=E2=80=99 defined but not used [-Werror=3Dunused-function] static int ufs_mtk_runtime_suspend(struct device *dev) ^~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors The declarations of func "ufshcd_runtime_suspend()" and "ufshcd_runtime_res= ume()" depended on CONFIG_PM, so the function wrappers "ufs_mtk_runtime_sus= pend()" and "ufs_mtk_runtime_resume()" both should warpped by CONFIG_PM to= o. Reported-by: Hulk Robot Fixes: e7bf1d50063c ("scsi: ufs: ufs-mediatek: Fix build warnings") Signed-off-by: Ren Zhijie Reviewed-by: Bart Van Assche Reviewed-by: Stanley Chu Suggested-by: Arnd Bergmann --- drivers/ufs/host/ufs-mediatek.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediate= k.c index c958279bdd8f..e006c2528a3a 100644 --- a/drivers/ufs/host/ufs-mediatek.c +++ b/drivers/ufs/host/ufs-mediatek.c @@ -1427,6 +1427,7 @@ static int ufs_mtk_system_resume(struct device *dev) } #endif =20 +#ifdef CONFIG_PM static int ufs_mtk_runtime_suspend(struct device *dev) { struct ufs_hba *hba =3D dev_get_drvdata(dev); @@ -1449,6 +1450,7 @@ static int ufs_mtk_runtime_resume(struct device *dev) =20 return ufshcd_runtime_resume(dev); } +#endif =20 static const struct dev_pm_ops ufs_mtk_pm_ops =3D { SET_SYSTEM_SLEEP_PM_OPS(ufs_mtk_system_suspend, --=20 2.17.1