From nobody Sat Sep 21 23:07:53 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B69CC43334 for ; Fri, 1 Jul 2022 12:12:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237124AbiGAMMp (ORCPT ); Fri, 1 Jul 2022 08:12:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234932AbiGAMMm (ORCPT ); Fri, 1 Jul 2022 08:12:42 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D5D084EC4; Fri, 1 Jul 2022 05:12:37 -0700 (PDT) X-UUID: e3fc1f7e0f894af28296fd1ab2201014-20220701 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.7,REQID:e8e2cf25-5683-42ab-9e21-cca7f5e36829,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:87442a2,CLOUDID:36872c63-0b3f-4b2c-b3a6-ed5c044366a0,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: e3fc1f7e0f894af28296fd1ab2201014-20220701 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1364862465; Fri, 01 Jul 2022 20:12:33 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.186) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Fri, 1 Jul 2022 20:12:31 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Fri, 1 Jul 2022 20:12:31 +0800 From: Allen-KH Cheng To: Bjorn Andersson , Mathieu Poirier , Rob Herring , "Matthias Brugger" CC: , , , , , , Hsin-Yi Wang , Allen-KH Cheng Subject: [PATCH v2 1/1] remoteproc: mediatek: enable cache for mt8186 SCP Date: Fri, 1 Jul 2022 20:12:29 +0800 Message-ID: <20220701121229.22756-2-allen-kh.cheng@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20220701121229.22756-1-allen-kh.cheng@mediatek.com> References: <20220701121229.22756-1-allen-kh.cheng@mediatek.com> MIME-Version: 1.0 X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch is for enableing cache in SCP. There is not enough space on the SRAM of SCP. We need to run programs in DRAM. The DRAM power and latency is much larger than SRAM, so cache is used to mitigate the negative effects for performance. we set SCP registers for cache size before loading SCP FW. (8KB+8KB) and also adjust ipi_buf_offset in SRAM from 0x7bdb0 to 0x3BDB0 for enableing cache. This patch was tested on MediaTek mt8186. Signed-off-by: Allen-KH Cheng Reviewed-by: AngeloGioacchino Del Regno Tested-by: TingHan Shen --- drivers/remoteproc/mtk_scp.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c index 47b2a40e1b4a..5b2ad789e720 100644 --- a/drivers/remoteproc/mtk_scp.c +++ b/drivers/remoteproc/mtk_scp.c @@ -401,6 +401,14 @@ static int mt8186_scp_before_load(struct mtk_scp *scp) writel(0x0, scp->reg_base + MT8186_SCP_L1_SRAM_PD_P1); writel(0x0, scp->reg_base + MT8186_SCP_L1_SRAM_PD_p2); =20 + /* + * Set I-cache and D-cache size before loading SCP FW. + * SCP SRAM logical address may change when cache size setting differs. + */ + writel(MT8183_SCP_CACHE_CON_WAYEN | MT8183_SCP_CACHESIZE_8KB, + scp->reg_base + MT8183_SCP_CACHE_CON); + writel(MT8183_SCP_CACHESIZE_8KB, scp->reg_base + MT8183_SCP_DCACHE_CON); + return 0; } =20 @@ -943,7 +951,7 @@ static const struct mtk_scp_of_data mt8186_of_data =3D { .scp_da_to_va =3D mt8183_scp_da_to_va, .host_to_scp_reg =3D MT8183_HOST_TO_SCP, .host_to_scp_int_bit =3D MT8183_HOST_IPC_INT_BIT, - .ipi_buf_offset =3D 0x7bdb0, + .ipi_buf_offset =3D 0x3bdb0, }; =20 static const struct mtk_scp_of_data mt8192_of_data =3D { --=20 2.18.0