From nobody Thu Apr 30 09:51:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16CFCC43334 for ; Fri, 1 Jul 2022 06:55:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234956AbiGAGzD (ORCPT ); Fri, 1 Jul 2022 02:55:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234874AbiGAGzA (ORCPT ); Fri, 1 Jul 2022 02:55:00 -0400 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70088.outbound.protection.outlook.com [40.107.7.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E54661D7C for ; Thu, 30 Jun 2022 23:54:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RSdRJO+f2p24Qnp/k4sQLvuq8ifxFO3/4PKSh7+scwCxuhjoC9oqwc1CQJ/qCmX45WPdZF9dKlbDqSoW+qP4f2JgvchfudteJr+gtRIoBqac+Pfghj3dFVX5BkD6UPgavldWxpXpYPk3Wpgf+8KLiNUFlKiCd40Tc7wF2IqkKlYyQP/8+4mzKv+iIamlvOhPvHFt+rtKtisYyr7GhCWtVDSzsWH4PMDPGhFzoB+BiDVZ2pFJWZUuCfn5F8QjJDgVRcceaOdvTWdtOnA7GyicsdVZnYZmS+5U+K8Dk1+Lp5Pd7jUEY9tz5TM3EEqof4S87bkxRayw0es6kg4d8iSDVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zRngNZAyYtWkCyIueLTFLwL0rE2iVA2RVGcS5JmbGRQ=; b=Zq0VosqIIOMttRo8EOWGxocHXXIx93QGehMQiJpF+rnwaHutDt5zBOSuuwuNvGc1Use/9pOHN6qNP8aisfJoRpYtWmgeRRqSO1yo77T9ZQjXDWL+7cRD1K9tyG/oagtviz8cpaycojk9FFMY+Lej8wS3S37G/cu2mgczVhEWKBjXQffEq47M8b+yho37mdDQajY+aLpoiEr8T+/Kki4FyMB2jaXieW+V6GX0DVTiXHvd1eGvdhgZBioKT8mI4FhkueEARpBQNSmQseP5xITRYTst6yGnf5iXE6NJA5syvkvC7MC6/rWXI9ZQf9EiOaW3Hb8NIYP36hHPR5d+c7Q+7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zRngNZAyYtWkCyIueLTFLwL0rE2iVA2RVGcS5JmbGRQ=; b=eWszoxanQmv1XmPHNdrcF4GFExMU2r9c0ciQmolR13fYwnZ0Ws2YTkrRxph6XObvLFODOUF8tczuPXjHh4Apgx8Doc29MyYPrMm3aWi6/7fvDoYXaiYJlwW1Vk1SpIcCDhr9vHQ/3pT6GqDlmJnnvvcWG9OzWTSfV14tTJyjK9M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by AM0PR04MB5762.eurprd04.prod.outlook.com (2603:10a6:208:123::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Fri, 1 Jul 2022 06:54:57 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::416e:6e99:bac6:d3a9]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::416e:6e99:bac6:d3a9%6]) with mapi id 15.20.5395.015; Fri, 1 Jul 2022 06:54:57 +0000 From: Liu Ying To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: andrzej.hajda@intel.com, narmstrong@baylibre.com, robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch, sam@ravnborg.org, marex@denx.de, linux-imx@nxp.com Subject: [PATCH 1/3] drm/bridge: fsl-ldb: Fix mode clock rate validation Date: Fri, 1 Jul 2022 14:56:32 +0800 Message-Id: <20220701065634.4027537-2-victor.liu@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220701065634.4027537-1-victor.liu@nxp.com> References: <20220701065634.4027537-1-victor.liu@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR04CA0013.apcprd04.prod.outlook.com (2603:1096:4:197::6) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a2001636-0320-4bfd-9143-08da5b2e9c06 X-MS-TrafficTypeDiagnostic: AM0PR04MB5762:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vS1JyCRMQQqary72NfeZ9gq0iaU92LT0kl+TihAq51ULEumG+73NK3kxGD9oL6d6ie3d6tg7EKf2K0rURWgbsPhsbYHEi6lnGza0jUSedKc78KkpnbdBpQ+xURzqPStDcYBGA8FJDMnSMEkBvx0VIRvESeyhxPj8+Krye3Ez1v16rhaSJPjxctxWpFpFDT9gYOK7oNIGVscNol1O2t+hlA8Q6/YLPlOMOuAY7W/ejjo3gltCvRh/JUZKjwPsOnkGUCwrUUTd1jR/rYLUJAId5aWM9yJJ/ljAo8QqLsbe9RuPI0InG2MGk6mL093tr8TrCx7R6QfHozAqJbjeZ9F8OQnEQovk4HTC4SFkBUZSgQq6Rxmqsw8PDL2x06li8bdnhZKy26pInvxHZyMWB7GkeD7fky6ckBRoABF9/x8s7qPS5lUBEK0YujDVJKyqgPCkIEZLF5It4M9ZvowOcsNkpJCyXAwoL5tjczNyMlvrkd/wj6XpzAQuC4WZSunBo6aEn1r1G4Jnr6VbPjFZy1aFgkya9Kzh/hUJOgPDu08Qtil3xODEDfn2s7MGd627770+gFKAn3fTsqYVHwSN6h+L9erYb/djOCh3XCB20Z6YVXMBBByOAlDQHVnpfFZujwxoRTYihf3C2sAwn1cNLZd6nuXcbEP0/fR6BotyH96r/we5916n6YxbU+DCfyD7x+ZRfDCI9U11uQ89Kn9OexPqBtMuElJcw57vSitUygU+WLzd7E208+8srBb9bawjOZvkOoTi9NLgKlhw2JCYfNg1uE4BInpUp48rdfkrrkBPkQ8FdFg9dwQMKGFieBzPDhWD X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(376002)(396003)(39860400002)(346002)(8676002)(38350700002)(66476007)(316002)(4326008)(66946007)(2906002)(6512007)(38100700002)(7416002)(6666004)(66556008)(8936002)(5660300002)(86362001)(83380400001)(41300700001)(6506007)(26005)(52116002)(1076003)(186003)(6486002)(478600001)(2616005)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yyssFHdRQCQZXUkYG27Nfc8fVqCgG1msysXl5SmwfcP2yFhnLA7vc/aBhuSi?= =?us-ascii?Q?8BIComhEmdvxBcwTWw0upMctesJSnQ/wKkvC/WWPWNzFhAhaILWKVfhQQxD2?= =?us-ascii?Q?xnMtbieC9IJpNCcQnhd/pq/vlyV0/Y9apXkO2SSIsvETU99hbDg4LYHcWx0H?= =?us-ascii?Q?UaddWzKgWtOqVWMy7iFD8phMcQ5/tVG9KdXqOeoSywJCNtQDVX3ch+woKFDm?= =?us-ascii?Q?lfkGZHhVMKcPrK9dzxKCXhOPgVBn1v2y5oJzyJAlqPXXXkhXSP3W7NrEpIcA?= =?us-ascii?Q?vJlyks+/YisQ0S0qD44OcpdydIsovqWhiFHcb1AahkIDW2YZUBmhpTpnTDlo?= =?us-ascii?Q?SOia64KiPRqk3sQRrXAHzOOw2ug4ldKn5mjF1mxLb4CegkYLcw7U6S508ZXC?= =?us-ascii?Q?wwQ1czfd7DG4bpwjULxoJazPskpYuEQQ51U8jF/1NAtw3hNNLxPnuphhgAK2?= =?us-ascii?Q?Yn05fX6r4tXNM3zRxQOtwOCwX6FdZOvRI4s3qold3+ciUeNGsE0lziYCFJj6?= =?us-ascii?Q?0mxFjvNrAhPEd70nFhKGPKjBRxrnrAFOkjwIAoqjAh3SA9w3NhgKMZycfIt6?= =?us-ascii?Q?CboGPJuEyxI3ICmSHZK08xlOoVJpOgbfKgxaMM2gSa3UwCxYWxe1cAuCnltK?= =?us-ascii?Q?oMe1btU+Pxx5PCnmIeIVeIMoYjhYv6ZnMO1ZBk9sdqBxQWhssdckzUcNXFqW?= =?us-ascii?Q?3okTSMFLuuAWSMIM6EiKGDqxd2eeF3H5+khHkGCPvHECgAo5EpaT2tY475/G?= =?us-ascii?Q?BA7l46iYHz6UY38qZuFsPYSQayx4pY80QMO/peLO/CJIpXHHfGDhcdUZxlIG?= =?us-ascii?Q?/Vv1ciYoibOJiaTVn/6+iJA8XBye2Rl/f4OhaMku7XeyBxThT9M3E0zKBn0B?= =?us-ascii?Q?oqkDEeHcvfUk4o+MGaqYtQPjjAzLOmYKHy0K9ZBNeU3NdrVVsG2T/xwkKVPt?= =?us-ascii?Q?I8g9xBRC6TIwpWOpGUXBQIfEamS9UxtiM4b9mK84ohcgoMdwtgTN9MSAuXIV?= =?us-ascii?Q?7FWI5u/SQi8p1zM39aroJ2TsYlkf0O6kt7d3fxFrrLq/+tiYmkpc7Qib8KS2?= =?us-ascii?Q?vwS56ogOdoSKMMTM3uHdIdJLBHOIECSy5Jsl3yJ5kVeGgQcC1irl3grdQvBv?= =?us-ascii?Q?Za2arhUPfKKdZR/Jc23XbC2cZkx6veJXw/bIv2yqYANrSJkU8O4pr3yiB2s9?= =?us-ascii?Q?xb6WhwTlr8KRNrgmKG/I3BceZTFVD+KUijZsZ2FBSvG6fdUxjtsGIxGlzerT?= =?us-ascii?Q?P9osLTN2YafRPuu9qXbiMbsjqzbCJdnCXoC82kGkMoksWaJkr9/xZBGjP4tt?= =?us-ascii?Q?9MToKGU7/+XaZQDyGl0Z6roaInJb0ZanyuDbyOQ2G1zjrQs3wBDzR/bpzq9L?= =?us-ascii?Q?m5xv7FII991m7mcQJ8XhBOfeUDQsbGzhjklukauMXLgV2McVO3WJyaAxGIFs?= =?us-ascii?Q?gyCe4Na9nzE43OGNZAZk5hKr46cz11fGojTXpL+7XmyDT9lXq0sJ+Q4qiWug?= =?us-ascii?Q?F/PmmQuTh2BNbwBD2cp8ejXa4/cmR7q4L/LwzFIs0EJ9/TEumJ1xTJEggjQJ?= =?us-ascii?Q?Jyo/SL2oMEv+fEE2QmQDh7VypaZNBgm8I7o7QJPV?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2001636-0320-4bfd-9143-08da5b2e9c06 X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 06:54:57.2364 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yU5CXkLL10NnPkdNNbq27X7i8bXiF8F0HaQDA2/kjPe/PN98DgzU7b8YFkNkNpIPohgkRlc4fkR7P5D5mO9YVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5762 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" With LVDS dual link, up to 160MHz mode clock rate is supported. With LVDS single link, up to 80MHz mode clock rate is supported. Fix mode clock rate validation by swapping the maximum mode clock rates of the two link modes. Fixes: 463db5c2ed4a ("drm: bridge: ldb: Implement simple Freescale i.MX8MP = LDB bridge") Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: Sam Ravnborg Cc: Marek Vasut Cc: NXP Linux Team Signed-off-by: Liu Ying Reviewed-by: Marek Vasut --- drivers/gpu/drm/bridge/fsl-ldb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-= ldb.c index b2675c769a55..3cb3b310e283 100644 --- a/drivers/gpu/drm/bridge/fsl-ldb.c +++ b/drivers/gpu/drm/bridge/fsl-ldb.c @@ -233,7 +233,7 @@ fsl_ldb_mode_valid(struct drm_bridge *bridge, { struct fsl_ldb *fsl_ldb =3D to_fsl_ldb(bridge); =20 - if (mode->clock > (fsl_ldb->lvds_dual_link ? 80000 : 160000)) + if (mode->clock > (fsl_ldb->lvds_dual_link ? 160000 : 80000)) return MODE_CLOCK_HIGH; =20 return MODE_OK; --=20 2.25.1 From nobody Thu Apr 30 09:51:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23006C433EF for ; Fri, 1 Jul 2022 06:55:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234793AbiGAGzO (ORCPT ); Fri, 1 Jul 2022 02:55:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234854AbiGAGzF (ORCPT ); Fri, 1 Jul 2022 02:55:05 -0400 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60088.outbound.protection.outlook.com [40.107.6.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0B7F6050D for ; Thu, 30 Jun 2022 23:55:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gzw/ZN4PBCaJhsBml+iD1fulq+XxkoFV1o59hkfEEYhZgotu9YZbbv4ccB63490Wo+U+3Tye/dY/g7Qt9vlojKxBRP1uaeJ6Ugl6kMbWLG2qS4vlpWutc4qDxmryEEVP4Ra2LonjXNXE94jyjI5kr7yEm6vXuudLlYi8T7ic4ge1Uc/i8zDgEwpmJqKrV1pCIBG07tpkOuiBVr1wa1D238vrYBJgH68qKQ/Rn3shD/oUPDpi3vdtLaOLK5mF/LfKDRsW4kd3eVmyJL57PAjlh0OKoRZ0muy1l5eRrZd5QPfkFJufwyNZJSiyAro3UIdLPsb7/aNNs4WnY0+wvlnu4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jDgraNn+FmLRQ89Ejl4lOjbe2AAp07kxL9TYXedwk6o=; b=Kq1A9Q8ku4WoyGW0kvYCLUDXJ5KoopiE0uLkps82TpfyzFnCxdYycqp3SBTq/LuYqnHgRB+BES+iJsVOpwkqbOjzcanHmUGsc/TW+HxUbjTR++5Cwg1ky0SjIAnskQn4Kty6aWwEg6JCfnQ1miOvCnoBEwAUFQ6jGFCggK17SXWmtG1ldpzDxqDMGAKvD1uncfvfPU2uaelH+uZGtV3oUVZBqOiu/3RTPeEW/y/92SLFTyootvwHSg6MCgsctddUlqbP1q8q26SwB8dDnpkOIxUjsuZy9TzWsdFv6uiUX8ethIaLvhOwU9xPnKibEq75xj7jgiuC2uZKD5UWtypMwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jDgraNn+FmLRQ89Ejl4lOjbe2AAp07kxL9TYXedwk6o=; b=bIP3rIyC+0lfm65yQ2Sp7zB7pNOvPqZTI/476E8lL1dpCytegy9oP+eHwgld+D6F2Rn0yz+jBpF2TfPzgWPFdvsZhyiuqihUBjUrOT2dsklA4S9z/qRDkJH+Vy48zhiShmQWTRM/DA+MbseIpvjCkE0lXE6jRtQUReJ83LMiP7M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by DB6PR04MB3270.eurprd04.prod.outlook.com (2603:10a6:6:11::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 1 Jul 2022 06:55:01 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::416e:6e99:bac6:d3a9]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::416e:6e99:bac6:d3a9%6]) with mapi id 15.20.5395.015; Fri, 1 Jul 2022 06:55:01 +0000 From: Liu Ying To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: andrzej.hajda@intel.com, narmstrong@baylibre.com, robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch, sam@ravnborg.org, marex@denx.de, linux-imx@nxp.com Subject: [PATCH 2/3] drm/bridge: fsl-ldb: Enable split mode for LVDS dual link Date: Fri, 1 Jul 2022 14:56:33 +0800 Message-Id: <20220701065634.4027537-3-victor.liu@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220701065634.4027537-1-victor.liu@nxp.com> References: <20220701065634.4027537-1-victor.liu@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR04CA0013.apcprd04.prod.outlook.com (2603:1096:4:197::6) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 00ea01e8-3e17-412e-e445-08da5b2e9e5a X-MS-TrafficTypeDiagnostic: DB6PR04MB3270:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eTBcjM5LRmg2YVZiphcq/7RKMukyVDL1VPLIau90rKCtZ65JfW18znpwbNoydzNFaPxhF23T4C95N1cYytzBdHmed7T4g1a6YB7mKffMi4EOsQgwp8p/poGaa8JdnD/0PTwP+DxxClcFSzZrs1txUmAfmk/waWoN+kvva2E6lGwSOLRLKVd+0/nDLbMDDRM1x7HzLxy6BBm/CRmmA6XOBvqx/pTzyzTi3G7DoQkOmVbZudRFCbUw+PSereywqU0Oax6zDutgYELxQ9R0CSmj6jtavm2oYKuXEvWnGu6NdeiN7ugG5PdsRW5pyuKFdG6V5Lb0rEugvL44c3g+wUiy7sw58dgL5gzcHXxc+y/TNU2hIrYS1vCwwmqH8xDYAQSGUM776lU9ZRWd8sSQGnpfVbnqO9jjC0jB2tCunJryvlnJjcvpfFrJTGCoqqH1fpZd12A4KWGYXLmXq5j8niVz1I5HnLwEFeBzqXhPN1JUlf+5+9RPUWNUsloIxS3i37qnp7djBZNY2D6GGeDjk5QoNXQrWDZHnCwsKX9qQZZ/4kDLX0U5pb+B131rzseUGrH/4Hs31dpxurlDKLBd4o3XZa88OuLG3ZKM/pS1XxJXetn8nIZLUkVO3QnbHf4LvSzqIkg6Q3ojkBFDTBsH3Qqaz5PkKvWdbjt+Bu8Cle/lvRJqVVkGj/W0co5gmN+/8ieSXWPQYfNd1hyNhYZFLkg6KGBeIfOyNpZ5xQ07cv0cxe7avjhYE6YgqqVvzzll+MyCS6pifZ/xhuRFimjX05UOWVVWy3bhptjZ2FgcHoS/ivhwG7O++NUygFgtcaqfHUXI X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(346002)(136003)(376002)(366004)(83380400001)(2616005)(36756003)(2906002)(6512007)(66946007)(41300700001)(6506007)(6666004)(1076003)(52116002)(26005)(186003)(7416002)(478600001)(4326008)(8936002)(38350700002)(38100700002)(316002)(8676002)(5660300002)(86362001)(6486002)(66556008)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+T6yBlviI9eNlqdRy/oB9q808VmBGkiFpJNxk32OAERvN8IHPZ1/OcaUEOm6?= =?us-ascii?Q?1Hy+TgDUzO+lbw74BCRYIBcvQS7sNbXBiOGBmo3kHG/12is1D+NoaFwP+nrn?= =?us-ascii?Q?BTtnPAhowVMDvXip6LL102ndzdfZB2R9pMXcNnvuS3k1tdb+hc7noS1Pf7he?= =?us-ascii?Q?ak6Fgd0z4odygjTW1aXVnNy/unC0rVcKIZPcJIdG/AIbwqopTd0TMwHdcw1V?= =?us-ascii?Q?s+3NAkE8wozsU0JiSkl839kr5DPll6VXUyL9OxKrDd56kdGVRSY8IXrdZFkV?= =?us-ascii?Q?AX++jak/v5RJxx1mwjSyU1iPZWvcirtvJeQrMArTVhmGbIPXlM0CmCpxSENj?= =?us-ascii?Q?Sl7WHOlgQfsnO9vzMlparFf+7VMZcpR6/9JdTRDiCuf4BGlYgKEj5Nx1Ue35?= =?us-ascii?Q?1zeoI3hAUTs0Y95MWO3t18OStQQZFGSAzC+wgtX1EVzgFNi9a2/FFKzyXAm5?= =?us-ascii?Q?XY4RG4txU7LETaS2MldRM7nuTExdSa3J6FnFeHIn6R6L+eMPgPfSXwq/lqSk?= =?us-ascii?Q?V/ZvLFnoy/n1HRMnGIQEFIsyThXHCTI7gZw8XuP5f9/wA6cET+W0rXNnKIiI?= =?us-ascii?Q?mUeNLvXw2EzBFI35T8neqS5mgXn9Uekqeusw6Ola1RqDQ9KedJXewB4v2x7b?= =?us-ascii?Q?RjPgoa66LIiEpwgVgsf4Hheu4aZZts58wyNu4eimQKKkgguiAxcyVin+Fe1t?= =?us-ascii?Q?T6BmtIGUgjAQl9bgeDvMbVUk8acKomovcjgafjD+56xJOl4BCmEmDAu9pjVK?= =?us-ascii?Q?Gcy57lFDOoYl1LwP4OyDDPjpMIzH5uxv07l/PcGEGfBz2Fua9Crwl5Yn3kVb?= =?us-ascii?Q?X9HmhpI7gCxEQ7onRME6G/tADC8ePeRNwXRcdexw5rkLr8mgueJguIjDOVWK?= =?us-ascii?Q?JJeqsyNY53qwgdrpLyqpbLTrkHzuwnMVyJ+MLPc8az/n7+bYb8jWdIjyM7gi?= =?us-ascii?Q?qSDmqlaKlOpYOiocPFbAwHJDNbqCJshbm/Bg6pIQp5CEKGn3z+nnQHN0/5S3?= =?us-ascii?Q?GlvFXnnMSbvaYEH25iSV0nzGNpLsNrAKBq3JvRmSErrYmb/2++wxR0Q1+IfD?= =?us-ascii?Q?7ibpc+xd5ZnGlRdeQ7gac/0H4jEtbIHDsV1AdqN7Z2gbjEObUQ9lFL7PIB1P?= =?us-ascii?Q?r6N1j6Cz2LZu2Aa6IFzsvFzZj6lK4rzPQUpnN4CBlqHuBk0AYGcXgV/+5BJR?= =?us-ascii?Q?lahiwXK5gWbd5u5po12xuJ+PvBi0m6DEr1+NGmJtAcxx1T0k5z/Iam7zJ1f3?= =?us-ascii?Q?Z3NVNhvwigFwRX6wkzVLfIDqsTWveyoo8Na7VRDbegY8vyoo0kEih3YAtEFJ?= =?us-ascii?Q?goFDSGnROhWrgf5s8aqKz8/AhFSy3OaFrHGT+O7ZXibilFvQHLRoEpXNs/cM?= =?us-ascii?Q?lIhcQD0cM3WjyJCSgo4OS2IN4SQE6nYyQCIwGG7VJRBFQHHe4ckjEO9kuhM1?= =?us-ascii?Q?HO5OkYStf6SWz+0iFie7lxXI7WOUv0UPfgiwcoRoUDmmp+4HgmtPpXNzHC2V?= =?us-ascii?Q?DpBfkn5WhVn4ktiBU4AAMvRw0c/JZtJq4EXpPFhi5xxy+ROWWYAhIIDY3xBr?= =?us-ascii?Q?aTVbQ7R82+2yKVcA5Ibk1vdgHZMdYd1MZtdWpifH?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00ea01e8-3e17-412e-e445-08da5b2e9e5a X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 06:55:01.2694 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: THgcxB8YZPBREOL0GYGp7rrVMq4Tuox3LqzN2wB9BvCWg/3LC3mFrBfmqDG17s2t6zeBAPq8Wv9ksRrLlpAjwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3270 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" When LVDS dual link is used, we have to enable the LDB_CTRL_SPLIT_MODE bit. Fixes: 463db5c2ed4a ("drm: bridge: ldb: Implement simple Freescale i.MX8MP = LDB bridge") Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: Sam Ravnborg Cc: Marek Vasut Cc: NXP Linux Team Signed-off-by: Liu Ying Reviewed-by: Marek Vasut --- drivers/gpu/drm/bridge/fsl-ldb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-= ldb.c index 3cb3b310e283..d4f005eef6f6 100644 --- a/drivers/gpu/drm/bridge/fsl-ldb.c +++ b/drivers/gpu/drm/bridge/fsl-ldb.c @@ -153,7 +153,7 @@ static void fsl_ldb_atomic_enable(struct drm_bridge *br= idge, reg =3D LDB_CTRL_CH0_ENABLE; =20 if (fsl_ldb->lvds_dual_link) - reg |=3D LDB_CTRL_CH1_ENABLE; + reg |=3D LDB_CTRL_CH1_ENABLE | LDB_CTRL_SPLIT_MODE; =20 if (lvds_format_24bpp) { reg |=3D LDB_CTRL_CH0_DATA_WIDTH; --=20 2.25.1 From nobody Thu Apr 30 09:51:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A9E4C43334 for ; Fri, 1 Jul 2022 06:55:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234693AbiGAGzT (ORCPT ); Fri, 1 Jul 2022 02:55:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234874AbiGAGzI (ORCPT ); Fri, 1 Jul 2022 02:55:08 -0400 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60085.outbound.protection.outlook.com [40.107.6.85]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCFE361D4C for ; Thu, 30 Jun 2022 23:55:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g5SnxWllch55cco3TkdBejm/zDnS/x1EHPdgV4+V7+SiTfOcpmiNkHnHvcHoYOBcXDIc+FJCwNpL7BzzYV5ZUJ3IONHM92VlulGFnTG27HgnXg61bnbhAeoOsISL3H83oSy7/xpQtGgT2uBIckotN9U2fp/k5qNxnuSlJBW3Zy4MdJIPaqfycc/4gdr16n3jueLN1mLVWhkd0dr6/POStn/k/fcmNw8uLxA82xqW8qNhnBtvm1zB3/WPBnSaxiyzkBMI9+jYCWY7xsfw6iND63TmvJ3Pg52cDGnbnJh2xXitwTCjIYQh2vZ6H/j4dqbcZOzC86cA5Vxp2LCjIbZFdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Uf2rt0cy7GFOP8pf/wqQaLnlTUQgi7RaDY6tAOvbLq0=; b=SF5SnlRhriQY+ItnR1pGAh1z+WeqjsXgENfINwhLuPD34SwIpnVxiJSLzTtQzIHAyktiFdSN+P4dpJmMTWO/hZuDd4oK+v3JCBHDR/+76uHxz35VlY78PhxwS+S/MXQUiZ+drWJc3AGctqRnCpZJS05SridVC9GbI0+YjgA9U8YFLkgxxF8+hwqRZuPQahXa0Ip28ZAZWPK8rcCl1ay9OY6yiVmrUvqIZ4BJ+jhhjcXd5FHRm2vPqTOmM0j1ddK4I1qT9wFiKNmHCvGW0rm4MkbU7XDzsguoIi6OiETZH5EHvL1GpfNj5CbvKo2Ol/j9FjQBSOWGdzgum7EClHouxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uf2rt0cy7GFOP8pf/wqQaLnlTUQgi7RaDY6tAOvbLq0=; b=bl9lSkErK7Lj+7np97VWu2E4LboEn0dzbEkao5AGFzv0J5NdzQmjoDR0GMGy9fR9Bi5wsqYAqEw8DogWlVYZgQ0WlCDcM1kRhfJLghrqrRL43cpd6Geg4fDVjz+huSWor2xs4UjSt/HFUlwo9ZKcw423SFZuthX1npjPjqZNmP8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by DB6PR04MB3270.eurprd04.prod.outlook.com (2603:10a6:6:11::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 1 Jul 2022 06:55:05 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::416e:6e99:bac6:d3a9]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::416e:6e99:bac6:d3a9%6]) with mapi id 15.20.5395.015; Fri, 1 Jul 2022 06:55:05 +0000 From: Liu Ying To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: andrzej.hajda@intel.com, narmstrong@baylibre.com, robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch, sam@ravnborg.org, marex@denx.de, linux-imx@nxp.com Subject: [PATCH 3/3] drm/bridge: fsl-ldb: Drop DE signal polarity inversion Date: Fri, 1 Jul 2022 14:56:34 +0800 Message-Id: <20220701065634.4027537-4-victor.liu@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220701065634.4027537-1-victor.liu@nxp.com> References: <20220701065634.4027537-1-victor.liu@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR04CA0013.apcprd04.prod.outlook.com (2603:1096:4:197::6) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a94d84ea-b28d-414b-8044-08da5b2ea0c2 X-MS-TrafficTypeDiagnostic: DB6PR04MB3270:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VHZmvsTfPuT8w2GeSSMLs8dgkz/ITzsf0K0UKfILNKvvUmcuB112JMRMcuJQ60Xf9gIsjYOG1FKtuQMqvYkm6allvNrs+sqPe+XDUhvOju51tWMRR3BY2Rdxf0XYo9Ez5tjgvDdsTjGBa1E3NgiCgcw4GMaAENmoga6l+M6C8nFRd0947oWEvA1fQXnktwaYNKHLIhJZm81VFcL1rgAjlqRiou/EHAY9ik4XobdmBDv2SImrcoyFTIAKqMhAtyKIOl3adW1nJYjg+vPPZNVEY47C+WZiGLB7MjGQBe5KSjsQq0Kqg3D71crY8U95+EsVggRdf3DQpzcCRuMKxHIKhYX08EdzHZ66XQMpd+W/qGl8yVeD60vHvXbh/vnr0XZk1QVidBP8vSX1avgP/GNZoowgjTLbA2Z+fb9hRWc3R/jcJN0hZhMsbIoaJLB15+/3eDetDJmWK2I0q8wQe6Ddc/Zcorf56em6IjW6I4qUbVlkbwe6VSmtGOFpK2PjDbsmbNAtCud5cViJmDePpRJOPiQLxH51r0mo+usUrqgm8yYv3/4o7ow+aGCHsxrfhBvmPF0dN46yR8XU6Bv9PYZ0jwimw9ochRiFqOv5YaPG2yque5U+W8pYXV6nwHK+Dz8LzrK4r3QNRSbExc/deNme6pnFwOb25f5NkmSEvDJvVJkpmxpy/CepCHFvtRYBr/tdAR7n/31hF8VBDttnDMe7w8lnTB1kp30N6dFgvmothcXGZX3U6qRIgdDqFGn3BrKd5nPcycl92S8f7sRDSUOt7gdU6DmqoH1INKDaPk6kTBLVIZtMB5rZg7c47tnttoei X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(346002)(136003)(376002)(366004)(83380400001)(2616005)(36756003)(2906002)(6512007)(66946007)(41300700001)(6506007)(6666004)(1076003)(52116002)(26005)(186003)(7416002)(478600001)(4326008)(8936002)(38350700002)(38100700002)(316002)(8676002)(5660300002)(86362001)(6486002)(66556008)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?s3NSSw/I48QQfDFgUjoNFyk4FwM4iBgo2JROC4xq5TyruvcqbaSZ6pv1JvXB?= =?us-ascii?Q?pXf8TkMtC0ax1BhHvYCRFD93M2iagKEEEGhoptsHm67dQXi1XyW82RSFcf7D?= =?us-ascii?Q?zQemLMJS6181dk5q7cp78ZorbMtLDJXMexDGMbd6ntT8CGJ+8JdDDXTcW2gW?= =?us-ascii?Q?bHW3SozCCiUqx617Zsr7sz/oaEuVDJ/3rE1U+YyNfn2RuZx24uRDHZaEBI9L?= =?us-ascii?Q?fRJs4sAuHnn8nBg/uOEAwyLec8FCgWJXH6aV7j6Jd4BI9NiYWJXiRfmFJUYA?= =?us-ascii?Q?yD49uBYK8s1j+xerpj6Es3oUtOeFSEacVby/t/fhu3wSeM+NZhEGo0vtX++e?= =?us-ascii?Q?WuE3sbNF0Sdr5f1j+VjP0zFX+YpG0RtcsRYgj5/ZiggLKbQbPZz9YMr2zGFX?= =?us-ascii?Q?H/6HhIXuajW2+Ul73lGASXFMo48I3XHUH93KVIkxVzXXE+ZE5tE4FDakaS2v?= =?us-ascii?Q?eE8N2oFSbVY8AOZC3Sx9ML2tAShxJ3etlsiGuwEjuLe7PlC2YKvNzIGqOKKE?= =?us-ascii?Q?0Ebhuk48wvDxCFxRndTFqmyVUBrb4V0LdJZmCwD9GpF6ZWa++xKs/Ljq8rSn?= =?us-ascii?Q?RP8U/DWdHP05QNjFD9QOkm/E6aJbxlM37JJQu5vaU1l6Yhpyy7ox12h29TlF?= =?us-ascii?Q?BdhOSnauUgcBxlz3cHqw5wDCyXltwKY1Ws9Edpl2ACbKCWYXEaV2f+3OK2st?= =?us-ascii?Q?OLukgQjAbJqUpkUWIUaQ8hPo7lHYM4+iawbF4JARhKFFUvYBDolNlwR0xicL?= =?us-ascii?Q?p51BppaqjdQy3SCC7DBAooLw8Q+uKiOt7K1rSUQk89RVCw/EslpNz2Bww7QA?= =?us-ascii?Q?t5dhMBNBAZMukmMObwTbb/bdGiWEXJaEggOC+6C7BdzzcF1YYgi/IIjtyzeW?= =?us-ascii?Q?hw5VpEWyOqkR/jhEhLhIr4rA0exW5FiXt7hXVedf1npesSdIDDiR9/CohufR?= =?us-ascii?Q?wdTkiDV3Rm4H7zwirIy+Y6K+gHvpek/txLoFw8AutzNF9GA1+PVgBq6xD1J7?= =?us-ascii?Q?FiTFKJBM0LJug8X3cjY61YIMvCMiUSSPhVoRaaLJyHUh3/65dDjwE4DE28hz?= =?us-ascii?Q?rP8ilZFTVMReSVtHaZCd/ULaF2MBqFSuFJXZKaofeMbIZPKvGbcl/QntjwDg?= =?us-ascii?Q?CNekK1hAFifbnLIkEVui4FVPZ9XGLazDjOuRABxLUsOl9vuFoF/3a9C4eaBh?= =?us-ascii?Q?tY+otw4gDauaMXLv2Mg2u45Kw82nVo8Yc+DC9wLimx1ONe1E2o9wFVQuXpZ0?= =?us-ascii?Q?9jh4tjOmoipMCVE+WDL08avj3T989QZ7u8D/8hf/48IBQeWMxuWC/b86VYlk?= =?us-ascii?Q?7YS5JPWrM/7UckQYMLVtLh6xYat2C1/21NA8CpZdhDUHA/U1JbUdEiXc55pn?= =?us-ascii?Q?95/ceH3BZX+fHSsaVYvRsBQl3guORg7fgIHMETVxrQfP9S1Dbp470Cqii5HM?= =?us-ascii?Q?MIFu3Npi56gkwvTfdmhkf5sQj5FCJkX551ZHvMEK4yl4bNIaaElYFbO/vARb?= =?us-ascii?Q?eM6DVWjUXxlUN4wIKLMf9shIdtkRkl65WJQELFd09B+DzLZ0R5SndXsd+dV5?= =?us-ascii?Q?hnzD23F3v2VArMJ9ywKDkjWjnME7OAThdCqWGyKE?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a94d84ea-b28d-414b-8044-08da5b2ea0c2 X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 06:55:05.2726 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TtOWmZBiJiK5/HPl1BxFIS61ekfEEBNroEBAe5dV6/d9Aw7Lszyedkds4NIDm4zU+de/zqWuhiNMzTS1GEYYfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3270 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" It's unnecessary to invert input data enable signal polarity according to the output one. Let's drop the inversion. Since ->atomic_check() does nothing more than the inversion, it can be dropped entirely as well. Without this patch, 'koe,tx26d202vm0bwa' LVDS panel connected with i.MX8MP EVK board does not show any data on screen. Fixes: 463db5c2ed4a ("drm: bridge: ldb: Implement simple Freescale i.MX8MP = LDB bridge") Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: Sam Ravnborg Cc: Marek Vasut Cc: NXP Linux Team Signed-off-by: Liu Ying Reviewed-by: Marek Vasut --- drivers/gpu/drm/bridge/fsl-ldb.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-= ldb.c index d4f005eef6f6..4b503c544256 100644 --- a/drivers/gpu/drm/bridge/fsl-ldb.c +++ b/drivers/gpu/drm/bridge/fsl-ldb.c @@ -74,22 +74,6 @@ static int fsl_ldb_attach(struct drm_bridge *bridge, bridge, flags); } =20 -static int fsl_ldb_atomic_check(struct drm_bridge *bridge, - struct drm_bridge_state *bridge_state, - struct drm_crtc_state *crtc_state, - struct drm_connector_state *conn_state) -{ - /* Invert DE signal polarity. */ - bridge_state->input_bus_cfg.flags &=3D ~(DRM_BUS_FLAG_DE_LOW | - DRM_BUS_FLAG_DE_HIGH); - if (bridge_state->output_bus_cfg.flags & DRM_BUS_FLAG_DE_LOW) - bridge_state->input_bus_cfg.flags |=3D DRM_BUS_FLAG_DE_HIGH; - else if (bridge_state->output_bus_cfg.flags & DRM_BUS_FLAG_DE_HIGH) - bridge_state->input_bus_cfg.flags |=3D DRM_BUS_FLAG_DE_LOW; - - return 0; -} - static void fsl_ldb_atomic_enable(struct drm_bridge *bridge, struct drm_bridge_state *old_bridge_state) { @@ -241,7 +225,6 @@ fsl_ldb_mode_valid(struct drm_bridge *bridge, =20 static const struct drm_bridge_funcs funcs =3D { .attach =3D fsl_ldb_attach, - .atomic_check =3D fsl_ldb_atomic_check, .atomic_enable =3D fsl_ldb_atomic_enable, .atomic_disable =3D fsl_ldb_atomic_disable, .atomic_duplicate_state =3D drm_atomic_helper_bridge_duplicate_state, --=20 2.25.1