From nobody Sun Apr 19 13:46:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8189C43334 for ; Thu, 30 Jun 2022 07:45:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233143AbiF3Hpf (ORCPT ); Thu, 30 Jun 2022 03:45:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232259AbiF3Hpc (ORCPT ); Thu, 30 Jun 2022 03:45:32 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81A9636B54 for ; Thu, 30 Jun 2022 00:45:31 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id sb34so37223069ejc.11 for ; Thu, 30 Jun 2022 00:45:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XZOi0La7XXKtkYx/fp0c768hVBWWCXiluyMMk6qKUzU=; b=MOT4Ask04bvtjdcHefCiKgo0uVx8FBvfb4js6ZVh70fYN+94Z+RF5YJakY/9i2yCBM 8wnt/IcUkrMBUbsEHWYnhaKERUTOtZjDlzGbgPQ8a2LrKyuK+cG+3HJt7g0zNKNsE3m8 njN62LsIS8zqzUfqokqe15f5n7cKWndXbMiPM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XZOi0La7XXKtkYx/fp0c768hVBWWCXiluyMMk6qKUzU=; b=UYoqVZ1Jr0eWzSMcTgTtQHwRlg0Zc/wGcZBW0khB0VdeC1rg0YLodR44vCKyk9NSZJ L0x0lsdOFEsrqPhYQksEpTTnSNmq0rTaZFVQio3kaz490avjdIL1rRXTYN3alTGliR/h TAnsOvWJsPRB5jtwLxgTOnLiM1JJOuWLatsWyuosYGQZJjiIvhcgp/n3H835raj2ceIP yTDzYN8ESNnlNUVJ1nrU8p/fuarec0PWdKGEXFbCezUOuJ8w9Oud6n8X/FRwIcTJmIAd ZcviZenHEbNHCgQslwD9j1aHrS62zDor+je68vnp9OJGkt8o2wfsCkwwyLfzdu+AOmyB FyfQ== X-Gm-Message-State: AJIora8WzLGoTrQQeFpbEKpRtjMvuSoifkKlSgEvBrOUOy1/EX3Kl1XB LGG2a/PDCOZvGsgOGnBQgj9Eug== X-Google-Smtp-Source: AGRyM1vffMug1IlnVp5LGuJQrv0D0KZZCOijptBd51rIvW5fVLabUJ71Ie0xhbQzlqaDGjloLym3ug== X-Received: by 2002:a17:907:7f1a:b0:726:2b37:7b82 with SMTP id qf26-20020a1709077f1a00b007262b377b82mr7314412ejc.366.1656575130059; Thu, 30 Jun 2022 00:45:30 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-58-216.cust.vodafonedsl.it. [188.217.58.216]) by smtp.gmail.com with ESMTPSA id b13-20020aa7c90d000000b0043564320274sm12594731edt.19.2022.06.30.00.45.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 00:45:29 -0700 (PDT) From: Tommaso Merciai To: tommaso.merciai@amarulasolutions.com Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Jacopo Mondi , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 1/6] media: ov5693: count num_supplies using array_size Date: Thu, 30 Jun 2022 09:45:20 +0200 Message-Id: <20220630074525.481790-2-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220630074525.481790-1-tommaso.merciai@amarulasolutions.com> References: <20220630074525.481790-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Instead of hardcode OV5693_NUM_SUPPLIES in a define is better use ARRAY_SIZE function to count the number of supplies from ov5693_supply_names array Signed-off-by: Tommaso Merciai Reviewed-by: Jacopo Mondi Reviewed-by: Daniel Scally --- Changes since v3: - Add reviewed-by tag, suggested by Jacopo, Krzysztof drivers/media/i2c/ov5693.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index 117ff5403312..f410333c4c67 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -127,11 +127,15 @@ #define OV5693_LINK_FREQ_419_2MHZ 419200000 #define OV5693_PIXEL_RATE 167680000 =20 -/* Miscellaneous */ -#define OV5693_NUM_SUPPLIES 2 - #define to_ov5693_sensor(x) container_of(x, struct ov5693_device, sd) =20 +static const char * const ov5693_supply_names[] =3D { + "avdd", /* Analog power */ + "dovdd", /* Digital I/O power */ +}; + +#define OV5693_NUM_SUPPLIES ARRAY_SIZE(ov5693_supply_names) + struct ov5693_reg { u32 reg; u8 val; @@ -352,11 +356,6 @@ static const s64 link_freq_menu_items[] =3D { OV5693_LINK_FREQ_419_2MHZ }; =20 -static const char * const ov5693_supply_names[] =3D { - "avdd", - "dovdd", -}; - static const char * const ov5693_test_pattern_menu[] =3D { "Disabled", "Random Data", --=20 2.25.1 From nobody Sun Apr 19 13:46:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CD5CCCA47E for ; Thu, 30 Jun 2022 07:45:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233160AbiF3Hpi (ORCPT ); Thu, 30 Jun 2022 03:45:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233148AbiF3Hpe (ORCPT ); Thu, 30 Jun 2022 03:45:34 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11B5E3B298 for ; Thu, 30 Jun 2022 00:45:33 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id o9so25365506edt.12 for ; Thu, 30 Jun 2022 00:45:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VNYYioEE6eRAWTo799NfZ03VtyHU0+m847tUVl43Yck=; b=YLjiXgvt9WepSmT9ZWnR5NUIPpyCbwSk9tCnGGCA2MfRQJ/JQiQv3MrwkZKcd/ANyt 95Z1mmWkFJRAhnXMGxLr6usLtWiqEogLMVG0Gh96jm1DsCvDisP9v1JOYJGkUo0qCeW6 skVfivMIR2LzuOFje+9s9oRNrsyjTks2W1Guo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VNYYioEE6eRAWTo799NfZ03VtyHU0+m847tUVl43Yck=; b=QcdN5p1+3T2cYtBD4MZhU2D7lWDx24kIpL9tFcNKsqSLpOFkcT/3m3lWKgMAF6Y4X0 erLfQ9NTsu/aZ6Mzh8E5KPNkeslKR58gBMDDJ4JHUkWrFGMo0m/+0hPdvrq5QxGWRysI pZc/NEZ47P17XBi3ETw+p8bE95SsDugT/NeVLI/KnfaSEG+oh1O8L0Su4/I0O2WNvUmy M2JSdl3RCELu8mphYNDAx9MuSRGvkrFqNV0reICJZOytIzCBmQq7LLvlPYSQ4ZURNtWN BLkUjbQtE2J5m1XbZ/I1EXIuLjoB9Vce3jNhWmJZLZzS2qSdDSyIfbjRhwQxq7gUA76H Tqag== X-Gm-Message-State: AJIora9IrO7OksBDMnvN1Nsla+ZLuGo9RX1vpsRPK7VrmnBufjLmCm8t 6tNNoajGutvDZsSLRUx4kfTpoA== X-Google-Smtp-Source: AGRyM1sFj8MoQk6ICrYzIG/7k4fYwLARHuMRDZqT7YjTSOwCdeamIUesx/jFGg0+IMSxYVgWyznfWg== X-Received: by 2002:a05:6402:4408:b0:435:9ed2:9be with SMTP id y8-20020a056402440800b004359ed209bemr9590051eda.81.1656575131548; Thu, 30 Jun 2022 00:45:31 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-58-216.cust.vodafonedsl.it. [188.217.58.216]) by smtp.gmail.com with ESMTPSA id b13-20020aa7c90d000000b0043564320274sm12594731edt.19.2022.06.30.00.45.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 00:45:31 -0700 (PDT) From: Tommaso Merciai To: tommaso.merciai@amarulasolutions.com Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Jacopo Mondi , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 2/6] media: ov5693: add dvdd into ov5693_supply_names array Date: Thu, 30 Jun 2022 09:45:21 +0200 Message-Id: <20220630074525.481790-3-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220630074525.481790-1-tommaso.merciai@amarulasolutions.com> References: <20220630074525.481790-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add missing "dvdd" (Digital circuit power) entry into ov5693_supply_names array Signed-off-by: Tommaso Merciai Reviewed-by: Jacopo Mondi Reviewed-by: Daniel Scally --- Changes since v3: - Add reviewed-by tag, suggested by Jacopo, Krzysztof drivers/media/i2c/ov5693.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index f410333c4c67..9e84468d920e 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -132,6 +132,7 @@ static const char * const ov5693_supply_names[] =3D { "avdd", /* Analog power */ "dovdd", /* Digital I/O power */ + "dvdd", /* Digital circuit power */ }; =20 #define OV5693_NUM_SUPPLIES ARRAY_SIZE(ov5693_supply_names) --=20 2.25.1 From nobody Sun Apr 19 13:46:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BB1CCCA47B for ; Thu, 30 Jun 2022 07:45:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233204AbiF3Hpl (ORCPT ); Thu, 30 Jun 2022 03:45:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233161AbiF3Hpf (ORCPT ); Thu, 30 Jun 2022 03:45:35 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B7EC3A71C for ; Thu, 30 Jun 2022 00:45:34 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id r18so17532761edb.9 for ; Thu, 30 Jun 2022 00:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ctpa/T2vVk1WErHGmcuqVVZ1P5/ZM5PQkEWqW8vXr7A=; b=lRMEg3/FRguw5FwS8pKZMz//6FUb1bmUu/durvcaUXE93Uz6C54xek86KnAfW5U1ca ntiBw22+0Z9UspHk18n14P34zxpuhqERuCCMNUPyduCT9sOFyyb5SZGWpgBUMdk6gN5G V92UCxsO3NxQGZGqLelxE9MLKBOblUkvc5F3s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ctpa/T2vVk1WErHGmcuqVVZ1P5/ZM5PQkEWqW8vXr7A=; b=75XeTDbzbe/HAQcfrioozBNTBirTn/W7z4ee0GSthpS7l2zCH8IU7diqsYbjixZTLr KuSU4ca+YcCAy9l59N5UvDaji1Hfg5zQVVSUwTqEwTtNbOkcucT5ncaBQGFVeqcrQ0TB J1uBNn86hXhESK5WN62YF0nN+HhnNDclMjSKXI6hqb2RpDJb++b1fo+9XL5GVGmtpZuv /AUifqdlTmjThmYOkYuXxKnrtez1tlz/disJoetVFdSDmz4/bOKvaY4Yp4ob9Xg6dgIr M5YxiRGvyz7sPwE7EdW+nCEOSMD6s51rWxEr9zTlAoDuk3aYaTEPBybZ77CXv77aGWPj YdZA== X-Gm-Message-State: AJIora9dBrLLDar0cI/EOz5g/DWq8vZiNKnJqYH0uwmib5nYXftXJpfi ZzEV2Fsb5rhJAaSEvK+AU8M+yw== X-Google-Smtp-Source: AGRyM1uuAMkrYZQ8JChtMp+7GI/hYI16/CjCaUjNyphloY7yDvh7i21GX7ol110y4S0BSN6t6q1vHw== X-Received: by 2002:a05:6402:2786:b0:435:da07:14cb with SMTP id b6-20020a056402278600b00435da0714cbmr9744966ede.408.1656575133094; Thu, 30 Jun 2022 00:45:33 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-58-216.cust.vodafonedsl.it. [188.217.58.216]) by smtp.gmail.com with ESMTPSA id b13-20020aa7c90d000000b0043564320274sm12594731edt.19.2022.06.30.00.45.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 00:45:32 -0700 (PDT) From: Tommaso Merciai To: tommaso.merciai@amarulasolutions.com Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Jacopo Mondi , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 3/6] media: ov5693: rename clk into xvclk Date: Thu, 30 Jun 2022 09:45:22 +0200 Message-Id: <20220630074525.481790-4-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220630074525.481790-1-tommaso.merciai@amarulasolutions.com> References: <20220630074525.481790-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename clk pdata pointer into xvclk (system clock input). Same for clk_rate into xvclk_rate. This is more explicit Signed-off-by: Tommaso Merciai Reviewed-by: Jacopo Mondi --- Changes since v3: - Add reviewed-by tag, suggested by Jacopo, Krzysztof drivers/media/i2c/ov5693.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index 9e84468d920e..d2adc5513a21 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -157,7 +157,7 @@ struct ov5693_device { struct gpio_desc *reset; struct gpio_desc *powerdown; struct regulator_bulk_data supplies[OV5693_NUM_SUPPLIES]; - struct clk *clk; + struct clk *xvclk; =20 struct ov5693_mode { struct v4l2_rect crop; @@ -794,7 +794,7 @@ static void ov5693_sensor_powerdown(struct ov5693_devic= e *ov5693) =20 regulator_bulk_disable(OV5693_NUM_SUPPLIES, ov5693->supplies); =20 - clk_disable_unprepare(ov5693->clk); + clk_disable_unprepare(ov5693->xvclk); } =20 static int ov5693_sensor_powerup(struct ov5693_device *ov5693) @@ -804,7 +804,7 @@ static int ov5693_sensor_powerup(struct ov5693_device *= ov5693) gpiod_set_value_cansleep(ov5693->reset, 1); gpiod_set_value_cansleep(ov5693->powerdown, 1); =20 - ret =3D clk_prepare_enable(ov5693->clk); + ret =3D clk_prepare_enable(ov5693->xvclk); if (ret) { dev_err(ov5693->dev, "Failed to enable clk\n"); goto fail_power; @@ -1390,7 +1390,7 @@ static int ov5693_check_hwcfg(struct ov5693_device *o= v5693) static int ov5693_probe(struct i2c_client *client) { struct ov5693_device *ov5693; - u32 clk_rate; + u32 xvclk_rate; int ret =3D 0; =20 ov5693 =3D devm_kzalloc(&client->dev, sizeof(*ov5693), GFP_KERNEL); @@ -1408,16 +1408,16 @@ static int ov5693_probe(struct i2c_client *client) =20 v4l2_i2c_subdev_init(&ov5693->sd, client, &ov5693_ops); =20 - ov5693->clk =3D devm_clk_get(&client->dev, "xvclk"); - if (IS_ERR(ov5693->clk)) { + ov5693->xvclk =3D devm_clk_get(&client->dev, "xvclk"); + if (IS_ERR(ov5693->xvclk)) { dev_err(&client->dev, "Error getting clock\n"); - return PTR_ERR(ov5693->clk); + return PTR_ERR(ov5693->xvclk); } =20 - clk_rate =3D clk_get_rate(ov5693->clk); - if (clk_rate !=3D OV5693_XVCLK_FREQ) + xvclk_rate =3D clk_get_rate(ov5693->xvclk); + if (xvclk_rate !=3D OV5693_XVCLK_FREQ) dev_warn(&client->dev, "Found clk freq %u, expected %u\n", - clk_rate, OV5693_XVCLK_FREQ); + xvclk_rate, OV5693_XVCLK_FREQ); =20 ret =3D ov5693_configure_gpios(ov5693); if (ret) --=20 2.25.1 From nobody Sun Apr 19 13:46:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D192C43334 for ; Thu, 30 Jun 2022 07:45:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233216AbiF3Hpp (ORCPT ); Thu, 30 Jun 2022 03:45:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232259AbiF3Hph (ORCPT ); Thu, 30 Jun 2022 03:45:37 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40B723B3E8 for ; Thu, 30 Jun 2022 00:45:36 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id e40so25420329eda.2 for ; Thu, 30 Jun 2022 00:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HMgTO+0GXKbF2GDHku+aibaoRp7NUzUN5XoO55rghiY=; b=j4norZtA85g2BOXLRNrwavWs1/mJePBfPBNyDy9UFriTTcOYUrQma2J0aN1MnbBA71 hkEOx/EZ0K0fri78rRfWG70dS5DGbV1Q5fvkdJFTxSI9tXDhndkO+3xuQ6MEGnQoazEy viKZ6bRQboidvZgQrLt/L3ABOOhbY3SdLwgkU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HMgTO+0GXKbF2GDHku+aibaoRp7NUzUN5XoO55rghiY=; b=IpB3HQXTqWKpKiI2uI9JHIo0848iPBccE/Pn+XH2+ojH6Qb704DnaeYhmD04h+Dnxr wzXFtEtE93h2tgwZCgOrZkgZAS/4PHdR2EoItuQUn/ohwme2hizIhVI8jUqK3tcxi/Gj khvEFpdpLPaTRJZPmPJqdNEBqKXrB9udwBs5chkBohdbIyS/oa0d5eDJbxyiwVn1jp/0 +dy2stU5AF+e0+5faC6ugBZH01XWWypYFFUkjHgPE1kTA6ADG94Ug4fSHJHc5QBDktUo hTtov9bQ7+ELpY80FPDNK44kztlrsRWaR4d3w27r32JQPZn9QEX9oEvEclhASdyfH+ez ONRQ== X-Gm-Message-State: AJIora/rliyHP/xZlms12IUHVtYlJQWmIj3Ibrv840ACso3vmLAqQgW/ tU94cwCs9jnxwNQphVBP55bctA== X-Google-Smtp-Source: AGRyM1vhhj9Qoso+xYV2Bazg/Et/lwaVLyV/sYrTBQSibERjoPA+gE5dkWLrEYd+RJniTFkWQXuClw== X-Received: by 2002:a05:6402:3490:b0:435:9802:96ac with SMTP id v16-20020a056402349000b00435980296acmr9772735edc.40.1656575134769; Thu, 30 Jun 2022 00:45:34 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-58-216.cust.vodafonedsl.it. [188.217.58.216]) by smtp.gmail.com with ESMTPSA id b13-20020aa7c90d000000b0043564320274sm12594731edt.19.2022.06.30.00.45.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 00:45:34 -0700 (PDT) From: Tommaso Merciai To: tommaso.merciai@amarulasolutions.com Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Jacopo Mondi , Sakari Ailus , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 4/6] media: ov5693: move hw cfg functions into ov5693_hwcfg Date: Thu, 30 Jun 2022 09:45:23 +0200 Message-Id: <20220630074525.481790-5-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220630074525.481790-1-tommaso.merciai@amarulasolutions.com> References: <20220630074525.481790-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Move hw configuration functions into ov5693_hwcfg. This is done to separate the code that handle the hw cfg from probe in a clean way. Add support for ACPI-based platforms that specify the clock frequency by using the "clock-frequency" property instead of specifying a clock provider reference Signed-off-by: Tommaso Merciai Reviewed-by: Jacopo Mondi Reviewed-by: Sakari Ailus --- Changes since v2: - Fix commit body as suggested by Sakari, Jacopo - Add details to commit body as suggested by Jacopo - Move ov5693_check_hwcfg into ov5693_hwcfg - Fix xvclk_rate position as suggested by Jacopo - Use devm_clk_get_optional instead of devm_clk_get as suggested Jacopo Changes since v3: - Fix commit body as suggested by Jacopo - Add reviewed-by tags, suggested by Jacopo, Krzysztof drivers/media/i2c/ov5693.c | 57 +++++++++++++++++++++++--------------- 1 file changed, 34 insertions(+), 23 deletions(-) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index d2adc5513a21..3c805a5a5181 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -1339,16 +1339,48 @@ static int ov5693_get_regulators(struct ov5693_devi= ce *ov5693) ov5693->supplies); } =20 -static int ov5693_check_hwcfg(struct ov5693_device *ov5693) +static int ov5693_hwcfg(struct ov5693_device *ov5693) { struct fwnode_handle *fwnode =3D dev_fwnode(ov5693->dev); struct v4l2_fwnode_endpoint bus_cfg =3D { .bus_type =3D V4L2_MBUS_CSI2_DPHY, }; struct fwnode_handle *endpoint; + u32 xvclk_rate; unsigned int i; int ret; =20 + ov5693->xvclk =3D devm_clk_get_optional(ov5693->dev, "xvclk"); + if (IS_ERR(ov5693->xvclk)) + return dev_err_probe(ov5693->dev, PTR_ERR(ov5693->xvclk), + "failed to get xvclk: %ld\n", + PTR_ERR(ov5693->xvclk)); + + if (ov5693->xvclk) { + xvclk_rate =3D clk_get_rate(ov5693->xvclk); + } else { + ret =3D fwnode_property_read_u32(fwnode, "clock-frequency", + &xvclk_rate); + + if (ret) { + dev_err(ov5693->dev, "can't get clock frequency"); + return ret; + } + } + + if (xvclk_rate !=3D OV5693_XVCLK_FREQ) + dev_warn(ov5693->dev, "Found clk freq %u, expected %u\n", + xvclk_rate, OV5693_XVCLK_FREQ); + + ret =3D ov5693_configure_gpios(ov5693); + if (ret) + return ret; + + ret =3D ov5693_get_regulators(ov5693); + if (ret) + return dev_err_probe(ov5693->dev, ret, + "Error fetching regulators\n"); + endpoint =3D fwnode_graph_get_next_endpoint(fwnode, NULL); if (!endpoint) return -EPROBE_DEFER; /* Could be provided by cio2-bridge */ @@ -1390,7 +1422,6 @@ static int ov5693_check_hwcfg(struct ov5693_device *o= v5693) static int ov5693_probe(struct i2c_client *client) { struct ov5693_device *ov5693; - u32 xvclk_rate; int ret =3D 0; =20 ov5693 =3D devm_kzalloc(&client->dev, sizeof(*ov5693), GFP_KERNEL); @@ -1400,7 +1431,7 @@ static int ov5693_probe(struct i2c_client *client) ov5693->client =3D client; ov5693->dev =3D &client->dev; =20 - ret =3D ov5693_check_hwcfg(ov5693); + ret =3D ov5693_hwcfg(ov5693); if (ret) return ret; =20 @@ -1408,26 +1439,6 @@ static int ov5693_probe(struct i2c_client *client) =20 v4l2_i2c_subdev_init(&ov5693->sd, client, &ov5693_ops); =20 - ov5693->xvclk =3D devm_clk_get(&client->dev, "xvclk"); - if (IS_ERR(ov5693->xvclk)) { - dev_err(&client->dev, "Error getting clock\n"); - return PTR_ERR(ov5693->xvclk); - } - - xvclk_rate =3D clk_get_rate(ov5693->xvclk); - if (xvclk_rate !=3D OV5693_XVCLK_FREQ) - dev_warn(&client->dev, "Found clk freq %u, expected %u\n", - xvclk_rate, OV5693_XVCLK_FREQ); - - ret =3D ov5693_configure_gpios(ov5693); - if (ret) - return ret; - - ret =3D ov5693_get_regulators(ov5693); - if (ret) - return dev_err_probe(&client->dev, ret, - "Error fetching regulators\n"); - ov5693->sd.flags |=3D V4L2_SUBDEV_FL_HAS_DEVNODE; ov5693->pad.flags =3D MEDIA_PAD_FL_SOURCE; ov5693->sd.entity.function =3D MEDIA_ENT_F_CAM_SENSOR; --=20 2.25.1 From nobody Sun Apr 19 13:46:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 215A6C433EF for ; Thu, 30 Jun 2022 07:45:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232445AbiF3Hps (ORCPT ); Thu, 30 Jun 2022 03:45:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233185AbiF3Hpk (ORCPT ); Thu, 30 Jun 2022 03:45:40 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C48F23B298 for ; Thu, 30 Jun 2022 00:45:38 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id fd6so25374177edb.5 for ; Thu, 30 Jun 2022 00:45:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2VoT8i8QeRks6MlNZX2wBTS/uT3kTm3TDTeb8DcOv84=; b=Cg9ldFAaThDM26guf461l+5hmf9AUk2f8wu5v9WUkPIRT1g2qexq3gpJpL+fr9Lyc9 VA0WfJrfo8XlXEvlfJ5kk8uoVJmCBMgGWEzXG+Uuc1SZEOKzsvFQaO8pwnIkQSZhQPYB +QPhGBko/zn+LtGQbPbP5e3dKyuQQ+T0bj1ds= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2VoT8i8QeRks6MlNZX2wBTS/uT3kTm3TDTeb8DcOv84=; b=kNHrKlcsZMPgKn6fhSYKNkwobqMotlaF9Ck4YsVFa7EDqTAWkngEFqNQQMl4mZ2qMl QdLnR0HBjdw7kUFKMCwAFPy9Z+hc/O3LEl/RxoMXE77qUYt235B77tl5LuZKRUmlFJgz Nz3CwACelm6gQX+4VJj0quGLMBxOMFKthrAVYuSIonbeaRYgnPbvsovM2q+QS1RoOVCh wAJGgG2UUH0wtAod6dPVgHSNZrYANrLelIH1PzJrWYeXEio8+HPEJ5mfK5UnSiR0MwAD HzZMFD+Gg4FnzwGi7FAIct5GQpCqE4P+jIIXOs+H/COJuWqHTbCbugklbdQCDaqVO6u5 Cgiw== X-Gm-Message-State: AJIora+BxVukevAkgFz8oMkHSlPn2sGiXLOnv8JocTdxX05Iniw/rRf2 KpDRs4dAEV2PS66AZ2vk+5DZzQ== X-Google-Smtp-Source: AGRyM1tzmpExmPgVDkzSX2xg767f6uWXrRkq/o6zPDN/PQYKdNvvBvcAXHnBfwWXSwDagnWlMbeC5Q== X-Received: by 2002:a05:6402:438a:b0:435:bc23:d615 with SMTP id o10-20020a056402438a00b00435bc23d615mr9597360edc.283.1656575137327; Thu, 30 Jun 2022 00:45:37 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-58-216.cust.vodafonedsl.it. [188.217.58.216]) by smtp.gmail.com with ESMTPSA id b13-20020aa7c90d000000b0043564320274sm12594731edt.19.2022.06.30.00.45.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 00:45:37 -0700 (PDT) From: Tommaso Merciai To: tommaso.merciai@amarulasolutions.com Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Krzysztof Kozlowski , Sakari Ailus , Daniel Scally , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 5/6] media: dt-bindings: ov5693: document YAML binding Date: Thu, 30 Jun 2022 09:45:24 +0200 Message-Id: <20220630074525.481790-6-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220630074525.481790-1-tommaso.merciai@amarulasolutions.com> References: <20220630074525.481790-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add documentation of device tree in YAML schema for the OV5693 CMOS image sensor from Omnivision Signed-off-by: Tommaso Merciai Reviewed-by: Krzysztof Kozlowski Reviewed-by: Sakari Ailus --- Changes since v1: - Fix allOf position as suggested by Krzysztof - Remove port description as suggested by Krzysztof - Fix EOF as suggested by Krzysztof Changes since v2: - Fix commit body as suggested by Krzysztof Changes since v3: - Add reviewed-by tags, ssuggested by Jacopo, Krzysztof .../bindings/media/i2c/ovti,ov5693.yaml | 106 ++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 107 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov5693= .yaml diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml b= /Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml new file mode 100644 index 000000000000..b83c9fc04023 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml @@ -0,0 +1,106 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (c) 2022 Amarulasolutions +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/ovti,ov5693.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Omnivision OV5693 CMOS Sensor + +maintainers: + - Tommaso Merciai + +description: | + The Omnivision OV5693 is a high performance, 1/4-inch, 5 megapixel, CMOS + image sensor that delivers 2592x1944 at 30fps. It provides full-frame, + sub-sampled, and windowed 10-bit MIPI images in various formats via the + Serial Camera Control Bus (SCCB) interface. + + OV5693 is controlled via I2C and two-wire Serial Camera Control Bus (SCC= B). + The sensor output is available via CSI-2 serial data output (up to 2-lan= e). + +allOf: + - $ref: /schemas/media/video-interface-devices.yaml# + +properties: + compatible: + const: ovti,ov5693 + + reg: + maxItems: 1 + + clocks: + description: + System input clock (aka XVCLK). From 6 to 27 MHz. + maxItems: 1 + + dovdd-supply: + description: + Digital I/O voltage supply, 1.8V. + + avdd-supply: + description: + Analog voltage supply, 2.8V. + + dvdd-supply: + description: + Digital core voltage supply, 1.2V. + + reset-gpios: + description: + The phandle and specifier for the GPIO that controls sensor reset. + This corresponds to the hardware pin XSHUTDN which is physically + active low. + maxItems: 1 + +required: + - compatible + - reg + - clocks + - dovdd-supply + - avdd-supply + - dvdd-supply + - port + +unevaluatedProperties: false + +examples: + - | + #include + #include + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + ov5693: camera@36 { + compatible =3D "ovti,ov5693"; + reg =3D <0x36>; + + reset-gpios =3D <&gpio2 RK_PB1 GPIO_ACTIVE_LOW>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&cif_clkout_m0>; + + clocks =3D <&cru SCLK_CIF_OUT>; + assigned-clocks =3D <&cru SCLK_CIF_OUT>; + assigned-clock-rates =3D <19200000>; + + avdd-supply =3D <&vcc_1v8>; + dvdd-supply =3D <&vcc_1v2>; + dovdd-supply =3D <&vcc_2v8>; + + rotation =3D <90>; + orientation =3D <0>; + + port { + ucam_out: endpoint { + remote-endpoint =3D <&mipi_in_ucam>; + data-lanes =3D <1 2>; + link-frequencies =3D /bits/ 64 <450000000>; + }; + }; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index 1fc9ead83d2a..844307cb20c4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14719,6 +14719,7 @@ M: Daniel Scally L: linux-media@vger.kernel.org S: Maintained T: git git://linuxtv.org/media_tree.git +F: Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml F: drivers/media/i2c/ov5693.c =20 OMNIVISION OV5695 SENSOR DRIVER --=20 2.25.1 From nobody Sun Apr 19 13:46:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64D97C43334 for ; Thu, 30 Jun 2022 07:45:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233233AbiF3Hpv (ORCPT ); Thu, 30 Jun 2022 03:45:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233186AbiF3Hpk (ORCPT ); Thu, 30 Jun 2022 03:45:40 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05FC03B3E8 for ; Thu, 30 Jun 2022 00:45:40 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id o25so4845564ejm.3 for ; Thu, 30 Jun 2022 00:45:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VBaQhh8M0SGoulgjZzCVQ2UkjFdtWV7Yt+dzNHvww78=; b=JCcxg9P/Qzd0goJ7WT9kRMcUwBSR0+QniS+dbJ8ePAquHKkURaZCDhsoeXGDw4Th+p pYxS34BY+bL9BH+CUO5St6BRL9iD8ddkcYVr8T1pz1N1stKRy6zMLAScsfLlYZsKL67h dKoJ5XuTadatvpcT2QMB/DCK7BbYwY6G1E3Fc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VBaQhh8M0SGoulgjZzCVQ2UkjFdtWV7Yt+dzNHvww78=; b=OKY/m2UIHlVMxqF4xEuv7SzF0T/gCTSnuiSwW0gcQ09D9xBKiBjWW0otlm8oYNriB0 qiZRaO/UaNwAIw88ASuIDH/sP0beqJxijv2mNHXfQpYkeuyuPquKb4GuLR0ffrSB/2dp dEe3RY883QO6vDqEpOriKTUeSobijgPRdF4DyFCmGtqE/ftsnijkyR9GVz62H4ref4vJ LpD1NIHn8dvuhtgibGraIwh/26QEMpv93fVFq9g9xHoCbZFeElTv8Z4xDfgCQP14/+Xy pX/gCpVAqSdx7hPEP4/oRHflcTVkjcwSyyJcDan+TY769bc4F8BG6zCho6zlMV0tPT7e G0gg== X-Gm-Message-State: AJIora9ArWItdhjdPBgHUC4HnoBMl28oblkxDOR0OAb0JdLJdg7y6OW7 g2/06EY7bL19DUg84uBbdpf7lQ== X-Google-Smtp-Source: AGRyM1sDgEvklapqUFjo5inrAdF/mgAhHliKgdgUttcbfqZDFoCqIsitSjQSSgoZ1BPm6ZU7nGW4gw== X-Received: by 2002:a17:907:7fa9:b0:711:d214:36cd with SMTP id qk41-20020a1709077fa900b00711d21436cdmr7285524ejc.600.1656575138524; Thu, 30 Jun 2022 00:45:38 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-58-216.cust.vodafonedsl.it. [188.217.58.216]) by smtp.gmail.com with ESMTPSA id b13-20020aa7c90d000000b0043564320274sm12594731edt.19.2022.06.30.00.45.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 00:45:38 -0700 (PDT) From: Tommaso Merciai To: tommaso.merciai@amarulasolutions.com Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Jacopo Mondi , Sakari Ailus , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 6/6] media: ov5693: add ov5693_of_match, dts support Date: Thu, 30 Jun 2022 09:45:25 +0200 Message-Id: <20220630074525.481790-7-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220630074525.481790-1-tommaso.merciai@amarulasolutions.com> References: <20220630074525.481790-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add ov5693_of_match. Device tree support Signed-off-by: Tommaso Merciai Reviewed-by: Jacopo Mondi Reviewed-by: Sakari Ailus Reviewed-by: Daniel Scally --- Changes since v2: - Change patch order 7 -> 6 as suggested by Sakari - Add missing signed-off as suggested by Jacopo Changes since v3: - Add reviewed-by tags, suggested by Jacopo, Krzysztof drivers/media/i2c/ov5693.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index 3c805a5a5181..5930207193c7 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -1532,10 +1532,17 @@ static const struct acpi_device_id ov5693_acpi_matc= h[] =3D { }; MODULE_DEVICE_TABLE(acpi, ov5693_acpi_match); =20 +static const struct of_device_id ov5693_of_match[] =3D { + { .compatible =3D "ovti,ov5693", }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(of, ov5693_of_match); + static struct i2c_driver ov5693_driver =3D { .driver =3D { .name =3D "ov5693", .acpi_match_table =3D ov5693_acpi_match, + .of_match_table =3D ov5693_of_match, .pm =3D &ov5693_pm_ops, }, .probe_new =3D ov5693_probe, --=20 2.25.1