From nobody Sun Apr 19 13:44:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59432CCA480 for ; Thu, 30 Jun 2022 05:58:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230285AbiF3F6U (ORCPT ); Thu, 30 Jun 2022 01:58:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229891AbiF3F6P (ORCPT ); Thu, 30 Jun 2022 01:58:15 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A009244 for ; Wed, 29 Jun 2022 22:58:12 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id cv13so17760537pjb.4 for ; Wed, 29 Jun 2022 22:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gNI2eErAlbnR33nd0lAZVKjou66LXCn6ck0SwxHv5j4=; b=d5+O04srINiHMfVNndzpsa6dNc8jJ5xaDyO5vi6a0dFIecI/i37uzbcZo+hqiDz8SX ZPAiQNVFjdhW25SzvxGfbZqLlpUJdYRZtW905YwHk3mvZOrTxzBE02a/vPIkz+hoYyGf 53zP+cQt/oYmN7A+1gGnp8pKV89GoBjHeOs+k40TTB0EGj5beyrYGx7Ue7Djk/1pReSm vddAG4P9uHV2dvOKfacbSaxrfAWH4fjrgKg/ga1D72uvEYNpd2ka9cDsLZANOXgIjPeY 9mEr3kBVR9ahZAs9Hvf6+kCYkKYd1j4jQEgJoSPfQjc/QUKzFYD2e0zLfLJFMpYDVbyY tRPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gNI2eErAlbnR33nd0lAZVKjou66LXCn6ck0SwxHv5j4=; b=vV6r4ddxrXdRR86EbvqHKNgFTm3mV6bwjkNbMjwwzJ+yowdIHk8jdSDkhX1ZufA4XG 6u7zjui0JrWdUiWKlOpEf9a2lYTuSPYaYB9+lhScDXXQwr1H7de2GXXzV6NqmmmmWtc8 3PEttuQ7JqwXz1atQ/Dvdkl0V8bCu73QrRrEFAFu6MBBTH5CG08GPi8DL7MXLFsbpQRX 0tAaOf413cYm83oqhOSPypeqrvHRyQdhRrErj5tB7/d9xinMppB1a9tPxnvpqboTfmSi LD+XjTOKmYJZeC+jkrgvFCDeIVgXldoDOaYDJA8w1ifp7lAq9BtrXqPnrz4KEmSJpF4A yUsQ== X-Gm-Message-State: AJIora/UfcVT6FUaeQVujYgxmhEBi2S167cXJBTopU+ygHjKn1N0Dfgr 1PKlRLRRf4VrlPxIlPWa8FYJEQ== X-Google-Smtp-Source: AGRyM1sp43RP8loICF5kakWaLmA+jQrwb5s0TO/6VgBGlMCeg7CSpnVA2fI5eiiDTD58heB5y3Mobw== X-Received: by 2002:a17:90b:4a03:b0:1ed:2071:e8c with SMTP id kk3-20020a17090b4a0300b001ed20710e8cmr10354265pjb.216.1656568691964; Wed, 29 Jun 2022 22:58:11 -0700 (PDT) Received: from leo-build-box.lan ([154.3.32.171]) by smtp.gmail.com with ESMTPSA id b14-20020a17090a550e00b001e31f4cc977sm3309288pji.56.2022.06.29.22.58.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 22:58:11 -0700 (PDT) From: Leo Yan To: Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Leo Yan Subject: [PATCH v2 1/5] dt-bindings: interconnect: Update property for icc-rpm path tag Date: Thu, 30 Jun 2022 13:57:18 +0800 Message-Id: <20220630055723.704605-2-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220630055723.704605-1-leo.yan@linaro.org> References: <20220630055723.704605-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" To support path tag in icc-rpm driver, the "#interconnect-cells" property is updated as enumerate values: 1 or 2. Setting to 1 means it is compatible with old DT binding that interconnect path only contains node id; if set to 2 for "#interconnect-cells" property, then the second specifier is used as a tag (e.g. vote for which buckets). Signed-off-by: Leo Yan --- .../devicetree/bindings/interconnect/qcom,rpm.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml b= /Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml index 8a676fef8c1d..16df305ea243 100644 --- a/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml @@ -45,7 +45,11 @@ properties: - qcom,sdm660-snoc =20 '#interconnect-cells': - const: 1 + description: + '1' is one cell in a interconnect specifier for the interconnect + node id, or '2' requires the interconnect node id and an extra + path tag. + enum: [ 1, 2 ] =20 clocks: minItems: 2 --=20 2.25.1 From nobody Sun Apr 19 13:44:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE5F7C43334 for ; Thu, 30 Jun 2022 05:58:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232530AbiF3F6Y (ORCPT ); Thu, 30 Jun 2022 01:58:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230308AbiF3F6R (ORCPT ); Thu, 30 Jun 2022 01:58:17 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C470DD63 for ; Wed, 29 Jun 2022 22:58:15 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id c6-20020a17090abf0600b001eee794a478so1825026pjs.1 for ; Wed, 29 Jun 2022 22:58:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6WnlHr6IrouPH/wdi+y79keal1VSMpfo6gBqx2QqUOA=; b=Gu3xvYiMouqlwZpc9/SkH6JQqvVSCOyz8MLUd5itR13depoSpnvcPr3dOMYJzktbiF lceoCUDuu8wqeRw8FLCVW8Dw6zofkzFuXjm32pB1rGj3NXxBciFb15NI/PcrOQWag2Qb X00oTwnPyCjh9Q9rvs+S2R77RtkdkvVMmXZ5vFYJtBCy8ilLP/lQDSzOoqanup5X9TEz MkL2rJM409RL7ppDjdS2NdVtoVc+W42XthkRaycBtwoBZupBeMw0d3ICYGny3vz57Kni 85c8WCJCT0Y7rraZJzNBOTCMQbkltu5an+VcD1L0YlFHmgmriaF4qHvaLlb28J1jX4eJ 7Jpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6WnlHr6IrouPH/wdi+y79keal1VSMpfo6gBqx2QqUOA=; b=ogWgV0jIEcxp4rqkW3Mrkp52wBMvhUR0xezkZGFzApT/aahFSV1blki9lo25aAdaxt E68f3bGkRugh2fOn/y1RLgFUZEuYagm+4y1ph2FjvS8r79Iqn3zbGbDhgIrzhj7SwO53 Tb+G9SEHrnLxItl4HK+NBOAXrnyiU/JuhDNV/snPUqCMg8xomwU9fezp7QzmBZKb+48I x9WuZDuSmP789NCWkX7Rser4ZEQJjz0H15enl6HfRb5IoiYPECDhINwVyHDwlrBpwqfq ruRub2OYd6aW1tNEoe+cs+GUyuiCheIh9QIYRWPTfdV9ZeOlVvu2iXg5k+HTW9/1Xl1c YyXw== X-Gm-Message-State: AJIora/5bu9bq5gr38BZqd5gYWnj9TU+6XqV7PmgpFynXenFS/LtuKc+ mq5v9y+YubY7iT78In6dCzvmyw== X-Google-Smtp-Source: AGRyM1tFYvtMedQBveBDorOasCM1TNMj/Lv00Kb+GhciVBDFT4eW3NXi3u9THxGKm+9jPDQZE/mqKw== X-Received: by 2002:a17:90b:4b48:b0:1ec:fc87:691c with SMTP id mi8-20020a17090b4b4800b001ecfc87691cmr10124494pjb.120.1656568694991; Wed, 29 Jun 2022 22:58:14 -0700 (PDT) Received: from leo-build-box.lan ([154.3.32.171]) by smtp.gmail.com with ESMTPSA id b14-20020a17090a550e00b001e31f4cc977sm3309288pji.56.2022.06.29.22.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 22:58:14 -0700 (PDT) From: Leo Yan To: Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Leo Yan , Dmitry Baryshkov Subject: [PATCH v2 2/5] interconnect: qcom: Move qcom_icc_xlate_extended() to a common file Date: Thu, 30 Jun 2022 13:57:19 +0800 Message-Id: <20220630055723.704605-3-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220630055723.704605-1-leo.yan@linaro.org> References: <20220630055723.704605-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" since there have conflict between two headers icc-rpmh.h and icc-rpm.h, the function qcom_icc_xlate_extended() is declared in icc-rpmh.h thus it cannot be used by icc-rpm driver. Move the function to a new common file icc-common.c so that allow it to be called by multiple drivers. Signed-off-by: Leo Yan Reviewed-by: Dmitry Baryshkov --- drivers/interconnect/qcom/Makefile | 3 +++ drivers/interconnect/qcom/icc-common.c | 34 ++++++++++++++++++++++++++ drivers/interconnect/qcom/icc-common.h | 13 ++++++++++ drivers/interconnect/qcom/icc-rpmh.c | 26 +------------------- drivers/interconnect/qcom/icc-rpmh.h | 1 - drivers/interconnect/qcom/sm8450.c | 1 + 6 files changed, 52 insertions(+), 26 deletions(-) create mode 100644 drivers/interconnect/qcom/icc-common.c create mode 100644 drivers/interconnect/qcom/icc-common.h diff --git a/drivers/interconnect/qcom/Makefile b/drivers/interconnect/qcom= /Makefile index 120e279a7427..8e357528185d 100644 --- a/drivers/interconnect/qcom/Makefile +++ b/drivers/interconnect/qcom/Makefile @@ -1,5 +1,8 @@ # SPDX-License-Identifier: GPL-2.0 =20 +obj-$(CONFIG_INTERCONNECT_QCOM) +=3D interconnect_qcom.o + +interconnect_qcom-y :=3D icc-common.o icc-bcm-voter-objs :=3D bcm-voter.o qnoc-msm8916-objs :=3D msm8916.o qnoc-msm8939-objs :=3D msm8939.o diff --git a/drivers/interconnect/qcom/icc-common.c b/drivers/interconnect/= qcom/icc-common.c new file mode 100644 index 000000000000..0822ce207b5d --- /dev/null +++ b/drivers/interconnect/qcom/icc-common.c @@ -0,0 +1,34 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2022 Linaro Ltd. + */ + +#include +#include + +#include "icc-common.h" + +struct icc_node_data *qcom_icc_xlate_extended(struct of_phandle_args *spec= , void *data) +{ + struct icc_node_data *ndata; + struct icc_node *node; + + node =3D of_icc_xlate_onecell(spec, data); + if (IS_ERR(node)) + return ERR_CAST(node); + + ndata =3D kzalloc(sizeof(*ndata), GFP_KERNEL); + if (!ndata) + return ERR_PTR(-ENOMEM); + + ndata->node =3D node; + + if (spec->args_count =3D=3D 2) + ndata->tag =3D spec->args[1]; + + if (spec->args_count > 2) + pr_warn("%pOF: Too many arguments, path tag is not parsed\n", spec->np); + + return ndata; +} +EXPORT_SYMBOL_GPL(qcom_icc_xlate_extended); diff --git a/drivers/interconnect/qcom/icc-common.h b/drivers/interconnect/= qcom/icc-common.h new file mode 100644 index 000000000000..33bb2c38dff3 --- /dev/null +++ b/drivers/interconnect/qcom/icc-common.h @@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (C) 2022 Linaro Ltd. + */ + +#ifndef __DRIVERS_INTERCONNECT_QCOM_ICC_COMMON_H__ +#define __DRIVERS_INTERCONNECT_QCOM_ICC_COMMON_H__ + +#include + +struct icc_node_data *qcom_icc_xlate_extended(struct of_phandle_args *spec= , void *data); + +#endif diff --git a/drivers/interconnect/qcom/icc-rpmh.c b/drivers/interconnect/qc= om/icc-rpmh.c index 8acc8e67a332..114bb8f64573 100644 --- a/drivers/interconnect/qcom/icc-rpmh.c +++ b/drivers/interconnect/qcom/icc-rpmh.c @@ -11,6 +11,7 @@ #include =20 #include "bcm-voter.h" +#include "icc-common.h" #include "icc-rpmh.h" =20 /** @@ -100,31 +101,6 @@ int qcom_icc_set(struct icc_node *src, struct icc_node= *dst) } EXPORT_SYMBOL_GPL(qcom_icc_set); =20 -struct icc_node_data *qcom_icc_xlate_extended(struct of_phandle_args *spec= , void *data) -{ - struct icc_node_data *ndata; - struct icc_node *node; - - node =3D of_icc_xlate_onecell(spec, data); - if (IS_ERR(node)) - return ERR_CAST(node); - - ndata =3D kzalloc(sizeof(*ndata), GFP_KERNEL); - if (!ndata) - return ERR_PTR(-ENOMEM); - - ndata->node =3D node; - - if (spec->args_count =3D=3D 2) - ndata->tag =3D spec->args[1]; - - if (spec->args_count > 2) - pr_warn("%pOF: Too many arguments, path tag is not parsed\n", spec->np); - - return ndata; -} -EXPORT_SYMBOL_GPL(qcom_icc_xlate_extended); - /** * qcom_icc_bcm_init - populates bcm aux data and connect qnodes * @bcm: bcm to be initialized diff --git a/drivers/interconnect/qcom/icc-rpmh.h b/drivers/interconnect/qc= om/icc-rpmh.h index d29929461c17..04391c1ba465 100644 --- a/drivers/interconnect/qcom/icc-rpmh.h +++ b/drivers/interconnect/qcom/icc-rpmh.h @@ -131,7 +131,6 @@ struct qcom_icc_desc { int qcom_icc_aggregate(struct icc_node *node, u32 tag, u32 avg_bw, u32 peak_bw, u32 *agg_avg, u32 *agg_peak); int qcom_icc_set(struct icc_node *src, struct icc_node *dst); -struct icc_node_data *qcom_icc_xlate_extended(struct of_phandle_args *spec= , void *data); int qcom_icc_bcm_init(struct qcom_icc_bcm *bcm, struct device *dev); void qcom_icc_pre_aggregate(struct icc_node *node); int qcom_icc_rpmh_probe(struct platform_device *pdev); diff --git a/drivers/interconnect/qcom/sm8450.c b/drivers/interconnect/qcom= /sm8450.c index 7e3d372b712f..e821fd0b2f66 100644 --- a/drivers/interconnect/qcom/sm8450.c +++ b/drivers/interconnect/qcom/sm8450.c @@ -12,6 +12,7 @@ #include =20 #include "bcm-voter.h" +#include "icc-common.h" #include "icc-rpmh.h" #include "sm8450.h" =20 --=20 2.25.1 From nobody Sun Apr 19 13:44:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EDAFCCA47B for ; Thu, 30 Jun 2022 05:58:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232574AbiF3F60 (ORCPT ); Thu, 30 Jun 2022 01:58:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231690AbiF3F6W (ORCPT ); Thu, 30 Jun 2022 01:58:22 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFF5DEA2 for ; Wed, 29 Jun 2022 22:58:18 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id w1-20020a17090a6b8100b001ef26ab992bso1763444pjj.0 for ; Wed, 29 Jun 2022 22:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5+gYIpHsZ47Eh2pxDFNpWAcmAPIFH2rD2QueXVUKLjQ=; b=VS39FgceRCVipIQogedEwFgAvy76jT2W0c4CCyo+PPlTZ+QmI4LuhhM5ya3OhUWgWF QPvSs0x8ZBrkGUEbnsTwwk+hTcepX62ot6CeQYGJa4CGvLU+DCyb8NimPa/IrxPKfKc2 biY1yU6Ik/GLFoi7O2JpRFUigsurzegwUbhqweNzdN84a6ZP+z1zEm7OPxlMocj3ZayL kPm3w/mh3QkHZvUL74aMKZcdARNsvXczHQbrlgZplcslom4R9KZ1S/ab7tJPyIGnxFA0 /2EPSY2vue/DvhZYkKbi76YVmTfYQfvXoPQ3BE7kumPvexU6GeJHZtmxqmZm6Wk3Fx/l l44g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5+gYIpHsZ47Eh2pxDFNpWAcmAPIFH2rD2QueXVUKLjQ=; b=y01lne6zWl0SZHhEfOxXd12yAJDonVxMACNoUkAaC/DWbosXJ3GfF1ctW+fcvn/eL+ eO0iYXPIRYxA87AOrgqpP7pU1q4c4PyT1q8XWZI83wyX/KODe+YIr1P7w446Y9uRAqwp dC5p7opTUhyVrtMjX0sP5Y+8ob5x6VgJeizSW/p2OTjSj3Y3UE1kigYm4W72XM2IxSFY u4rEU2sWUhmQLKvKeEFKyUry2pyHuk4Wld+juNDR0AWft79Qc3UsX2kOCddhthYkeDy5 ySFHfMNB8TEWLJh/Ln3gbPjZs9a5Hdvj1mbJMTq9tBgMOl0nRmbbDvGMqsvmlVsW3HJa nywQ== X-Gm-Message-State: AJIora/WQujqgU8WME63evpc/28Vn8jsOySO+nVYNueYaUjz1WO6LE3U Xh8prKVUIRw38RG/++ACtHW0UQ== X-Google-Smtp-Source: AGRyM1tnxFIiHLBlvCMuIDhD6msTNejBsQvf+bkwYfMoJ42aiYgUpwvzjCg/xjcSPx12/zKVCAfeQw== X-Received: by 2002:a17:90b:248b:b0:1ec:9869:59a0 with SMTP id nt11-20020a17090b248b00b001ec986959a0mr8110417pjb.37.1656568698192; Wed, 29 Jun 2022 22:58:18 -0700 (PDT) Received: from leo-build-box.lan ([154.3.32.171]) by smtp.gmail.com with ESMTPSA id b14-20020a17090a550e00b001e31f4cc977sm3309288pji.56.2022.06.29.22.58.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 22:58:17 -0700 (PDT) From: Leo Yan To: Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Leo Yan , Dmitry Baryshkov Subject: [PATCH v2 3/5] interconnect: qcom: icc-rpm: Change to use qcom_icc_xlate_extended() Date: Thu, 30 Jun 2022 13:57:20 +0800 Message-Id: <20220630055723.704605-4-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220630055723.704605-1-leo.yan@linaro.org> References: <20220630055723.704605-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This commit changes to use callback qcom_icc_xlate_extended(). This is a preparation for population path tags from the interconnect DT binding, it doesn't introduce functionality change for the existed DT binding without path tags. Signed-off-by: Leo Yan Reviewed-by: Dmitry Baryshkov --- drivers/interconnect/qcom/icc-rpm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qco= m/icc-rpm.c index 7e8bcbb2f5db..8c9d5cc7276c 100644 --- a/drivers/interconnect/qcom/icc-rpm.c +++ b/drivers/interconnect/qcom/icc-rpm.c @@ -16,6 +16,7 @@ #include =20 #include "smd-rpm.h" +#include "icc-common.h" #include "icc-rpm.h" =20 /* QNOC QoS */ @@ -414,7 +415,7 @@ int qnoc_probe(struct platform_device *pdev) provider->dev =3D dev; provider->set =3D qcom_icc_set; provider->aggregate =3D icc_std_aggregate; - provider->xlate =3D of_icc_xlate_onecell; + provider->xlate_extended =3D qcom_icc_xlate_extended; provider->data =3D data; =20 ret =3D icc_provider_add(provider); --=20 2.25.1 From nobody Sun Apr 19 13:44:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E366FCCA47B for ; Thu, 30 Jun 2022 05:58:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232719AbiF3F6e (ORCPT ); Thu, 30 Jun 2022 01:58:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232449AbiF3F6X (ORCPT ); Thu, 30 Jun 2022 01:58:23 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FD611038 for ; Wed, 29 Jun 2022 22:58:21 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id 128so17115691pfv.12 for ; Wed, 29 Jun 2022 22:58:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YZw35i4tD7dQYkHhZWLzGB0BrtXzLncPfNzT7OZ+gHQ=; b=MnrkkkQngsd882Zalre1QkUMe2ArvPJYExWnuAXbTuXsuU2qRxNOE5BVO1bfkeE1Re puXMlzWxtZ35+ltaHCe+oT8MWh8sKhbBMn8NR6K4m8xfG90bn0nlzaTglNagAg3JEE+J UTr/DVFQix0Z5NVe3RO+R8qPtVmQwR7RWW4TBe5IHR+QiUJR4ga6QZLCqR3aVFcqlSWu giLINCkQ8dMjmoqg1R0Ayj7DSzy9TODnxJzSNE767uqfRvp1zjHgtMLXzRiRKH44Sbpp 9v0Psj1iendUbddbUSqzWmcmtr6qg3K8euV3dZi3F7cVY05hPVukCNBooEOKPgCY8pFC SPEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YZw35i4tD7dQYkHhZWLzGB0BrtXzLncPfNzT7OZ+gHQ=; b=xOdZEbg5OtNUhdcTPBBaB1NlP3l8xTexslF1I+1p99poM3E43z2uphSQCiFrX88Tvg D5CiWA7FwA1aNQ9nuWW6eGb8A53KvqInGrLoOezAVw27xbZJvU7YFh91LfEx0Xi/95yt M/0hL8TUmZRbig9xH0YEhQjgadIJeoXE/E2YJq9zrNtE9ALwxljGLZ3hldorrRH3RScQ m/Dbl7BW0YVSyZvc5rLt0oZIpF3uo6DGII7zxM4wirQPRp9h4jQbRpewjcQ62Vl5P3e0 P6LBAvPeycZUCCAoWPvtUzrG/NNhHc9KrI8XzMgh0T1wWR/QzBSGf3KXo6HRS8fVqsVq FN+g== X-Gm-Message-State: AJIora9nUS8cckOzsOIy23+RxMA6X4PVC8s3337FWFrg80/U/8n722tX PEL6hPQ57DwVmUpuWoLQaYnpCQ== X-Google-Smtp-Source: AGRyM1s0pbVgYymjRA/AoQmD/YyxHMpMN4XE9vLP38BnWLV3SpmI5t3mWSuoR8Dl1JLjDFosnOFnlg== X-Received: by 2002:a63:8949:0:b0:40d:44d6:423e with SMTP id v70-20020a638949000000b0040d44d6423emr6141673pgd.525.1656568700955; Wed, 29 Jun 2022 22:58:20 -0700 (PDT) Received: from leo-build-box.lan ([154.3.32.171]) by smtp.gmail.com with ESMTPSA id b14-20020a17090a550e00b001e31f4cc977sm3309288pji.56.2022.06.29.22.58.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 22:58:20 -0700 (PDT) From: Leo Yan To: Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Leo Yan Subject: [PATCH v2 4/5] interconnect: qcom: icc-rpm: Support multiple buckets Date: Thu, 30 Jun 2022 13:57:21 +0800 Message-Id: <20220630055723.704605-5-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220630055723.704605-1-leo.yan@linaro.org> References: <20220630055723.704605-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The current interconnect rpm driver uses a single aggregate bandwidth to calculate the clock rates for both active and sleep clocks; therefore, it has no chance to separate bandwidth requests for these two kinds of clocks. This patch studies the implementation from interconnect rpmh driver to support multiple buckets. The rpmh driver provides three buckets for AMC, WAKE, and SLEEP; this driver only needs to use WAKE and SLEEP buckets, but we keep the same way with rpmh driver, this can allow us to reuse the DT binding and avoid to define duplicated data structures. This patch introduces two callbacks: qcom_icc_pre_bw_aggregate() is used to clean up bucket values before aggregate bandwidth requests, and qcom_icc_bw_aggregate() is to aggregate bandwidth for buckets. Signed-off-by: Leo Yan --- drivers/interconnect/qcom/icc-rpm.c | 51 ++++++++++++++++++++++++++++- drivers/interconnect/qcom/icc-rpm.h | 6 ++++ 2 files changed, 56 insertions(+), 1 deletion(-) diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qco= m/icc-rpm.c index 8c9d5cc7276c..b025fc6b97c9 100644 --- a/drivers/interconnect/qcom/icc-rpm.c +++ b/drivers/interconnect/qcom/icc-rpm.c @@ -254,6 +254,54 @@ static int __qcom_icc_set(struct icc_node *n, struct q= com_icc_node *qn, return 0; } =20 +/** + * qcom_icc_rpm_pre_bw_aggregate - cleans up values before re-aggregate re= quests + * @node: icc node to operate on + */ +static void qcom_icc_pre_bw_aggregate(struct icc_node *node) +{ + struct qcom_icc_node *qn; + size_t i; + + qn =3D node->data; + for (i =3D 0; i < QCOM_ICC_NUM_BUCKETS; i++) { + qn->sum_avg[i] =3D 0; + qn->max_peak[i] =3D 0; + } +} + +/** + * qcom_icc_bw_aggregate - aggregate bw for buckets indicated by tag + * @node: node to aggregate + * @tag: tag to indicate which buckets to aggregate + * @avg_bw: new bw to sum aggregate + * @peak_bw: new bw to max aggregate + * @agg_avg: existing aggregate avg bw val + * @agg_peak: existing aggregate peak bw val + */ +static int qcom_icc_bw_aggregate(struct icc_node *node, u32 tag, u32 avg_b= w, + u32 peak_bw, u32 *agg_avg, u32 *agg_peak) +{ + size_t i; + struct qcom_icc_node *qn; + + qn =3D node->data; + + if (!tag) + tag =3D QCOM_ICC_TAG_ALWAYS; + + for (i =3D 0; i < QCOM_ICC_NUM_BUCKETS; i++) { + if (tag & BIT(i)) { + qn->sum_avg[i] +=3D avg_bw; + qn->max_peak[i] =3D max_t(u32, qn->max_peak[i], peak_bw); + } + } + + *agg_avg +=3D avg_bw; + *agg_peak =3D max_t(u32, *agg_peak, peak_bw); + return 0; +} + static int qcom_icc_set(struct icc_node *src, struct icc_node *dst) { struct qcom_icc_provider *qp; @@ -414,7 +462,8 @@ int qnoc_probe(struct platform_device *pdev) INIT_LIST_HEAD(&provider->nodes); provider->dev =3D dev; provider->set =3D qcom_icc_set; - provider->aggregate =3D icc_std_aggregate; + provider->pre_aggregate =3D qcom_icc_pre_bw_aggregate; + provider->aggregate =3D qcom_icc_bw_aggregate; provider->xlate_extended =3D qcom_icc_xlate_extended; provider->data =3D data; =20 diff --git a/drivers/interconnect/qcom/icc-rpm.h b/drivers/interconnect/qco= m/icc-rpm.h index ebee9009301e..a49af844ab13 100644 --- a/drivers/interconnect/qcom/icc-rpm.h +++ b/drivers/interconnect/qcom/icc-rpm.h @@ -6,6 +6,8 @@ #ifndef __DRIVERS_INTERCONNECT_QCOM_ICC_RPM_H #define __DRIVERS_INTERCONNECT_QCOM_ICC_RPM_H =20 +#include + #define RPM_BUS_MASTER_REQ 0x73616d62 #define RPM_BUS_SLAVE_REQ 0x766c7362 =20 @@ -65,6 +67,8 @@ struct qcom_icc_qos { * @links: an array of nodes where we can go next while traversing * @num_links: the total number of @links * @buswidth: width of the interconnect between a node and the bus (bytes) + * @sum_avg: current sum aggregate value of all avg bw requests + * @max_peak: current max aggregate value of all peak bw requests * @mas_rpm_id: RPM id for devices that are bus masters * @slv_rpm_id: RPM id for devices that are bus slaves * @qos: NoC QoS setting parameters @@ -75,6 +79,8 @@ struct qcom_icc_node { const u16 *links; u16 num_links; u16 buswidth; + u64 sum_avg[QCOM_ICC_NUM_BUCKETS]; + u64 max_peak[QCOM_ICC_NUM_BUCKETS]; int mas_rpm_id; int slv_rpm_id; struct qcom_icc_qos qos; --=20 2.25.1 From nobody Sun Apr 19 13:44:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 771F8C43334 for ; Thu, 30 Jun 2022 05:58:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232625AbiF3F6h (ORCPT ); Thu, 30 Jun 2022 01:58:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232569AbiF3F60 (ORCPT ); Thu, 30 Jun 2022 01:58:26 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 920155F66 for ; Wed, 29 Jun 2022 22:58:24 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id m14-20020a17090a668e00b001ee6ece8368so1800564pjj.3 for ; Wed, 29 Jun 2022 22:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mOcKN2QE8NoS+NlXFqyzvr6uXu60h5tTF9oQlF/WJLc=; b=pZjsRZTAwDlI6M2jOs66KZmBv8r8btKEibDsbfGgZSpidDHtmMDdj6IC77PdRTCtqt p6uBX2yhxuwyhTrdxYbhL1BA8hOxIBCmJvd+WJ151KUlBRSyqdx8RXwGZIAm578e7gm8 fTumnZDyFspv0s9uN93zk+/M+quP154g5IbRGFKaqFw1If+UahOcYIcK50KX+PPr69xt c9CYNWVgY/B9FYW0KvmnfHzZsMUuqljPikr1xXTraKp694O7k7vmK6GtE9adBR7Vy0SE iJPpvqpBotCziNebA1k74r5bF59nrsAfeBFpwa5iRyG7x3sj9b/V2QQ38vpWeLWJ7J1s hdQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mOcKN2QE8NoS+NlXFqyzvr6uXu60h5tTF9oQlF/WJLc=; b=lWgHVXrPyfGp3N/eB5DAgEaB0emxWzq+Id3NL0qOnA6rYBMS8F68ynbiZFdMRE7EFf QkqpNCPzhLUl9MPYgMXUT+Jn/y81pGCZfTXs5wuGCYxxElenXs8JRv87d2H6APzB9RCf 00XfEkP8E+wGIVrxyaOdc5ivkCQTKSMo8aAnz9ucpPIggDNGBPgHOZ+/3gxdsEm6oG5s XzJwIj58Nlo5GCNKy6oZ0d+4PoFNgZexgb88UTiWOrhfaS8DaGDm8g9kKcdpx9A8Ixyk 4yH4RhBtyku+EWiCFGxsiT1pOcuPjjhFMzGMGO4dl/051AUW8u7VYOoWT3wA4Fnu0Ssg 3/OA== X-Gm-Message-State: AJIora9y01hLf4gbMFv2oeAdjzOxk0KwuQUcXGryAl3zrFHq3fQ/I2JD SQtElXNl31YGizPukdJH9Y7pdw== X-Google-Smtp-Source: AGRyM1vqhX+FQ8dE0YoXIV3JRUBlBXZSr4HU0Fid4k1/qav4hqj7bVmuCBytiMOacAgz/y291CanFw== X-Received: by 2002:a17:903:41d2:b0:16a:2cc4:4824 with SMTP id u18-20020a17090341d200b0016a2cc44824mr13069024ple.112.1656568703771; Wed, 29 Jun 2022 22:58:23 -0700 (PDT) Received: from leo-build-box.lan ([154.3.32.171]) by smtp.gmail.com with ESMTPSA id b14-20020a17090a550e00b001e31f4cc977sm3309288pji.56.2022.06.29.22.58.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 22:58:23 -0700 (PDT) From: Leo Yan To: Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Leo Yan Subject: [PATCH v2 5/5] interconnect: qcom: icc-rpm: Set bandwidth and clock for bucket values Date: Thu, 30 Jun 2022 13:57:22 +0800 Message-Id: <20220630055723.704605-6-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220630055723.704605-1-leo.yan@linaro.org> References: <20220630055723.704605-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This commit uses buckets for support bandwidth and clock rates. It introduces a new function qcom_icc_bus_aggregate() to calculate the aggregate average and peak bandwidths for every bucket, and also it calculates the maximum aggregate values across all buckets. The maximum aggregate values are used to calculate the final bandwidth requests. And we can set the clock rate per bucket, we use SLEEP bucket as default bucket if a platform doesn't enable the interconnect path tags in DT binding; otherwise, we use WAKE bucket to set active clock and use SLEEP bucket for other clocks. So far we don't use AMC bucket. Signed-off-by: Leo Yan --- drivers/interconnect/qcom/icc-rpm.c | 80 ++++++++++++++++++++++++----- 1 file changed, 67 insertions(+), 13 deletions(-) diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qco= m/icc-rpm.c index b025fc6b97c9..4b932eb807c7 100644 --- a/drivers/interconnect/qcom/icc-rpm.c +++ b/drivers/interconnect/qcom/icc-rpm.c @@ -302,18 +302,62 @@ static int qcom_icc_bw_aggregate(struct icc_node *nod= e, u32 tag, u32 avg_bw, return 0; } =20 +/** + * qcom_icc_bus_aggregate - aggregate bandwidth by traversing all nodes + * @provider: generic interconnect provider + * @agg_avg: an array for aggregated average bandwidth of buckets + * @agg_peak: an array for aggregated peak bandwidth of buckets + * @max_agg_avg: pointer to max value of aggregated average bandwidth + * @max_agg_peak: pointer to max value of aggregated peak bandwidth + */ +static void qcom_icc_bus_aggregate(struct icc_provider *provider, + u64 *agg_avg, u64 *agg_peak, + u64 *max_agg_avg, u64 *max_agg_peak) +{ + struct icc_node *node; + struct qcom_icc_node *qn; + int i; + + /* Initialise aggregate values */ + for (i =3D 0; i < QCOM_ICC_NUM_BUCKETS; i++) { + agg_avg[i] =3D 0; + agg_peak[i] =3D 0; + } + + *max_agg_avg =3D 0; + *max_agg_peak =3D 0; + + /* + * Iterate nodes on the interconnect and aggregate bandwidth + * requests for every bucket. + */ + list_for_each_entry(node, &provider->nodes, node_list) { + qn =3D node->data; + for (i =3D 0; i < QCOM_ICC_NUM_BUCKETS; i++) { + agg_avg[i] +=3D qn->sum_avg[i]; + agg_peak[i] =3D max_t(u64, agg_peak[i], qn->max_peak[i]); + } + } + + /* Find maximum values across all buckets */ + for (i =3D 0; i < QCOM_ICC_NUM_BUCKETS; i++) { + *max_agg_avg =3D max_t(u64, *max_agg_avg, agg_avg[i]); + *max_agg_peak =3D max_t(u64, *max_agg_peak, agg_peak[i]); + } +} + static int qcom_icc_set(struct icc_node *src, struct icc_node *dst) { struct qcom_icc_provider *qp; struct qcom_icc_node *src_qn =3D NULL, *dst_qn =3D NULL; struct icc_provider *provider; - struct icc_node *n; u64 sum_bw; u64 max_peak_bw; u64 rate; - u32 agg_avg =3D 0; - u32 agg_peak =3D 0; + u64 agg_avg[QCOM_ICC_NUM_BUCKETS], agg_peak[QCOM_ICC_NUM_BUCKETS]; + u64 max_agg_avg, max_agg_peak; int ret, i; + int bucket; =20 src_qn =3D src->data; if (dst) @@ -321,12 +365,11 @@ static int qcom_icc_set(struct icc_node *src, struct = icc_node *dst) provider =3D src->provider; qp =3D to_qcom_provider(provider); =20 - list_for_each_entry(n, &provider->nodes, node_list) - provider->aggregate(n, 0, n->avg_bw, n->peak_bw, - &agg_avg, &agg_peak); + qcom_icc_bus_aggregate(provider, agg_avg, agg_peak, &max_agg_avg, + &max_agg_peak); =20 - sum_bw =3D icc_units_to_bps(agg_avg); - max_peak_bw =3D icc_units_to_bps(agg_peak); + sum_bw =3D icc_units_to_bps(max_agg_avg); + max_peak_bw =3D icc_units_to_bps(max_agg_peak); =20 ret =3D __qcom_icc_set(src, src_qn, sum_bw); if (ret) @@ -337,12 +380,23 @@ static int qcom_icc_set(struct icc_node *src, struct = icc_node *dst) return ret; } =20 - rate =3D max(sum_bw, max_peak_bw); - - do_div(rate, src_qn->buswidth); - rate =3D min_t(u64, rate, LONG_MAX); - for (i =3D 0; i < qp->num_clks; i++) { + /* + * Use WAKE bucket for active clock, otherwise, use SLEEP bucket + * for other clocks. If a platform doesn't set interconnect + * path tags, by default use sleep bucket for all clocks. + * + * Note, AMC bucket is not supported yet. + */ + if (!strcmp(qp->bus_clks[i].id, "bus_a")) + bucket =3D QCOM_ICC_BUCKET_WAKE; + else + bucket =3D QCOM_ICC_BUCKET_SLEEP; + + rate =3D icc_units_to_bps(max(agg_avg[bucket], agg_peak[bucket])); + do_div(rate, src_qn->buswidth); + rate =3D min_t(u64, rate, LONG_MAX); + if (qp->bus_clk_rate[i] =3D=3D rate) continue; =20 --=20 2.25.1