From nobody Sat Sep 21 23:34:31 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE2B6CCA480 for ; Wed, 29 Jun 2022 03:19:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231571AbiF2DTT (ORCPT ); Tue, 28 Jun 2022 23:19:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231301AbiF2DSm (ORCPT ); Tue, 28 Jun 2022 23:18:42 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D4EA2C679; Tue, 28 Jun 2022 20:18:15 -0700 (PDT) X-UUID: 3c8677af3a3a440e87e120b35c39efa2-20220629 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.7,REQID:1c8d46cc-16ba-475e-aff8-a5ac090c5834,OB:0,LO B:20,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:100,FILE:0,RULE:Release_Ham,A CTION:release,TS:100 X-CID-INFO: VERSION:1.1.7,REQID:1c8d46cc-16ba-475e-aff8-a5ac090c5834,OB:0,LOB: 20,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:100,FILE:0,RULE:Spam_GS981B3D,A CTION:quarantine,TS:100 X-CID-META: VersionHash:87442a2,CLOUDID:d0de1ad6-5d6d-4eaf-a635-828a3ee48b7c,C OID:90a5dc5ce69d,Recheck:0,SF:28|17|19|48,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,QS:nil,BEC:nil,COL:0 X-UUID: 3c8677af3a3a440e87e120b35c39efa2-20220629 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 711735201; Wed, 29 Jun 2022 11:18:09 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Wed, 29 Jun 2022 11:18:08 +0800 Received: from localhost.localdomain (10.17.3.154) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Wed, 29 Jun 2022 11:18:06 +0800 From: Biao Huang To: David Miller , Jakub Kicinski , "Rob Herring" , Bartosz Golaszewski , "Fabien Parent" CC: Felix Fietkau , John Crispin , Sean Wang , Mark Lee , "Matthias Brugger" , , , , , , Biao Huang , Yinghua Pan , Macpaul Lin Subject: [PATCH net-next v5 10/10] net: ethernet: mtk-star-emac: enable half duplex hardware support Date: Wed, 29 Jun 2022 11:17:43 +0800 Message-ID: <20220629031743.22115-11-biao.huang@mediatek.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220629031743.22115-1-biao.huang@mediatek.com> References: <20220629031743.22115-1-biao.huang@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Current driver doesn't support half duplex correctly. This patch enable half duplex capability in hardware. Signed-off-by: Biao Huang Signed-off-by: Yinghua Pan --- drivers/net/ethernet/mediatek/mtk_star_emac.c | 30 ++++++++----------- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/et= hernet/mediatek/mtk_star_emac.c index 87c6c9bc221d..21c3668194eb 100644 --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c @@ -883,32 +883,26 @@ static void mtk_star_phy_config(struct mtk_star_priv = *priv) val <<=3D MTK_STAR_OFF_PHY_CTRL1_FORCE_SPD; =20 val |=3D MTK_STAR_BIT_PHY_CTRL1_AN_EN; - val |=3D MTK_STAR_BIT_PHY_CTRL1_FORCE_FC_RX; - val |=3D MTK_STAR_BIT_PHY_CTRL1_FORCE_FC_TX; - /* Only full-duplex supported for now. */ - val |=3D MTK_STAR_BIT_PHY_CTRL1_FORCE_DPX; - - regmap_write(priv->regs, MTK_STAR_REG_PHY_CTRL1, val); - if (priv->pause) { - val =3D MTK_STAR_VAL_FC_CFG_SEND_PAUSE_TH_2K; - val <<=3D MTK_STAR_OFF_FC_CFG_SEND_PAUSE_TH; - val |=3D MTK_STAR_BIT_FC_CFG_UC_PAUSE_DIR; + val |=3D MTK_STAR_BIT_PHY_CTRL1_FORCE_FC_RX; + val |=3D MTK_STAR_BIT_PHY_CTRL1_FORCE_FC_TX; + val |=3D MTK_STAR_BIT_PHY_CTRL1_FORCE_DPX; } else { - val =3D 0; + val &=3D ~MTK_STAR_BIT_PHY_CTRL1_FORCE_FC_RX; + val &=3D ~MTK_STAR_BIT_PHY_CTRL1_FORCE_FC_TX; + val &=3D ~MTK_STAR_BIT_PHY_CTRL1_FORCE_DPX; } + regmap_write(priv->regs, MTK_STAR_REG_PHY_CTRL1, val); =20 + val =3D MTK_STAR_VAL_FC_CFG_SEND_PAUSE_TH_2K; + val <<=3D MTK_STAR_OFF_FC_CFG_SEND_PAUSE_TH; + val |=3D MTK_STAR_BIT_FC_CFG_UC_PAUSE_DIR; regmap_update_bits(priv->regs, MTK_STAR_REG_FC_CFG, MTK_STAR_MSK_FC_CFG_SEND_PAUSE_TH | MTK_STAR_BIT_FC_CFG_UC_PAUSE_DIR, val); =20 - if (priv->pause) { - val =3D MTK_STAR_VAL_EXT_CFG_SND_PAUSE_RLS_1K; - val <<=3D MTK_STAR_OFF_EXT_CFG_SND_PAUSE_RLS; - } else { - val =3D 0; - } - + val =3D MTK_STAR_VAL_EXT_CFG_SND_PAUSE_RLS_1K; + val <<=3D MTK_STAR_OFF_EXT_CFG_SND_PAUSE_RLS; regmap_update_bits(priv->regs, MTK_STAR_REG_EXT_CFG, MTK_STAR_MSK_EXT_CFG_SND_PAUSE_RLS, val); } --=20 2.25.1