From nobody Sun Apr 26 12:18:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2639CCA479 for ; Tue, 28 Jun 2022 11:28:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345509AbiF1L2Z (ORCPT ); Tue, 28 Jun 2022 07:28:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345465AbiF1L2K (ORCPT ); Tue, 28 Jun 2022 07:28:10 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE3DAF4D; Tue, 28 Jun 2022 04:28:09 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id o10so17138236edi.1; Tue, 28 Jun 2022 04:28:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+LlLZaDtYyevN2FUYLTzNmH0PwKbstBSDwmDMRaV6wQ=; b=n7pPSVPiiSJ1+gdboLLhYJ9f2hGhbzZRAJmZl5PEMUU87GpbDbIYORHNkubL6j125d U3G7vvwWc2C/l5ESEfNezHayvDrhVYJPeLDQPmHXW+nXcyqAGxVu4bEwZYSHgzynMaIg 14hWsOCnf5YzkJE14RXt1lbyHOdu1yL0j4UtR90OXZj2wlpf8IIzBzcwVCXV0n2SqQJw ltnorUr4yOgaKyq1iTwP6B3n2r3Z285MWTN0W+q8iP46pBZnXLuKyRHqt88VjYRc2q1B 5bE8LpsiIAXZAxIGYz+IVVuijgojfzTFg7gpPmURZO1JjWnKCsBbBlAFx6MuqC2eRuFm BCZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+LlLZaDtYyevN2FUYLTzNmH0PwKbstBSDwmDMRaV6wQ=; b=j7B8TLABJx5ApwRiKTmS2TU53MdTaScqFooxoOp9EMKiAG8tPqNGpzHFdOBz8syEiU QOX2/8hcGYGpyvcYC24p7PXUKsiHgGlCUzzOrUoI0Qs6MmkDp9AXQBkJ+cB3YNaOYilp pOdavDmFKgBI4XyyjhPNw2mCmqSG1sjBhVknXn0hAerJaxa+lLOas0k3C5MMR0Gixaxd d+iQ/PMap7G+NnerKV9B5feCayQGm1t3qRzeFSIWHN0GZ/Abt7lcviMVTQ5yU8AvO2/r HtXHHtx6e5yo7d65ztBxq7fGxy/5BfuQuq3bwenqdaaZRm3qY83teaaxgjSREJCtWQcn VARw== X-Gm-Message-State: AJIora8Fb1puJZq8OYtjU+B/Rv+0r/0pcZ6jiQCsWnRz9TfMo4eux/Tl Jzicp6prL0SXiOcH//moIvg= X-Google-Smtp-Source: AGRyM1uhgE91nhjR/KZn+mG1jgfNS2BuoAiTS53aWpUhL4EPUwgHNPi54ElTY6ldhaT1A4HEavdEdQ== X-Received: by 2002:aa7:d709:0:b0:435:6ae6:5fb8 with SMTP id t9-20020aa7d709000000b004356ae65fb8mr21875688edq.161.1656415688197; Tue, 28 Jun 2022 04:28:08 -0700 (PDT) Received: from localhost.localdomain (dynamic-095-114-061-215.95.114.pool.telefonica.de. [95.114.61.215]) by smtp.googlemail.com with ESMTPSA id h6-20020aa7cdc6000000b00435720b7a1csm9456318edw.20.2022.06.28.04.28.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 04:28:07 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH RFC v1 1/8] dt-bindings: mtd: intel: lgm-nand: Fix compatible string Date: Tue, 28 Jun 2022 13:27:24 +0200 Message-Id: <20220628112731.2041976-2-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> References: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The driver which was added at the same time as the dt-bindings uses the compatible string "intel,lgm-ebunand". Use the same compatible string also in the dt-bindings. Fixes: 2f9cea8eae44f5 ("dt-bindings: mtd: Add Nand Flash Controller support= for Intel LGM SoC") Signed-off-by: Martin Blumenstingl --- Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml b/Do= cumentation/devicetree/bindings/mtd/intel,lgm-nand.yaml index 30e0c66ab0eb..763ee3e1faf3 100644 --- a/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml +++ b/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml @@ -1,7 +1,7 @@ # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2 --- -$id: http://devicetree.org/schemas/mtd/intel,lgm-nand.yaml# +$id: http://devicetree.org/schemas/mtd/intel,lgm-ebunand.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# =20 title: Intel LGM SoC NAND Controller Device Tree Bindings @@ -14,7 +14,7 @@ maintainers: =20 properties: compatible: - const: intel,lgm-nand + const: intel,lgm-ebunand =20 reg: maxItems: 6 @@ -75,7 +75,7 @@ additionalProperties: false examples: - | nand-controller@e0f00000 { - compatible =3D "intel,lgm-nand"; + compatible =3D "intel,lgm-ebunand"; reg =3D <0xe0f00000 0x100>, <0xe1000000 0x300>, <0xe1400000 0x8000>, --=20 2.36.1 From nobody Sun Apr 26 12:18:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5889C433EF for ; Tue, 28 Jun 2022 11:28:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345515AbiF1L23 (ORCPT ); Tue, 28 Jun 2022 07:28:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344317AbiF1L2P (ORCPT ); Tue, 28 Jun 2022 07:28:15 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A2A16552; Tue, 28 Jun 2022 04:28:13 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id pk21so25146688ejb.2; Tue, 28 Jun 2022 04:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=C7hxbvOysOVU/UTQ861hxTJENidUKbCv/fSaMWTU3aI=; b=Kb3GrCLoxkYt2/yVGmqqO4w8RxBfyYZ6rRu+LEu9FAzsG2xDTJNzh8tf9/B84y/aDR bOwn5BfibkkSmxciqncxsdkBGyewMT8FU18aKZ/SvMGZ+tTRZFGB9r1VdT/0TFZbe7M6 LmMDTXWIeqrViuKl8dNo1OB8sHS1F4rT47JUY8ZaDQb0B8Bu5YS+mYbsvPLD/w9MH1Vb fF/AvomeNtZA4qcdckaJjf8slVctIuc8khfDjCv078OE3FYj/ILVVt70Bh8RiwchL59/ LpchdbicFwJOTHOxjYYgkgXM4e3K8mwD95s+2mjFj7x0kuZl96pU8gCLnWNElYRi/xJk VTew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=C7hxbvOysOVU/UTQ861hxTJENidUKbCv/fSaMWTU3aI=; b=o459icN/okSIUqPfGYCJMfPFxdlhJfYSvjq9eOQHy3ft2hsj+2hJQWo0jwrY6SQn2r PkxqqL+M6MHrPTNmDpDsXC6rbBqXbMqIEJFb1e/7PPLOJXsChy79+F74INuleNVsVTmB M0iY/35Ilgx44xGtAJjsmhExLIFT317sVMrvdjdzZSySGrswQJR/36YQtLSb5SYQYCrA +LD47M++euVmfVV5+/TTAwDt1qclkxRxw6pbmqoSSXOhL4Cd3ue4akruUdX9SFgj5ub4 dDrF8omBacFqvBP+Ydu8feTkZoCFyYKL0bqP110uz9yQivPsoLBIxNFZMjc+/KKC/7wZ xyYQ== X-Gm-Message-State: AJIora/AAHgWWCVwq0x2hYihJyR9y9Ljb2JBHRI9y0l0sCzQ17zx5s3B 9iqHqdlTCMyWfb2O1Y6EfNg= X-Google-Smtp-Source: AGRyM1slseCRLwPgpXyPajn0dpOI3hl7Jgl4zNknGOXyGIQeIUZzYiCPMBFWkQQsyhJE0Hu+dqVM1Q== X-Received: by 2002:a17:907:7f1d:b0:71d:ea75:e533 with SMTP id qf29-20020a1709077f1d00b0071dea75e533mr17799271ejc.78.1656415691749; Tue, 28 Jun 2022 04:28:11 -0700 (PDT) Received: from localhost.localdomain (dynamic-095-114-061-215.95.114.pool.telefonica.de. [95.114.61.215]) by smtp.googlemail.com with ESMTPSA id h6-20020aa7cdc6000000b00435720b7a1csm9456318edw.20.2022.06.28.04.28.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 04:28:11 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH RFC v1 2/8] dt-bindings: mtd: intel: lgm-nand: Fix maximum chip select value Date: Tue, 28 Jun 2022 13:27:25 +0200 Message-Id: <20220628112731.2041976-3-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> References: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The Intel LGM NAND IP only supports two chip selects: There's only two CS and ADDR_SEL register sets. Fix the maximum allowed chip select value according to the dt-bindings. Fixes: 2f9cea8eae44f5 ("dt-bindings: mtd: Add Nand Flash Controller support= for Intel LGM SoC") Signed-off-by: Martin Blumenstingl --- Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml b/Do= cumentation/devicetree/bindings/mtd/intel,lgm-nand.yaml index 763ee3e1faf3..04f26196c4c1 100644 --- a/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml +++ b/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml @@ -51,7 +51,7 @@ patternProperties: properties: reg: minimum: 0 - maximum: 7 + maximum: 1 =20 nand-ecc-mode: true =20 --=20 2.36.1 From nobody Sun Apr 26 12:18:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 804EEC433EF for ; Tue, 28 Jun 2022 11:28:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345527AbiF1L2a (ORCPT ); Tue, 28 Jun 2022 07:28:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345207AbiF1L2P (ORCPT ); Tue, 28 Jun 2022 07:28:15 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 466F5655C; Tue, 28 Jun 2022 04:28:14 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id ge10so25095879ejb.7; Tue, 28 Jun 2022 04:28:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=L/vVPNNNi/M5hFZ14uI3yR7vQmNxehz58sZt8wiaUeE=; b=HaWubVbNaxSD+nlcHJa49uO9e6VAh9gOOIRMAfHc/SGLurGEg8A6CZo1MHioC4yM9T BF0JznCyJN2tmhkcShwNh03rwsG6BUiTv87W8haV9GF/CxjpFVr2idmrgq0UJzzXm9/a uYVinDWBpYg40+c5lzK2vpa96lAZjgm7jWCu6pIX/lqRa0EYeZFjRqRDsg1d9NjGH15b CazDQm2NN45LJqPwSDHocRDtYiDhXJ7BJjO1W8qbAzWtWcLAiCrOXcF1vYw0WWHSIGlr IYM/6MascnMHRGlSBL5Z137juzIVHeHJAX8YM02AKrWrUgl+7SN4HmN2Y3Rhi5RWeAVI 61jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L/vVPNNNi/M5hFZ14uI3yR7vQmNxehz58sZt8wiaUeE=; b=wLLTPWSV7xzPhjNI1nw8M2BIKYosBn3TLDvAcP/QNbf2Egt/diHO+39f0sNJuY+uso L6ssjktsNcu8v4O1e1blp8E0p4yHYbGs2ZgZ+gFTP+Lqe5T1zFG0bsSYB2vpVk+Bp2GX GN9l3WCZ+6bJL8Cc+dq0Ml0WTHzkgXubxxzHtfwUXbx5J9y8/agwK95VaLT4IrhZzVm7 lzBfrkAGtaqhYEeIiC1TxIQ8MEOmVd9NrCiOwkUeRjByx5Ici23NQdg9L3gjmTqvF+BP /sZuqr1X/xN59GfeS5FNWp0twrUdSrF8h/or/ge+2hKI8OySJkqMFPiAs/U/HbbAP0Iu tQ4g== X-Gm-Message-State: AJIora+04Fg200SSJePzyglOr1G77UR4g+5XWRZDBcxgBv2j/bRQuYOm 1sypx9sv50DaAG1VPHZzHtc= X-Google-Smtp-Source: AGRyM1tn25cwZFHS/DKbUQZdk6M3oiSNF7RkIMRFB9m1OpkuIcAdUMVXZJI1tQCvfXCkFMcBZmC9pg== X-Received: by 2002:a17:907:6d1d:b0:726:363e:cca3 with SMTP id sa29-20020a1709076d1d00b00726363ecca3mr17142850ejc.713.1656415692784; Tue, 28 Jun 2022 04:28:12 -0700 (PDT) Received: from localhost.localdomain (dynamic-095-114-061-215.95.114.pool.telefonica.de. [95.114.61.215]) by smtp.googlemail.com with ESMTPSA id h6-20020aa7cdc6000000b00435720b7a1csm9456318edw.20.2022.06.28.04.28.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 04:28:12 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH RFC v1 3/8] mtd: rawnand: intel: Read the chip-select line from the correct OF node Date: Tue, 28 Jun 2022 13:27:26 +0200 Message-Id: <20220628112731.2041976-4-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> References: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The chip select has to be read from the flash node which is a child node of the NAND controller. Fixes: 0b1039f016e8a3 ("mtd: rawnand: Add NAND controller support on Intel = LGM SoC") Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nan= d/raw/intel-nand-controller.c index e91b879b32bd..3df3f32423f9 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -16,6 +16,7 @@ #include #include =20 +#include #include #include #include @@ -580,6 +581,7 @@ static int ebu_nand_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; struct ebu_nand_controller *ebu_host; + struct device_node *chip_np; struct nand_chip *nand; struct mtd_info *mtd; struct resource *res; @@ -604,7 +606,12 @@ static int ebu_nand_probe(struct platform_device *pdev) if (IS_ERR(ebu_host->hsnand)) return PTR_ERR(ebu_host->hsnand); =20 - ret =3D device_property_read_u32(dev, "reg", &cs); + chip_np =3D of_get_next_child(dev->of_node, NULL); + if (!chip_np) + return dev_err_probe(dev, -EINVAL, + "Could not find child node for the NAND chip\n"); + + ret =3D of_property_read_u32(chip_np, "reg", &cs); if (ret) { dev_err(dev, "failed to get chip select: %d\n", ret); return ret; @@ -660,7 +667,7 @@ static int ebu_nand_probe(struct platform_device *pdev) writel(ebu_host->cs[cs].addr_sel | EBU_ADDR_MASK(5) | EBU_ADDR_SEL_REGEN, ebu_host->ebu + EBU_ADDR_SEL(cs)); =20 - nand_set_flash_node(&ebu_host->chip, dev->of_node); + nand_set_flash_node(&ebu_host->chip, chip_np); =20 mtd =3D nand_to_mtd(&ebu_host->chip); if (!mtd->name) { --=20 2.36.1 From nobody Sun Apr 26 12:18:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 226CFCCA47F for ; Tue, 28 Jun 2022 11:28:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345536AbiF1L2d (ORCPT ); Tue, 28 Jun 2022 07:28:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345360AbiF1L2R (ORCPT ); Tue, 28 Jun 2022 07:28:17 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5D7E6582; Tue, 28 Jun 2022 04:28:15 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id r18so9230163edb.9; Tue, 28 Jun 2022 04:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z/aCGOJhN5hhaa/wf3udZzref7WmmFge/G1kcYg31ZE=; b=CbVDEz1YIhN/CZwz7Po586XwhR1tDqMnUEZiyAz09iRURJR1bDxDRt7GkakaoBMvQV FUKWaFOIETEp7V9O5XgdKEJA7NWf0anlbK2XF9IqbXY517vNSaPnGajPw8WWH79aWnnX Yo1w8ea+6diWxwLYIVivAE/vLlBVoF0SZx3B1avkEBg7d9QO8fDyZ8Zi+70erfT+lKNz Bi+Yy7E3VEodPI3JUG8C94mNeymMndsANF/8MYmTzaIyU7hHK3O0DfHuGsmAs9nxM+xU UhPCe3/LVi3DPW2K3QvEGQUOJV5uPlI9uEmA8bb6T2ZeckMY8mVoQzR9aKbpQayk89iy pPOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z/aCGOJhN5hhaa/wf3udZzref7WmmFge/G1kcYg31ZE=; b=Z/lLmGyE+thvyyVL6isAYNhYTfybPIHULoeSkrw+Z/62HcsBqZSK3IGPMV2QgFAWuG Rshhc/nUA+f764GyjxBA6l8g6UwlnMPZUA6sTb9fFizeBVdFG6rrPx8lqWtpml9GJ9UG vmB+EWiJsVPnuh0hZ+Eq1XAEYkgI4c6Iut5T33IsFLJxaUOokZkLcq6w0HYggKvkbc0C JAXA4pzIoLHhBqmoHtC62FRApg7evGsOfB7X55aOoKmViiKnYf5rFtoEzhQrQc7JUk1R /RhoQsPn4/xIYclzD/EpZE42HtrK0Lj2ItycnAF9tt5IsrXjYsX+p7RZeu76yaOTt1mW 0+7g== X-Gm-Message-State: AJIora+LbvOiN6v6x42WmFgXIGQF179etHTFlh5xkmrGT5vJv9xa5AF4 NMsP3YTXlT8RSp+fdZwYlxw= X-Google-Smtp-Source: AGRyM1ty2755DziH+VQSppOQlJavQFFOcOu1ZHriPAA4F7jhidLeXeluQ2PnRW4xmThrhoABTwVnTw== X-Received: by 2002:a05:6402:1c09:b0:435:6562:e70d with SMTP id ck9-20020a0564021c0900b004356562e70dmr22237136edb.203.1656415694067; Tue, 28 Jun 2022 04:28:14 -0700 (PDT) Received: from localhost.localdomain (dynamic-095-114-061-215.95.114.pool.telefonica.de. [95.114.61.215]) by smtp.googlemail.com with ESMTPSA id h6-20020aa7cdc6000000b00435720b7a1csm9456318edw.20.2022.06.28.04.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 04:28:13 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH RFC v1 4/8] mtd: rawnand: intel: Remove undocumented compatible string Date: Tue, 28 Jun 2022 13:27:27 +0200 Message-Id: <20220628112731.2041976-5-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> References: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The "intel,nand-controller" compatible string is not part of the dt-bindings. Remove it from the driver as it's not supposed to be used without any documentation for it. Fixes: 0b1039f016e8a3 ("mtd: rawnand: Add NAND controller support on Intel = LGM SoC") Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nan= d/raw/intel-nand-controller.c index 3df3f32423f9..056835fd4562 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -723,7 +723,6 @@ static int ebu_nand_remove(struct platform_device *pdev) } =20 static const struct of_device_id ebu_nand_match[] =3D { - { .compatible =3D "intel,nand-controller" }, { .compatible =3D "intel,lgm-ebunand" }, {} }; --=20 2.36.1 From nobody Sun Apr 26 12:18:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58F67C43334 for ; Tue, 28 Jun 2022 11:28:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345547AbiF1L2h (ORCPT ); Tue, 28 Jun 2022 07:28:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345435AbiF1L2S (ORCPT ); Tue, 28 Jun 2022 07:28:18 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB18CA199; Tue, 28 Jun 2022 04:28:16 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id ay16so25118946ejb.6; Tue, 28 Jun 2022 04:28:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5wzm8aXQ7jfEpVVa+hUFH1hW1Ct7FIztd1NOXIDzjfE=; b=XH74Pz5YOnB4omNJDTWscDju8Y67UOhoqHfCkZwCx5LLSKKYOOXLjuFrhSnLXqhXB3 abm4wLC2wi/67TJtYAa/4rvjJpmbmWWbhJcLWdWed24A+CE9iREckGSewd0sZjKYPvQ1 e/O2CTyyhBBO+MkRTN4w1gteEFLZI4Dfa8zZGpVa4eYAKrMbkhl8MvxT0Hy9OPUehRhh HZI9X4q0Db5Ykuh0H8l9PpS5SNzz3CtijZO6JId8OMZvKYF9I91K5V/kuYyqvO6JiLbx LqrDKHy7KfRuBMfCTnh1rYHX65tbNn3DWi9TBAqbrkRmMUxrt4QU6HUyQhjgKNE+tKaZ UNbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5wzm8aXQ7jfEpVVa+hUFH1hW1Ct7FIztd1NOXIDzjfE=; b=gx+4v61TF9m4j+8nAuIGpIdlt2Gen8+3E/jlJ5ORQIEkbTiM+MIJ9XlUyh/nbzeuiL LcdnwEvrVVI2JtVPAP6q8hfg8iEbQ9UNL9dMSoycGGxZLrX1b6950r9qn9vNm0gLBC8P BEK8kn7/lOc1yZvqNO5vN7vsZA1mNZCT2bHTz9U3SOuSrKkr1zTiN9b5asocJ8RoPA6a yRdz6SrJz7eCRJrVE9AWx+lwTJF0F/LwDVy6Qq92ZcP6Z/iAVwzUBm6b7CNnQtJd1+Vn kHu8iroWNNdvbgrQmB7+qB90/+GfhBT5j6ZYA7Ya4KtIMgXyD+WTpS06Nm+q1lkg05B/ u5+Q== X-Gm-Message-State: AJIora9YMGi5eYh8smqebn5Pw6qWr7Cec9pj+3szsJqQrZ8JnNoY30af We3LqEne2x3pW72sK5hfrX4= X-Google-Smtp-Source: AGRyM1sDsDKOUmH0i6QVDvM2Jlx6H9R/wRxIYS1gH4CBNfulyXXOOVydVqD0/buMOXrZ4rCojhNJPQ== X-Received: by 2002:a17:906:4fd4:b0:722:f223:8d86 with SMTP id i20-20020a1709064fd400b00722f2238d86mr17271003ejw.558.1656415695311; Tue, 28 Jun 2022 04:28:15 -0700 (PDT) Received: from localhost.localdomain (dynamic-095-114-061-215.95.114.pool.telefonica.de. [95.114.61.215]) by smtp.googlemail.com with ESMTPSA id h6-20020aa7cdc6000000b00435720b7a1csm9456318edw.20.2022.06.28.04.28.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 04:28:14 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH RFC v1 5/8] mtd: rawnand: intel: Don't re-define NAND_DATA_IFACE_CHECK_ONLY Date: Tue, 28 Jun 2022 13:27:28 +0200 Message-Id: <20220628112731.2041976-6-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> References: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" NAND_DATA_IFACE_CHECK_ONLY is already defined in include/linux/mtd/rawnand.h which is also included by the driver. Drop the re-definition from the intel-nand-controller driver. Fixes: 0b1039f016e8a3 ("mtd: rawnand: Add NAND controller support on Intel = LGM SoC") Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nan= d/raw/intel-nand-controller.c index 056835fd4562..3df16d5ecae8 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -100,8 +100,6 @@ =20 #define HSNAND_ECC_OFFSET 0x008 =20 -#define NAND_DATA_IFACE_CHECK_ONLY -1 - #define MAX_CS 2 =20 #define USEC_PER_SEC 1000000L --=20 2.36.1 From nobody Sun Apr 26 12:18:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD982C433EF for ; Tue, 28 Jun 2022 11:28:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345552AbiF1L2l (ORCPT ); Tue, 28 Jun 2022 07:28:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345459AbiF1L2S (ORCPT ); Tue, 28 Jun 2022 07:28:18 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8FC7B863; Tue, 28 Jun 2022 04:28:17 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id u12so25057171eja.8; Tue, 28 Jun 2022 04:28:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8kX3dUaWuulkCwAMYcRWq/5OXE7N5XumBNg6KTJej40=; b=XsIH+2HQO1P1rHXYTPerAkTGiIM2ijXN6e2a8nA1YzRXVJbepZFT2gr/QLqLOsdi+U R6G1p3JiVf6mXXRNy2NwloPk+XpjErzFnhr9+k90lHUa87Hw8EtMPJv2yTM0jvL5jxIy cg3XL87XUQuJOf2cG+9nqf5K1DHKQ+mKiVBvUSyODcI2i/WNvHG5edVqsGJ1J348XXk8 J97p/fwJN94dnl6V9doQJxzxuZbfvkOO23QWSPDehyMLfsm/H33kznaTuk0VMa0a47k1 4sGwUw1gascOFrbo6akRUDX+vbAX3Kwt74m+SlY72fmFvNUUh5mTVdylQ8v35dmhAqxx kUeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8kX3dUaWuulkCwAMYcRWq/5OXE7N5XumBNg6KTJej40=; b=kWCY0F0Ujbf/uOlPvLp5WSk+h6hs7gbEttnuRdF8zqD6CV6s8FBtVx7bDhGj5Rv9/T eBLc/Jd7MY00SL33az7h9osn3R93VPb6XhwrgV18ZTR+kQNqSjTi2SKq0ai2plcNA/rj AY2hiyQfDted9HvDfPW/8xDiQk+6gsDZuHJKmc4Kcenwj64WjGY69fv/B9J3rfFzXva0 BH3Hlt4TqW2252p2u5I/jttaK6X+u1+vfX2DNIrVwh2mp3KZacGj3SUi8taqwonbGDFT VjVBe+OLHFUcg/k1lI0qTJvaRcmvRW2rQ3I/vg5CO86B0F5E1L8+zyktJHqxt/GDrRRY LqXQ== X-Gm-Message-State: AJIora+eyUUANRUqzM/9qjuG7jNSy8SLo5vdXGVx6NA/x6G0onWf2fYT qivp/yE+sh5ZhAYv8jmxW74= X-Google-Smtp-Source: AGRyM1skiyvCQpAlrk4WuoP4RqWyZwZfLZtvvrUmns96lKuveEOF6JxVfQfbbceXtsM4XMNcuXhTAg== X-Received: by 2002:a17:906:7315:b0:711:db45:af4c with SMTP id di21-20020a170906731500b00711db45af4cmr16554359ejc.412.1656415696584; Tue, 28 Jun 2022 04:28:16 -0700 (PDT) Received: from localhost.localdomain (dynamic-095-114-061-215.95.114.pool.telefonica.de. [95.114.61.215]) by smtp.googlemail.com with ESMTPSA id h6-20020aa7cdc6000000b00435720b7a1csm9456318edw.20.2022.06.28.04.28.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 04:28:16 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH RFC v1 6/8] mtd: rawnand: intel: Remove unused nand_pa member from ebu_nand_cs Date: Tue, 28 Jun 2022 13:27:29 +0200 Message-Id: <20220628112731.2041976-7-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> References: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The nand_pa member from struct ebu_nand_cs is only written but never read. Remove this unused and unneeded member. Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nan= d/raw/intel-nand-controller.c index 3df16d5ecae8..de4f85368988 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -106,7 +106,6 @@ =20 struct ebu_nand_cs { void __iomem *chipaddr; - dma_addr_t nand_pa; u32 addr_sel; }; =20 @@ -626,7 +625,6 @@ static int ebu_nand_probe(struct platform_device *pdev) ebu_host->cs[cs].chipaddr =3D devm_ioremap_resource(dev, res); if (IS_ERR(ebu_host->cs[cs].chipaddr)) return PTR_ERR(ebu_host->cs[cs].chipaddr); - ebu_host->cs[cs].nand_pa =3D res->start; =20 ebu_host->clk =3D devm_clk_get(dev, NULL); if (IS_ERR(ebu_host->clk)) --=20 2.36.1 From nobody Sun Apr 26 12:18:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49A64C433EF for ; Tue, 28 Jun 2022 11:28:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345521AbiF1L2t (ORCPT ); Tue, 28 Jun 2022 07:28:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345519AbiF1L2a (ORCPT ); Tue, 28 Jun 2022 07:28:30 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2FA310565; Tue, 28 Jun 2022 04:28:18 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id u12so25058020eja.8; Tue, 28 Jun 2022 04:28:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Wqgc6jUPRcLl2k1wjcuUn82u931h34UR3GkTMv8F/kk=; b=T95YBreZPHTSDKz9UPS5xFBpfWAVG8hi6XrIHo7W9zdKnDZlexZmx9ONBDVkhTa9ws L8QQ8OLu6Ver0m5jCahivuQrSXNQ90kJzWweUUYjzjcbYB9cdf3HBGtPB4qpxD3TFS6a UDP5sxqwtjdY+69yYYwkcvZECJW/fRPUHt7XoUuVoS7Kt2QUgZxyLXiRsHr2h2tuR9cP hrjCQcJFDxdwN/LWyB7bLCY8pY5e3Ks3rpeKYwce+THJ8BJNc+4CoZRa6rXnk/MXIFVD L22apaVIqSmKSwWsGsMGrVHhIE0KALKi/afSsBzevtO0jD2IEyA7tTqu3Em2Pw+YYZWa Iq2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Wqgc6jUPRcLl2k1wjcuUn82u931h34UR3GkTMv8F/kk=; b=1alQj/rPdj5Gxv0Lz8lttGxflYG0dNeqiqvcd26UQVFHrWtAMIzjVSVd3Tmt+F0fBu 3Z7xUu+CQj5+vVg28jmMHURhXKCmzeo4B1BZxy9PGvsxJshBZz0uMDDaWD9rQ4/+6m4T FueHg8x5GDTIh2bfynl35KSrduFIK4lpVL/1op1tDdjAvSyQLQzsgU2hXCOBTWyAhNgV ju5aQpXHPI06WBlXDQID9miWiZGrjOp3UEhkFB9fJLx2wKjPXGNuqRQZrj4AAK9Y0sq/ O6VB51JK2c7fFj2axt1ZN0fdQi25ZMn4ltZmGVdrfg12t6sa/73P8pBLdo+04f4+gUhw OD7A== X-Gm-Message-State: AJIora9LG0z9zaAJNuun0TpdePtPhWBfRNE3lS+8zijLBA31p5wo/rI5 Bw/7LRhwPMUExQwcPuNEiIs= X-Google-Smtp-Source: AGRyM1uI8tzxdpgnoE1YZHUjY+YKpwDRC1XmWEmYBE3VDOktzn/VoqQrNVoFIeXHaES1lKfRHOvuCQ== X-Received: by 2002:a17:906:58d5:b0:722:fc0b:305a with SMTP id e21-20020a17090658d500b00722fc0b305amr16784769ejs.251.1656415697498; Tue, 28 Jun 2022 04:28:17 -0700 (PDT) Received: from localhost.localdomain (dynamic-095-114-061-215.95.114.pool.telefonica.de. [95.114.61.215]) by smtp.googlemail.com with ESMTPSA id h6-20020aa7cdc6000000b00435720b7a1csm9456318edw.20.2022.06.28.04.28.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 04:28:17 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH RFC v1 7/8] mtd: rawnand: intel: Remove unused clk_rate member from struct ebu_nand Date: Tue, 28 Jun 2022 13:27:30 +0200 Message-Id: <20220628112731.2041976-8-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> References: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The clk_rate member from struct ebu_nand is only written but never read. Remove this unused and unneeded member. Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nan= d/raw/intel-nand-controller.c index de4f85368988..e486db11ecc3 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -118,7 +118,6 @@ struct ebu_nand_controller { struct dma_chan *dma_tx; struct dma_chan *dma_rx; struct completion dma_access_complete; - unsigned long clk_rate; struct clk *clk; u32 nd_para0; u8 cs_num; @@ -636,7 +635,6 @@ static int ebu_nand_probe(struct platform_device *pdev) dev_err(dev, "failed to enable clock: %d\n", ret); return ret; } - ebu_host->clk_rate =3D clk_get_rate(ebu_host->clk); =20 ebu_host->dma_tx =3D dma_request_chan(dev, "tx"); if (IS_ERR(ebu_host->dma_tx)) { --=20 2.36.1 From nobody Sun Apr 26 12:18:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A076C433EF for ; Tue, 28 Jun 2022 11:28:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345558AbiF1L2q (ORCPT ); Tue, 28 Jun 2022 07:28:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345496AbiF1L2U (ORCPT ); Tue, 28 Jun 2022 07:28:20 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B85B410543; Tue, 28 Jun 2022 04:28:18 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id r18so9230163edb.9; Tue, 28 Jun 2022 04:28:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wSWuOS2cAYv5FuJkZUEc6ND5j48qnvL32xgmlNFYci4=; b=FvZMPG4RvTvduiJLbxdgkpBmHO0eivfuDB3c9SxChryaMNJW+RHsG0LmEDG9Dw19sU +7kHR0ctkFPFGOzNyssScuN0/V6YJe1/jvh9gInfgAzF6JsMIKuFIEyXLrCsof1hI6uN ZkQgi842QELzR98SBpzr4fT6W/EvvNFPTkJlL2EMmHMiuCjvTXVkGI+ZQgEeXhmKYkdd zFWcZrdkpewXgyHVxaAEbaXRvd+LMr44fGqNdY4wToMrbyw8vJdaEaDMhAE92k31vfoq igJWVXzBZ29TByMze6b7uWTfch6DYTBA4eItcWvNKFVAqGqKk/g6Vzz4ucX1bg8aMnps vSsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wSWuOS2cAYv5FuJkZUEc6ND5j48qnvL32xgmlNFYci4=; b=zA+DBYjucJ6qe1DQ5fnduSRYG/JU41PaVOASftNJxEur2G0GSyt1Zw3NouOLbWsgsQ tpgaxqYKyMVtBIIu1wZlYEUSExWJ6ilwboJibjjy7TOCZ1T+0B+xd3pgLIXYXpR80Iby uzlC3HKVNIJiBpoPaSPwi7xF+Z3LkvzAlEvvT/Xix69YCXoZbelTbdOTWEauwpAn5Sas iftMp9ZQ4syjiu12loojI7LGiUxg7CAg5eqMIpGdgL29pIwQipWJquDSQhabu5ohIHcB Nk5tqB+vxhRq9Ksoplxrq91Rk4v6n4rvo1VmbJZ6tSy+9pYz4sJ+WroWoexd3nwrKkE0 nA8Q== X-Gm-Message-State: AJIora+MlmDy8YjMpGgNnnjUtzHBIuE5Pbk+s+U6pl5AqRG1I/Wg3ZsT sNlS/s9k3o6XpLQm0U9OjkM= X-Google-Smtp-Source: AGRyM1tN9+xICqng9ViA9oB4fb9cf2sQb53hvOku9jNJTaaO+oR/dcUdswOIf+hv1Nr6y/+uWwoFfw== X-Received: by 2002:aa7:c7c4:0:b0:431:75d6:6b3 with SMTP id o4-20020aa7c7c4000000b0043175d606b3mr22099442eds.280.1656415698324; Tue, 28 Jun 2022 04:28:18 -0700 (PDT) Received: from localhost.localdomain (dynamic-095-114-061-215.95.114.pool.telefonica.de. [95.114.61.215]) by smtp.googlemail.com with ESMTPSA id h6-20020aa7cdc6000000b00435720b7a1csm9456318edw.20.2022.06.28.04.28.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 04:28:17 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH RFC v1 8/8] mtd: rawnand: intel: Use devm_platform_ioremap_resource_byname() Date: Tue, 28 Jun 2022 13:27:31 +0200 Message-Id: <20220628112731.2041976-9-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> References: <20220628112731.2041976-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Switch from open-coded platform_get_resource_byname() and devm_ioremap_resource() to devm_platform_ioremap_resource_byname() where possible to simplify the code. Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nan= d/raw/intel-nand-controller.c index e486db11ecc3..d4a0987e93ac 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -592,13 +592,11 @@ static int ebu_nand_probe(struct platform_device *pde= v) ebu_host->dev =3D dev; nand_controller_init(&ebu_host->controller); =20 - res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "ebunand"); - ebu_host->ebu =3D devm_ioremap_resource(&pdev->dev, res); + ebu_host->ebu =3D devm_platform_ioremap_resource_byname(pdev, "ebunand"); if (IS_ERR(ebu_host->ebu)) return PTR_ERR(ebu_host->ebu); =20 - res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "hsnand"); - ebu_host->hsnand =3D devm_ioremap_resource(&pdev->dev, res); + ebu_host->hsnand =3D devm_platform_ioremap_resource_byname(pdev, "hsnand"= ); if (IS_ERR(ebu_host->hsnand)) return PTR_ERR(ebu_host->hsnand); =20 @@ -620,8 +618,8 @@ static int ebu_nand_probe(struct platform_device *pdev) ebu_host->cs_num =3D cs; =20 resname =3D devm_kasprintf(dev, GFP_KERNEL, "nand_cs%d", cs); - res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, resname); - ebu_host->cs[cs].chipaddr =3D devm_ioremap_resource(dev, res); + ebu_host->cs[cs].chipaddr =3D devm_platform_ioremap_resource_byname(pdev, + resname); if (IS_ERR(ebu_host->cs[cs].chipaddr)) return PTR_ERR(ebu_host->cs[cs].chipaddr); =20 --=20 2.36.1