From nobody Sun Apr 19 20:36:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BA89C43334 for ; Mon, 27 Jun 2022 15:05:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237625AbiF0PFG (ORCPT ); Mon, 27 Jun 2022 11:05:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237521AbiF0PFB (ORCPT ); Mon, 27 Jun 2022 11:05:01 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73C1B1759E for ; Mon, 27 Jun 2022 08:04:59 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id i1so8994447wrb.11 for ; Mon, 27 Jun 2022 08:04:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rpdfidpXpaazosoDOCbj0RBJV66iHVFwcJEcEN756BA=; b=HSNeFexte5YkNrSfmpa24bzpLSXiYVRqoRKgeLPFcCWAvFPnSgrKiQA4645Db6YcDV yKY2H+NIK0Yu7fS7aY00WqUc79oeuRg2g2YBRK3zu2E9cePfSRHr5FuecOL0EaoqwyQJ R38CdPHI63ndISKRhryCUirI/1ZO7jft5dQEg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rpdfidpXpaazosoDOCbj0RBJV66iHVFwcJEcEN756BA=; b=j16GT28TVSEWpo6ZP3yMghEcZgBao+O/onU3B6Ui6mbl3CUe/LyYH4tC0PF4ZlI1kZ ngYuUwzeR5iTw/th0V1maCFBETRhUZSb5QlcCtB3/CveAAD2YPIVWRgBPqtj+pZ+PkPo JX5Tna+mIAxBgeofh2JwoVvXV1JiSYLukiW3juFepW5udZOubh+AuvD8WMPfeGKYxjwK 4Nz6ngiPJ5ihJNUjYCOF7+jgMNBpeeMIAcD2gkWkrzdaFhCZlmW6E/8wGXa4rhv7clKK jP5B+oZ7LtFDzGJrBTmikPEDC+GJUEuTXwTOKp8ymgNhOAWBbqLaz5a7SF/dGSNMXpCs qlfQ== X-Gm-Message-State: AJIora8J9oOQumN1xjv3hNJ6eZB+SUD0ErnQS/slngnGThOmpqGpgdiY zPV9fBw4PzM1OIzQ7nTlTP6biA== X-Google-Smtp-Source: AGRyM1ugjMfso+GuSpxwGlBX35ok7y0Cmr7FXEAySzs+qOBy37hvkpgpQ9Zblc9e7HrHHRK7lQqhvg== X-Received: by 2002:a05:6000:1689:b0:218:3fb1:fd30 with SMTP id y9-20020a056000168900b002183fb1fd30mr12607196wrd.302.1656342298051; Mon, 27 Jun 2022 08:04:58 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-58-216.cust.vodafonedsl.it. [188.217.58.216]) by smtp.gmail.com with ESMTPSA id d18-20020adfe852000000b0021ba3d1f2a0sm10581250wrn.48.2022.06.27.08.04.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 08:04:57 -0700 (PDT) From: Tommaso Merciai Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Tommaso Merciai , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/7] media: ov5693: count num_supplies using array_size Date: Mon, 27 Jun 2022 17:04:47 +0200 Message-Id: <20220627150453.220292-2-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220627150453.220292-1-tommaso.merciai@amarulasolutions.com> References: <20220627150453.220292-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Instead of hardcode OV5693_NUM_SUPPLIES in a define is better use ARRAY_SIZE function to count the number of supplies from ov5693_supply_names array Signed-off-by: Tommaso Merciai Reviewed-by: Jacopo Mondi --- drivers/media/i2c/ov5693.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index 117ff5403312..f410333c4c67 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -127,11 +127,15 @@ #define OV5693_LINK_FREQ_419_2MHZ 419200000 #define OV5693_PIXEL_RATE 167680000 =20 -/* Miscellaneous */ -#define OV5693_NUM_SUPPLIES 2 - #define to_ov5693_sensor(x) container_of(x, struct ov5693_device, sd) =20 +static const char * const ov5693_supply_names[] =3D { + "avdd", /* Analog power */ + "dovdd", /* Digital I/O power */ +}; + +#define OV5693_NUM_SUPPLIES ARRAY_SIZE(ov5693_supply_names) + struct ov5693_reg { u32 reg; u8 val; @@ -352,11 +356,6 @@ static const s64 link_freq_menu_items[] =3D { OV5693_LINK_FREQ_419_2MHZ }; =20 -static const char * const ov5693_supply_names[] =3D { - "avdd", - "dovdd", -}; - static const char * const ov5693_test_pattern_menu[] =3D { "Disabled", "Random Data", --=20 2.25.1 From nobody Sun Apr 19 20:36:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9880BC433EF for ; Mon, 27 Jun 2022 15:05:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237656AbiF0PFK (ORCPT ); Mon, 27 Jun 2022 11:05:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236093AbiF0PFC (ORCPT ); Mon, 27 Jun 2022 11:05:02 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C54C17593 for ; Mon, 27 Jun 2022 08:05:01 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id v14so13488054wra.5 for ; Mon, 27 Jun 2022 08:05:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pGYlZSXrL+oaB0Q/zXs3LZ4NFxxmWuNHZP0D34FWGxY=; b=aVcPlY/e/m99y/qGbVvDjDSjv/2ydjwyEBwpEtzTxs+DDF8/2tInE4vWkkQs47wIkw Bp+GvBBrcJx8/tQaaHMaUaJpsQSQHNffH45vGnobt7SlC0tAfLVXCtmEUahLfiSTl91l ZnKd2OMdOSYA0L5ZWwedTNeQvtlZrkxFhz9Xc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pGYlZSXrL+oaB0Q/zXs3LZ4NFxxmWuNHZP0D34FWGxY=; b=HAxSE75+9/DjB7Mz/Bwh0ZiEdFl2YlmGkGKPj47DaKy/k5+tqNncopSI89J/GFl9ss ilnJ6msIR7waBKsoNWjZYrlnrhXZDuqGXCA+1NionRrTzt0KYvZSnqIMeLLDxqe3L04y Wyyb4nsFyQVFwHgtRTZydVusIxLMvkrGOPB9xpzecN0Manb/NHFMswG0+ryIYtLTUHkL nvTUADta2PM1pXdun1OqXq/y+fCG2FZsEux+Dp1lYevhTAnZDVeXccwX7xpIeqoWOdc/ xCX7PO7mIeh4L19BGZZnj3ZbnhWu/RVU2aUy1WIK7BT+5uV3LisTEf0cAm9YKG0C5rra tZTA== X-Gm-Message-State: AJIora/ft/xuXAeN74Zm4aLV3C29JJOiU3NHz9d0ed+ocl8IsmaAG75Q M1mWSkZdfr5poayVh5ORM4M0zg== X-Google-Smtp-Source: AGRyM1td5t3N3MSQv0AhcCYUAv+rIMiCvLzazaY2pmGLkqXdPiWEzt+KjuCMWt7OvTaWIsVO1dteLg== X-Received: by 2002:a05:6000:186e:b0:21b:c44a:7ab9 with SMTP id d14-20020a056000186e00b0021bc44a7ab9mr9873638wri.336.1656342299749; Mon, 27 Jun 2022 08:04:59 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-58-216.cust.vodafonedsl.it. [188.217.58.216]) by smtp.gmail.com with ESMTPSA id d18-20020adfe852000000b0021ba3d1f2a0sm10581250wrn.48.2022.06.27.08.04.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 08:04:59 -0700 (PDT) From: Tommaso Merciai Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Tommaso Merciai , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/7] media: ov5693: add dvdd into ov5693_supply_names array Date: Mon, 27 Jun 2022 17:04:48 +0200 Message-Id: <20220627150453.220292-3-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220627150453.220292-1-tommaso.merciai@amarulasolutions.com> References: <20220627150453.220292-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add missing "dvdd" (Digital circuit power) entry into ov5693_supply_names array Signed-off-by: Tommaso Merciai Reviewed-by: Jacopo Mondi --- drivers/media/i2c/ov5693.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index f410333c4c67..9e84468d920e 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -132,6 +132,7 @@ static const char * const ov5693_supply_names[] =3D { "avdd", /* Analog power */ "dovdd", /* Digital I/O power */ + "dvdd", /* Digital circuit power */ }; =20 #define OV5693_NUM_SUPPLIES ARRAY_SIZE(ov5693_supply_names) --=20 2.25.1 From nobody Sun Apr 19 20:36:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8132CC433EF for ; Mon, 27 Jun 2022 15:05:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237672AbiF0PFM (ORCPT ); Mon, 27 Jun 2022 11:05:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237613AbiF0PFE (ORCPT ); Mon, 27 Jun 2022 11:05:04 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B882317593 for ; Mon, 27 Jun 2022 08:05:02 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id m6-20020a05600c3b0600b003a0489f412cso1547203wms.1 for ; Mon, 27 Jun 2022 08:05:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l2qHBG28ZF/0BqgZtfUZ2wwyoD54f6fad9bi6YF6qP8=; b=KkiLJR+dI/sfPPQ2s1lOQsqvvaQpAmiK08gsGDaD57ph/EMv5+h9GmRBeL8UEl/18+ ou22mjauhcxTNohAl3306Hb6yBAONh50aZiBb1VyWgF89BO6v480wSJUML9ym+h4Q7LC y3wM9rytEgubnTsw8dXfS34e8QVJAGGhoIDBc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l2qHBG28ZF/0BqgZtfUZ2wwyoD54f6fad9bi6YF6qP8=; b=ElgQP5MvQJ/1yprwI29H3j4qBDqlZ/OhO5jf+NfsPTMc3Dhp2t88mav5tn8fbJVrsc AOSuJDjos+NMgIU+j0sm9A6g8ankt6/zXFLWpMTWtT3IEJ4+u3PVrMcnAXNl7XaGusBv oDVdcKWjcFdN9AAaUe5buHtHkjlgRcdk6tmk5sdMDc+pXOJ0jhHpiu9wZ/Qwv7P0cyQX 3WtRtR1Ko94yXm2aAszk8JhGW+kUF/WB0jY9d35orAkh4zWSvlWQotzJdTGBYTmq2lDr IjwGdqGn7+zLayzxxi89F8GvbzdRaGW9yY0ygmxaaHeqqPo4xRAnn5IPLZoQ/xmAcvUN PIIQ== X-Gm-Message-State: AJIora8J3itewmskrUYnSLizjKSGsADx8X9ZVPoth5xdZgKBq+EQqP8t o5J6TXXEhYUzJuCCM8cgnjrNvg== X-Google-Smtp-Source: AGRyM1uwQ/ftXCRReEPvQMOgtnMF2kmKx/Ogtd60o8TWs0K0is1A9sFNDATuAMoABM9niMGGVZZ5/Q== X-Received: by 2002:a05:600c:a03:b0:39e:4f0c:938c with SMTP id z3-20020a05600c0a0300b0039e4f0c938cmr15384218wmp.145.1656342301269; Mon, 27 Jun 2022 08:05:01 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-58-216.cust.vodafonedsl.it. [188.217.58.216]) by smtp.gmail.com with ESMTPSA id d18-20020adfe852000000b0021ba3d1f2a0sm10581250wrn.48.2022.06.27.08.05.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 08:05:00 -0700 (PDT) From: Tommaso Merciai Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Tommaso Merciai , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/7] media: ov5693: rename clk into xvclk Date: Mon, 27 Jun 2022 17:04:49 +0200 Message-Id: <20220627150453.220292-4-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220627150453.220292-1-tommaso.merciai@amarulasolutions.com> References: <20220627150453.220292-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename clk pdata pointer into xvclk (system clock input). Same for clk_rate into xvclk_rate. This is more explicit Signed-off-by: Tommaso Merciai Reviewed-by: Jacopo Mondi --- drivers/media/i2c/ov5693.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index 9e84468d920e..d2adc5513a21 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -157,7 +157,7 @@ struct ov5693_device { struct gpio_desc *reset; struct gpio_desc *powerdown; struct regulator_bulk_data supplies[OV5693_NUM_SUPPLIES]; - struct clk *clk; + struct clk *xvclk; =20 struct ov5693_mode { struct v4l2_rect crop; @@ -794,7 +794,7 @@ static void ov5693_sensor_powerdown(struct ov5693_devic= e *ov5693) =20 regulator_bulk_disable(OV5693_NUM_SUPPLIES, ov5693->supplies); =20 - clk_disable_unprepare(ov5693->clk); + clk_disable_unprepare(ov5693->xvclk); } =20 static int ov5693_sensor_powerup(struct ov5693_device *ov5693) @@ -804,7 +804,7 @@ static int ov5693_sensor_powerup(struct ov5693_device *= ov5693) gpiod_set_value_cansleep(ov5693->reset, 1); gpiod_set_value_cansleep(ov5693->powerdown, 1); =20 - ret =3D clk_prepare_enable(ov5693->clk); + ret =3D clk_prepare_enable(ov5693->xvclk); if (ret) { dev_err(ov5693->dev, "Failed to enable clk\n"); goto fail_power; @@ -1390,7 +1390,7 @@ static int ov5693_check_hwcfg(struct ov5693_device *o= v5693) static int ov5693_probe(struct i2c_client *client) { struct ov5693_device *ov5693; - u32 clk_rate; + u32 xvclk_rate; int ret =3D 0; =20 ov5693 =3D devm_kzalloc(&client->dev, sizeof(*ov5693), GFP_KERNEL); @@ -1408,16 +1408,16 @@ static int ov5693_probe(struct i2c_client *client) =20 v4l2_i2c_subdev_init(&ov5693->sd, client, &ov5693_ops); =20 - ov5693->clk =3D devm_clk_get(&client->dev, "xvclk"); - if (IS_ERR(ov5693->clk)) { + ov5693->xvclk =3D devm_clk_get(&client->dev, "xvclk"); + if (IS_ERR(ov5693->xvclk)) { dev_err(&client->dev, "Error getting clock\n"); - return PTR_ERR(ov5693->clk); + return PTR_ERR(ov5693->xvclk); } =20 - clk_rate =3D clk_get_rate(ov5693->clk); - if (clk_rate !=3D OV5693_XVCLK_FREQ) + xvclk_rate =3D clk_get_rate(ov5693->xvclk); + if (xvclk_rate !=3D OV5693_XVCLK_FREQ) dev_warn(&client->dev, "Found clk freq %u, expected %u\n", - clk_rate, OV5693_XVCLK_FREQ); + xvclk_rate, OV5693_XVCLK_FREQ); =20 ret =3D ov5693_configure_gpios(ov5693); if (ret) --=20 2.25.1 From nobody Sun Apr 19 20:36:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E98E9C43334 for ; Mon, 27 Jun 2022 15:05:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236531AbiF0PFP (ORCPT ); Mon, 27 Jun 2022 11:05:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237623AbiF0PFG (ORCPT ); Mon, 27 Jun 2022 11:05:06 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 467F617592 for ; Mon, 27 Jun 2022 08:05:04 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id l68so574458wml.3 for ; Mon, 27 Jun 2022 08:05:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AtZ/cIs6lq2eirM771Yk+JBARQCD5B0BoigyCmO2Az8=; b=cYYMdAf40LUhOh7aaAKdxOLc6v6PoFzaMIr+tICiSbNkwVafTgkoUcfaoSzLta9hmH rWYQYcRTFxjvADGbSecgiSpKYbzd7Nrkz4aYfCCVN6oDub9+Vg3QVJjsBeWUjSdu7agP bd+4EHj4NQqUPn45kXSfmUA32xlIEwvmq3Jds= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AtZ/cIs6lq2eirM771Yk+JBARQCD5B0BoigyCmO2Az8=; b=OsZk9oROveiYN+s2VGQuevXD4ioaVBRn4/vCsZnlZ9SzqL1t8yGCAmepcGPza3E/9L zEi2UpS6hAU4kQ93r6TxnS7dVV88WLdoKhuSxvYm5zqJWDsjPFK9meoktIH/9cGofold ubDiGdrJ7eeXVIQ9SpQSx2X2+DHT0w+Twj75bu76gRDKN3uhRxmA1V2bDj9KVBjlWeHz QsJVpWu9xfe/LLgRaGoJyrSlv9oB6yp6zXRceUEi/LO96cirL9nxTWumiSnLnWCsmn5Z YzBxa6owvGZksFRcoMRZrk5dHYEMD/fKE8Hdwl5WxvOtb1P7bbNlGhP31RloTChbTbKM nqtQ== X-Gm-Message-State: AJIora+vqByCMroP9Wno2vP4gC4c2bwHIQ+oPHgqfcnVub3cnZo06hqA j6FMMM8k75YiypHJSAkOKIhfcQ== X-Google-Smtp-Source: AGRyM1vJbFEzPVvR33i2qVveTyf/wUdKYArUHghQcAkmLddHCcDSR6go3aK+gcQnU374q+pmCYj+1w== X-Received: by 2002:a05:600c:4f54:b0:3a0:4a5b:2692 with SMTP id m20-20020a05600c4f5400b003a04a5b2692mr6413740wmq.109.1656342302744; Mon, 27 Jun 2022 08:05:02 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-58-216.cust.vodafonedsl.it. [188.217.58.216]) by smtp.gmail.com with ESMTPSA id d18-20020adfe852000000b0021ba3d1f2a0sm10581250wrn.48.2022.06.27.08.05.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 08:05:02 -0700 (PDT) From: Tommaso Merciai Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Tommaso Merciai , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/7] media: ov5693: move hw cfg functions into ov5693_check_hwcfg Date: Mon, 27 Jun 2022 17:04:50 +0200 Message-Id: <20220627150453.220292-5-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220627150453.220292-1-tommaso.merciai@amarulasolutions.com> References: <20220627150453.220292-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Move hw configuration functions into ov5693_check_hwcfg. This is done to separe the code that handle the hw cfg from probe in a clean way Signed-off-by: Tommaso Merciai --- drivers/media/i2c/ov5693.c | 53 +++++++++++++++++++++++--------------- 1 file changed, 32 insertions(+), 21 deletions(-) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index d2adc5513a21..d5a934ace597 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -1348,6 +1348,38 @@ static int ov5693_check_hwcfg(struct ov5693_device *= ov5693) struct fwnode_handle *endpoint; unsigned int i; int ret; + u32 xvclk_rate; + + ov5693->xvclk =3D devm_clk_get(ov5693->dev, "xvclk"); + if (IS_ERR(ov5693->xvclk)) + return dev_err_probe(ov5693->dev, PTR_ERR(ov5693->xvclk), + "failed to get xvclk: %ld\n", + PTR_ERR(ov5693->xvclk)); + + if (ov5693->xvclk) { + xvclk_rate =3D clk_get_rate(ov5693->xvclk); + } else { + ret =3D fwnode_property_read_u32(fwnode, "clock-frequency", + &xvclk_rate); + + if (ret) { + dev_err(ov5693->dev, "can't get clock frequency"); + return ret; + } + } + + if (xvclk_rate !=3D OV5693_XVCLK_FREQ) + dev_warn(ov5693->dev, "Found clk freq %u, expected %u\n", + xvclk_rate, OV5693_XVCLK_FREQ); + + ret =3D ov5693_configure_gpios(ov5693); + if (ret) + return ret; + + ret =3D ov5693_get_regulators(ov5693); + if (ret) + return dev_err_probe(ov5693->dev, ret, + "Error fetching regulators\n"); =20 endpoint =3D fwnode_graph_get_next_endpoint(fwnode, NULL); if (!endpoint) @@ -1390,7 +1422,6 @@ static int ov5693_check_hwcfg(struct ov5693_device *o= v5693) static int ov5693_probe(struct i2c_client *client) { struct ov5693_device *ov5693; - u32 xvclk_rate; int ret =3D 0; =20 ov5693 =3D devm_kzalloc(&client->dev, sizeof(*ov5693), GFP_KERNEL); @@ -1408,26 +1439,6 @@ static int ov5693_probe(struct i2c_client *client) =20 v4l2_i2c_subdev_init(&ov5693->sd, client, &ov5693_ops); =20 - ov5693->xvclk =3D devm_clk_get(&client->dev, "xvclk"); - if (IS_ERR(ov5693->xvclk)) { - dev_err(&client->dev, "Error getting clock\n"); - return PTR_ERR(ov5693->xvclk); - } - - xvclk_rate =3D clk_get_rate(ov5693->xvclk); - if (xvclk_rate !=3D OV5693_XVCLK_FREQ) - dev_warn(&client->dev, "Found clk freq %u, expected %u\n", - xvclk_rate, OV5693_XVCLK_FREQ); - - ret =3D ov5693_configure_gpios(ov5693); - if (ret) - return ret; - - ret =3D ov5693_get_regulators(ov5693); - if (ret) - return dev_err_probe(&client->dev, ret, - "Error fetching regulators\n"); - ov5693->sd.flags |=3D V4L2_SUBDEV_FL_HAS_DEVNODE; ov5693->pad.flags =3D MEDIA_PAD_FL_SOURCE; ov5693->sd.entity.function =3D MEDIA_ENT_F_CAM_SENSOR; --=20 2.25.1 From nobody Sun Apr 19 20:36:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41431CCA473 for ; Mon, 27 Jun 2022 15:05:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235301AbiF0PFT (ORCPT ); Mon, 27 Jun 2022 11:05:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237635AbiF0PFI (ORCPT ); Mon, 27 Jun 2022 11:05:08 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC794175B7 for ; Mon, 27 Jun 2022 08:05:05 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id i67-20020a1c3b46000000b003a03567d5e9so6057256wma.1 for ; Mon, 27 Jun 2022 08:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mbhraybs4BrIz6d4796cwXXFW6lfNPQ37w8o2Zpee1o=; b=KupZZ+sarY3guqQXY2ptFD5NlYKfyYBs2ZTgqZ0qkyAc7wHfgowtz1NZmiJdEnK+wo n1x4HvtvDNXbDaaHIfajhHX2qAR/vhf5P44qF9fLXEjvmB2olv9CHMsGOToomOpgv6kS AyNKEk/UWWE1IkxXRE2nAUpJtMUklGWeZx35I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mbhraybs4BrIz6d4796cwXXFW6lfNPQ37w8o2Zpee1o=; b=lEtO2If7yUPYUndsNo8eKY6kXwMCjR9lQ+yiLFZ1tBWC0Q3ehO7GsxOg+Ns7kPph2v YOvMuLjc0G4cj2cgySlgFUuezVClQfrZnvS9uoprEhB7FVNTRtyOTvxYYjT0OcP2a3cG SGBPl0WOSnP/35mFkGUh1CRmrsWAUthek9EQ3ZNrMwjJ8HW5uHYtaioWzlDWZozOktoO e9Seb+7Vd/zuT+zqccsaWg6SNtu7mh0gdSR5KW1Q7n2ieqckkLAkDpchOTM6Cr3k0BtL TWOwIoKe+9AXDo6dntpER83vWNpbX0HFb+zZKZACXcYXyeKrt5IwM9VL6/3o+mDU+4bf 066g== X-Gm-Message-State: AJIora8ZOmEIAmjebEzRQGx3++wNYvd4rTEoRllxeGpKKXZRq8jmXM5F 4rZDo3bYpeb3OwoLub5lG/l8ug== X-Google-Smtp-Source: AGRyM1v+UVG8BbbMwMvAW42KVwxZzoiPd+lqZKHuXK/Mx/9tVTy1Cb9XbuPSeO1lJZzpIbjguIVojw== X-Received: by 2002:a05:600c:228c:b0:3a0:43ee:d88b with SMTP id 12-20020a05600c228c00b003a043eed88bmr13081363wmf.135.1656342304223; Mon, 27 Jun 2022 08:05:04 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-58-216.cust.vodafonedsl.it. [188.217.58.216]) by smtp.gmail.com with ESMTPSA id d18-20020adfe852000000b0021ba3d1f2a0sm10581250wrn.48.2022.06.27.08.05.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 08:05:03 -0700 (PDT) From: Tommaso Merciai Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Tommaso Merciai , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/7] media: ov5693: rename ov5693_check_hwcfg into ov5693_get_hwcfg Date: Mon, 27 Jun 2022 17:04:51 +0200 Message-Id: <20220627150453.220292-6-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220627150453.220292-1-tommaso.merciai@amarulasolutions.com> References: <20220627150453.220292-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Function ov5693_check_hwcfg don't only check the hw configuration but also get the hw configuration. Is better better to rename this into ov5693_= get_hwcfg Signed-off-by: Tommaso Merciai Reviewed-by: Jacopo Mondi --- drivers/media/i2c/ov5693.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index d5a934ace597..273caef467fe 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -1339,7 +1339,7 @@ static int ov5693_get_regulators(struct ov5693_device= *ov5693) ov5693->supplies); } =20 -static int ov5693_check_hwcfg(struct ov5693_device *ov5693) +static int ov5693_get_hwcfg(struct ov5693_device *ov5693) { struct fwnode_handle *fwnode =3D dev_fwnode(ov5693->dev); struct v4l2_fwnode_endpoint bus_cfg =3D { @@ -1431,7 +1431,7 @@ static int ov5693_probe(struct i2c_client *client) ov5693->client =3D client; ov5693->dev =3D &client->dev; =20 - ret =3D ov5693_check_hwcfg(ov5693); + ret =3D ov5693_get_hwcfg(ov5693); if (ret) return ret; =20 --=20 2.25.1 From nobody Sun Apr 19 20:36:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBC75C433EF for ; Mon, 27 Jun 2022 15:05:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237680AbiF0PFW (ORCPT ); Mon, 27 Jun 2022 11:05:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237637AbiF0PFJ (ORCPT ); Mon, 27 Jun 2022 11:05:09 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48EC917A8D for ; Mon, 27 Jun 2022 08:05:06 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id l68so574458wml.3 for ; Mon, 27 Jun 2022 08:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xYWlc/wQ018OwOnNA+AyeCt3Ba+fxR9sI/D7eVEieKk=; b=oIMyRqLbbNcQeDmGyzit2hoWXaACc6GAE/IMnjYVAbnHJQ6q5o/Gj7o+kOwoAz/Ach dv+JkhuPgsPBPfduG/ElG1gb9r+ZuBWDtWmTXEq86+g722shXGWd9j1CyWKgOKiNALOu JcMrRwJykwsRu9UtQGriXChqD34mkNQtWZ8Gk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xYWlc/wQ018OwOnNA+AyeCt3Ba+fxR9sI/D7eVEieKk=; b=tYHjUQrshkSyZJofZC2S8EVF7qjQKkbsBkJYJHVfxpdqdxqluaqcTH7RvlR9BcZV9M snsOo24yGE3BcZwmwg0L4xw7udzJf0c38kMX5UhgUDBjyYpdQXYzz0FgPNZ0jvQoTXgh Iv/sTzy4CW+GAxAqAm6hLhN2B4T3S6V13s+0EywcEvP6UWJFS990U3LUxlzWr0/FBbPj jq+7LyLzIk34iDZjCJBMMMkTHOdXxxEt01nIPK/rBQ+anRwimhS8ZGyJEceQ2G2o7p0/ WEQsQp8y6HMIDDg4rlqNAOrqmNw3iImJRIwn4G2dlqhESmbgKcQfuIEgd4IajFOufVTY 1Y6A== X-Gm-Message-State: AJIora/+kxzY+akIvq2yHvV4fH3XM3a3HVKnSfJEYER8pvE/XkKq7LoU wOCg9PW+hDnlPFfNaFMwEpbNmQ== X-Google-Smtp-Source: AGRyM1uZH3Ii4ouIoGJ/bAPB0LRMvYK4GIAO6xqMH2pvQRoACmD/dsL1R4X08FqzAFFRop6qXGT8kw== X-Received: by 2002:a05:600c:a18a:b0:3a0:2978:30d2 with SMTP id id10-20020a05600ca18a00b003a0297830d2mr15765046wmb.173.1656342305771; Mon, 27 Jun 2022 08:05:05 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-58-216.cust.vodafonedsl.it. [188.217.58.216]) by smtp.gmail.com with ESMTPSA id d18-20020adfe852000000b0021ba3d1f2a0sm10581250wrn.48.2022.06.27.08.05.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 08:05:05 -0700 (PDT) From: Tommaso Merciai Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Tommaso Merciai , Dario Binacchi , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 6/7] media: ov5693: add ov5693_of_match, dts support Date: Mon, 27 Jun 2022 17:04:52 +0200 Message-Id: <20220627150453.220292-7-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220627150453.220292-1-tommaso.merciai@amarulasolutions.com> References: <20220627150453.220292-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add ov5693_of_match. Device tree support Reviewed-by: Dario Binacchi --- drivers/media/i2c/ov5693.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index 273caef467fe..0854226dc140 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -1532,10 +1532,17 @@ static const struct acpi_device_id ov5693_acpi_matc= h[] =3D { }; MODULE_DEVICE_TABLE(acpi, ov5693_acpi_match); =20 +static const struct of_device_id ov5693_of_match[] =3D { + { .compatible =3D "ovti,ov5693", }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(of, ov5693_of_match); + static struct i2c_driver ov5693_driver =3D { .driver =3D { .name =3D "ov5693", .acpi_match_table =3D ov5693_acpi_match, + .of_match_table =3D ov5693_of_match, .pm =3D &ov5693_pm_ops, }, .probe_new =3D ov5693_probe, --=20 2.25.1 From nobody Sun Apr 19 20:36:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 120BCC43334 for ; Mon, 27 Jun 2022 15:05:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237728AbiF0PF0 (ORCPT ); Mon, 27 Jun 2022 11:05:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236342AbiF0PFL (ORCPT ); Mon, 27 Jun 2022 11:05:11 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B9D61759E for ; Mon, 27 Jun 2022 08:05:10 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id k129so4213577wme.0 for ; Mon, 27 Jun 2022 08:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q/qNchMN3fi99e0hw7FrgtY/UyQg4ox/iqGDXX9XdaQ=; b=e8qLad0cOTMs7IHvIZLMmYbi3/SfNmnY8OFnjn8+OdCKmwvED5rARJ7juYlpYdhryV 1Qr/1UuLLIvZQa87uFTclFe1u/Kx+4SuQr35WBz/ktaJFxMIl1PFEb8gxE19GeFL7qmc 4qJeqkATx+o0s1y0uUQ+WO+cmMRFM0NP8J4es= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q/qNchMN3fi99e0hw7FrgtY/UyQg4ox/iqGDXX9XdaQ=; b=2jWstrtxV5I6YjFhKK3+FkODaw9r/8RsKBKB/dCaRmr3WeAxW8zILgoP28XLYv9+XM sgIiD+HSaZ84lWIYWca1X7hE1oc+wzy5mSYjb4FX7n2yXqEGWHTRtfxXxhYtOg2hE+0I H+b2KC4TSkx1RUVNdOgxs2dVzbJ91YtgZDDq1921gixmRwvi9/D2JVtNqxzjmM275WpV TdCPPOANvVDipiT8TtJIpuK8XpZAkP23IjXFAvJDLnGrlDZLtbnPR75G7/vp0tPkBe4i 7tzgG87cXkUj/vEvT78koxsjtwIfadFxLwdXxRsUZ7FQDUdAOSyBd/c6YbvZunaR9+Xe 7/qQ== X-Gm-Message-State: AJIora9yyMVN86Agrthos6SzcMCOwu80sdsbeIU/PMZ26K4rPDb0yOBH Cu3jIB/GgrwNQvnt6lchlt8wSA== X-Google-Smtp-Source: AGRyM1v8O4fcCQ/hU78/LPZ5Zd2jI0PQIzJBDQS4a1F8Ic7fbDz8SQ6Nvwui6Szr+NGZwtzdowiMMg== X-Received: by 2002:a1c:2703:0:b0:3a0:2ffb:1781 with SMTP id n3-20020a1c2703000000b003a02ffb1781mr19998529wmn.146.1656342308807; Mon, 27 Jun 2022 08:05:08 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i.station (net-188-217-58-216.cust.vodafonedsl.it. [188.217.58.216]) by smtp.gmail.com with ESMTPSA id d18-20020adfe852000000b0021ba3d1f2a0sm10581250wrn.48.2022.06.27.08.05.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 08:05:08 -0700 (PDT) From: Tommaso Merciai Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Tommaso Merciai , Daniel Scally , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 7/7] media: dt-bindings: ov5693: document YAML binding Date: Mon, 27 Jun 2022 17:04:53 +0200 Message-Id: <20220627150453.220292-8-tommaso.merciai@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220627150453.220292-1-tommaso.merciai@amarulasolutions.com> References: <20220627150453.220292-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This patch adds documentation of device tree in YAML schema for the OV5693 CMOS image sensor from Omnivision Signed-off-by: Tommaso Merciai Reviewed-by: Krzysztof Kozlowski --- Changes since v1: - Fix allOf position as suggested by Krzysztof - Remove port description as suggested by Krzysztof - Fix EOF as suggested by Krzysztof .../bindings/media/i2c/ovti,ov5693.yaml | 108 ++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 109 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov5693= .yaml diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml b= /Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml new file mode 100644 index 000000000000..e8e2776efc08 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml @@ -0,0 +1,108 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (c) 2022 Amarulasolutions +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/ovti,ov5693.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Omnivision OV5693 CMOS Sensor + +maintainers: + - Tommaso Merciai + +description: | + The Omnivision OV5693 is a high performance, 1/4-inch, 5 megapixel, CMOS + image sensor that delivers 2592x1944 at 30fps. It provides full-frame, + sub-sampled, and windowed 10-bit MIPI images in various formats via the + Serial Camera Control Bus (SCCB) interface. + + Supports images sizes: 5 Mpixel, EIS1080p, 1080p, 720p, VGA, QVGA + + OV5693 is programmable through I2C and two-wire Serial Camera Control Bu= s (SCCB). + The sensor output is available via CSI-2 serial data output (up to 2-lan= e). + +allOf: + - $ref: /schemas/media/video-interface-devices.yaml# + +properties: + compatible: + const: ovti,ov5693 + + reg: + maxItems: 1 + + clocks: + description: + System input clock (aka XVCLK). From 6 to 27 MHz. + maxItems: 1 + + dovdd-supply: + description: + Digital I/O voltage supply, 1.8V. + + avdd-supply: + description: + Analog voltage supply, 2.8V. + + dvdd-supply: + description: + Digital core voltage supply, 1.2V. + + reset-gpios: + description: + The phandle and specifier for the GPIO that controls sensor reset. + This corresponds to the hardware pin XSHUTDN which is physically + active low. + maxItems: 1 + +required: + - compatible + - reg + - clocks + - dovdd-supply + - avdd-supply + - dvdd-supply + - port + +unevaluatedProperties: false + +examples: + - | + #include + #include + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + ov5693: camera@36 { + compatible =3D "ovti,ov5693"; + reg =3D <0x36>; + + reset-gpios =3D <&gpio2 RK_PB1 GPIO_ACTIVE_LOW>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&cif_clkout_m0>; + + clocks =3D <&cru SCLK_CIF_OUT>; + assigned-clocks =3D <&cru SCLK_CIF_OUT>; + assigned-clock-rates =3D <19200000>; + + avdd-supply =3D <&vcc_1v8>; + dvdd-supply =3D <&vcc_1v2>; + dovdd-supply =3D <&vcc_2v8>; + + rotation =3D <90>; + orientation =3D <0>; + + port { + ucam_out: endpoint { + remote-endpoint =3D <&mipi_in_ucam>; + data-lanes =3D <1 2>; + link-frequencies =3D /bits/ 64 <450000000>; + }; + }; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index 1fc9ead83d2a..844307cb20c4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14719,6 +14719,7 @@ M: Daniel Scally L: linux-media@vger.kernel.org S: Maintained T: git git://linuxtv.org/media_tree.git +F: Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml F: drivers/media/i2c/ov5693.c =20 OMNIVISION OV5695 SENSOR DRIVER --=20 2.25.1