From nobody Sun Apr 19 21:57:34 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAA62CCA47F for ; Sat, 25 Jun 2022 19:29:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233244AbiFYT30 (ORCPT ); Sat, 25 Jun 2022 15:29:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231311AbiFYT3Y (ORCPT ); Sat, 25 Jun 2022 15:29:24 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2B6E13F5D; Sat, 25 Jun 2022 12:29:23 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id g20-20020a17090a579400b001ed52939d72so337141pji.4; Sat, 25 Jun 2022 12:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=c5lEV7bdqnDxF2NAwEQaD17yfLDKPDGXJ3egD+ggkUc=; b=JuFkR299mwMEl/sHjr8YsK7XkBcyohPBCGMflYSQenEHx83adbPHh8Ptx+F/W23Dxm yFAXkBkY7ErqSL3Ow9xju+nmn/2J50TeMR71bfP4YqN4Dr7y/5tRbDDEkcPQHXMlTEV3 8o7ibWcvTqb9BTLsvQhTfSHMuWbBxrb9BtHxkIanzaxWmTfxC6H4KMBCFPP39eJv6Zdh Sd+4J56AplRlz2+XZ8Sxq5OUdOgtwAgkMGR3T2kEprDHBYs+n9Ypc2gWO5u3Ou+CqUYo HfN/URxPQVOkVcStOwEHkxNZLQ8f1Ae+b3cXjSrzJePWUQGPBmpHntOFA+dNDQ6QuVDp ZSQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=c5lEV7bdqnDxF2NAwEQaD17yfLDKPDGXJ3egD+ggkUc=; b=0pj6ha02u4jLemPPqv4aFwR9RJwPUq0Vk2btMMhwFWP2h2NGA/lMLSqGefzvC0zlT6 wkQqXGOMYWEmZpjTG1cwIPzx4M8ZJEVs8/QWBix6HxxFvH+4Jj36zedW+tIOmFI3YcYi K60rjMZV7+fjIahO2OskVYR03hCTsfvepQYTkJ5DRb+kVC+5mea/jhIpCI/Ux8/+RsbX VHM+F0rYRUxa6XsznPfozr6B4HWrsq416+LRW9CJpp7Kt/XkV5YKfGm0NX6cUFQNPqTV gd78t4BSjvdRmSDfAc0F976Ng7SJcAcoMttZ+ZB0vuhEU5QPLzNu1TKVxkKTaEVq7T2o Sz7w== X-Gm-Message-State: AJIora988Vl05veVi9QU12snJG6kymPlSeHru0yCY6vcKYGfE8nC5Bmv SQKDv66aLw0FfpbJz21Zq8U= X-Google-Smtp-Source: AGRyM1sBR1gbq+FRX/P79kfzBtenpKE3iztXCEXfUro5yRwMen+vBGatOmgkhGddAmSoQ7gzYnargQ== X-Received: by 2002:a17:902:d488:b0:16a:158e:dd19 with SMTP id c8-20020a170902d48800b0016a158edd19mr5787747plg.105.1656185363072; Sat, 25 Jun 2022 12:29:23 -0700 (PDT) Received: from ip-172-31-11-128.ap-south-1.compute.internal (ec2-15-207-248-140.ap-south-1.compute.amazonaws.com. [15.207.248.140]) by smtp.gmail.com with ESMTPSA id c12-20020a17090a1d0c00b001ec92575e83sm3933650pjd.4.2022.06.25.12.29.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jun 2022 12:29:22 -0700 (PDT) From: Praghadeesh T K S To: Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Praghadeesh T K S , linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: praghadeeshtks@zohomail.in, skhan@linuxfoundation.org Subject: [PATCH] net: wireless/broadcom: fix possible condition with no effect Date: Sat, 25 Jun 2022 19:29:01 +0000 Message-Id: <20220625192902.30050-1-praghadeeshthevendria@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix a coccinelle warning by removing condition with no possible effect Signed-off-by: Praghadeesh T K S --- drivers/net/wireless/broadcom/b43/xmit.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/wireless/broadcom/b43/xmit.c b/drivers/net/wireles= s/broadcom/b43/xmit.c index 7651b1b..667a74b 100644 --- a/drivers/net/wireless/broadcom/b43/xmit.c +++ b/drivers/net/wireless/broadcom/b43/xmit.c @@ -169,12 +169,7 @@ static u16 b43_generate_tx_phy_ctl1(struct b43_wldev *= dev, u8 bitrate) const struct b43_phy *phy =3D &dev->phy; const struct b43_tx_legacy_rate_phy_ctl_entry *e; u16 control =3D 0; - u16 bw; - - if (phy->type =3D=3D B43_PHYTYPE_LP) - bw =3D B43_TXH_PHY1_BW_20; - else /* FIXME */ - bw =3D B43_TXH_PHY1_BW_20; + u16 bw =3D B43_TXH_PHY1_BW_20; =20 if (0) { /* FIXME: MIMO */ } else if (b43_is_cck_rate(bitrate) && phy->type !=3D B43_PHYTYPE_LP) { --=20 2.34.1