From nobody Mon Apr 20 01:11:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B8FAC43334 for ; Thu, 23 Jun 2022 12:56:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231984AbiFWMz6 (ORCPT ); Thu, 23 Jun 2022 08:55:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229765AbiFWMzy (ORCPT ); Thu, 23 Jun 2022 08:55:54 -0400 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FC1649F9F; Thu, 23 Jun 2022 05:55:53 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 25NCtahc088610; Thu, 23 Jun 2022 07:55:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1655988936; bh=LudpT7lFWiW8BGbvk0yTcNCyZfVY1zyH1uoq35WMDh0=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=RJmdbr60yJnnGGO+mhXGtsg7t6X+qk6+PPQkcZkfXCRCpgHKyUyRgJ0uOCxWnLee1 6gVfEX+wWMiDu4lNS/SjsBC3++fnLhbDZnKbefTvT8VopkvkIv1b0WvGiizm68kcRO eP1rUiIxNnLGs32wR2yKFuyTCdBQmn1FlK6XNzNQ= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 25NCtaU3091234 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 23 Jun 2022 07:55:36 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Thu, 23 Jun 2022 07:55:35 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Thu, 23 Jun 2022 07:55:35 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 25NCtYf2028813; Thu, 23 Jun 2022 07:55:35 -0500 From: Rahul T R To: , , , , CC: , , , , , , , , , , Rahul T R , Krzysztof Kozlowski Subject: [PATCH v4 1/3] phy: dt-bindings: cdns,dphy: Add compatible for dphy on j721e Date: Thu, 23 Jun 2022 18:24:31 +0530 Message-ID: <20220623125433.18467-2-r-ravikumar@ti.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220623125433.18467-1-r-ravikumar@ti.com> References: <20220623125433.18467-1-r-ravikumar@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add compatible to support dphy tx on j721e Signed-off-by: Rahul T R Reviewed-by: Laurent Pinchart Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/phy/cdns,dphy.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml b/Documen= tation/devicetree/bindings/phy/cdns,dphy.yaml index c50629bd1b51..f0e9ca8427bb 100644 --- a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml +++ b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml @@ -11,8 +11,9 @@ maintainers: =20 properties: compatible: - items: - - const: cdns,dphy + enum: + - cdns,dphy + - ti,j721e-dphy =20 reg: maxItems: 1 --=20 2.36.1 From nobody Mon Apr 20 01:11:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 910F0C433EF for ; Thu, 23 Jun 2022 12:56:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232125AbiFWM4D (ORCPT ); Thu, 23 Jun 2022 08:56:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229765AbiFWMz6 (ORCPT ); Thu, 23 Jun 2022 08:55:58 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DD1449CA9; Thu, 23 Jun 2022 05:55:57 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 25NCtmdR104662; Thu, 23 Jun 2022 07:55:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1655988948; bh=4XwwzbOSUen5F3tnuKla9UlebDbQMg9n3BkwPwYF3UE=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=Oi9wAfYXi5D4Q/VZrNny9eyKD8kKp90Y67HTRJ9Nuq/AKY+npdXm9u2gO356pqFK9 ot2WpYm1yyxx8rZ4uza1hIzLq969VBwccpbaBNgsHpK6ZrtgyjK/cBWruxRtOCoxLU D5lPCtGtIZi7Jtq+LUg8nEKHhcu7W0wShPxz54X8= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 25NCtm5G091482 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 23 Jun 2022 07:55:48 -0500 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Thu, 23 Jun 2022 07:55:38 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Thu, 23 Jun 2022 07:55:37 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 25NCtak2079630; Thu, 23 Jun 2022 07:55:36 -0500 From: Rahul T R To: , , , , CC: , , , , , , , , , , Rahul T R Subject: [PATCH v4 2/3] phy: cdns-dphy: Add band config for dphy tx Date: Thu, 23 Jun 2022 18:24:32 +0530 Message-ID: <20220623125433.18467-3-r-ravikumar@ti.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220623125433.18467-1-r-ravikumar@ti.com> References: <20220623125433.18467-1-r-ravikumar@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add support for band ctrl config for dphy tx. Signed-off-by: Rahul T R Reviewed-by: Pratyush Yadav --- drivers/phy/cadence/cdns-dphy.c | 40 ++++++++++++++++++++++++++++++++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/drivers/phy/cadence/cdns-dphy.c b/drivers/phy/cadence/cdns-dph= y.c index ba042e39cfaf..14f951013b4f 100644 --- a/drivers/phy/cadence/cdns-dphy.c +++ b/drivers/phy/cadence/cdns-dphy.c @@ -3,6 +3,7 @@ * Copyright: 2017-2018 Cadence Design Systems, Inc. */ =20 +#include #include #include #include @@ -45,6 +46,10 @@ #define DPHY_CMN_OPDIV_FROM_REG BIT(6) #define DPHY_CMN_OPDIV(x) ((x) << 7) =20 +#define DPHY_BAND_CFG DPHY_PCS(0x0) +#define DPHY_BAND_CFG_LEFT_BAND GENMASK(4, 0) +#define DPHY_BAND_CFG_RIGHT_BAND GENMASK(9, 5) + #define DPHY_PSM_CFG DPHY_PCS(0x4) #define DPHY_PSM_CFG_FROM_REG BIT(0) #define DPHY_PSM_CLK_DIV(x) ((x) << 1) @@ -92,6 +97,12 @@ struct cdns_dphy { struct phy *phy; }; =20 +/* Order of bands is important since the index is the band number. */ +static const unsigned int tx_bands[] =3D { + 80, 100, 120, 160, 200, 240, 320, 390, 450, 510, 560, 640, 690, 770, + 870, 950, 1000, 1200, 1400, 1600, 1800, 2000, 2200, 2500 +}; + static int cdns_dsi_get_dphy_pll_cfg(struct cdns_dphy *dphy, struct cdns_dphy_cfg *cfg, struct phy_configure_opts_mipi_dphy *opts, @@ -232,6 +243,24 @@ static int cdns_dphy_config_from_opts(struct phy *phy, return 0; } =20 +static int cdns_dphy_tx_get_band_ctrl(unsigned long hs_clk_rate) +{ + unsigned int rate; + int i; + + rate =3D hs_clk_rate / 1000000UL; + + if (rate < tx_bands[0]) + return -EOPNOTSUPP; + + for (i =3D 0; i < ARRAY_SIZE(tx_bands) - 1; i++) { + if (rate >=3D tx_bands[i] && rate < tx_bands[i + 1]) + return i; + } + + return -EOPNOTSUPP; +} + static int cdns_dphy_validate(struct phy *phy, enum phy_mode mode, int sub= mode, union phy_configure_opts *opts) { @@ -247,7 +276,8 @@ static int cdns_dphy_configure(struct phy *phy, union p= hy_configure_opts *opts) { struct cdns_dphy *dphy =3D phy_get_drvdata(phy); struct cdns_dphy_cfg cfg =3D { 0 }; - int ret; + int ret, band_ctrl; + unsigned int reg; =20 ret =3D cdns_dphy_config_from_opts(phy, &opts->mipi_dphy, &cfg); if (ret) @@ -276,6 +306,14 @@ static int cdns_dphy_configure(struct phy *phy, union = phy_configure_opts *opts) */ cdns_dphy_set_pll_cfg(dphy, &cfg); =20 + band_ctrl =3D cdns_dphy_tx_get_band_ctrl(opts->mipi_dphy.hs_clk_rate); + if (band_ctrl < 0) + return band_ctrl; + + reg =3D FIELD_PREP(DPHY_BAND_CFG_LEFT_BAND, band_ctrl) | + FIELD_PREP(DPHY_BAND_CFG_RIGHT_BAND, band_ctrl); + writel(reg, dphy->regs + DPHY_BAND_CFG); + return 0; } =20 --=20 2.36.1 From nobody Mon Apr 20 01:11:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76313CCA47C for ; Thu, 23 Jun 2022 12:56:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232051AbiFWM4A (ORCPT ); Thu, 23 Jun 2022 08:56:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231942AbiFWMz4 (ORCPT ); Thu, 23 Jun 2022 08:55:56 -0400 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35F7A49FA8; Thu, 23 Jun 2022 05:55:54 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 25NCtdCg120641; Thu, 23 Jun 2022 07:55:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1655988939; bh=qRX5ulrjpRrc4s5hWh/KXX+XTVfrzioD8WfNo0Ky2aE=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=JXGIVoyRb7C4Gv4yW2chmB3m9bAQ9CdlohI4sES8roZYilP4kB+N5lGQ+bV+Fwp59 TaOmIizn73+FO52jVRnpwEd5dO3ChKEr6AMyVKVXwAms3uG8kgg+gGdfVQ4ZolU3O2 iTJZkIhaX9MxBqNDV/xdh8F92Dtz6EakfomG2ofo= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 25NCtdMU091336 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 23 Jun 2022 07:55:39 -0500 Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Thu, 23 Jun 2022 07:55:39 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Thu, 23 Jun 2022 07:55:39 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 25NCtc6X122511; Thu, 23 Jun 2022 07:55:38 -0500 From: Rahul T R To: , , , , CC: , , , , , , , , , , Rahul T R Subject: [PATCH v4 3/3] phy: cdns-dphy: Add support for DPHY TX on J721e Date: Thu, 23 Jun 2022 18:24:33 +0530 Message-ID: <20220623125433.18467-4-r-ravikumar@ti.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220623125433.18467-1-r-ravikumar@ti.com> References: <20220623125433.18467-1-r-ravikumar@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add support new compatible for dphy-tx on j721e and implement dphy ops required. Signed-off-by: Rahul T R Reviewed-by: Pratyush Yadav --- drivers/phy/cadence/cdns-dphy.c | 61 +++++++++++++++++++++++++++++++++ 1 file changed, 61 insertions(+) diff --git a/drivers/phy/cadence/cdns-dphy.c b/drivers/phy/cadence/cdns-dph= y.c index 14f951013b4f..3dfdfb33cd0a 100644 --- a/drivers/phy/cadence/cdns-dphy.c +++ b/drivers/phy/cadence/cdns-dphy.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -18,6 +19,7 @@ =20 #define REG_WAKEUP_TIME_NS 800 #define DPHY_PLL_RATE_HZ 108000000 +#define POLL_TIMEOUT_US 1000 =20 /* DPHY registers */ #define DPHY_PMA_CMN(reg) (reg) @@ -62,6 +64,18 @@ #define DSI_NULL_FRAME_OVERHEAD 6 #define DSI_EOT_PKT_SIZE 4 =20 +#define DPHY_TX_J721E_WIZ_PLL_CTRL 0xF04 +#define DPHY_TX_J721E_WIZ_STATUS 0xF08 +#define DPHY_TX_J721E_WIZ_RST_CTRL 0xF0C +#define DPHY_TX_J721E_WIZ_PSM_FREQ 0xF10 + +#define DPHY_TX_J721E_WIZ_IPDIV GENMASK(4, 0) +#define DPHY_TX_J721E_WIZ_OPDIV GENMASK(13, 8) +#define DPHY_TX_J721E_WIZ_FBDIV GENMASK(25, 16) +#define DPHY_TX_J721E_WIZ_LANE_RSTB BIT(31) +#define DPHY_TX_WIZ_PLL_LOCK BIT(31) +#define DPHY_TX_WIZ_O_CMN_READY BIT(31) + struct cdns_dphy_cfg { u8 pll_ipdiv; u8 pll_opdiv; @@ -210,6 +224,46 @@ static void cdns_dphy_ref_set_psm_div(struct cdns_dphy= *dphy, u8 div) dphy->regs + DPHY_PSM_CFG); } =20 +static unsigned long cdns_dphy_j721e_get_wakeup_time_ns(struct cdns_dphy *= dphy) +{ + /* Minimum wakeup time as per MIPI D-PHY spec v1.2 */ + return 1000000; +} + +static void cdns_dphy_j721e_set_pll_cfg(struct cdns_dphy *dphy, + const struct cdns_dphy_cfg *cfg) +{ + u32 status; + + /* + * set the PWM and PLL Byteclk divider settings to recommended values + * which is same as that of in ref ops + */ + writel(DPHY_CMN_PWM_HIGH(6) | DPHY_CMN_PWM_LOW(0x101) | + DPHY_CMN_PWM_DIV(0x8), + dphy->regs + DPHY_CMN_PWM); + + writel((FIELD_PREP(DPHY_TX_J721E_WIZ_IPDIV, cfg->pll_ipdiv) | + FIELD_PREP(DPHY_TX_J721E_WIZ_OPDIV, cfg->pll_opdiv) | + FIELD_PREP(DPHY_TX_J721E_WIZ_FBDIV, cfg->pll_fbdiv)), + dphy->regs + DPHY_TX_J721E_WIZ_PLL_CTRL); + + writel(DPHY_TX_J721E_WIZ_LANE_RSTB, + dphy->regs + DPHY_TX_J721E_WIZ_RST_CTRL); + + readl_poll_timeout(dphy->regs + DPHY_TX_J721E_WIZ_PLL_CTRL, status, + (status & DPHY_TX_WIZ_PLL_LOCK), 0, POLL_TIMEOUT_US); + + readl_poll_timeout(dphy->regs + DPHY_TX_J721E_WIZ_STATUS, status, + (status & DPHY_TX_WIZ_O_CMN_READY), 0, + POLL_TIMEOUT_US); +} + +static void cdns_dphy_j721e_set_psm_div(struct cdns_dphy *dphy, u8 div) +{ + writel(div, dphy->regs + DPHY_TX_J721E_WIZ_PSM_FREQ); +} + /* * This is the reference implementation of DPHY hooks. Specific integratio= n of * this IP may have to re-implement some of them depending on how they dec= ided @@ -221,6 +275,12 @@ static const struct cdns_dphy_ops ref_dphy_ops =3D { .set_psm_div =3D cdns_dphy_ref_set_psm_div, }; =20 +static const struct cdns_dphy_ops j721e_dphy_ops =3D { + .get_wakeup_time_ns =3D cdns_dphy_j721e_get_wakeup_time_ns, + .set_pll_cfg =3D cdns_dphy_j721e_set_pll_cfg, + .set_psm_div =3D cdns_dphy_j721e_set_psm_div, +}; + static int cdns_dphy_config_from_opts(struct phy *phy, struct phy_configure_opts_mipi_dphy *opts, struct cdns_dphy_cfg *cfg) @@ -408,6 +468,7 @@ static int cdns_dphy_remove(struct platform_device *pde= v) =20 static const struct of_device_id cdns_dphy_of_match[] =3D { { .compatible =3D "cdns,dphy", .data =3D &ref_dphy_ops }, + { .compatible =3D "ti,j721e-dphy", .data =3D &j721e_dphy_ops }, { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, cdns_dphy_of_match); --=20 2.36.1