From nobody Fri May 3 09:43:58 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66EEFC43334 for ; Thu, 23 Jun 2022 07:51:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230335AbiFWHvw (ORCPT ); Thu, 23 Jun 2022 03:51:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230300AbiFWHvs (ORCPT ); Thu, 23 Jun 2022 03:51:48 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0F7D2CE0E; Thu, 23 Jun 2022 00:51:47 -0700 (PDT) Received: from dslb-188-096-142-050.188.096.pools.vodafone-ip.de ([188.96.142.50] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1o4Hcr-0006sS-JZ; Thu, 23 Jun 2022 09:51:41 +0200 From: Martin Kaiser To: Abel Vesa , Stephen Boyd Cc: Shawn Guo , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH v2 1/2] clk: imx25: print silicon revision during init Date: Thu, 23 Jun 2022 09:51:03 +0200 Message-Id: <20220623075104.166529-2-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220623075104.166529-1-martin@kaiser.cx> References: <20220602080344.208702-1-martin@kaiser.cx> <20220623075104.166529-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Print the imx25 silicon revision when the clocks are initialised. Use the same mechanism as for imx27, i.e. call mx25_revision. This function is unused at the moment. Signed-off-by: Martin Kaiser --- changes in v2: - send the patch to the clk maintainers drivers/clk/imx/clk-imx25.c | 3 +++ include/soc/imx/revision.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c index 66192fe0a898..263409fca1eb 100644 --- a/drivers/clk/imx/clk-imx25.c +++ b/drivers/clk/imx/clk-imx25.c @@ -13,6 +13,7 @@ #include #include #include +#include =20 #include "clk.h" =20 @@ -220,6 +221,8 @@ static int __init __mx25_clocks_init(void __iomem *ccm_= base) =20 imx_register_uart_clocks(6); =20 + imx_print_silicon_rev("i.MX25", mx25_revision()); + return 0; } =20 diff --git a/include/soc/imx/revision.h b/include/soc/imx/revision.h index b2a55dafaf0a..b122d2fc8881 100644 --- a/include/soc/imx/revision.h +++ b/include/soc/imx/revision.h @@ -22,6 +22,7 @@ #define IMX_CHIP_REVISION_3_3 0x33 #define IMX_CHIP_REVISION_UNKNOWN 0xff =20 +int mx25_revision(void); int mx27_revision(void); int mx31_revision(void); int mx35_revision(void); --=20 2.30.2 From nobody Fri May 3 09:43:58 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA8A3C43334 for ; Thu, 23 Jun 2022 07:51:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230405AbiFWHvz (ORCPT ); Thu, 23 Jun 2022 03:51:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230300AbiFWHvw (ORCPT ); Thu, 23 Jun 2022 03:51:52 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24C972983A; Thu, 23 Jun 2022 00:51:51 -0700 (PDT) Received: from dslb-188-096-142-050.188.096.pools.vodafone-ip.de ([188.96.142.50] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1o4Hcx-0006sS-BK; Thu, 23 Jun 2022 09:51:47 +0200 From: Martin Kaiser To: Abel Vesa , Stephen Boyd Cc: Shawn Guo , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH v2 2/2] clk: imx25: make __mx25_clocks_init return void Date: Thu, 23 Jun 2022 09:51:04 +0200 Message-Id: <20220623075104.166529-3-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220623075104.166529-1-martin@kaiser.cx> References: <20220602080344.208702-1-martin@kaiser.cx> <20220623075104.166529-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The __mx25_clocks_init function always returns 0 and its only caller does not check the return value. Let's remove it. Signed-off-by: Martin Kaiser --- changes in v2: - send the patch to the clk maintainers drivers/clk/imx/clk-imx25.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c index 263409fca1eb..72b30dd7f05f 100644 --- a/drivers/clk/imx/clk-imx25.c +++ b/drivers/clk/imx/clk-imx25.c @@ -74,7 +74,7 @@ enum mx25_clks { =20 static struct clk *clk[clk_max]; =20 -static int __init __mx25_clocks_init(void __iomem *ccm_base) +static void __init __mx25_clocks_init(void __iomem *ccm_base) { BUG_ON(!ccm_base); =20 @@ -222,8 +222,6 @@ static int __init __mx25_clocks_init(void __iomem *ccm_= base) imx_register_uart_clocks(6); =20 imx_print_silicon_rev("i.MX25", mx25_revision()); - - return 0; } =20 static void __init mx25_clocks_init_dt(struct device_node *np) --=20 2.30.2