From nobody Mon Apr 20 02:46:13 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A02A2C433EF for ; Thu, 23 Jun 2022 04:59:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229527AbiFWE7b (ORCPT ); Thu, 23 Jun 2022 00:59:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230105AbiFWE5g (ORCPT ); Thu, 23 Jun 2022 00:57:36 -0400 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A5A147558; Wed, 22 Jun 2022 21:44:03 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 25N4hhQl007210; Wed, 22 Jun 2022 23:43:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1655959423; bh=FzKrRm04wWtFn692doS62Lv/7usbJv0aDyQjyM4vhQ8=; h=From:To:CC:Subject:Date; b=ZgvnoOoZxc3lFYc/7yKZPuQgUVS94yqvCdRdEIbMn56XfGa9CCoGXadVQ2N7+DAwn 87b5olorbSEqb9N+qvVbDH9l9+59qiwRxxsdS8OL3SdJgpUdKKKPjIrGVfVt0Jt7li rFjoA2Uel+eesL3+iXt3vS+/YOUXFpcnDu1aic+g= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 25N4hhoW015178 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 22 Jun 2022 23:43:43 -0500 Received: from DFLE112.ent.ti.com (10.64.6.33) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Wed, 22 Jun 2022 23:43:42 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Wed, 22 Jun 2022 23:43:42 -0500 Received: from ula0492258.dal.design.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 25N4hcHT127881; Wed, 22 Jun 2022 23:43:39 -0500 From: Siddharth Vadapalli To: , , CC: , , , , , Subject: [PATCH] net: ethernet: ti: am65-cpsw: Fix devlink port register sequence Date: Thu, 23 Jun 2022 10:13:37 +0530 Message-ID: <20220623044337.6179-1-s-vadapalli@ti.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Renaming interfaces using udevd depends on the interface being registered before its netdev is registered. Otherwise, udevd reads an empty phys_port_name value, resulting in the interface not being renamed. Fix this by registering the interface before registering its netdev by invoking am65_cpsw_nuss_register_devlink() before invoking register_netdev() for the interface. Signed-off-by: Siddharth Vadapalli --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/etherne= t/ti/am65-cpsw-nuss.c index fb92d4c1547d..47a6c4e5360b 100644 --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c @@ -2527,6 +2527,10 @@ static int am65_cpsw_nuss_register_ndevs(struct am65= _cpsw_common *common) return ret; } =20 + ret =3D am65_cpsw_nuss_register_devlink(common); + if (ret) + goto err_cleanup_ndev; + for (i =3D 0; i < common->port_num; i++) { port =3D &common->ports[i]; =20 @@ -2545,17 +2549,12 @@ static int am65_cpsw_nuss_register_ndevs(struct am6= 5_cpsw_common *common) if (ret) goto err_cleanup_ndev; =20 - ret =3D am65_cpsw_nuss_register_devlink(common); - if (ret) - goto clean_unregister_notifiers; - /* can't auto unregister ndev using devm_add_action() due to * devres release sequence in DD core for DMA */ =20 return 0; -clean_unregister_notifiers: - am65_cpsw_unregister_notifiers(common); + err_cleanup_ndev: am65_cpsw_nuss_cleanup_ndev(common); =20 --=20 2.36.1