From nobody Sun Apr 26 21:37:46 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A15CC43334 for ; Wed, 22 Jun 2022 10:54:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355921AbiFVKyA (ORCPT ); Wed, 22 Jun 2022 06:54:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355279AbiFVKxl (ORCPT ); Wed, 22 Jun 2022 06:53:41 -0400 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63A9D3BA69; Wed, 22 Jun 2022 03:53:39 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 25MArIS0035558; Wed, 22 Jun 2022 05:53:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1655895198; bh=zt9NxPj7rP19gJeRkq7nMIQHQLbolwtS/UXEfZYjJIo=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=gK+g+HNoVcYVOevXf9DVfopp38Ex2MqB1I8hK+7maa0CUEvT59zzJYyDu7jwaJocd pJhinHQyy1SqrC7OREOawCA33/BAnY+MWSADyDhHDsmaWInjB+2ZsVKsfhQlMVwXRf Ex+U/+m3FTsuFQa2omzk4QSopH5aPxk2QT2aPjIg= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 25MArI97080666 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 22 Jun 2022 05:53:18 -0500 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Wed, 22 Jun 2022 05:53:18 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Wed, 22 Jun 2022 05:53:18 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 25MArHDh089940; Wed, 22 Jun 2022 05:53:17 -0500 From: Rahul T R To: , , , , , CC: , , , , , , , , , Rahul T R Subject: [PATCH v3 1/3] phy: dt-bindings: cdns,dphy: Add compatible for dphy on j721e Date: Wed, 22 Jun 2022 16:23:09 +0530 Message-ID: <20220622105311.21415-2-r-ravikumar@ti.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220622105311.21415-1-r-ravikumar@ti.com> References: <20220622105311.21415-1-r-ravikumar@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add compatible to support dphy tx on j721e Signed-off-by: Rahul T R Reviewed-by: Laurent Pinchart Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/phy/cdns,dphy.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml b/Documen= tation/devicetree/bindings/phy/cdns,dphy.yaml index c50629bd1b51..f0e9ca8427bb 100644 --- a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml +++ b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml @@ -11,8 +11,9 @@ maintainers: =20 properties: compatible: - items: - - const: cdns,dphy + enum: + - cdns,dphy + - ti,j721e-dphy =20 reg: maxItems: 1 --=20 2.36.1 From nobody Sun Apr 26 21:37:46 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2E3AC433EF for ; Wed, 22 Jun 2022 10:54:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356049AbiFVKyC (ORCPT ); Wed, 22 Jun 2022 06:54:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355122AbiFVKxi (ORCPT ); Wed, 22 Jun 2022 06:53:38 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 613123B57B; Wed, 22 Jun 2022 03:53:36 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 25MArL3l020508; Wed, 22 Jun 2022 05:53:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1655895201; bh=09m75uj4VJKcv8qDIqXsO3yJrvrISC65hIrs8N9FE4I=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=UdGmC5fmkakApd7lqlK57Rq/M3yjOL6hddo7ojONKa/oiclikRntxdiEBnte9g5rR UxFS6ILTmwJNCm3zG57nVCffL93pAvbxujM61dRD5tIt4Tm+3fSUev6wAAZg8xW55m wxoUTrxwOX27wOqLC0WwDZ/ZFm5+ph32ielFgkNg= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 25MArLPh026681 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 22 Jun 2022 05:53:21 -0500 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Wed, 22 Jun 2022 05:53:20 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Wed, 22 Jun 2022 05:53:20 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 25MArJ2P016904; Wed, 22 Jun 2022 05:53:19 -0500 From: Rahul T R To: , , , , , CC: , , , , , , , , , Rahul T R Subject: [PATCH v3 2/3] phy: cdns-dphy: Add band config for dphy tx Date: Wed, 22 Jun 2022 16:23:10 +0530 Message-ID: <20220622105311.21415-3-r-ravikumar@ti.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220622105311.21415-1-r-ravikumar@ti.com> References: <20220622105311.21415-1-r-ravikumar@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add support for band ctrl config for dphy tx. Signed-off-by: Rahul T R Reviewed-by: Pratyush Yadav --- drivers/phy/cadence/cdns-dphy.c | 40 ++++++++++++++++++++++++++++++++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/drivers/phy/cadence/cdns-dphy.c b/drivers/phy/cadence/cdns-dph= y.c index ba042e39cfaf..14f951013b4f 100644 --- a/drivers/phy/cadence/cdns-dphy.c +++ b/drivers/phy/cadence/cdns-dphy.c @@ -3,6 +3,7 @@ * Copyright: 2017-2018 Cadence Design Systems, Inc. */ =20 +#include #include #include #include @@ -45,6 +46,10 @@ #define DPHY_CMN_OPDIV_FROM_REG BIT(6) #define DPHY_CMN_OPDIV(x) ((x) << 7) =20 +#define DPHY_BAND_CFG DPHY_PCS(0x0) +#define DPHY_BAND_CFG_LEFT_BAND GENMASK(4, 0) +#define DPHY_BAND_CFG_RIGHT_BAND GENMASK(9, 5) + #define DPHY_PSM_CFG DPHY_PCS(0x4) #define DPHY_PSM_CFG_FROM_REG BIT(0) #define DPHY_PSM_CLK_DIV(x) ((x) << 1) @@ -92,6 +97,12 @@ struct cdns_dphy { struct phy *phy; }; =20 +/* Order of bands is important since the index is the band number. */ +static const unsigned int tx_bands[] =3D { + 80, 100, 120, 160, 200, 240, 320, 390, 450, 510, 560, 640, 690, 770, + 870, 950, 1000, 1200, 1400, 1600, 1800, 2000, 2200, 2500 +}; + static int cdns_dsi_get_dphy_pll_cfg(struct cdns_dphy *dphy, struct cdns_dphy_cfg *cfg, struct phy_configure_opts_mipi_dphy *opts, @@ -232,6 +243,24 @@ static int cdns_dphy_config_from_opts(struct phy *phy, return 0; } =20 +static int cdns_dphy_tx_get_band_ctrl(unsigned long hs_clk_rate) +{ + unsigned int rate; + int i; + + rate =3D hs_clk_rate / 1000000UL; + + if (rate < tx_bands[0]) + return -EOPNOTSUPP; + + for (i =3D 0; i < ARRAY_SIZE(tx_bands) - 1; i++) { + if (rate >=3D tx_bands[i] && rate < tx_bands[i + 1]) + return i; + } + + return -EOPNOTSUPP; +} + static int cdns_dphy_validate(struct phy *phy, enum phy_mode mode, int sub= mode, union phy_configure_opts *opts) { @@ -247,7 +276,8 @@ static int cdns_dphy_configure(struct phy *phy, union p= hy_configure_opts *opts) { struct cdns_dphy *dphy =3D phy_get_drvdata(phy); struct cdns_dphy_cfg cfg =3D { 0 }; - int ret; + int ret, band_ctrl; + unsigned int reg; =20 ret =3D cdns_dphy_config_from_opts(phy, &opts->mipi_dphy, &cfg); if (ret) @@ -276,6 +306,14 @@ static int cdns_dphy_configure(struct phy *phy, union = phy_configure_opts *opts) */ cdns_dphy_set_pll_cfg(dphy, &cfg); =20 + band_ctrl =3D cdns_dphy_tx_get_band_ctrl(opts->mipi_dphy.hs_clk_rate); + if (band_ctrl < 0) + return band_ctrl; + + reg =3D FIELD_PREP(DPHY_BAND_CFG_LEFT_BAND, band_ctrl) | + FIELD_PREP(DPHY_BAND_CFG_RIGHT_BAND, band_ctrl); + writel(reg, dphy->regs + DPHY_BAND_CFG); + return 0; } =20 --=20 2.36.1 From nobody Sun Apr 26 21:37:46 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1DBECCA47D for ; Wed, 22 Jun 2022 10:53:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355656AbiFVKxv (ORCPT ); Wed, 22 Jun 2022 06:53:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355072AbiFVKxi (ORCPT ); Wed, 22 Jun 2022 06:53:38 -0400 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29A8739B9A; Wed, 22 Jun 2022 03:53:36 -0700 (PDT) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 25MArMte027964; Wed, 22 Jun 2022 05:53:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1655895202; bh=28XJ9wIA9l8rfkupe3uYGly7sxILC7G1n8Ezz6F22jA=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=I+yTT2dw9VtgG60z9c47p3kqWNCykoLbY+HSrIUoqlPhTYlAs3/W9Yoz/OzUHsNBz 0A70MJgAMziUmhw4oKP/0lz2PujbqmlnDkYZBRL8XhgFvtXSPw1XLd4t1F1EWvEI2Q I4Dtj+Ch1QkEbDppQ3QCIi9j9PJit0QOYK1pxs3c= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 25MArMsd083854 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 22 Jun 2022 05:53:22 -0500 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Wed, 22 Jun 2022 05:53:22 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Wed, 22 Jun 2022 05:53:22 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 25MArLqp043750; Wed, 22 Jun 2022 05:53:21 -0500 From: Rahul T R To: , , , , , CC: , , , , , , , , , Rahul T R Subject: [PATCH v3 3/3] phy: cdns-dphy: Add support for DPHY TX on J721e Date: Wed, 22 Jun 2022 16:23:11 +0530 Message-ID: <20220622105311.21415-4-r-ravikumar@ti.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220622105311.21415-1-r-ravikumar@ti.com> References: <20220622105311.21415-1-r-ravikumar@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add support new compatible for dphy-tx on j721e and implement dphy ops required. Signed-off-by: Rahul T R --- drivers/phy/cadence/Kconfig | 10 ++++++ drivers/phy/cadence/cdns-dphy.c | 62 +++++++++++++++++++++++++++++++++ 2 files changed, 72 insertions(+) diff --git a/drivers/phy/cadence/Kconfig b/drivers/phy/cadence/Kconfig index 1adde2d99ae7..18024ac6d511 100644 --- a/drivers/phy/cadence/Kconfig +++ b/drivers/phy/cadence/Kconfig @@ -22,6 +22,16 @@ config PHY_CADENCE_DPHY system. If M is selected, the module will be called cdns-dphy. =20 +if PHY_CADENCE_DPHY + +config PHY_CADENCE_DPHY_J721E + depends on ARCH_K3 || COMPILE_TEST + bool "J721E DPHY TX Wiz support" + default y + help + Support J721E Cadence DPHY TX Wiz configuration. +endif + config PHY_CADENCE_DPHY_RX tristate "Cadence D-PHY Rx Support" depends on HAS_IOMEM && OF diff --git a/drivers/phy/cadence/cdns-dphy.c b/drivers/phy/cadence/cdns-dph= y.c index 14f951013b4f..a6b7d696f77a 100644 --- a/drivers/phy/cadence/cdns-dphy.c +++ b/drivers/phy/cadence/cdns-dphy.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -18,6 +19,7 @@ =20 #define REG_WAKEUP_TIME_NS 800 #define DPHY_PLL_RATE_HZ 108000000 +#define POLL_TIMEOUT_US 1000 =20 /* DPHY registers */ #define DPHY_PMA_CMN(reg) (reg) @@ -62,6 +64,18 @@ #define DSI_NULL_FRAME_OVERHEAD 6 #define DSI_EOT_PKT_SIZE 4 =20 +#define DPHY_TX_J721E_WIZ_PLL_CTRL 0xF04 +#define DPHY_TX_J721E_WIZ_STATUS 0xF08 +#define DPHY_TX_J721E_WIZ_RST_CTRL 0xF0C +#define DPHY_TX_J721E_WIZ_PSM_FREQ 0xF10 + +#define DPHY_TX_J721E_WIZ_IPDIV GENMASK(4, 0) +#define DPHY_TX_J721E_WIZ_OPDIV GENMASK(13, 8) +#define DPHY_TX_J721E_WIZ_FBDIV GENMASK(25, 16) +#define DPHY_TX_J721E_WIZ_LANE_RSTB BIT(31) +#define DPHY_TX_WIZ_PLL_LOCK BIT(31) +#define DPHY_TX_WIZ_O_CMN_READY BIT(31) + struct cdns_dphy_cfg { u8 pll_ipdiv; u8 pll_opdiv; @@ -210,6 +224,43 @@ static void cdns_dphy_ref_set_psm_div(struct cdns_dphy= *dphy, u8 div) dphy->regs + DPHY_PSM_CFG); } =20 +#ifdef CONFIG_PHY_CADENCE_DPHY_J721E +static unsigned long cdns_dphy_j721e_get_wakeup_time_ns(struct cdns_dphy *= dphy) +{ + return 1000000; +} + +static void cdns_dphy_j721e_set_pll_cfg(struct cdns_dphy *dphy, + const struct cdns_dphy_cfg *cfg) +{ + u32 status; + + writel(DPHY_CMN_PWM_HIGH(6) | DPHY_CMN_PWM_LOW(0x101) | + DPHY_CMN_PWM_DIV(0x8), + dphy->regs + DPHY_CMN_PWM); + + writel((FIELD_PREP(DPHY_TX_J721E_WIZ_IPDIV, cfg->pll_ipdiv) | + FIELD_PREP(DPHY_TX_J721E_WIZ_OPDIV, cfg->pll_opdiv) | + FIELD_PREP(DPHY_TX_J721E_WIZ_FBDIV, cfg->pll_fbdiv)), + dphy->regs + DPHY_TX_J721E_WIZ_PLL_CTRL); + + writel(DPHY_TX_J721E_WIZ_LANE_RSTB, + dphy->regs + DPHY_TX_J721E_WIZ_RST_CTRL); + + readl_poll_timeout(dphy->regs + DPHY_TX_J721E_WIZ_PLL_CTRL, status, + (status & DPHY_TX_WIZ_PLL_LOCK), 0, POLL_TIMEOUT_US); + + readl_poll_timeout(dphy->regs + DPHY_TX_J721E_WIZ_STATUS, status, + (status & DPHY_TX_WIZ_O_CMN_READY), 0, + POLL_TIMEOUT_US); +} + +static void cdns_dphy_j721e_set_psm_div(struct cdns_dphy *dphy, u8 div) +{ + writel(div, dphy->regs + DPHY_TX_J721E_WIZ_PSM_FREQ); +} +#endif /* !CONFIG_PHY_CADENCE_DPHY_J721E */ + /* * This is the reference implementation of DPHY hooks. Specific integratio= n of * this IP may have to re-implement some of them depending on how they dec= ided @@ -221,6 +272,14 @@ static const struct cdns_dphy_ops ref_dphy_ops =3D { .set_psm_div =3D cdns_dphy_ref_set_psm_div, }; =20 +#ifdef CONFIG_PHY_CADENCE_DPHY_J721E +static const struct cdns_dphy_ops j721e_dphy_ops =3D { + .get_wakeup_time_ns =3D cdns_dphy_j721e_get_wakeup_time_ns, + .set_pll_cfg =3D cdns_dphy_j721e_set_pll_cfg, + .set_psm_div =3D cdns_dphy_j721e_set_psm_div, +}; +#endif /* !CONFIG_PHY_CADENCE_DPHY_J721E */ + static int cdns_dphy_config_from_opts(struct phy *phy, struct phy_configure_opts_mipi_dphy *opts, struct cdns_dphy_cfg *cfg) @@ -408,6 +467,9 @@ static int cdns_dphy_remove(struct platform_device *pde= v) =20 static const struct of_device_id cdns_dphy_of_match[] =3D { { .compatible =3D "cdns,dphy", .data =3D &ref_dphy_ops }, +#ifdef CONFIG_PHY_CADENCE_DPHY_J721E + { .compatible =3D "ti,j721e-dphy", .data =3D &j721e_dphy_ops }, +#endif /* !CONFIG_PHY_CADENCE_DPHY_J721E */ { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, cdns_dphy_of_match); --=20 2.36.1