From nobody Mon Apr 20 07:31:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC389C43334 for ; Tue, 21 Jun 2022 13:00:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351056AbiFUNAx (ORCPT ); Tue, 21 Jun 2022 09:00:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351022AbiFUNA2 (ORCPT ); Tue, 21 Jun 2022 09:00:28 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B9702C119; Tue, 21 Jun 2022 05:59:57 -0700 (PDT) Received: from kwepemi500015.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LS6334vNNzSgwV; Tue, 21 Jun 2022 20:56:31 +0800 (CST) Received: from huawei.com (10.175.127.227) by kwepemi500015.china.huawei.com (7.221.188.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 21 Jun 2022 20:59:54 +0800 From: Zheng Bin To: , , , , , , , , , , CC: , Subject: [PATCH -next] net: pcs: pcs-xpcs: Fix build error when CONFIG_PCS_XPCS=y && CONFIG_PHYLINK=m Date: Tue, 21 Jun 2022 21:12:51 +0800 Message-ID: <20220621131251.3357104-1-zhengbin13@huawei.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.127.227] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500015.china.huawei.com (7.221.188.92) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" If CONFIG_PCS_XPCS=3Dy, CONFIG_PHYLINK=3Dm, bulding fails: drivers/net/pcs/pcs-xpcs.o: in function `xpcs_do_config': pcs-xpcs.c:(.text+0x64f): undefined reference to `phylink_mii_c22_pcs_encod= e_advertisement' drivers/net/pcs/pcs-xpcs.o: in function `xpcs_get_state': pcs-xpcs.c:(.text+0x10f8): undefined reference to `phylink_mii_c22_pcs_deco= de_state Make PCS_XPCS depends on PHYLINK to fix this. Fixes: b47aec885bcd ("net: pcs: xpcs: add CL37 1000BASE-X AN support") Signed-off-by: Zheng Bin --- drivers/net/pcs/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/pcs/Kconfig b/drivers/net/pcs/Kconfig index 22ba7b0b476d..faec931b1e65 100644 --- a/drivers/net/pcs/Kconfig +++ b/drivers/net/pcs/Kconfig @@ -8,6 +8,7 @@ menu "PCS device drivers" config PCS_XPCS tristate "Synopsys DesignWare XPCS controller" depends on MDIO_DEVICE && MDIO_BUS + depends on PHYLINK help This module provides helper functions for Synopsys DesignWare XPCS controllers. -- 2.31.1