From nobody Mon Apr 20 07:30:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 928C6C43334 for ; Tue, 21 Jun 2022 12:40:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350494AbiFUMkB (ORCPT ); Tue, 21 Jun 2022 08:40:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350483AbiFUMjr (ORCPT ); Tue, 21 Jun 2022 08:39:47 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3A9127FDA for ; Tue, 21 Jun 2022 05:39:43 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id mf9so6879737ejb.0 for ; Tue, 21 Jun 2022 05:39:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TyZtZSd5cTSSlPOn3/pu61X0lFqS8ubq/VPK6S5b8ro=; b=Rv/Yqt5L/Omcx8Z4jk+PLWm3p+qCYYlTOiWU4H928xtWMMWnYe6lWQGl6vwZeL3eSF KtmmQP8JAslPyl/TNLCcj2Orv7v4qSudY/6USovJIjwqxi3U/KYIWpD4nVwvfXcnGzxg R6r+aLDpNBtUmmj5Vc2IqoiHL5nwxJLzwBdL0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TyZtZSd5cTSSlPOn3/pu61X0lFqS8ubq/VPK6S5b8ro=; b=7NxnzGxT80zVlJtHQ4zJgnGitWi+KyTyWK1B8jNzK40tJSx81oKbJdgofB7qsI5Z5t sKcFgHNocpETlv8u0kvgmYD2ftY0yQlgaWAHVQRWLQESjod5fik2FcumPN7LPKIB1xEK LLDdElaHqLMQPDqOgQq8mbtomKuqjlNr/cjXZc38Lf9+YuGHHhhdFBtFBjBaeX+wVNW4 kQBk3QvoHH30/EqrzNAzU/9RWORoYNO+WUevk4qEnlc0M+/rd4Hd7X+0Cvri/dNQurML M/Oqs3v9XW7NbASoPITRzcpx0jMZU6Y29Z1PawO15MeyCyqm69Z7GMvkvLO5VRDpUhju CCTw== X-Gm-Message-State: AJIora/oEwGwoN8W1Py4Q5TgYYTsdPkqUz1d0yehzJP9AgaC8qCl0yTH 3VHp+YaQ51YqMv4VLmVJDuWeyotp98YIwA== X-Google-Smtp-Source: AGRyM1tico6RHxSTDuKq8TfoYMOplNp3NnDhWLGZr7I0mOs1ETwvU6g+HB4Sv95AsVv1Cdv+3MFF0g== X-Received: by 2002:a17:906:7953:b0:722:e8e3:ef67 with SMTP id l19-20020a170906795300b00722e8e3ef67mr49309ejo.199.1655815182051; Tue, 21 Jun 2022 05:39:42 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-80-116-90-174.pool80116.interbusiness.it. [80.116.90.174]) by smtp.gmail.com with ESMTPSA id c19-20020aa7c753000000b004357063bf60sm8003945eds.41.2022.06.21.05.39.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 05:39:41 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Dario Binacchi , Michael Trimarchi , Rob Herring , Dmitry Torokhov , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-input@vger.kernel.org Subject: [RESEND PATCH v4 1/6] dt-bindings: input: touchscreen: edt-ft5x06: add report-rate-hz Date: Tue, 21 Jun 2022 14:39:32 +0200 Message-Id: <20220621123937.1330389-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220621123937.1330389-1-dario.binacchi@amarulasolutions.com> References: <20220621123937.1330389-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" It allows to change the M06/M12 default scan rate. Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Acked-by: Rob Herring --- Changes in v4: - Add Rob Herring 'Acked-by' tag. Changes in v3: - Add hz unit suffix. - Add '|' to description. .../devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06= .yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml index 2e8da7470513..46bc8c028fe6 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml @@ -85,6 +85,14 @@ properties: minimum: 0 maximum: 80 =20 + report-rate-hz: + description: | + Allows setting the scan rate in Hertz. + M06 supports range from 30 to 140 Hz. + M12 supports range from 1 to 255 Hz. + minimum: 1 + maximum: 255 + touchscreen-size-x: true touchscreen-size-y: true touchscreen-fuzz-x: true --=20 2.32.0 From nobody Mon Apr 20 07:30:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86472C43334 for ; Tue, 21 Jun 2022 12:39:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350515AbiFUMjw (ORCPT ); Tue, 21 Jun 2022 08:39:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350480AbiFUMjq (ORCPT ); Tue, 21 Jun 2022 08:39:46 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5EAC24099 for ; Tue, 21 Jun 2022 05:39:44 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id g26so5828272ejb.5 for ; Tue, 21 Jun 2022 05:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5FXIG1Rp9D4NgAZ2oOx6JgdhKdrDvM+0LjdQT4OHOI8=; b=nqeYuagDG4VYaSbzaCmy1tqZMz4yp8N0hl1ERuPdogW+lf6Y9/K1Y2I2Xx5BZufqh0 +ZxOWPo83uLZX9jfNahcgB3YaOLeN5Viv+5gt0YC/3DOWL3dtcwSE6yNLgwjZlzE0ehx XMmS5FKcAkTdcjPzYcqBZasbpYKnp2NeTomi0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5FXIG1Rp9D4NgAZ2oOx6JgdhKdrDvM+0LjdQT4OHOI8=; b=55bAqXuWvuBi1yyGCJiGi36/aGEdoJbn+XxLHsGeI/iPvhm/uhpRz2aDzjPHCRb6km 98JKTnxXD3gq8ZsriRfNbRbab5Ok8Hpt2uSPLQ3qfJo9PwFq43R0gW4Qfw8aCWgA+Ce4 3RxEK3r/QxBASz/9Gm3TIyIoNkkxqQxxQ/LIdAIsQjFCWAolxcMq8bjtgEu9jf3LD2Or hHgnV/qusFmjZHjRpfKOweQgAtjYqR7QZfJzj0AHcnIFOQnOSQyGPB0BQ5b7pNb4pBbX esDdvlncSOzS6DTZY5D8yM/XY6Rtaejz6XyERyknNvxarjeB0XVayiTrGQN2NBs0xMtP qP+w== X-Gm-Message-State: AJIora/RMpaSDFAtq3gXKUZj3AGqKwZ7u700/g021bU7HNyhuLSUZWkg Ezgh/5f/VuHhzInCFsLeiNADpa8LHr68kg== X-Google-Smtp-Source: AGRyM1snl4Lq8GimgUfgjaF2BN5Pglx7SsqDhORPMHpswAOut39kUfL6kVlUcNgUJ5cXMSx+m6Ioiw== X-Received: by 2002:a17:907:c202:b0:710:8d0c:6e89 with SMTP id ti2-20020a170907c20200b007108d0c6e89mr25577538ejc.141.1655815183056; Tue, 21 Jun 2022 05:39:43 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-80-116-90-174.pool80116.interbusiness.it. [80.116.90.174]) by smtp.gmail.com with ESMTPSA id c19-20020aa7c753000000b004357063bf60sm8003945eds.41.2022.06.21.05.39.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 05:39:42 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Dario Binacchi , Michael Trimarchi , Dmitry Torokhov , Marco Felsch , Oliver Graute , linux-input@vger.kernel.org Subject: [RESEND PATCH v4 2/6] Input: edt-ft5x06 - get/set M12 report rate by sysfs Date: Tue, 21 Jun 2022 14:39:33 +0200 Message-Id: <20220621123937.1330389-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220621123937.1330389-1-dario.binacchi@amarulasolutions.com> References: <20220621123937.1330389-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add support for reading/writing scan rate (SC) register for M12 by sysfs. The register value is equal to the SC (Hz), unlike M06, where instead it is equal to SC / 10. Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Tested-by: Dario Binacchi Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/input/touchscreen/edt-ft5x06.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchsc= reen/edt-ft5x06.c index bb2e1cbffba7..77f061af5c61 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c @@ -47,6 +47,8 @@ #define M09_REGISTER_NUM_X 0x94 #define M09_REGISTER_NUM_Y 0x95 =20 +#define M12_REGISTER_REPORT_RATE 0x88 + #define EV_REGISTER_THRESHOLD 0x40 #define EV_REGISTER_GAIN 0x41 #define EV_REGISTER_OFFSET_Y 0x45 @@ -523,9 +525,9 @@ static EDT_ATTR(offset_y, S_IWUSR | S_IRUGO, NO_REGISTE= R, NO_REGISTER, /* m06: range 20 to 80, m09: range 0 to 30, m12: range 1 to 255... */ static EDT_ATTR(threshold, S_IWUSR | S_IRUGO, WORK_REGISTER_THRESHOLD, M09_REGISTER_THRESHOLD, EV_REGISTER_THRESHOLD, 0, 255); -/* m06: range 3 to 14, m12: (0x64: 100Hz) */ +/* m06: range 3 to 14, m12: range 1 to 255 */ static EDT_ATTR(report_rate, S_IWUSR | S_IRUGO, WORK_REGISTER_REPORT_RATE, - NO_REGISTER, NO_REGISTER, 0, 255); + M12_REGISTER_REPORT_RATE, NO_REGISTER, 0, 255); =20 static struct attribute *edt_ft5x06_attrs[] =3D { &edt_ft5x06_attr_gain.dattr.attr, @@ -1030,7 +1032,8 @@ static void edt_ft5x06_ts_set_regs(struct edt_ft5x06_= ts_data *tsdata) case EDT_M09: case EDT_M12: reg_addr->reg_threshold =3D M09_REGISTER_THRESHOLD; - reg_addr->reg_report_rate =3D NO_REGISTER; + reg_addr->reg_report_rate =3D tsdata->version =3D=3D EDT_M12 ? + M12_REGISTER_REPORT_RATE : NO_REGISTER; reg_addr->reg_gain =3D M09_REGISTER_GAIN; reg_addr->reg_offset =3D M09_REGISTER_OFFSET; reg_addr->reg_offset_x =3D NO_REGISTER; --=20 2.32.0 From nobody Mon Apr 20 07:30:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87679C43334 for ; Tue, 21 Jun 2022 12:40:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350522AbiFUMj6 (ORCPT ); Tue, 21 Jun 2022 08:39:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350494AbiFUMjs (ORCPT ); Tue, 21 Jun 2022 08:39:48 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C08CF237C2 for ; Tue, 21 Jun 2022 05:39:45 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id ej4so15228533edb.7 for ; Tue, 21 Jun 2022 05:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NIUuHRgvgWCmYJCricL+FHDsiVQYgUJ0FjEwcnUqvHA=; b=gWq873+sESE/ug08HIlhpajhkAH5/6YjB/Wi0lpEju9TWgO/BWQ727bblRKV2pHzwY NHMjW4qq9mCgRnxGIhyl+9xMuCnz6LspsIzfEJXBwzE8sXnUgIXiHYuUk2KbbmdBDC3q GvUATBF9RB43qxWJWsK4v8sw77gJkC4h5BcFA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NIUuHRgvgWCmYJCricL+FHDsiVQYgUJ0FjEwcnUqvHA=; b=z5sKQIn3dhUxeu4qe5YRa7pG7v+QvYmBriukvTM0BOrFhYzQu3cYWes4KMOtcIVyiH HWdYAR1IZ1+FfHEvEYygtZHLVmUUymH/elVhlX0YaTYnb2XEAKu0zCmLTwxKUb1BAJqU AL6VrI1z5LWNWhp/obGm+3gxne9xso6iP7Ne6/J1jw30/FzZWWL3zCbmYCX+TziTz/47 zos1NklPzUrxQrOCZl0rA0HCqVCXn98vFYfeabj4F3Kq+JADF8F8OsojMUQq/4ImVCLh e1j3iJoRG47HpwKYcKillSz+CmEDrUVyPj8RtoCNrxWbYovbli/xLHTzzb3u18zeOve8 f19Q== X-Gm-Message-State: AJIora/dY7ULiA7WyUmGXZMJfEtQpQmOAdGTsAjDndm9TYhV2Ff2vycm gl7YW2rkZ1hpxOMShPCdrdWmv+fWHQKPKw== X-Google-Smtp-Source: AGRyM1vWRZC2rTjzpFcdLFBlYMHd99yNVBLnBQl3nqWi1gNfOcY5sV+TaSYUg95yWXhwsr32p/cUpQ== X-Received: by 2002:a05:6402:3713:b0:435:539e:a939 with SMTP id ek19-20020a056402371300b00435539ea939mr30972033edb.160.1655815184111; Tue, 21 Jun 2022 05:39:44 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-80-116-90-174.pool80116.interbusiness.it. [80.116.90.174]) by smtp.gmail.com with ESMTPSA id c19-20020aa7c753000000b004357063bf60sm8003945eds.41.2022.06.21.05.39.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 05:39:43 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Dario Binacchi , Michael Trimarchi , Dmitry Torokhov , Marco Felsch , Oliver Graute , linux-input@vger.kernel.org Subject: [RESEND PATCH v4 3/6] Input: edt-ft5x06 - set report rate by dts property Date: Tue, 21 Jun 2022 14:39:34 +0200 Message-Id: <20220621123937.1330389-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220621123937.1330389-1-dario.binacchi@amarulasolutions.com> References: <20220621123937.1330389-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" It allows to change the M06/M12 default scan rate on driver probing. Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v3) Changes in v3: - Check the lower and upper limits of the report-rate-hz value - Convert the M06 report-rate-hz value drivers/input/touchscreen/edt-ft5x06.c | 30 ++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchsc= reen/edt-ft5x06.c index 77f061af5c61..843e8b0522f7 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c @@ -1084,6 +1084,7 @@ static int edt_ft5x06_ts_probe(struct i2c_client *cli= ent, struct input_dev *input; unsigned long irq_flags; int error; + u32 report_rate; char fw_version[EDT_NAME_LEN]; =20 dev_dbg(&client->dev, "probing for EDT FT5x06 I2C\n"); @@ -1213,6 +1214,35 @@ static int edt_ft5x06_ts_probe(struct i2c_client *cl= ient, edt_ft5x06_ts_get_defaults(&client->dev, tsdata); edt_ft5x06_ts_get_parameters(tsdata); =20 + if (tsdata->reg_addr.reg_report_rate !=3D NO_REGISTER && + !of_property_read_u32(client->dev.of_node, "report-rate-hz", + &report_rate)) { + tsdata->report_rate =3D report_rate; + if (tsdata->version =3D=3D EDT_M06) { + if (report_rate < 30) + report_rate =3D 30; + else if (report_rate > 140) + report_rate =3D 140; + } else if (report_rate < 1) { + report_rate =3D 1; + } else if (report_rate > 255) + report_rate =3D 255; + + if (report_rate !=3D tsdata->report_rate) + dev_warn(&client->dev, + "report-rate %dHz is unsupported, use %dHz\n", + tsdata->report_rate, report_rate); + + if (tsdata->version =3D=3D EDT_M06) + report_rate /=3D 10; + + tsdata->report_rate =3D report_rate; + + edt_ft5x06_register_write(tsdata, + tsdata->reg_addr.reg_report_rate, + tsdata->report_rate); + } + dev_dbg(&client->dev, "Model \"%s\", Rev. \"%s\", %dx%d sensors\n", tsdata->name, fw_version, tsdata->num_x, tsdata->num_y); --=20 2.32.0 From nobody Mon Apr 20 07:30:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 059F4C43334 for ; Tue, 21 Jun 2022 12:40:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350570AbiFUMkD (ORCPT ); Tue, 21 Jun 2022 08:40:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350496AbiFUMjs (ORCPT ); Tue, 21 Jun 2022 08:39:48 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E66D1D33E for ; Tue, 21 Jun 2022 05:39:47 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id z19so2339074edb.11 for ; Tue, 21 Jun 2022 05:39:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b85JvDSGn8w4tr7JpVbjtxkbsu1O4D+F+hX3OsbfqCs=; b=T09TgHVdVJZmzUPSPlFfOkxGtvFLfz7rmFTqJydBgLkLmCznsPvZI8z/meS3GIC2JR 6C7bXfvH3fPLxkB6WtUZr0Sqb2BIooFp/gex5z2dU0IXfSA9QB5T2r+yGSwfY+x0PRy+ tqUHvyTWk50XH2CvqoIB023ycbrr0BUwIxvxg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b85JvDSGn8w4tr7JpVbjtxkbsu1O4D+F+hX3OsbfqCs=; b=qQ/w7rgUOXwZe8JvS7k01/ZyVjT4tYl/PdGdmznFvwpC2KH5aWWT/23YuEvjswRZCs XUU4mltKSTDkTmkUKopvRPj+YIwt9c6PdB40cwhyW5EsBYAeNomeB49x9NduW0Yw2Ta9 mdoNvlbgl32LS170mpvAwrOioD6lg2R31rlUfxZ4rh1KPGL17qede09yyh0AxWosqGaI nGAxiTgoGpD8Ho29M9nkWoaqjTX6kCmCr4G7bDXcshHvZ9jfmKJIOX2wrOv5NX9r98yR vR4+RrXMuYWWzfPe7yz+bFVNyA8JXLxob4/S6hAGCgyq4XOVHjf3qVgxMWycj4Ogw9zu LDRw== X-Gm-Message-State: AJIora81f72ynRzc62TWUPwdtFDwZIMvanoTohL2Lq4S95ItGXmPvaLC qPrW+/EfVKSzOINupNyUCSTvp0mX0T9jmA== X-Google-Smtp-Source: AGRyM1tvKjTE5lH7ZBfFar8AtZLlU1qZ5MxnP7NFKK0HAHmBK3hBafLydCKrN97pZu5KO/gjBKv7aw== X-Received: by 2002:aa7:db8d:0:b0:42e:1cbc:5e28 with SMTP id u13-20020aa7db8d000000b0042e1cbc5e28mr34978873edt.366.1655815185253; Tue, 21 Jun 2022 05:39:45 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-80-116-90-174.pool80116.interbusiness.it. [80.116.90.174]) by smtp.gmail.com with ESMTPSA id c19-20020aa7c753000000b004357063bf60sm8003945eds.41.2022.06.21.05.39.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 05:39:44 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Dario Binacchi , Michael Trimarchi , Oliver Graute , Dmitry Torokhov , Marco Felsch , linux-input@vger.kernel.org Subject: [RESEND PATCH v4 4/6] Input: edt-ft5x06 - show model name by sysfs Date: Tue, 21 Jun 2022 14:39:35 +0200 Message-Id: <20220621123937.1330389-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220621123937.1330389-1-dario.binacchi@amarulasolutions.com> References: <20220621123937.1330389-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The model name was printed only if debug mode was enabled. Now you can always get it from sysfs. Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Acked-by: Oliver Graute --- (no changes since v1) drivers/input/touchscreen/edt-ft5x06.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchsc= reen/edt-ft5x06.c index 843e8b0522f7..89157deebfcb 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c @@ -529,6 +529,17 @@ static EDT_ATTR(threshold, S_IWUSR | S_IRUGO, WORK_REG= ISTER_THRESHOLD, static EDT_ATTR(report_rate, S_IWUSR | S_IRUGO, WORK_REGISTER_REPORT_RATE, M12_REGISTER_REPORT_RATE, NO_REGISTER, 0, 255); =20 +static ssize_t model_show(struct device *dev, struct device_attribute *att= r, + char *buf) +{ + struct i2c_client *client =3D to_i2c_client(dev); + struct edt_ft5x06_ts_data *tsdata =3D i2c_get_clientdata(client); + + return scnprintf(buf, PAGE_SIZE, "%s\n", tsdata->name); +} + +static DEVICE_ATTR_RO(model); + static struct attribute *edt_ft5x06_attrs[] =3D { &edt_ft5x06_attr_gain.dattr.attr, &edt_ft5x06_attr_offset.dattr.attr, @@ -536,6 +547,7 @@ static struct attribute *edt_ft5x06_attrs[] =3D { &edt_ft5x06_attr_offset_y.dattr.attr, &edt_ft5x06_attr_threshold.dattr.attr, &edt_ft5x06_attr_report_rate.dattr.attr, + &dev_attr_model.attr, NULL }; =20 --=20 2.32.0 From nobody Mon Apr 20 07:30:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CF26C43334 for ; Tue, 21 Jun 2022 12:40:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350584AbiFUMkG (ORCPT ); Tue, 21 Jun 2022 08:40:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350477AbiFUMjt (ORCPT ); Tue, 21 Jun 2022 08:39:49 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F2B32459E for ; Tue, 21 Jun 2022 05:39:48 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id e2so8244920edv.3 for ; Tue, 21 Jun 2022 05:39:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YV+qTrBSZlEdVwvYGQdRpxUtm5BLonFPqiCggidUwTw=; b=DzjD39TO7HO7BYMja/VLATnaxbVRWSyYcQpTzloDDWZX9fn4l/9ro6ykcILPApxrkO 6vPdVBsjJgL5uAUXCSslYuh/0EzQXAc5nGXP/dm0roklLNQxMOzU+hozlFJlDaxiKEgP r4frnOOI5K4eI6tDbyLGe1sLU2uOfcm/sxAAQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YV+qTrBSZlEdVwvYGQdRpxUtm5BLonFPqiCggidUwTw=; b=gsb5igLWKkNXukBlT1bQekmlbZKbxV/WwMy/8eMHGZ+2ydQ+LkqF1B2lKJtUehw+/W aeh0RaYw1M7KfHv2XOJLe8xVcSOMk4zWJmP/ltqtAJB3qVrIMVqvoxNxCo9LKH0D3wMF ZgsIUXCyrXKEmu1SjjcSEQNaaNnGtzkWVMXrnE76k7GA6D8fLPvrzG2nzf3mah+Q0UlO e8sTWxKhcW73dub29lZkLLoHM11VUN8LgJEdjvrBcyL3upcGW6zJCSDPWlKfi/465Bow x7G1GlW4HTOIm4uUpiNQ3hGM14bTLmVBE1a9WvmiurZCfDfCkXYh/yhE5JPbh3pAFgzE fevw== X-Gm-Message-State: AJIora/L1gM7WPWEyrnyEcZRdHrH8x9GNILhVSsId+D4xoe46Vjej9qo SFabvw6BOELs0cnyjWIEng/Z9eCT7MFVNg== X-Google-Smtp-Source: AGRyM1vtfHojiMAA0tPuu4LTypwrbhOpn71vP5WR1ZIlLO8y9atpt4RoG5X027Wu9x4ZRerph1+AjA== X-Received: by 2002:a05:6402:b8c:b0:435:6d4b:37e4 with SMTP id cf12-20020a0564020b8c00b004356d4b37e4mr20951504edb.109.1655815186334; Tue, 21 Jun 2022 05:39:46 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-80-116-90-174.pool80116.interbusiness.it. [80.116.90.174]) by smtp.gmail.com with ESMTPSA id c19-20020aa7c753000000b004357063bf60sm8003945eds.41.2022.06.21.05.39.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 05:39:45 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Dario Binacchi , Michael Trimarchi , Oliver Graute , Dmitry Torokhov , Marco Felsch , linux-input@vger.kernel.org Subject: [RESEND PATCH v4 5/6] Input: edt-ft5x06 - show firmware version by sysfs Date: Tue, 21 Jun 2022 14:39:36 +0200 Message-Id: <20220621123937.1330389-6-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220621123937.1330389-1-dario.binacchi@amarulasolutions.com> References: <20220621123937.1330389-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The firmware version was printed only if debug mode was enabled. Now you can always get it from sysfs. Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Acked-by: Oliver Graute --- (no changes since v1) drivers/input/touchscreen/edt-ft5x06.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchsc= reen/edt-ft5x06.c index 89157deebfcb..bab92344b2ea 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c @@ -129,6 +129,7 @@ struct edt_ft5x06_ts_data { int max_support_points; =20 char name[EDT_NAME_LEN]; + char fw_version[EDT_NAME_LEN]; =20 struct edt_reg_addr reg_addr; enum edt_ver version; @@ -540,6 +541,17 @@ static ssize_t model_show(struct device *dev, struct d= evice_attribute *attr, =20 static DEVICE_ATTR_RO(model); =20 +static ssize_t fw_version_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct i2c_client *client =3D to_i2c_client(dev); + struct edt_ft5x06_ts_data *tsdata =3D i2c_get_clientdata(client); + + return scnprintf(buf, PAGE_SIZE, "%s\n", tsdata->fw_version); +} + +static DEVICE_ATTR_RO(fw_version); + static struct attribute *edt_ft5x06_attrs[] =3D { &edt_ft5x06_attr_gain.dattr.attr, &edt_ft5x06_attr_offset.dattr.attr, @@ -548,6 +560,7 @@ static struct attribute *edt_ft5x06_attrs[] =3D { &edt_ft5x06_attr_threshold.dattr.attr, &edt_ft5x06_attr_report_rate.dattr.attr, &dev_attr_model.attr, + &dev_attr_fw_version.attr, NULL }; =20 @@ -834,13 +847,13 @@ static void edt_ft5x06_ts_teardown_debugfs(struct edt= _ft5x06_ts_data *tsdata) #endif /* CONFIG_DEBUGFS */ =20 static int edt_ft5x06_ts_identify(struct i2c_client *client, - struct edt_ft5x06_ts_data *tsdata, - char *fw_version) + struct edt_ft5x06_ts_data *tsdata) { u8 rdbuf[EDT_NAME_LEN]; char *p; int error; char *model_name =3D tsdata->name; + char *fw_version =3D tsdata->fw_version; =20 /* see what we find if we assume it is a M06 * * if we get less than EDT_NAME_LEN, we don't want @@ -1097,7 +1110,6 @@ static int edt_ft5x06_ts_probe(struct i2c_client *cli= ent, unsigned long irq_flags; int error; u32 report_rate; - char fw_version[EDT_NAME_LEN]; =20 dev_dbg(&client->dev, "probing for EDT FT5x06 I2C\n"); =20 @@ -1210,7 +1222,7 @@ static int edt_ft5x06_ts_probe(struct i2c_client *cli= ent, tsdata->input =3D input; tsdata->factory_mode =3D false; =20 - error =3D edt_ft5x06_ts_identify(client, tsdata, fw_version); + error =3D edt_ft5x06_ts_identify(client, tsdata); if (error) { dev_err(&client->dev, "touchscreen probe failed\n"); return error; @@ -1257,7 +1269,7 @@ static int edt_ft5x06_ts_probe(struct i2c_client *cli= ent, =20 dev_dbg(&client->dev, "Model \"%s\", Rev. \"%s\", %dx%d sensors\n", - tsdata->name, fw_version, tsdata->num_x, tsdata->num_y); + tsdata->name, tsdata->fw_version, tsdata->num_x, tsdata->num_y); =20 input->name =3D tsdata->name; input->id.bustype =3D BUS_I2C; --=20 2.32.0 From nobody Mon Apr 20 07:30:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BF68C433EF for ; Tue, 21 Jun 2022 12:40:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350552AbiFUMkI (ORCPT ); Tue, 21 Jun 2022 08:40:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350512AbiFUMju (ORCPT ); Tue, 21 Jun 2022 08:39:50 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F93924F17 for ; Tue, 21 Jun 2022 05:39:49 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id ej4so15228732edb.7 for ; Tue, 21 Jun 2022 05:39:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=V78a4T+XxMalGYKe1sIzEqFdtRWisjMfkHNLxFh+Xuk=; b=USYW0p//evI6FmwwoomQYK1kmu7U+jM2to1UOgYGvAZmu9YJV48sYKlssNA1bxE3Q9 ehN0vy0xceUsqbYpvhE7OCKxffLkmpTFER0fm0bAzPrS/BOct2K6FevtBDwnb46eL4K7 uOkAMNcv+n/lDS9hna9RMNUwo10pQGuvaOPJ8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=V78a4T+XxMalGYKe1sIzEqFdtRWisjMfkHNLxFh+Xuk=; b=qThagQpXDDP2+g88Qf2o9ag3smyuVKOBtKh6VvX2cHPToIzQcmhBT6QkfstemO0Pvm G6+f90bId21wj0hUT1RFETWlje7AoMCZmg3Uo6sOi6DXF7E4drAI7jifXZyuTZ1wYATD K4nAeUNzRROMWQNRocaXRlWTTi8BkZc7dKTGs77moO5kiWipUUH/E60RK0Tj8xb1+EoU nA1RfGsu2prPNdNU7AZuy5obZCaH/KPjuiXFLC9kq237GQLLB3I9osW24ygH06sLEGbc CBISC8DmJe3ORgCBTl16HtU41VuuY1n1frlprkx77t3VKIisAoRPnDOb1ngdqdH9z7UZ lIsw== X-Gm-Message-State: AJIora/KqhjXh4XP0P6K0tzMkB+M3xq8EVr0pkrf2ZtXrea9N/VyCcAs 54F63s2blqUGOc0Mb+9G+HA+TeFjQYJqjQ== X-Google-Smtp-Source: AGRyM1tqJZXy3HO6L1prVRBXforWwXZTvSEoQrPQS7azVRlaTF2uVcyV4OQWSqZtRH1yyLBhUIxWCA== X-Received: by 2002:aa7:c542:0:b0:435:75e:8a7b with SMTP id s2-20020aa7c542000000b00435075e8a7bmr29236378edr.108.1655815187550; Tue, 21 Jun 2022 05:39:47 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-80-116-90-174.pool80116.interbusiness.it. [80.116.90.174]) by smtp.gmail.com with ESMTPSA id c19-20020aa7c753000000b004357063bf60sm8003945eds.41.2022.06.21.05.39.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 05:39:47 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Dario Binacchi , Michael Trimarchi , Dmitry Torokhov , Marco Felsch , Oliver Graute , linux-input@vger.kernel.org Subject: [RESEND PATCH v4 6/6] Input: edt-ft5x06 - show crc and header errors by sysfs Date: Tue, 21 Jun 2022 14:39:37 +0200 Message-Id: <20220621123937.1330389-7-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220621123937.1330389-1-dario.binacchi@amarulasolutions.com> References: <20220621123937.1330389-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" M06 sends packets with header and crc for data verification. Now you can check at runtime how many packets have been dropped. Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v2) Changes in v2: - Add Oliver Graute's 'Acked-by' tag to: * Input: edt-ft5x06 - show model name by sysfs * Input: edt-ft5x06 - show firmware version by sysfs - Fix yaml file. Tested with `make DT_CHECKER_FLAGS=3D-m dt_binding_check'. drivers/input/touchscreen/edt-ft5x06.c | 30 ++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchsc= reen/edt-ft5x06.c index bab92344b2ea..3deb66d67469 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c @@ -133,6 +133,8 @@ struct edt_ft5x06_ts_data { =20 struct edt_reg_addr reg_addr; enum edt_ver version; + unsigned int crc_errors; + unsigned int header_errors; }; =20 struct edt_i2c_chip_data { @@ -181,6 +183,7 @@ static bool edt_ft5x06_ts_check_crc(struct edt_ft5x06_t= s_data *tsdata, crc ^=3D buf[i]; =20 if (crc !=3D buf[buflen-1]) { + tsdata->crc_errors++; dev_err_ratelimited(&tsdata->client->dev, "crc error: 0x%02x expected, got 0x%02x\n", crc, buf[buflen-1]); @@ -238,6 +241,7 @@ static irqreturn_t edt_ft5x06_ts_isr(int irq, void *dev= _id) if (tsdata->version =3D=3D EDT_M06) { if (rdbuf[0] !=3D 0xaa || rdbuf[1] !=3D 0xaa || rdbuf[2] !=3D datalen) { + tsdata->header_errors++; dev_err_ratelimited(dev, "Unexpected header: %02x%02x%02x!\n", rdbuf[0], rdbuf[1], rdbuf[2]); @@ -552,6 +556,30 @@ static ssize_t fw_version_show(struct device *dev, =20 static DEVICE_ATTR_RO(fw_version); =20 +/* m06 only */ +static ssize_t header_errors_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct i2c_client *client =3D to_i2c_client(dev); + struct edt_ft5x06_ts_data *tsdata =3D i2c_get_clientdata(client); + + return scnprintf(buf, PAGE_SIZE, "%d\n", tsdata->header_errors); +} + +static DEVICE_ATTR_RO(header_errors); + +/* m06 only */ +static ssize_t crc_errors_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct i2c_client *client =3D to_i2c_client(dev); + struct edt_ft5x06_ts_data *tsdata =3D i2c_get_clientdata(client); + + return scnprintf(buf, PAGE_SIZE, "%d\n", tsdata->crc_errors); +} + +static DEVICE_ATTR_RO(crc_errors); + static struct attribute *edt_ft5x06_attrs[] =3D { &edt_ft5x06_attr_gain.dattr.attr, &edt_ft5x06_attr_offset.dattr.attr, @@ -561,6 +589,8 @@ static struct attribute *edt_ft5x06_attrs[] =3D { &edt_ft5x06_attr_report_rate.dattr.attr, &dev_attr_model.attr, &dev_attr_fw_version.attr, + &dev_attr_header_errors.attr, + &dev_attr_crc_errors.attr, NULL }; =20 --=20 2.32.0