From nobody Mon Apr 27 01:52:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 159B3C433EF for ; Mon, 20 Jun 2022 01:15:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237749AbiFTBPE (ORCPT ); Sun, 19 Jun 2022 21:15:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237769AbiFTBOn (ORCPT ); Sun, 19 Jun 2022 21:14:43 -0400 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72DD1B4A9 for ; Sun, 19 Jun 2022 18:14:36 -0700 (PDT) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25JH8CIU000692; Mon, 20 Jun 2022 01:14:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=WxzbB4BATD+CFL1NiVOP8Rv0r7TGLFMIADPmLhFJ9BU=; b=1C9SlW3b4o4FZDjzIoARwLFUI5m0WXWNViYtLbeORLnUcuhb+iqnJCuzThBOcKuhItAy uoiAMDWzHafEugrz2UcjqQonUnSmv7ON29puuLcoUX1AHoriA2CcYxYTRLanjWQunuXt LhFQFuVoluTaJikxiHeUGRFbLjb5O3MbZKNbOoTB+yLwCvJTeh87ioB8eyh0dEhDSs+I hb6yCq+5PTWvk+6TOwCwni+nW52ON5eustfMFKtmiAv88IW/TxhCaZbT6F3lnBjZWN08 ItZFJ5bIYPR4C/OfFJTzP1wwyFo7uQvgkrEcmYi3wIhjhL46stf93gO5lNOXzPEL3MVA nQ== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3gs54cj1bm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Jun 2022 01:14:13 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 25K1A3RX038698; Mon, 20 Jun 2022 01:14:13 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2047.outbound.protection.outlook.com [104.47.56.47]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3gtbu5tbf4-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Jun 2022 01:14:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h56HvbhhiEE5TzLNRKj+crIyvUm+FBwkqU9th0+RmuuUQbrkdOYuXY4ZC7b9PIHVrrWecb6sC6jbZhTSxHT4VcgHUi4aJl84RtnSkL620MLc5pzcBcTqg6pSJvVXjmu46KWC/xIzM1v/v/VocGxUMMNJd5UtMjFTotuK1W0zSHvNH2YoyPkAVomgjERvEyUiiSG1SiYD3TJTdATTw97ESIktwg5JAuk68lEYlrMJMMl83h1IGDeAPMUE5oSpH16QwwnA9yxmyT7mosy2K66hOu0aR8p1sVc/6jd0Ln1thnJRXcxxRwCuH7+YL0H3MEevwFRtvLpmpFDxSKOJIqebDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WxzbB4BATD+CFL1NiVOP8Rv0r7TGLFMIADPmLhFJ9BU=; b=ednKIKvhJgjspe8TNI/ToAK86VUWU3eI7hBQh+ncaPCTJve3Jiw+hFPXyzRhDLjS0Yd02S6LMOnwPTdFC0RrQKxpMaH7oiz0Ml7u8jsm+n7bMa3zW7HU8YJ9l6s7JEGCb6+4qoBKtbtAXtZW+b3fsTWfIJaGAjrkAOec7VhbDE9iJTi8qzSnte3I8UCIe7d3hBdz+X34BbAiJlMuYxvWXx4mJB9Y7pXo8oXy1oxIcjc6RbwbNKXJ16PHIb1W00hIbW1ydsuxXygWlqQ02xxqnVSHKmhg+7Yjdf2XB2Ca2jVZgHgIEimnhLrVLMFFlhq21xBSsqecAMfWeJGs1EQ6aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WxzbB4BATD+CFL1NiVOP8Rv0r7TGLFMIADPmLhFJ9BU=; b=u4vsjtzcqfNJYC1+J6GWvnnEn9uUFETbZY8WUaG9X4khj34Il0tZmiQPIMBkFGYLgECTJGzbOW58+Br6wFWusEHH4GeILY+W9J6tIO5TOZvbpLSL/zUWONcbVGTWY4twi2yUrWaLujSbKsG1QQNMGcQwPtlOb+IiljaEC/7Qt0I= Received: from DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) by DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.18; Mon, 20 Jun 2022 01:14:06 +0000 Received: from DM5PR10MB1466.namprd10.prod.outlook.com ([fe80::f81d:b8ef:c5a4:9c9b]) by DM5PR10MB1466.namprd10.prod.outlook.com ([fe80::f81d:b8ef:c5a4:9c9b%3]) with mapi id 15.20.5353.018; Mon, 20 Jun 2022 01:14:06 +0000 From: Mike Christie To: hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com, mst@redhat.com, sgarzare@redhat.com, virtualization@lists.linux-foundation.org, brauner@kernel.org, ebiederm@xmission.com, linux-kernel@vger.kernel.org Cc: Mike Christie , Christoph Hellwig Subject: [PATCH v10 1/8] fork: Make IO worker options flag based Date: Sun, 19 Jun 2022 20:13:50 -0500 Message-Id: <20220620011357.10646-2-michael.christie@oracle.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220620011357.10646-1-michael.christie@oracle.com> References: <20220620011357.10646-1-michael.christie@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR13CA0014.namprd13.prod.outlook.com (2603:10b6:5:bc::27) To DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: da6805b1-067d-4962-e06a-08da525a2ba9 X-MS-TrafficTypeDiagnostic: DM5PR10MB1466:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: skfdrmkA07eWxeTa1ndSEqDTUt2UCbmazXw9PVe3bzjAfG4RuOFbWJO3KspVChOdcHdfDHVxz8e1nmkhFb45HBmpKtZLv1b1zHKCsR/nguOHaRWtbik9xOxOE8juQiErzhFT8F8X3Uh99jzQrLBiBC9cO9dy8vimOsl8Pk/VsP04pwqJE6wV/kVEkUQutSVu+BOXoRGh8toVDK09H4HW2SOVJBN9uOtV9yErE6KIXfLgci/ErA738k3n2IoEmMi1TaMgJRy/JLfPhrs3hWMGN98SaSLbZR9nqcQ+rKIlIy14WkYxH6veMUu2UFOizvIWdZffZH9Mccwd4Ve/61v1uivGaLuloVJ/OmRcFRmNPOyR8EWAdScmnkBYSdlunLpjflDlp4ttlnDLDFpFFwtWqiBP2vWI0kmuWPntWaY4sPbYSnsMV77eB8LHKhEmLhcPG5L1DHCJhtZZgZMlOEcTJgHST0NzTZBjjnfxQSZMubgv3YgUm+VodocWQHNxPgq3mXI6pGektpCjUP/RzlvpLM2Ap+qAnJEa4f1LJaXrciNMntUTI7rdnPLFDN5QBHD4Y//hlwPTDvxLl7kzuk9mkERzhAkWkGdLC2Jahjf6x0eFL02tnyAfkuqbPbO542Gdo9ChsHfwAkhht4NB4IRcy0A72R7JeR29WlG/WQMqjx93HVNg4H5LSPuvyA0KxLm1wZQipqZFFPsemli8XsLKPg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR10MB1466.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(54906003)(316002)(6486002)(6512007)(26005)(38100700002)(8936002)(7416002)(38350700002)(5660300002)(83380400001)(6506007)(2616005)(8676002)(36756003)(4326008)(52116002)(66556008)(498600001)(66476007)(66946007)(86362001)(1076003)(2906002)(6666004)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tj+xOquwxT/iDln7tlx43tIOn/CtEpfxVKJgLnuLze52403gq5Th1LGN8txi?= =?us-ascii?Q?zRMFUQZJ6s3yhMHnhND+kNsUxGuxyFQt0dyn8piiEmldAL2h63RY4YW0IZrM?= =?us-ascii?Q?n9ksYbnZKuo7Om4Y04+WiBLYaPHvB9MBJRtV99KkC7LmJm1yYBVgYOushO8n?= =?us-ascii?Q?u+pWK4DI8bYPgZ8gLyutPxpheYk1oswRGjL1wNlzWDN+Jaext6P34CNckRQM?= =?us-ascii?Q?TEV9kUjF8PCOXJK2v7fykI3Nauq7fs0EnXgG2Sjxkn5I9eqEGN5SlHdgJXEf?= =?us-ascii?Q?QZR3WOO/Gp70x10Y1LkE6h0ux+RBCa1o7DUKONVt5T38CBYJmhGp011I7iQx?= =?us-ascii?Q?1E6N6A879pj/6Zc0EjFuXQctG/ivN8H0RQYE/7tOFLP0VI1TZBNR87wah+F6?= =?us-ascii?Q?KRvqj0V/nXbuBh3iYAJSDxGYqLcvd8dyybZLEy3tpiGVAhenZADp269qqgYG?= =?us-ascii?Q?zqyYbwmtrDer5FEK5rXYRG7o4QhT6bSAYt5MATP5Vzo+K9JlsLSYZkht2p/T?= =?us-ascii?Q?YgiqjktSMFQP13ei87RQ/7Uj3jvNuN9wtqJ1LQSIn/S3VpLu6rEMcYPyQ5U9?= =?us-ascii?Q?xSqD+9Blw+cpl2ZQdN3z5qNs52MRztxjKTUnmyDbkVCDuPdiUqH4JsEYUeZQ?= =?us-ascii?Q?9qsX6C/tJl/jqGfUFwKQVIFyGNCVuUhzJwUmCCnhqB2ZFOgObzJjPcKaxgKB?= =?us-ascii?Q?BgXMkOHlT1M1MCXWkAdjhGARoYmMGL4mgjSrQH7TP7MbkNjbJiMHEDmAiRvg?= =?us-ascii?Q?CQbke1rdIn3Bywy8yfn7S/L+hrr5p7rMKuiU/uSTxhcDbG9LZo/RjXuSXkAv?= =?us-ascii?Q?GwLqwdxm7xEDGtvlPqHJR3jHW1qt99cxNn5SSELe6vuiStqzRE0ec2KEJBVY?= =?us-ascii?Q?VKoUjGOIFjtm1JlkoQjAEa21arAW6WlKl9xrlGk5JxLnHW6ujLf8ZRbHcDC3?= =?us-ascii?Q?3Eidl/7qdTOKj5OOVpgUETQvbfgS9U+p6BwS+fV6qe+0M2arRRbs2Ha6MeO4?= =?us-ascii?Q?w8kghLmo9UFY8v77zoBabYaoIGjmvy2WIFEUxKR5YeRRLRKFqFQY7QN35Vu5?= =?us-ascii?Q?OZa43J1y8yL5K8ERKj6yTtLZ+lGN5SabwI8+eGChOp8BZGtpnkqbUWIy7Vfr?= =?us-ascii?Q?BtirAr/YNNpO9Wy4ujmjiG+78+Y50iBdEEAh3A/be6jpG48NfcB7abmc8VS8?= =?us-ascii?Q?59ZBaoG57E7i3yt4dG3zEF0hEcM0O8cHRSBBnC3wcRP+HCaaUabX9BaS+/nL?= =?us-ascii?Q?fYRbuirCUIgDuw85q1PIxd8vXwYR4wS1Pl+9Nuu2dcBAvXc9AnFbYX1RDzST?= =?us-ascii?Q?3B6EJam6vgpNAxYxtCIK5/hd8WPkFvdFNQKH6GYonJi1SiF/ieNz9jWyS0iO?= =?us-ascii?Q?L51AEOvyee4O8lBqb5gDmNz3Rm7AyS+XXbtqq39B0zTVkyU5ryMmtefzby8n?= =?us-ascii?Q?q0wrQCcHG95RkStlZwzGG9px8a51SYVl87dSRs6UgHlDTaO302bCRwLHgV8e?= =?us-ascii?Q?G/zGbXkMs4c5CwMVYNFyuT1qqoy0OjFIBfpT/c4SVXk6zLcPYyN1pMmXlxnZ?= =?us-ascii?Q?np2/YcZsSkCfoUOThKHL5K3/lyDhbw9/6wR+aidAkUPgar1yZtz5zR5DlY6u?= =?us-ascii?Q?OUYbJIwrSvZn/lTiMDMylv4bp68fai7SJNmNtFN7Q0FrSFz4aZWhEb5vuIjS?= =?us-ascii?Q?Ms2cnYXyfv2X/ya90CIFwx2hFhkHYE24exUOoY9ytcwZksb1n3uh/bFV6C2J?= =?us-ascii?Q?M4tmAAAaILIrD4Wym0ECCBWGDU8S3BU=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: da6805b1-067d-4962-e06a-08da525a2ba9 X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 01:14:06.1152 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o5xNfB6LqO0Z1zaAqAJH+j8L4KdGCCZBnl3Q9XSV/5/1bd5a3lv8TX1seygZ23uY/LhLjG58+tEazEBuec5bt+dL8RY8TtK1FLGSaRnv7io= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1466 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883 definitions=2022-06-19_12:2022-06-17,2022-06-19 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0 mlxscore=0 phishscore=0 suspectscore=0 malwarescore=0 mlxlogscore=731 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206200004 X-Proofpoint-GUID: ahBIelTtR8JYkIXkJY2vc85qWVv16kjj X-Proofpoint-ORIG-GUID: ahBIelTtR8JYkIXkJY2vc85qWVv16kjj Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This patchset adds a couple new options to kernel_clone_args for the vhost layer which is going to work like PF_IO_WORKER but will differ enough that we will need to add several fields to kernel_clone_args. This patch moves us to a flags based approach for these types of users. Signed-off-by: Mike Christie Suggested-by: Christian Brauner Acked-by: Christian Brauner Reviewed-by: Christoph Hellwig Acked-by: Michael S. Tsirkin --- include/linux/sched/task.h | 4 +++- kernel/fork.c | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h index 505aaf9fe477..b0a9d6c75bcc 100644 --- a/include/linux/sched/task.h +++ b/include/linux/sched/task.h @@ -18,8 +18,11 @@ struct css_set; /* All the bits taken by the old clone syscall. */ #define CLONE_LEGACY_FLAGS 0xffffffffULL =20 +#define USER_WORKER_IO BIT(0) + struct kernel_clone_args { u64 flags; + u32 worker_flags; int __user *pidfd; int __user *child_tid; int __user *parent_tid; @@ -31,7 +34,6 @@ struct kernel_clone_args { /* Number of elements in *set_tid */ size_t set_tid_size; int cgroup; - int io_thread; int kthread; int idle; int (*fn)(void *); diff --git a/kernel/fork.c b/kernel/fork.c index 9d44f2d46c69..49fedb79925b 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -2074,7 +2074,7 @@ static __latent_entropy struct task_struct *copy_proc= ess( p->flags &=3D ~PF_KTHREAD; if (args->kthread) p->flags |=3D PF_KTHREAD; - if (args->io_thread) { + if (args->worker_flags & USER_WORKER_IO) { /* * Mark us an IO worker, and block any signal that isn't * fatal or STOP @@ -2597,7 +2597,7 @@ struct task_struct *create_io_thread(int (*fn)(void *= ), void *arg, int node) .exit_signal =3D (lower_32_bits(flags) & CSIGNAL), .fn =3D fn, .fn_arg =3D arg, - .io_thread =3D 1, + .worker_flags =3D USER_WORKER_IO, }; =20 return copy_process(NULL, 0, node, &args); --=20 2.25.1 From nobody Mon Apr 27 01:52:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B688C43334 for ; Mon, 20 Jun 2022 01:15:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238202AbiFTBPH (ORCPT ); Sun, 19 Jun 2022 21:15:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237788AbiFTBOn (ORCPT ); Sun, 19 Jun 2022 21:14:43 -0400 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F670B4A6 for ; Sun, 19 Jun 2022 18:14:35 -0700 (PDT) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25JH6TuP030122; Mon, 20 Jun 2022 01:14:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=6/iIQ97akuse4EJmbn8sqSbLLvmlhDQsXhvPgbAh36M=; b=xLAtQNfd5FWr768q2zXMlMtoFrUWp7lkLhPD2zM0RCaTy+XDf0swOkTmDkdAL8+Ra0tK imw+PN8tDgKkKs6KC7SfNIHcxm2LetOEU5WRSl9MJhU/jR1F5QXo5Wh9T4duSg4CRZKN EmMNvihUnM8R+OsrUmeyLsEJLUbQhsCYMq6rK3afloRQ/8aHt3FE43jdr/fQg7E6OYws JRWONFI3bMQtRJ8zZUi/8ZAqa34lxTzQ4oPLkeY9uuzDCclMVQDDAirvQpEQ5u4CrAQ6 pKlsL6naDRYrTT+AhpbWesZ3Mkj/9ftoeKXqYLulw3MoV7I4ZnfRaVJi5oBJaZo7hnlN XA== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3gs6ast048-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Jun 2022 01:14:14 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 25K1A3RY038698; Mon, 20 Jun 2022 01:14:13 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2047.outbound.protection.outlook.com [104.47.56.47]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3gtbu5tbf4-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Jun 2022 01:14:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O2+j/FieIcjWZeFecb0vlPejfMHDrlF6nCUT084k4Y/tfKOG15eVd2YFI25ZwE688nQzEpF+1hs+nTaxRRdwTYvbIU/fHqcfxwnY3ZMPfOvmzNi/J3vtiHSDqG8+EZndoY5RuoI8nmTVI4ClKdpxugnPExVEr05SxwhAfm2exp2Z3atZdPqvdKPfA1RacxYmJ67qH6EbFV+ZGn1CNKVvZ8n6elbBKRT8Nj6So14h5M5tIO6VMl166H5bEJXpa/eYpDf0LtDXA0Dx1KIJWlQitIgEuT8jcVMgM7AEttHvwSQ9nU2j7UA/8TE8kM5KkzvcmdiA9xDA8a3DDqcovf9sKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6/iIQ97akuse4EJmbn8sqSbLLvmlhDQsXhvPgbAh36M=; b=FUlzypVOOiccY+2Lgvf5ERq/X2f2qg9C3GjZshnjloeITfXoce9mAus2rty8aFIzKhFXc6wuBeZ9xrUSiIZR5xL8ipkgty7HgB4jxPsfzEl2fBZQjZpLAOEGk4GOuWRrMR7wduDBVhOH1rMc1vDwYddByzJDBW5fKmGou4JHPAkaziRRZpbdb77U6qwxBSe7ARXZCUrRseVOQLTbcy78rTgj74brSqVMQY4we4Q1hFpP3dX+VTW5M0P4M/elQ1lxCG+l1fMQRrwTRBDR4t/UBhU5XhxFi1vSnYztF7c3poVbJN+D/kfRjPrqtZoTwv/HQdvPO9VDv1IXcms/K9lGTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6/iIQ97akuse4EJmbn8sqSbLLvmlhDQsXhvPgbAh36M=; b=gHfe8xnNOSocmjkRardeOfbVM9sH1/14QmA3yMY6Tiw4TlsAyyLGGDnH7y0CvG0fMM1YC+dD4tNGDWqZJ7HA0BkpCN9kajpuQjp6k2D0gTudhwBC4S5aA6JCGmX5DKK8mJTLvtdB82/LE1ay69b15nQS0f5lLXQTaFfwZWQh9Jk= Received: from DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) by DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.18; Mon, 20 Jun 2022 01:14:07 +0000 Received: from DM5PR10MB1466.namprd10.prod.outlook.com ([fe80::f81d:b8ef:c5a4:9c9b]) by DM5PR10MB1466.namprd10.prod.outlook.com ([fe80::f81d:b8ef:c5a4:9c9b%3]) with mapi id 15.20.5353.018; Mon, 20 Jun 2022 01:14:07 +0000 From: Mike Christie To: hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com, mst@redhat.com, sgarzare@redhat.com, virtualization@lists.linux-foundation.org, brauner@kernel.org, ebiederm@xmission.com, linux-kernel@vger.kernel.org Cc: Mike Christie Subject: [PATCH v10 2/8] fork/vm: Move common PF_IO_WORKER behavior to new flag Date: Sun, 19 Jun 2022 20:13:51 -0500 Message-Id: <20220620011357.10646-3-michael.christie@oracle.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220620011357.10646-1-michael.christie@oracle.com> References: <20220620011357.10646-1-michael.christie@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR13CA0014.namprd13.prod.outlook.com (2603:10b6:5:bc::27) To DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b9b2048f-d58e-4898-3a7b-08da525a2c28 X-MS-TrafficTypeDiagnostic: DM5PR10MB1466:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bA+wAWecYyxhPO45NgmaUxA9Qaw0wcsxDZBhE7wpfT7XFFMgcgttsYwX84Kaqt2x3RYG8WngczcR/rpRAA+V1hDdiR7ET5lfBLTWIwq7H54NVeSf9jww0OpuTgKrArwL1WT8nSAJwBJJZmq5M779b4goTNk6iY2M8WhaOG2e8lkVy2Q33upUlIMTaG2lmHzZE19TFvtiFIqwhh6q9hspThB59I2CaZXlckryISUHnv9QAOckrDMxlGKL+tBc8Cbxn0CjNsR5s/OfmqD/uE+IwcyDSGlqkirSerEKMoiYSIOOOxv6UA+OHsWuWArjRGjIPprp2j0F5jNuhcrEm54yXzePf5uC5WKFAkXy27o1lq+ZfNJs8QW7u/jykjyJa/oseqmFc16/WaPMPV+FFAc9kPZ2EMz/tUYcTQ/cPjYUjj7F7XkuPXfSrZGWDYx+Jll9bVWHuF2+VOaHv9D73yky750SdqXEVr5bs5NaxX5o3DAIGvdaRwQLVESZYXuUANQM0IcA/ckD01teRKBK1bfOQ7M2v7sHf1LUWdm9aR3PxPem5EFwExBsPycAj3yv/pvAxb4DNo9HTzyRglQnXSfxTRcvFDfY1UWJlCy7tkBnq4+6npAbhOSTjC0VBRRYDV1jGgytsG85qBHEJ95i4SSYwTAHL9kIdzC8I3wGUv4OOmU+KN31fQ9abVa2k8zIHnTBRrWMfdA86B1KH5BZ2wKD/w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR10MB1466.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(316002)(6486002)(6512007)(26005)(38100700002)(8936002)(38350700002)(5660300002)(83380400001)(6506007)(2616005)(8676002)(107886003)(36756003)(4326008)(52116002)(66556008)(498600001)(66476007)(66946007)(86362001)(1076003)(2906002)(6666004)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4D2/6Muc6qz14E2uZE1mktqlHGVRTlU+oH9gMFqEiDAcpOeJnrtq0EQdm1fK?= =?us-ascii?Q?aLzDkaGoAdVJGYqDFqsI3HB0yGR8QrokoJSWCYVLegl+oGZPSqoqXNBeG4YC?= =?us-ascii?Q?mHc6YXtLNlARsHl9pyrqodH6NK5ioL4hMsmGsCJUv381yar5TOLvOMi/F8rH?= =?us-ascii?Q?e43AlmE07nBQ19BqdT/YWfZXCcEo2Khj5LZfAdfTrVfbObOYuxl2uthrJ7Z4?= =?us-ascii?Q?c0hXmUG3mpDCbeykvH5tgP1wm0goTPSob61Y0yQbfHCh6aEjnb5uJI8VW4iP?= =?us-ascii?Q?ZFntralY7M4GitDZVU6Km04xcnFMKkv+BRldA09Q4x4iii32slJWpVaQAiae?= =?us-ascii?Q?Q97PJB5NNWiemOxkFa5SzCfnYQfjHuQTRiQDNziTMIFE3pLDC6ftYKSNQ62u?= =?us-ascii?Q?jsoRjRU5INNfQbjGv8ABJp/0vQ/fUD/vCgTip0JtSRZ0t8Ggly9oBEkdOxz0?= =?us-ascii?Q?hhTaoRMnWBr5C/zBpJbQeKlKwdJmNeJ4/jwUhr36gdKUqvEHmmCzUQQIKyDs?= =?us-ascii?Q?LgbbA6InPLlAbRmpwoleLkwd3IPZCnu9TsRRpMAbWRRAlSAHHHO8TPEoM680?= =?us-ascii?Q?EhG35loSuyaAtw1a5NLkzZPjYC3IzKUJtMKC33DKS4bZ5X1lQ21LDO0oi7LU?= =?us-ascii?Q?E+vXCBawbUVvNuGYv+DG3kzw4LK4Ka+1w3e5qIp7AynaK/kdQ2/HYKIiEade?= =?us-ascii?Q?RQMXG3zjDUDhVZycf2/elfH4p6H3QWshTsFHRiIm5/D0kgavNPVW2PKP0Eq+?= =?us-ascii?Q?YjdXFvyIXDcYax7tgRi25ixFk8eCGCj2xtsBwvHvvv/nCdFZXFUc9TWpBIRA?= =?us-ascii?Q?aWnkYvlzihbSiVQpcyoJp9s9hY9AOZ+uNYv0Kq7vclvYdriFCu9JoM7U58lD?= =?us-ascii?Q?Ii8h3HrRXVS5wWz+stN/ZuZXKZUtjWDN+/d3fVO+i4BhPem1HxxpL255d69a?= =?us-ascii?Q?EJ3CMNB6HBqwjUMddcGTA0d3B6PnZJKzP7Vm7tzqnFNKwktuBjAw5P8OerFk?= =?us-ascii?Q?kGX+45eCnegj7Xmz7baxUefiUdNRLMPc0IhRiLlo5iw2aYUz5aOLRdCJnjBH?= =?us-ascii?Q?gIFMpRqk14k3VDz1Zm1jpkbP4cx772aWlM9rFsr6oLF43/x9EoM6sgwR1phk?= =?us-ascii?Q?UYZ2/duCBkRFifAiy2u9Y+Z3zuV0zm08J8DMepxsyzOL7W77XLAhfnoqGny3?= =?us-ascii?Q?ONWOkLFB2vehTFQrUKRVTQ8GWIyOxjaXQIfE1Zki/m7in5R7MxFDfttxlrtc?= =?us-ascii?Q?TsoCQSwrLZDvxiAKrhS+9bHaMRoi0oODmVC/0+hCy7xZNGJoSi1iLcB9Munw?= =?us-ascii?Q?CCyvQM/jzQhaamyp+cQcPh0pPNzzVWnxSoQYyq0foNP1ed07uPanCLOrdVi+?= =?us-ascii?Q?a73TPEmoIy0Wyj3TeyllJ6Uk4ZsKTy/+w2IejdN1CFSht5lJRaiOpS60r62V?= =?us-ascii?Q?vRUOyRLEe5tsxGOf9vm7L1aluk/TD2LBFwG3RbN2IHXkUTaQJpwxj+U9zqDX?= =?us-ascii?Q?sGV10frtv4nEJEQ99f8hyhaQQhWMKj1VZBrthwDavSfQ1nPAxObJjSjJvKrT?= =?us-ascii?Q?Ll7a55KVGzdRhYI725BAvN/IEQ949XYIt1R9pYtLDyqp0T0YkOTUSmt8aAYV?= =?us-ascii?Q?gTyaye2+AXSA4EZ8ZpUubohq7bSCSpqtXXEz1LgXUNRs+ytKLo5mR+Pxr5ha?= =?us-ascii?Q?vpcCbJY620pshvGAL0x1JXpJ7i11WfaBWTxvOkkAWTEgJ4x3Vcft4YM8QkRa?= =?us-ascii?Q?ipyp0XFr3yE92ppbeP2JLa4ugoZVvoY=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9b2048f-d58e-4898-3a7b-08da525a2c28 X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 01:14:06.9433 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OCpsKHrCnA0zFwVV3sk6jfFkAJnxw1fIGIO/nXiG0+K20kD0Y+fJkUzeMgehc/LYtdZdicDbOpZ+gcC25VK8FTEGKOsyxw7+1WMsIS2DkR4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1466 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883 definitions=2022-06-19_12:2022-06-17,2022-06-19 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0 mlxscore=0 phishscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206200004 X-Proofpoint-ORIG-GUID: ez-tNgAa_x1YxVB3b2LdxdCSHElmsmCI X-Proofpoint-GUID: ez-tNgAa_x1YxVB3b2LdxdCSHElmsmCI Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This adds a new flag, PF_USER_WORKER, that's used for behavior common to to both PF_IO_WORKER and users like vhost which will use a new helper instead of create_io_thread because they require different behavior for operations like signal handling. The common behavior PF_USER_WORKER covers is the vm reclaim handling. Signed-off-by: Mike Christie Acked-by: Michael S. Tsirkin --- include/linux/sched.h | 1 + include/linux/sched/task.h | 3 ++- kernel/fork.c | 4 ++++ mm/vmscan.c | 4 ++-- 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index c46f3a63b758..d7cd2037430b 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1701,6 +1701,7 @@ extern struct pid *cad_pid; #define PF_MEMALLOC 0x00000800 /* Allocating memory */ #define PF_NPROC_EXCEEDED 0x00001000 /* set_user() noticed that RLIMIT_NPR= OC was exceeded */ #define PF_USED_MATH 0x00002000 /* If unset the fpu must be initialized b= efore use */ +#define PF_USER_WORKER 0x00004000 /* Kernel thread cloned from userspace = thread */ #define PF_NOFREEZE 0x00008000 /* This thread should not be frozen */ #define PF_FROZEN 0x00010000 /* Frozen for system suspend */ #define PF_KSWAPD 0x00020000 /* I am kswapd */ diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h index b0a9d6c75bcc..9e20fa18c41f 100644 --- a/include/linux/sched/task.h +++ b/include/linux/sched/task.h @@ -18,7 +18,8 @@ struct css_set; /* All the bits taken by the old clone syscall. */ #define CLONE_LEGACY_FLAGS 0xffffffffULL =20 -#define USER_WORKER_IO BIT(0) +#define USER_WORKER BIT(0) +#define USER_WORKER_IO BIT(1) =20 struct kernel_clone_args { u64 flags; diff --git a/kernel/fork.c b/kernel/fork.c index 49fedb79925b..604c7f3cdde8 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -2074,6 +2074,10 @@ static __latent_entropy struct task_struct *copy_pro= cess( p->flags &=3D ~PF_KTHREAD; if (args->kthread) p->flags |=3D PF_KTHREAD; + + if (args->worker_flags & USER_WORKER) + p->flags |=3D PF_USER_WORKER; + if (args->worker_flags & USER_WORKER_IO) { /* * Mark us an IO worker, and block any signal that isn't diff --git a/mm/vmscan.c b/mm/vmscan.c index f7d9a683e3a7..6d771d8a3a4a 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1047,12 +1047,12 @@ void reclaim_throttle(pg_data_t *pgdat, enum vmscan= _throttle_state reason) DEFINE_WAIT(wait); =20 /* - * Do not throttle IO workers, kthreads other than kswapd or + * Do not throttle user workers, kthreads other than kswapd or * workqueues. They may be required for reclaim to make * forward progress (e.g. journalling workqueues or kthreads). */ if (!current_is_kswapd() && - current->flags & (PF_IO_WORKER|PF_KTHREAD)) { + current->flags & (PF_USER_WORKER|PF_KTHREAD)) { cond_resched(); return; } --=20 2.25.1 From nobody Mon Apr 27 01:52:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3700FC43334 for ; Mon, 20 Jun 2022 01:14:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237862AbiFTBOq (ORCPT ); Sun, 19 Jun 2022 21:14:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232936AbiFTBOf (ORCPT ); Sun, 19 Jun 2022 21:14:35 -0400 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93C5865C7 for ; Sun, 19 Jun 2022 18:14:33 -0700 (PDT) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25JHOmg5005310; Mon, 20 Jun 2022 01:14:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=1XNown0ZJ3G7NR4AflklOVJs9xLODizTTlE12mLIl+w=; b=fOGN4xHjhdN4LvDOym3z9OYYrPIQi7K9gb04zfBQvudHAty96H+hF3X8KpjWeXv0dyiI NrsglAkN+cQQHcMnBvfLceBGsLhv2wJ3OxjhquLf3QfVMnEx+uFw1SThDG/d4tARBIcj OTW/zmgJeQ1jR8rFiaYiOI46bkwCy44m4jircQD583kPxT17/1sRJPUQaYOmjjbmCaUp 7QJEbi/RO4wm5EWa+H6rnf7Y0zN+JyCgLlgpBUrtxQkB4ObGsAVYCMcrn6yJ1AU5I9v9 H+BRkUuiQUYKZtIX2CvGOpu0MqyFTOnytdXGyd/XpX0zgIjZUZc2jPYR/EqVQXAXyfjS jg== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3gs5a0a05d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Jun 2022 01:14:15 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 25K1A3Ra038698; Mon, 20 Jun 2022 01:14:13 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2047.outbound.protection.outlook.com [104.47.56.47]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3gtbu5tbf4-4 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Jun 2022 01:14:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KpGm2epCESqcwbGbfs9AbW4x4uC/McAWWeLJCyvWjGhaeumerfsEhVadpEXf6XexQd/323afvVi4/QEs6M4JqcxsD9ADdhTVjxKZvCrfFy1+95Ac+3lKoLVr8AXvXBh3aEOPsy21Ejbuk2cQ4v0XrMK3xMHBcZhNhMIbXS6hi9GS4/EnWbBY0ADEpqhWaew5JzQpVNNTMcc/aeUlEfpPQJ0ECwE1v5rWLLWZVXSUU87wtimu4b/4uhTqIQQp4juvjTM2vMvAXlPgBjkOFoyZwBWCGH2hLQjuPP6Cat1MMNTm7VuZqyVeDfBEUWhmxn8iIk7UoxhZBs+eVTSlwIQJNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1XNown0ZJ3G7NR4AflklOVJs9xLODizTTlE12mLIl+w=; b=Gq0NQ9PnhshnRCCg1t6FapV8kMCxz14cuaFxOF95VuD1FAmjAAUerYRkH+MHaMQmbDZVMRSQiY9iO5FgliHfC0+HIcEAzzMMBpIo751QCFg/fbSO+y5K3fOfN3PoV4/08x9+r4JcUJgVcBfKBxE6duUsujZyyWUbrVrs/nmmfuy2IlCqlOzefNDT+wF+Ye+3OHCekWPppJFT038ptVehUhb24vKoTHYEY0vjwIh/hbhsCwgvQzxaxTJ5mcwgtk6uEOkWXg7eehqTZZNYqSNpZpSx1gZWyfIdU6nxDkl2nUFs7XcC4gV3jBPmiZbtqXvZFyC5ZWA+lhhIm4iOM7lCLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1XNown0ZJ3G7NR4AflklOVJs9xLODizTTlE12mLIl+w=; b=n2AKt7IwLNAMxHEYG+3YvzJIW2Gbpmcluk7ai3JyWSjE1iu4wQaO8EylbSku6vkDuTvuGrlofAfMku0sAv/ZD7fPOE1ifa4xDuP6CMDTwfBQrkho/604+okj0CZ3cYj8KubOekgqoWJSQd6tevIuD2dgjMJeCGUam9LfFBAhfcc= Received: from DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) by DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.18; Mon, 20 Jun 2022 01:14:07 +0000 Received: from DM5PR10MB1466.namprd10.prod.outlook.com ([fe80::f81d:b8ef:c5a4:9c9b]) by DM5PR10MB1466.namprd10.prod.outlook.com ([fe80::f81d:b8ef:c5a4:9c9b%3]) with mapi id 15.20.5353.018; Mon, 20 Jun 2022 01:14:07 +0000 From: Mike Christie To: hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com, mst@redhat.com, sgarzare@redhat.com, virtualization@lists.linux-foundation.org, brauner@kernel.org, ebiederm@xmission.com, linux-kernel@vger.kernel.org Cc: Mike Christie , Christoph Hellwig Subject: [PATCH v10 3/8] fork: add USER_WORKER flag to not dup/clone files Date: Sun, 19 Jun 2022 20:13:52 -0500 Message-Id: <20220620011357.10646-4-michael.christie@oracle.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220620011357.10646-1-michael.christie@oracle.com> References: <20220620011357.10646-1-michael.christie@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR13CA0014.namprd13.prod.outlook.com (2603:10b6:5:bc::27) To DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7302b176-7ffb-4468-1db1-08da525a2cb0 X-MS-TrafficTypeDiagnostic: DM5PR10MB1466:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q/q+bZX+K0T8hRV1nUm6XoVXkc0W7+LvqyST3m3GVMTrlTUJ6z4UqowGCkFzTjlMijzJ9kDVg0XbgcID4QSmWEDaafTGr4JlcoO8/8dXflChqHorA0/bIWH5NxE+NXs9D35/5kPtwDesrX6199L/744PULntV/DuvbDpRurEQMD+oT9+YjSX6TX+qXxmiyvTJr0cYeq/3k0u9YuwDFrDhT0YHG2Lcduzne4bDOON+/u7Suxkw12gK4US8X2dd5xqvbacmW+NWVxVCcltNLd1PlkywQJeHeeG9v0DRHB5sNMk8/6vVNt3JphcICpdGm6UhT0+WrOds7cK1EpS0l5DhWJEvlNjKXynM/jYpiGfomMaEfaFFtFXgB7VqulDgyHRHE2zeTUtlynuryVW7uleaNspjYJ+d9iTfKimZWkFkLxFhXBr/Fagg9qyJprVAwv/Iogk5Sj0YUlN+F96wvZVCaUanNBrtSIYIkegj8IClaPNl6vbIe9qNG8auwZgKvQpcNgVlq3S60cCY5IMnomxYXGkD4lLZ4WdDJVc1TMARRF1+XQTy/BocRnG+Fk+ngRPywXuT9K/sQwD52AZzLKRRkW9DKLGQwJWyT2wROWj9XPSzPUxErppCuGkiBfBQFHIM9wlfQhHeEBicNWye3lFUaQONegK1SCwQUggK0fYbzK6abs74+p7n7Zi60q4dJvGNAdirwFC8UPThH9TslfCdA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR10MB1466.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(54906003)(316002)(6486002)(6512007)(26005)(38100700002)(8936002)(7416002)(38350700002)(5660300002)(83380400001)(6506007)(2616005)(8676002)(36756003)(4326008)(52116002)(66556008)(498600001)(66476007)(66946007)(86362001)(1076003)(2906002)(6666004)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cH/3LCZBNvT60eeuYwMlc4QL6dIMXqs/4qCk/yK+vHJ+tj7RELRHD7KGt6fj?= =?us-ascii?Q?oh0sMm0+3jgDmCj2KeLXCK+zZyE14aVAupovDUw0I5ppCgtVGllcx+u6wdki?= =?us-ascii?Q?jpQu7ytmXwjAYg5eET4Soj5CiSbBIYjtVIuVtAe8BkxF0usTm5S5Q7XbhZfX?= =?us-ascii?Q?0JQtTFEdhiWwvAgEc2794HcG09fa200+O9KkRUyj8KymJZ9q4tL7/Rn/IduD?= =?us-ascii?Q?7CTmro543+oF5ifrastow4ZXfnoaWLwhXIvSAHMTKymo+9elsHtTd2TsanB0?= =?us-ascii?Q?+Y8Cx+nb8A6phi7oldiiQLjTnDtbbyTm3X+NdaB7hm+H/RCJO/W3aXPG5tKg?= =?us-ascii?Q?v/YxJlMifEGmqUNCkDMzPgL7O721qTB58dlmW1p9kanlksj3HEdL1hKud8R1?= =?us-ascii?Q?BGY6q3I+zuifNnHAJZ9Tl+LVjqOZmbGL2ekjGn7A79D6jVHp6PvCwBLI7R26?= =?us-ascii?Q?Pi6pxtVLbxTKlzf/VVT/XdXZ1eu5/2Dw7MxfRxHeRWAap/TjY48s1xjrCdDF?= =?us-ascii?Q?gJ3kl3AK+TnqFvht1P2dl6dJTZzD6BW23IayArx7TW+4wxa1J/MhbqkwDgCU?= =?us-ascii?Q?XuzibZrK9mhFkseqr8ncd/E4iBg58Lk2FUl2fQv4zK4KbHZy8MZNasnPXY77?= =?us-ascii?Q?tFmn6MbA3R+m/kd/qevIkQ+Aj3rNKNmvnwpfY7CIfx+NmKseMhAyw+WXTQRW?= =?us-ascii?Q?Yt4RYcEyc79kizoeQPt1vTFFsz4hMz/hkBlzgtXvBr2Xu+nOdDq40SdQvqjt?= =?us-ascii?Q?aFm1K4EdGkwfjlzOxyaC8b991cM5FcKm9zYcx8ywSI0BXjenB89rJB78rK3Q?= =?us-ascii?Q?TNmGzHWeyQqXUGGoSWTNIHFpDx3gvyO9fTbbICtyhtTXlegHnuTh5F5MGlNB?= =?us-ascii?Q?hRQtT2WGV3/AI2LTWvfIKMsobEL9VGZDUifrlUfNyzEsz77crTDCPu1D393Y?= =?us-ascii?Q?aiFWLAFov6jLWjsbi3qPS5QAZc5RKZAUZDfb1s6cy4P/IepF9FQ9ucreT1FT?= =?us-ascii?Q?7UwVtOSGUAcUO0/dKmwgl6IrFrDTgJ3+tyWar1ZY3V8K1dZ//tgbMA0AqGTQ?= =?us-ascii?Q?T0vVpoUOwapAszH+6JERT+dk2HTi6hOyO3mNG25yP+4asw9nm26gCaz1s3Ht?= =?us-ascii?Q?9/gR6dKIGM2iqxB/TYyBoW77HQyVzTGDFZ5hPV00WTubNqYGex+v0AQeRq8h?= =?us-ascii?Q?9gHAZr5PNUkUggQ7izyx1fIkCZKqo5bpapkwRaPtQNZU7CV+JnmH8xYkpDhf?= =?us-ascii?Q?7MBsnjtYuumJ1nGfd5FNb8ucAxVVRmwtHRmCq9PtxyWTIPH9B3Lt8AHWgmVY?= =?us-ascii?Q?jn5HAhNemvwztf2vLnryOAmwnQae8hKouw9AD/MEt9HBUNdlgiHAZ02K9eOp?= =?us-ascii?Q?GG5W76upRCjOae1+frUJLRUrLATA9XMKvZ95GExZYFYEw9JJIrtMFNN2aym3?= =?us-ascii?Q?Y0voLYfwzDqjQJMAo4jRvWbxg0rTetcfY2ozeS4PXQ9fASXQFLqpJl0yhqbo?= =?us-ascii?Q?t5PM+rb+sdeS7VwosxrOBg/CI3ju50t0fkOSlrBni7SOJdHPL5/yZxn39IE/?= =?us-ascii?Q?VZm2eR8uf/Jvu3yrerUOM5n66MkjVM7kwhp4ldVw4iaTxfkrkVXEIqLwDU6v?= =?us-ascii?Q?w8tPZXfOWw5S5RNqx68r5PyejEk7MAaJqUSYkOfZ35RXNugVUmV6vGKhwkDG?= =?us-ascii?Q?SkjgwG+LzONtj6M7xF8s9riLXyILSfarMPPTUov55kdm8v/pzJW/uYsQ1UVB?= =?us-ascii?Q?aRtWGmO8RZqMM+hncHeG6NevR1z/sbw=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7302b176-7ffb-4468-1db1-08da525a2cb0 X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 01:14:07.8338 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wgS0cAfjZXxSP3Z/7L81xh+BomidWCbWLiz7hcCEgmitVJkr8wWI7OFnSQvf2dOod2zjAABuaCOGblfmE8h4MHibJi9Rm45qpd7ne6V4ywk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1466 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883 definitions=2022-06-19_12:2022-06-17,2022-06-19 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0 mlxscore=0 phishscore=0 suspectscore=0 malwarescore=0 mlxlogscore=844 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206200004 X-Proofpoint-ORIG-GUID: ZicX-J59G5UDImycJ2GqruC7eRyfUr6E X-Proofpoint-GUID: ZicX-J59G5UDImycJ2GqruC7eRyfUr6E Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Each vhost device gets a thread that is used to perform IO and management operations. Instead of a thread that is accessing a device, the thread is part of the device, so when it creates a thread using a helper based on copy_process we can't dup or clone the parent's files/FDS because it would do an extra increment on ourself. Later, when we do: Qemu process exits: do_exit -> exit_files -> put_files_struct -> close_files we would leak the device's resources because of that extra refcount on the fd or file_struct. This patch adds a no_files option so these worker threads can prevent taking an extra refcount on themselves. Signed-off-by: Mike Christie Acked-by: Christian Brauner Reviewed-by: Christoph Hellwig Acked-by: Michael S. Tsirkin --- include/linux/sched/task.h | 1 + kernel/fork.c | 11 +++++++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h index 9e20fa18c41f..7f6364e5aa1a 100644 --- a/include/linux/sched/task.h +++ b/include/linux/sched/task.h @@ -20,6 +20,7 @@ struct css_set; =20 #define USER_WORKER BIT(0) #define USER_WORKER_IO BIT(1) +#define USER_WORKER_NO_FILES BIT(2) =20 struct kernel_clone_args { u64 flags; diff --git a/kernel/fork.c b/kernel/fork.c index 604c7f3cdde8..0313aa9ead89 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -1603,7 +1603,8 @@ static int copy_fs(unsigned long clone_flags, struct = task_struct *tsk) return 0; } =20 -static int copy_files(unsigned long clone_flags, struct task_struct *tsk) +static int copy_files(unsigned long clone_flags, struct task_struct *tsk, + int no_files) { struct files_struct *oldf, *newf; int error =3D 0; @@ -1615,6 +1616,11 @@ static int copy_files(unsigned long clone_flags, str= uct task_struct *tsk) if (!oldf) goto out; =20 + if (no_files) { + tsk->files =3D NULL; + goto out; + } + if (clone_flags & CLONE_FILES) { atomic_inc(&oldf->count); goto out; @@ -2229,7 +2235,8 @@ static __latent_entropy struct task_struct *copy_proc= ess( retval =3D copy_semundo(clone_flags, p); if (retval) goto bad_fork_cleanup_security; - retval =3D copy_files(clone_flags, p); + retval =3D copy_files(clone_flags, p, + args->worker_flags & USER_WORKER_NO_FILES); if (retval) goto bad_fork_cleanup_semundo; retval =3D copy_fs(clone_flags, p); --=20 2.25.1 From nobody Mon Apr 27 01:52:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3B31C43334 for ; Mon, 20 Jun 2022 01:15:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238357AbiFTBPQ (ORCPT ); Sun, 19 Jun 2022 21:15:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237783AbiFTBOn (ORCPT ); Sun, 19 Jun 2022 21:14:43 -0400 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DED75B7D8 for ; Sun, 19 Jun 2022 18:14:36 -0700 (PDT) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25K1DwH6009331; Mon, 20 Jun 2022 01:14:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=O9OfoQqtyDULESzakeHcKvUmA7Xni/CUfnI3Mjwztr0=; b=iUIuCWGpri8Ck9v0OlH6qgAhZkKJXz1MRWFOXwBIBakYmWQC6FvzfEWOwXP3O5ZF17i4 NWTrsZvGy1eMpnhZAk6Up6IDs+0m97Bqwcqzp0SzJkbIVU9ZAZ1ildE1XxPCcm9YVN5P naip/4apzB/sWK4e3bHnZchuH42VZ/as60ZQBtRc55odyyM38CfxEqHTI10Jl77KxJ+Y lmtLm7zdgwztpzECQ+zzKIsU6UCLTCMAJEE1yvOmIGomFnTNH/Kmr6Q6M9u1uO6re4FJ 6tt7Be3cFmJGGI7S0qv/NxxWw99M/sUmKDvtyGVDuss0OZdufzZrgjmxOTFqNcdSU5+Q cw== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3gs6ast047-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Jun 2022 01:14:13 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 25K19qKq038388; Mon, 20 Jun 2022 01:14:12 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2040.outbound.protection.outlook.com [104.47.73.40]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3gtbu5tbfn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Jun 2022 01:14:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mSfbnYJmN9HuZyU+ykwrzCFdS3oVz4a2LofWOXswjAcGFY94Ml04UQHg5IkM6guB2LGg/ZlWqEwei2OUG0AU+/c2wjpLVEp301+GJ85nK1d3pkWcv8LWIbwG5ALfuvqZ1ng0vLKbFSwhS4nDx81w2lGXglxW8KJbd6DvUamzTcn2TdErU8QFeeFauwSsIBWeQEus2N4SlZfFS26hS+dPm+oyoDFg2gi50wYipn9AsBSxqWjFeAwvSqhu0DwaDaFYtiNOxaz+Z9aE67jOlmYLUD+MKrslj+FAD7RLnHxZZthigTqHbHiDw2FP7kR7iHTb/esMvkB3ayxGyYdXSokduA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O9OfoQqtyDULESzakeHcKvUmA7Xni/CUfnI3Mjwztr0=; b=mJj3JwlA5v8bfDXkuMS5/0AvfoTW80mIj+Xz53iYQDpDsPWKxR7o8GCJ9Xapj3K+FwHM6OWQzqL2tSCBMsEYLbvgiffbFaI97pnbTzeXYqcGQjb+AkDn0v1yhfSErt3sW10+6berkPVZX7EQJM/yXzqq+btEhx5hdAdGhMBN3pSK+Bl2edXP1tgql5ZTC5LozQ1XO+31BVNWoFWM88wcZCgbrj6m+tc8YsxH4wJuZzFOKxxkeG6fL97zhUVenUXYwRr+cE90Ua3IrLcInCqLbBmbu2UUtHdj5h/ElbUtNHxPrvCTU/3X5ixq7kJRHOUr/NQ7LvixG+IhqySYpemUdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O9OfoQqtyDULESzakeHcKvUmA7Xni/CUfnI3Mjwztr0=; b=Erh34aPXd20+OsJ3Cy0XGN7ezf6XxGlrynxi/Y09EynEtvCzOVzPLGiNDzwYij13WRIe1ImtecXUrhs8U4TM2YFqpbi+y/ZhJpJN4ie1upgS+vYfe//zpKNpGD6vmOJbreNdRP8UR6LIXfSWxMmG/RRgpThjRW6V+GldpEvGlko= Received: from DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) by BN6PR10MB1905.namprd10.prod.outlook.com (2603:10b6:404:ff::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Mon, 20 Jun 2022 01:14:10 +0000 Received: from DM5PR10MB1466.namprd10.prod.outlook.com ([fe80::f81d:b8ef:c5a4:9c9b]) by DM5PR10MB1466.namprd10.prod.outlook.com ([fe80::f81d:b8ef:c5a4:9c9b%3]) with mapi id 15.20.5353.018; Mon, 20 Jun 2022 01:14:08 +0000 From: Mike Christie To: hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com, mst@redhat.com, sgarzare@redhat.com, virtualization@lists.linux-foundation.org, brauner@kernel.org, ebiederm@xmission.com, linux-kernel@vger.kernel.org Cc: Mike Christie , Christoph Hellwig Subject: [PATCH v10 4/8] fork: Add USER_WORKER flag to ignore signals Date: Sun, 19 Jun 2022 20:13:53 -0500 Message-Id: <20220620011357.10646-5-michael.christie@oracle.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220620011357.10646-1-michael.christie@oracle.com> References: <20220620011357.10646-1-michael.christie@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR13CA0014.namprd13.prod.outlook.com (2603:10b6:5:bc::27) To DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9cf1b84f-03e1-4905-9ead-08da525a2d35 X-MS-TrafficTypeDiagnostic: BN6PR10MB1905:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JiMOhwm32YZAQ1DOANZJsvnmQI3A+OH3Rse15+DIcFz1OVbIFTh4H7yo6pm/7XUkz+OkqnyORn+LtCWFmLsGcOo60PH/qtUA1FoLlmxJN4SQ14WNGUV5YHsMOJGTzl2JlqckCCixplzeBwCIRjJxSj6SSOQnf7FVMVwlONz1BNvk7/O4Bhq9lt2xWPdcMUX5rhEpuEkmQA3W3uu/VqJliwV+ykDFE9vWJsmJXJdkj1aZa0ungsI1CuBFXTfMyB4L05EV29AAkg3k3qwBwqD3cBTZ745NQVALV/pOViuAzeGyPqFWdxGFER/DNMrsaSIpod4ImKug543Sh2RyaY9Y55dhkbdoQitiAIltE0d6MJD2L0fPXYchXw6zQn80SFA9feKCMYpdFrtNBpWcU2m70G5p1n+fVdqtW/kejAEj+pE8BaBn1RqykhSFQOdOK7v3lTkS+0vF6AUunmSIw2GjViN9yAU/0Xd+CiW8rBdLaiBmEZOao0eQjHlwXCqoPRRczKjTF/zLaFrvJaeYSxZGyPyBMg+s6clmMMDfRZL3SF/Y06fSfVL+PjksNT6a+SCZWddVN7ivNiqlDuiw/LG1MuVdJ6Jn+SJpABBEbELF5u1YR3Mii1q6vk6fidk6dK5FRyVAitcb3pTIgyGe5+B6uaGUGfl4eDxZFf2lLiQu76rx2ZWJMTJ/mWNPgp9kY6gS9LFU2s38tKQPlJ3bUmteZw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR10MB1466.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(38100700002)(5660300002)(2616005)(7416002)(6512007)(2906002)(6506007)(6666004)(38350700002)(26005)(86362001)(52116002)(66946007)(83380400001)(66556008)(36756003)(66476007)(8676002)(4326008)(498600001)(1076003)(6486002)(8936002)(316002)(186003)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tJVzdXBM6q/i/fpULSFeaIL3Zn9tgqTu0aYGmre3Xs6ASjAKSE07ZdFldxPj?= =?us-ascii?Q?0LxocEZWaUZAYjfZyqYsqa/C97y6oJ214ACaKlJQ4ybjO8a8ju3jAghnV+1Q?= =?us-ascii?Q?WZM0RwF68x15B35KHVU9uxCtjklqHqEkFzj1fB0aEm+1eObSCF1nozytdd+3?= =?us-ascii?Q?uHELzXOSyO+xZCPVohJDt1ka0Eq6nQrwjMmLb0caVA2BDHXYT7MKLHnvU6UM?= =?us-ascii?Q?vzYswcrvwpSrjUkr7/b+dAVPOcahFl/sT3RjBGjBKhI/DMkCiy6XOTanst8N?= =?us-ascii?Q?Ebq2nYYMH5KQ/sMZPmK8GTzWbjsMzGThtOSjBK7E+R/Vkxw/qK+oXvKdiomq?= =?us-ascii?Q?iPDQESnWKQa/8opvudIL8lGK9JPGf7RwG4AnSEpj6KzvEAT2qpw2kW74OdRo?= =?us-ascii?Q?V13otiyafKh8pSgMdXxsySTxbldyq7oXTTT7TwHGMyay6E1T0bADBTmI23dc?= =?us-ascii?Q?vf9Mo7IAUP3P6htaDgZYPBgYnAsyqB1yCS0+h8Q6QhkARqdIlrhhHNwa0NCN?= =?us-ascii?Q?i3zz5UkraBAjE185fiiKk9IWz4tz3crlP0nw6rV0rW+CnXVH/6W5UTpg1owA?= =?us-ascii?Q?/uaDFvzgIcgG/6ES++qZqibWdcUJL6mR43OfB9nnmnkqmQJuMELtKo9oXsW3?= =?us-ascii?Q?TA3EKNh5iKWY7XNNhSTEPdQgN9npxcvWiJfcc9I63CXA8LHZ1g2oR/qDz53u?= =?us-ascii?Q?HOV9Bm4I/YnzLdQKdisSrQsTGWY2ZTom8Hj7fJY5HAxeBq485PMZwIQXuxsY?= =?us-ascii?Q?FOZ/Ph1FKLohhMrvK16/HdJW7hCAp7gOyadFQDyptF2Ps5SiQb0+JyzSggDa?= =?us-ascii?Q?rQy85w3MwWHL6PxACE+8IqDPVs2enNBshNnRPscGDD2WnkIKh1Fjmtyn0She?= =?us-ascii?Q?7Dwlr3vhYNVSk8RKf8LJk+X3Wrq3HfzSSBJ938+2lvWCumDt/tUmZgR7SkL4?= =?us-ascii?Q?M4JoV3tlGvgj2Iz2FMTUIiwjxb0JUu03I8VXvbOQee/G5P8pEsF3cX7rT1dL?= =?us-ascii?Q?6Om4E/M7Inay9WI0bkGqbDQ2OF06h5T51mE8J2fdGGqwN2yz4mvJWr4aP+/+?= =?us-ascii?Q?UQRJ0Ll/ZoWxbyP/WO37OoU7RMoApyU3HhzO9sqp52dVauw9ddkcKXX459yg?= =?us-ascii?Q?O1i3Ud1GVAs/LL19p9JrIErSCoOx6nFXW2qknueUHMjVQwNoNNinLZShxA8b?= =?us-ascii?Q?xFvV0P7svHDvDJnq01hGTLwK+HnMdWFApyHDGD6+3nT2WhuRe2lvbQ7M7PUF?= =?us-ascii?Q?QbpHMZ4LLcQeCY6xQmgqaXLeBYRtuO2QG7s+rSYTApw5eIFzljCdzC+PJwKp?= =?us-ascii?Q?Apfpd2UuQrjQZx5+QZuT0/88238sjSJazLp9KDfkb3lh4MTVnsXgpW5S0EwO?= =?us-ascii?Q?SPgEz+OMxb/6CWlOLpeHygkcSTuM6KCXaYK0EtRyNOc2TGIXNdMi1smEsG1O?= =?us-ascii?Q?9lwhUp++gTPLGFhrgHQUm9pzIU9fd86WENSp4tdHOn4Tu4fVZ4Dz2CHVe64g?= =?us-ascii?Q?NHDGX2cR7isGuI1C0BcZtOLuNdEIC9iOEKTtGqGP7isMuP0xh+BWrA1iUnJ1?= =?us-ascii?Q?p0nXCHeRLBF535NzMhgjbMH8RvPbKsJ1xTuLlLvXRGUWFsNySwBvT4zdW0Yq?= =?us-ascii?Q?AXYQTxjdQcXHNkkMOVxHrgj6X5WMfmlkQ3zDFTzJXl2U34J8qYfQMk4W1omc?= =?us-ascii?Q?AZNKkrGRZ11oiXe8Um9jzDUK/vsaQS6dtW/JOd+1MNHLNghvaKFncuL1YbtA?= =?us-ascii?Q?5RDk31Af5xqv5nI96gAzDhWmxmftO2E=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9cf1b84f-03e1-4905-9ead-08da525a2d35 X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 01:14:08.7400 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TroPPveraprr3XoYXcbrJd1IEiCkqGDXpIJaVi6rb8DbnyGWLTarvUrLlPkiZLp+KXX/ip9xW27Zvt6LWfjzFmAr9/9HsIJ2gK8tiJiM7G4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1905 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883 definitions=2022-06-19_12:2022-06-17,2022-06-19 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0 mlxscore=0 phishscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206200004 X-Proofpoint-ORIG-GUID: Zl5mH4Kgd_rOZm-9kjIMOPWOxPjgBkpI X-Proofpoint-GUID: Zl5mH4Kgd_rOZm-9kjIMOPWOxPjgBkpI Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Christian Brauner Since: commit 10ab825bdef8 ("change kernel threads to ignore signals instead of blocking them") kthreads have been ignoring signals by default, and the vhost layer has never had a need to change that. This patch adds an option flag, USER_WORKER_SIG_IGN, handled in copy_process() after copy_sighand() and copy_signals() so vhost_tasks added in the next patches can continue to ignore singals. Signed-off-by: Christian Brauner Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Acked-by: Michael S. Tsirkin --- include/linux/sched/task.h | 1 + kernel/fork.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h index 7f6364e5aa1a..9fbb489b2512 100644 --- a/include/linux/sched/task.h +++ b/include/linux/sched/task.h @@ -21,6 +21,7 @@ struct css_set; #define USER_WORKER BIT(0) #define USER_WORKER_IO BIT(1) #define USER_WORKER_NO_FILES BIT(2) +#define USER_WORKER_SIG_IGN BIT(3) =20 struct kernel_clone_args { u64 flags; diff --git a/kernel/fork.c b/kernel/fork.c index 0313aa9ead89..c479b8419a6e 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -2261,6 +2261,9 @@ static __latent_entropy struct task_struct *copy_proc= ess( if (retval) goto bad_fork_cleanup_io; =20 + if (args->worker_flags & USER_WORKER_SIG_IGN) + ignore_signals(p); + stackleak_task_init(p); =20 if (pid !=3D &init_struct_pid) { --=20 2.25.1 From nobody Mon Apr 27 01:52:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7C91C433EF for ; Mon, 20 Jun 2022 01:15:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238090AbiFTBO6 (ORCPT ); Sun, 19 Jun 2022 21:14:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237749AbiFTBOm (ORCPT ); Sun, 19 Jun 2022 21:14:42 -0400 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46AF9B488 for ; Sun, 19 Jun 2022 18:14:35 -0700 (PDT) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25JGt81d018712; Mon, 20 Jun 2022 01:14:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=2j1xvGBUEglWQ5KNA7m6uAvAigJnl8nHYWH3eLconx0=; b=hG9xdHgubKBDWtwKMBEt1FW/TZkEVnqol9iNhbKCDyN1qtjkDLLa1Nh/UxKrKl1GtVKA vQ5ucl0oM8+NVbE+5KmSla90Ei55M0KOZ7XDBQ2djamwhcW9JoZcj1/T+BZJ66CxaeX3 6vhl4HQYPy50T4UiNAYdRLXHvdhw0IXQtX97HzYlXS0FsK6r7qc7HhIiq5ozC8kmm7oa mFBMz6LkCSyfbR3HMvcGC5xZukOIFaBRkreEppyDBUjjZvdTrDW6K0QghASGLLduzzKa MQ2gGnhx3+yVzqTY6lejYklmeZ2ddoqIEW5hnVc4+xZXNcR6UbEkZ5KxWFKDSBCrG1oF iw== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3gs5g1t12h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Jun 2022 01:14:13 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 25K19qKr038388; Mon, 20 Jun 2022 01:14:13 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2040.outbound.protection.outlook.com [104.47.73.40]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3gtbu5tbfn-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Jun 2022 01:14:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P6ue/RiFFENZaHL36VD2nTqGTKqfE88FNLuLNfA/M895rVY4yI9bx91i6NIyRjVU2Tczdqbl4sMZv7vkIsAuVmQjcC4mjZvcNjBuK00SWyASrJymJ4r078xG3t0t/l5kYkm5TK+y5GriK19L/16MW1KN1MEHvU99IS7LtBYKFsKsK+B7ZgUNVsNKBiKVANVeZzUTC9YnCschyxrCPDaDM3b1bVPzPS70sOdb9Ux0VR3M3q/NqvfFmJ/xKUSeZQKYzXjcwbR99QW9N9+eRGm2KMhOQzAN1Yed1R+Bvnu4BB/uG0cCNqugdxA7Kp0ksvb21I1/jcnbn340Q6NTe2MUfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2j1xvGBUEglWQ5KNA7m6uAvAigJnl8nHYWH3eLconx0=; b=DPJGuMkDDzUNmdPeMehCX+Rbl3SMFV5+XTX1GyP7qKfWxFcJJZ3g0vvG86anYgjsPJAPBiudB3iccP4PonYwo/tsHBIaFPQlvTZTesyyn+5zOG6dsDDFTHW6R+NtzXijeSK3E8ycJLK/PTo9oMwDMIa5y2WgTOOckyrcsczJhjR5eFcbYTv/uAddzsbxX6Ck1ngvKy2G3fbmC4N+8FKHv5P7twMXomj8utEHQFkiIubruzOJ3eEmAKiX+aqF7vSWLfhDPdJ6Bcc9WI2G8d34zYoB8soEweWtYLETeNmTn+Xu2yOO49AR+LbShZvRDOpDqixiIdkrSUeXk5DmRSFMOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2j1xvGBUEglWQ5KNA7m6uAvAigJnl8nHYWH3eLconx0=; b=bzfyjdzbn+3Fx6Xn+TA7erougD8Nhd5gTsYAJL/WL2bqf5mwYIcLsr1hvWG9XWEkLu/hZudycYEK78qJgR8R0PYp3MC+4wz+pxpOMOhYfDHAkX3jwABPgIXjIUhdQtXrY2QMxzgxUNruOpaWxq0bxaYfZYUc7l/ogGdgmRa4ukA= Received: from DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) by BN6PR10MB1905.namprd10.prod.outlook.com (2603:10b6:404:ff::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Mon, 20 Jun 2022 01:14:10 +0000 Received: from DM5PR10MB1466.namprd10.prod.outlook.com ([fe80::f81d:b8ef:c5a4:9c9b]) by DM5PR10MB1466.namprd10.prod.outlook.com ([fe80::f81d:b8ef:c5a4:9c9b%3]) with mapi id 15.20.5353.018; Mon, 20 Jun 2022 01:14:10 +0000 From: Mike Christie To: hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com, mst@redhat.com, sgarzare@redhat.com, virtualization@lists.linux-foundation.org, brauner@kernel.org, ebiederm@xmission.com, linux-kernel@vger.kernel.org Cc: Mike Christie Subject: [PATCH v10 5/8] fork: allow kernel code to call copy_process Date: Sun, 19 Jun 2022 20:13:54 -0500 Message-Id: <20220620011357.10646-6-michael.christie@oracle.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220620011357.10646-1-michael.christie@oracle.com> References: <20220620011357.10646-1-michael.christie@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR13CA0014.namprd13.prod.outlook.com (2603:10b6:5:bc::27) To DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6d2dba2c-e2f9-4f36-e436-08da525a2dbf X-MS-TrafficTypeDiagnostic: BN6PR10MB1905:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t14b4BSBBk8wJ5dp+2NXZUhucvIrOgAkvTbxIktPG4IgrWNFQ1DzObbWc1aA+Ekh8RxXiahCpa1M3xp8MNc0Mk7nopOxSUlvfvqTxfZ/lp7VkYpMkZJZVnnPPRzMcdeXoMmR14YhqrnGRB5D3nsxhWj52FW8aSGg/wni4SGT+U+1mTcviIgr+7p0bT5Xvk4Q1XU+aDFpdJQu/u5Vvzse1uWtnVywNc7E0y0m3g0qI9TOuCR1yV36Q2mjFFQwZzAuSRKoYu4S6dbNvE6Bp5x9xAu84RyqN3a9jyn13WpCjphq+Q2KIaopWQjVL4XJPtDofAjaLY65jMzjN1X285KnRcITh53dc28UrhtrzR1ra3CdVpBM6Cb6UdUp6Zln3aw6HRBtMcdikK5KAOQQBs/pZHrs+pCUjM2svIWHFFmqiKiB8IeoQoWZx+FZJLAJ+bjxSvTenUyIpQpiemvZSEXMvuTs9ikhqv12SAL7Vr1ezdQnQIm1gbLS3+v1GfXb52kTwfR6o7vSGP9ELMyVX+TeQDU/xKS2JWXEht8xpmeun6tyCBtXXhH1ChNIkVvCg6ocAWQ5+qfheTyHNQ1JOrr/rmmD/PZRXWud3OWkWfqsPpwaA4sntsqS9zGm40wtdTEYilS+kWmLQYETaK3eclEjx63ITMgvAfZGnm/fMe/2n+diozbYhK2ofdrXWpa6ZYzn2V4RT3LJ4meghuSn2RRrJg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR10MB1466.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(107886003)(38100700002)(5660300002)(2616005)(6512007)(2906002)(6506007)(6666004)(38350700002)(26005)(86362001)(52116002)(66946007)(83380400001)(66556008)(36756003)(66476007)(8676002)(4326008)(498600001)(1076003)(6486002)(8936002)(316002)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?c5wIBlpOACQ7mhaw7hS1XB1OXR1G8oHHZcj4AsV3Q8wFCnrQdAAuc05hK1rf?= =?us-ascii?Q?IidA60mmLnPsGVWph98/0TP3QdwYpFgzTWSbQZ+cv7lSV3jQLJR6LF10jein?= =?us-ascii?Q?Y2Ky9sbmZ/LL5vHKgcDqBTde9K3qJh/0xLge1M83mBE2fvSzRvDlqAM9y4OL?= =?us-ascii?Q?NePcW6IyCFH8bJirFRKZUe2X2QSDNJqUzusA6w4ziRaRARoaHjS+3avKMASV?= =?us-ascii?Q?VaaAq99kfEfMgxYJ4ozA9APMRPjtoRa0O+nMMRpqkMvq5KO0NnW1SAe2wG6a?= =?us-ascii?Q?faDD//HEHVDnSI8FqxidZYyVHTJr1auuEWadjfG78NVt6TVobVC6aEqpBC/v?= =?us-ascii?Q?hPAJjBm6YeQn2AIAubqoueTW1bAWcFsdkq9yOFDo9G4+8sQrq+59ryJSmqZo?= =?us-ascii?Q?C8dwMgeD7vHzRdTXYV4PgpYT1HAdebk1lgmWuNmU2kWfx5rXgJwUp/f/k5Ct?= =?us-ascii?Q?A6xXZNueLSh4kMNqTt27z9Ux0rJiSMWkkQy7USw7x0kCgymp1VR9eeYrY7fN?= =?us-ascii?Q?PMIDh6f30oPyCafmLrk9zT/BwGN43rh92z/oVytpQa+Bc2FHc+xnkuqOnDmd?= =?us-ascii?Q?GO7UPYwJfZt6obRIS92xdyECFRJrccisd485eV4p1ZFqNVlwYsAEHT6+HUTM?= =?us-ascii?Q?gmT8dP+3rVqlzqkA3fUk8AI5uEkCqdbohROuwPNq99cQb5wW5Y54xfn+1GJO?= =?us-ascii?Q?Vua5nurWbcM7km13Ntg/veifTaiL/LaPWRLpItXBKFsaRYJNIxY85jB0z3TI?= =?us-ascii?Q?p+72wLD/GcYLnOI9hnalT0RE2DBI4+Xqdya/zpYShUztNFz01tCeTs0pwIp2?= =?us-ascii?Q?VV0dvi+xeZvZK9FfTYMprk8BRWat30alMGpMarPt7JhRvyWOaHvIoMrCTs2g?= =?us-ascii?Q?WxVnJjPm8N0lES1CTs0Rey9RPGMEIweKwSBUIkMb1tn8qMYIhfbCHNHmoFMH?= =?us-ascii?Q?9ewo0NtqTVXDRZC4K4TxEPVHuU8Mc932EvBx76qCTyDAdyKU35811OCK1nm2?= =?us-ascii?Q?HsPoatFFLFghHemAxLLIPwPWS180P+kIgFCSYRTrCLm0MgN67BXYHTzcqcUk?= =?us-ascii?Q?MWZHLNoBn8oVjAYQ8nxb1Um1lUsgXLkbUUvYoj5l8R/4ZrAPVQANV+MG6rog?= =?us-ascii?Q?9HgLexLbkYQI7jgbSk6CsfuJpRRcvokMGbTN7NNqGeYIGTTWwImU81rdDa1d?= =?us-ascii?Q?0wEQS+vAY3Wk/6uRLM3uJEfKBVRdrzo5nJT/oQA4M4ns81chMiaSoYrPV9ev?= =?us-ascii?Q?FgJNDHz4Rm/wBs9JjNzx5UMIGJJ64d0x6QdkHI4by4IFr6pzKHvMnbQu5gtO?= =?us-ascii?Q?KNtLzjaDlc+hpj8EVrdcFMAHH6raGW0f9xAlV9/zem2W6rNlI3m3ELwfTLhB?= =?us-ascii?Q?5L4AqP9PzOdaejIfVFv+tAV70q7Tg0z/v4GAj5z8CV0w0ANSOdDgKYeyrMxL?= =?us-ascii?Q?v3nRiEEfGd4bSXmgf+FzrIGvXLz392H3isDPFs3+OvsahBGpWTpJzc3oHwqt?= =?us-ascii?Q?esMK1HoG5c65OHup6akTacd/UMKaY4VgfIXirrsR+guQS2fgMvu0vNAC8sAl?= =?us-ascii?Q?1OLpxTC5JqnL6Z2Qtya5zQ42NJn2CqNX4ZEccDOTSbyd1bMFOZ8G/9piFhXI?= =?us-ascii?Q?yGFi/3h/4vW2MiYtwyduqJF5ubfruvFMZz6hMDF886TnpJzFNLv6Yu7kmNYT?= =?us-ascii?Q?JgdvHP9MDAduou78SV8UxtXjWt2J+NMU/p5+icYIhmKCEfAPe8+JQwPCeBnn?= =?us-ascii?Q?SIafp29Aj4ve6p7zr+Z27cy36KldHMI=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d2dba2c-e2f9-4f36-e436-08da525a2dbf X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 01:14:09.5837 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h1G+xQ42y8hIPkWL6kZseLrvw+k2eGLmA5Ubu2hkY2+J4Qh2sWHPmZ0Kblu5M9YVYhLz/N8Vt/7a2ITSZadeAn5xLJ/QGylfVK/VUeNjbWQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1905 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883 definitions=2022-06-19_12:2022-06-17,2022-06-19 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0 mlxscore=0 phishscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206200004 X-Proofpoint-GUID: 1bQb3lZ6BiV8poEFc90uL0Cy9deJMeOS X-Proofpoint-ORIG-GUID: 1bQb3lZ6BiV8poEFc90uL0Cy9deJMeOS Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The next patch adds helpers like create_io_thread, but for use by the vhost layer. There are several functions, so they are in their own file instead of cluttering up fork.c. This patch allows that new file to call copy_process. Signed-off-by: Mike Christie Acked-by: Michael S. Tsirkin --- include/linux/sched/task.h | 2 ++ kernel/fork.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h index 9fbb489b2512..ec4a0097fe4c 100644 --- a/include/linux/sched/task.h +++ b/include/linux/sched/task.h @@ -93,6 +93,8 @@ extern void exit_files(struct task_struct *); extern void exit_itimers(struct signal_struct *); =20 extern pid_t kernel_clone(struct kernel_clone_args *kargs); +struct task_struct *copy_process(struct pid *pid, int trace, int node, + struct kernel_clone_args *args); struct task_struct *create_io_thread(int (*fn)(void *), void *arg, int nod= e); struct task_struct *fork_idle(int); struct mm_struct *copy_init_mm(void); diff --git a/kernel/fork.c b/kernel/fork.c index c479b8419a6e..7b6caf46187e 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -1978,7 +1978,7 @@ static void copy_oom_score_adj(u64 clone_flags, struc= t task_struct *tsk) * parts of the process environment (as per the clone * flags). The actual kick-off is left to the caller. */ -static __latent_entropy struct task_struct *copy_process( +__latent_entropy struct task_struct *copy_process( struct pid *pid, int trace, int node, --=20 2.25.1 From nobody Mon Apr 27 01:52:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AF5BC433EF for ; Mon, 20 Jun 2022 01:15:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238037AbiFTBPB (ORCPT ); Sun, 19 Jun 2022 21:15:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237739AbiFTBOm (ORCPT ); Sun, 19 Jun 2022 21:14:42 -0400 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FA5AB1D1 for ; Sun, 19 Jun 2022 18:14:34 -0700 (PDT) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25JKACH5013171; Mon, 20 Jun 2022 01:14:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=R3fLhmovGlX74ReigGhVPEWVr7zEEzYeYHsjq/K7XQ4=; b=K1CjLA5cw38X3kW6URY6mS4Z2UxJceuleVO+BQxyDJ+3BWpy5x6SUdRTRxtHkn3QQuPr f1LCxqEjMAfOkGVX3SapPvzvEGy5L2kSXAwZCU2oFNoDAlsD+NJ36LshcyYDrbj13nUs T6e0VhuWZjSlIPz9wqnVU6FYceiJVJJALcu4c5eesqqyZXu7YIK9tOJEFfvqNSKYwotm CpqH8hcXmHEBVlJPFf8I5Uuxl32Z+3WQIvzRf/MgDsBUOu7ErhnkPZQhLtjYR1vZk2NR 7L5WgAjtuinuZDPfSIhBhL+ZCWCvkpeca4pWXc6x1DkgIoaILKKf6aFk9wFSCqXPNwbg BA== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3gs54cj1bn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Jun 2022 01:14:14 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 25K19qKs038388; Mon, 20 Jun 2022 01:14:13 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2040.outbound.protection.outlook.com [104.47.73.40]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3gtbu5tbfn-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Jun 2022 01:14:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NsovWcrUcldjnlvogvvE9yYEn8iu4DDhQLK2tqTVtZgEhG0PB57x1pxj4aiF38J7lKrYSi0zvjKD6ZonwTiHt3Py9QGJ9bv0eWbx6KVI0+kKXFzGljeTHY252Zxqc0932L/R6O14O6mn5GKEyYzsvA2eiGgkOcHftWqWCMbpjYc3SP7lWNUlfsKsMQP/m9ezK24Uc1RKVYB4OINZKcYP9AdE+1Pvkup1PCA2wYrkvJkf+b4t506V++MarKgCsdJ6ZdVF0geJ/G5i/Juwkms1UcZ9i/hQHJOmyhr4trF9O4oKDvz1fQ9f5i7IVmCfGrOFLYVeaJlTa44ALBCYcOCFZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R3fLhmovGlX74ReigGhVPEWVr7zEEzYeYHsjq/K7XQ4=; b=fHBxlt9ArMSkO4N2bt3Td38hkAe0TkfFnbFXCU98LUTkRG44+ip/OawZvhSdgXwDdy4n8RxDoiWp9EcoDZwi5oh7A/H1Iz4zsA5cCyM9HZ7lMS0KHpyn6bFn3yZUqTfWh1jgzVHh+yn6RuGa9aa6jon/OXmCidBnNAKA2kFLWwagu+S6Xb6CX9OuFfGA/gkkGoVaq1Azc+jWQMGFpvmezTvEyxSJ/W3zv8B4hHVfElyJ9jcviPFu8fdcdp7KnPH73SAAjdcIR8HZyzhYid0USejppoxOQyr2LzdZbtxW3IywObOPXGyBspRo6mUCtKXwjiU0U5zWzlNOcSUZtfdVTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R3fLhmovGlX74ReigGhVPEWVr7zEEzYeYHsjq/K7XQ4=; b=QZrqXKmoMPXPvGaoF1FipyzvPG5YY1ZjenmVRPqNFa8LH/wquizUxhSsm/rUXa/wpXSu4En/gE2yiVN0XvMuZ28ZLQKbJeari/lHz9tHPopWI+XAtl14VDdFJfTso01Gp7Z9dRwhIMWqrQbAnOTkJ4WVwHnYj11stb2Dya/k0gc= Received: from DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) by BN6PR10MB1905.namprd10.prod.outlook.com (2603:10b6:404:ff::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Mon, 20 Jun 2022 01:14:11 +0000 Received: from DM5PR10MB1466.namprd10.prod.outlook.com ([fe80::f81d:b8ef:c5a4:9c9b]) by DM5PR10MB1466.namprd10.prod.outlook.com ([fe80::f81d:b8ef:c5a4:9c9b%3]) with mapi id 15.20.5353.018; Mon, 20 Jun 2022 01:14:11 +0000 From: Mike Christie To: hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com, mst@redhat.com, sgarzare@redhat.com, virtualization@lists.linux-foundation.org, brauner@kernel.org, ebiederm@xmission.com, linux-kernel@vger.kernel.org Cc: Mike Christie Subject: [PATCH v10 6/8] vhost_task: Allow vhost layer to use copy_process Date: Sun, 19 Jun 2022 20:13:55 -0500 Message-Id: <20220620011357.10646-7-michael.christie@oracle.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220620011357.10646-1-michael.christie@oracle.com> References: <20220620011357.10646-1-michael.christie@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR13CA0014.namprd13.prod.outlook.com (2603:10b6:5:bc::27) To DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d8cecb3d-58cd-4504-7994-08da525a2e39 X-MS-TrafficTypeDiagnostic: BN6PR10MB1905:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6nJTL+dlOTIzPUdrdfl/lduPUL9TqcdgfiW3ZQoxuuVWBHgDe7Efxxt55VddM5RLeROP7x+7j7E0L9NUORbCn/e1P1Er3xWlNjK40W2YgIB2x5ASKu2QVyYA+ZEz4xt+cTPVbKghVQhteh7u5XlE23ySxiT8Jwc5aeGob08o8s8ItyG1mwOQuJaWS4HYbfMnRsLTuMTm7vcly9bKiD+BBc3g37n/APASJpsfhBcI4oE7XRPQ6Y6ZOyuMV9XjFhs2i0/3pmsCfp0xv0k+jKKdVn64HlfERyNAhHie/CwfBBsk5EngTd6V2DQcmn825QqeDahkKCHqXFiyi3lXt6NO/f9bo8fxNV7KArS1e3juSi1rG2hKjO8ASaAYZON00OVH+i5kusKTLImAIyp34C7lWrI1a7skPykRpKEmxTsvhE/uKEhBGCfclOQmFr+inL1KVQW2g4l8Yrsk0qPrC1l22da4FrvwGUAz4icTkBFabi1N6aheUSdJhhGkhFV9dEQsxtl4ORrlChglZ425URH8u/LD90NYDPtmqsb5hccFGSjpbxJv6+9TdM4+OaveZqYDg145jmKVVZmdvTmtdBf3CMvCorsWMcFH6kbwFacDHp1usBdVq5336589eOVetYKuEzGx+LUkM6y643IkGcSa0jgYm4RfyPDMpWk9dRue0A+tz4nqFI8ejVr4853Od1I4V6zt1Ryr1b9QULfeZ+3mbw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR10MB1466.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(107886003)(38100700002)(5660300002)(2616005)(6512007)(2906002)(6506007)(6666004)(38350700002)(26005)(86362001)(52116002)(66946007)(83380400001)(66556008)(36756003)(66476007)(8676002)(4326008)(498600001)(1076003)(6486002)(8936002)(316002)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OZTygz3mVRv8i2NaJiO3GnD/xV9j5cfubP2v4pyhWG/Xook0JPprxa5hyDnW?= =?us-ascii?Q?SLBdobRapSwoAK0F09vBjlyv52d6suf9oeavn0jzWm9OztPTWknWT6YV1mj5?= =?us-ascii?Q?U1nHBufUJsoIEd4BrlZGPMBke1W2bNswFP2ubTwyC9MBiKlydMqwom+OSCfH?= =?us-ascii?Q?epZsTBLX/hBdb4PIeeEAYtqkh1pZ0rH6YCUOCiDNsBs9g5Iqe+BkyD7SNRgA?= =?us-ascii?Q?oYQIy7dCWyd+bRA1R0qi435jdBrXarjcOT9jFfbhfOgnmL1l8xBGK+grCEuk?= =?us-ascii?Q?+5QICDJLlTPLrocK7mm9ZbqbsDe7DvRtOFeHwjegY/UHj3LGPTalrmmkcw9X?= =?us-ascii?Q?7y4tRAeHlW3bnvzJl3Dbe71V+kyaJXh+Qpgu3wiPiwXv1u4TXSbh1Jeu6lL9?= =?us-ascii?Q?P0c2gJv5xOTypfU7hnDe8Vk6Eg2QUB3hVY9nDzjKxdIwuNCnucMF2XQYdTSv?= =?us-ascii?Q?ss8G3UOQF0ngHole1pQMYLEMksh9/YL9gZS759NPd4lenHyXdogPWO5PL8Iz?= =?us-ascii?Q?PqWNlIe4ZOiOhoZULuWkKdaIkEu7vTN4sEUIW5GVsiyMqYcPJYKKiC05Ve7O?= =?us-ascii?Q?9hkn6TSu2Xz0ZEeKxMHR50MKtBnfF5nMpDzDtqxWCBwqIavOlF41WwMf++Bz?= =?us-ascii?Q?h/NJEhdRyNcg7sF6bIAHRU6KKNMq39/uUw4P5ISwUMZuuxAtiQlEJeVoCaS1?= =?us-ascii?Q?GLHEN966FvAfTeWnPWF9A8eaIsrAF5fPZkFHx5atJ56YWh6dZsGyWww5PUXE?= =?us-ascii?Q?gQdYrM0FFMbK9MZjQ94am+Gm+lqTUwplRKkHVTg4nPepbcK/D/yg2bXLvXYV?= =?us-ascii?Q?5Ls5mopt43kvE/QXHpHomiHx9IV7tus8p7xzngr/E90cPCceZkC7XE9OkojS?= =?us-ascii?Q?abadNyTk1tEAWphKCLantW1UJdfZ8bOG+vvjZhDPglmh0xlK4nqldlq69Ou9?= =?us-ascii?Q?g5Ez9I/rD01lB9c6hpHV1PS7zeVINVUAQmsvvHcS83KAb+vBENDsL3sJKWSN?= =?us-ascii?Q?TV0yPoQVKO9tR64Vj1SN6G6xBCV74S9RCn+hjHSACEh0dgH1jq1A/U0Dg/JD?= =?us-ascii?Q?6KoZL1AvR3KzgEv90vxD/zL23W0HHh5IOdpkebjEs1N3lZS3NaHpj5TFqB+W?= =?us-ascii?Q?zID0RCuaoD4RY1FYCQPMbsW8e2YwM5Fh85sglKri64tuDuLPazzBwA6SANfv?= =?us-ascii?Q?xQlQPZMWpPuy0cORQgs9nYzxbBP2sjtjuog4pYdhpfTAlZww2aO23YyQ8O3i?= =?us-ascii?Q?0cjhZhH5GEo5woYHsF2vELgLeYkVKGI/Oiw2bFxehHhH0ljiXsxb++yGOuMe?= =?us-ascii?Q?p5iDDz2+ka4j1YaUzhjErnkQbTNhQGipWBY2umcWAOV1fZCeM8HHxLNJjGd7?= =?us-ascii?Q?3vTZnHWsjX8c8nm02NkiakRVVk1kictBuWe2yEZCsNR2UEgGearT7blKjThV?= =?us-ascii?Q?It9EJgiu8LMpExa6Iyii8b28eSkugmDKryaJ12tLotR9RoOWwfJyOM9nKIVB?= =?us-ascii?Q?8yCC2ej1hdHbrJM/POCYvnwUJhGBwpRFFqBLlUtXCBROcnHl7obtcJpaoaF9?= =?us-ascii?Q?26fkAPbKlbOXeWZSXDyi+488xtMxfb/c76ybT02+dGznOR3xV8FAOx0ifn5j?= =?us-ascii?Q?BKgGe2gQUEOEGjwMVKIhYY5j1Mbvhrq6X+ucf+9J/NxxR9/GXidu9xjsmrdZ?= =?us-ascii?Q?HbkpqBRDKDDQ74/omRrp82DUk4XkcEaRfRg3KCim4Z56lTpRlpiGiw1kiH4l?= =?us-ascii?Q?n3hMpdwfon8RmxXALhwAjyJ1X7P6aTg=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8cecb3d-58cd-4504-7994-08da525a2e39 X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 01:14:10.4118 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xKuD8f4X4Vm/NLka7z+ZgjhKZQ4OsO2MYms+RrepVG5q/vY81Jf3AZK5F7W291T5BDaHLy8aLTk8pIluOpCTOoOfGzBb246AAtAmzv8tKho= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1905 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883 definitions=2022-06-19_12:2022-06-17,2022-06-19 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0 mlxscore=0 phishscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206200004 X-Proofpoint-GUID: RnuMfabyio46HaR2fQ5CfnNUPAGokDbZ X-Proofpoint-ORIG-GUID: RnuMfabyio46HaR2fQ5CfnNUPAGokDbZ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Qemu will create vhost devices in the kernel which perform network, SCSI, etc IO and management operations from worker threads created by the kthread API. Because the kthread API does a copy_process on the kthreadd thread, the vhost layer has to use kthread_use_mm to access the Qemu thread's memory and cgroup_attach_task_all to add itself to the Qemu thread's cgroups, and it bypasses the RLIMIT_NPROC limit which can result in VMs creating more threads than the admin expected. This patch adds a new struct vhost_task which can be used instead of kthreads. They allow the vhost layer to use copy_process and inherit the userspace process's mm and cgroups, the task is accounted for under the userspace's nproc count and can be seen in its process tree, and other features like namespaces work and are inherited by default. Signed-off-by: Mike Christie Acked-by: Michael S. Tsirkin --- MAINTAINERS | 2 + drivers/vhost/Kconfig | 5 ++ include/linux/sched/vhost_task.h | 23 ++++++ kernel/Makefile | 1 + kernel/vhost_task.c | 122 +++++++++++++++++++++++++++++++ 5 files changed, 153 insertions(+) create mode 100644 include/linux/sched/vhost_task.h create mode 100644 kernel/vhost_task.c diff --git a/MAINTAINERS b/MAINTAINERS index f52543aedd61..8efd697499fd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -21147,7 +21147,9 @@ L: virtualization@lists.linux-foundation.org L: netdev@vger.kernel.org S: Maintained T: git git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git +F: kernel/vhost_task.c F: drivers/vhost/ +F: include/linux/sched/vhost_task.h F: include/linux/vhost_iotlb.h F: include/uapi/linux/vhost.h =20 diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig index 587fbae06182..b455d9ab6f3d 100644 --- a/drivers/vhost/Kconfig +++ b/drivers/vhost/Kconfig @@ -13,9 +13,14 @@ config VHOST_RING This option is selected by any driver which needs to access the host side of a virtio ring. =20 +config VHOST_TASK + bool + default n + config VHOST tristate select VHOST_IOTLB + select VHOST_TASK help This option is selected by any driver which needs to access the core of vhost. diff --git a/include/linux/sched/vhost_task.h b/include/linux/sched/vhost_t= ask.h new file mode 100644 index 000000000000..50d02a25d37b --- /dev/null +++ b/include/linux/sched/vhost_task.h @@ -0,0 +1,23 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _LINUX_VHOST_TASK_H +#define _LINUX_VHOST_TASK_H + +#include + +struct task_struct; + +struct vhost_task { + int (*fn)(void *data); + void *data; + struct completion exited; + unsigned long flags; + struct task_struct *task; +}; + +struct vhost_task *vhost_task_create(int (*fn)(void *), void *arg, int nod= e); +__printf(2, 3) +void vhost_task_start(struct vhost_task *vtsk, const char namefmt[], ...); +void vhost_task_stop(struct vhost_task *vtsk); +bool vhost_task_should_stop(struct vhost_task *vtsk); + +#endif diff --git a/kernel/Makefile b/kernel/Makefile index a7e1f49ab2b3..c00409e526ad 100644 --- a/kernel/Makefile +++ b/kernel/Makefile @@ -15,6 +15,7 @@ obj-y =3D fork.o exec_domain.o panic.o \ obj-$(CONFIG_USERMODE_DRIVER) +=3D usermode_driver.o obj-$(CONFIG_MODULES) +=3D kmod.o obj-$(CONFIG_MULTIUSER) +=3D groups.o +obj-$(CONFIG_VHOST_TASK) +=3D vhost_task.o =20 ifdef CONFIG_FUNCTION_TRACER # Do not trace internal ftrace files diff --git a/kernel/vhost_task.c b/kernel/vhost_task.c new file mode 100644 index 000000000000..517dd166bb2b --- /dev/null +++ b/kernel/vhost_task.c @@ -0,0 +1,122 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (C) 2021 Oracle Corporation + */ +#include +#include +#include +#include +#include + +enum vhost_task_flags { + VHOST_TASK_FLAGS_STOP, +}; + +static int vhost_task_fn(void *data) +{ + struct vhost_task *vtsk =3D data; + int ret; + + ret =3D vtsk->fn(vtsk->data); + complete(&vtsk->exited); + do_exit(ret); +} + +/** + * vhost_task_stop - stop a vhost_task + * @vtsk: vhost_task to stop + * + * Callers must call vhost_task_should_stop and return from their worker + * function when it returns true; + */ +void vhost_task_stop(struct vhost_task *vtsk) +{ + pid_t pid =3D vtsk->task->pid; + + set_bit(VHOST_TASK_FLAGS_STOP, &vtsk->flags); + wake_up_process(vtsk->task); + /* + * Make sure vhost_task_fn is no longer accessing the vhost_task before + * freeing it below. If userspace crashed or exited without closing, + * then the vhost_task->task could already be marked dead so + * kernel_wait will return early. + */ + wait_for_completion(&vtsk->exited); + /* + * If we are just closing/removing a device and the parent process is + * not exiting then reap the task. + */ + kernel_wait4(pid, NULL, __WCLONE, NULL); + kfree(vtsk); +} +EXPORT_SYMBOL_GPL(vhost_task_stop); + +/** + * vhost_task_should_stop - should the vhost task return from the work fun= ction + */ +bool vhost_task_should_stop(struct vhost_task *vtsk) +{ + return test_bit(VHOST_TASK_FLAGS_STOP, &vtsk->flags); +} +EXPORT_SYMBOL_GPL(vhost_task_should_stop); + +/** + * vhost_task_create - create a copy of a process to be used by the kernel + * @fn: thread stack + * @arg: data to be passed to fn + * @node: numa node to allocate task from + * + * This returns a specialized task for use by the vhost layer or NULL on + * failure. The returned task is inactive, and the caller must fire it up + * through vhost_task_start(). + */ +struct vhost_task *vhost_task_create(int (*fn)(void *), void *arg, int nod= e) +{ + struct kernel_clone_args args =3D { + .flags =3D CLONE_FS | CLONE_UNTRACED | CLONE_VM, + .exit_signal =3D 0, + .worker_flags =3D USER_WORKER | USER_WORKER_NO_FILES | + USER_WORKER_SIG_IGN, + .fn =3D vhost_task_fn, + }; + struct vhost_task *vtsk; + struct task_struct *tsk; + + vtsk =3D kzalloc(sizeof(*vtsk), GFP_KERNEL); + if (!vtsk) + return ERR_PTR(-ENOMEM); + init_completion(&vtsk->exited); + vtsk->data =3D arg; + vtsk->fn =3D fn; + + args.fn_arg =3D vtsk; + + tsk =3D copy_process(NULL, 0, node, &args); + if (IS_ERR(tsk)) { + kfree(vtsk); + return NULL; + } + + vtsk->task =3D tsk; + return vtsk; +} +EXPORT_SYMBOL_GPL(vhost_task_create); + +/** + * vhost_task_start - start a vhost_task created with vhost_task_create + * @vtsk: vhost_task to wake up + * @namefmt: printf-style format string for the thread name + */ +void vhost_task_start(struct vhost_task *vtsk, const char namefmt[], ...) +{ + char name[TASK_COMM_LEN]; + va_list args; + + va_start(args, namefmt); + vsnprintf(name, sizeof(name), namefmt, args); + set_task_comm(vtsk->task, name); + va_end(args); + + wake_up_new_task(vtsk->task); +} +EXPORT_SYMBOL_GPL(vhost_task_start); --=20 2.25.1 From nobody Mon Apr 27 01:52:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A41E5C433EF for ; Mon, 20 Jun 2022 01:14:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238042AbiFTBOz (ORCPT ); Sun, 19 Jun 2022 21:14:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234884AbiFTBOg (ORCPT ); Sun, 19 Jun 2022 21:14:36 -0400 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7466EAE62 for ; Sun, 19 Jun 2022 18:14:34 -0700 (PDT) Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25JEFUO3012858; Mon, 20 Jun 2022 01:14:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=WFaY45VwYR6sWK6+fArlPWWBj6ZoOOjrrsZeqeJkdZ8=; b=hyPMkTRXkVz45y8eFHfKZ/hKIW5smhBkVrJovW6Eeyago6JdPMD0iaubHkyfm01Ozmpx PXcTWBsA1egGByPkgQAq8toUsA7e0RrhkGYSrZ4fPpSM2U6lnn87pTV7WNQxjh49DSuu Ehlxlab4ZABbFgUEsdZP68SYVqHJyeKQiAt+rcmLoN9UwuufepVftNNnoRVXjVTw5CcM 0nNrRTh4IvPvcvBeJzRnTQe9bgfCuy+Ro3oqzuxNaY43J8Q2Os4mz0jnB7OvH8OuNrOB aujQuofIMChg0w39+1tEDNZE/RdIudfj0NhnVaOzuzR5X392Bx/PoMlqkdLdGw1Qv4F/ GQ== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3gs78tsxan-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Jun 2022 01:14:15 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 25K19qKt038388; Mon, 20 Jun 2022 01:14:14 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2040.outbound.protection.outlook.com [104.47.73.40]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3gtbu5tbfn-4 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Jun 2022 01:14:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z5HbYJd9QiRnBXuSaJmJoQfy1OYI3BvcRd2Dl5PXdZUH+Quvjsan2LEN83cr3sExjjVEVtbxS6Cnue2XQ68E9miCWXTba8JQUnufg+Q53NdFR+cBQIMnqx/l09EKxBb48pvlLrEzml5NEnQ030p3NjDRrp3uzjlsr9cVX7DKl1qLoD1aBW1xIQCi9bGyD7sK/3i3sjAp7mwRuYqjSBMpVNRa1eqCDoU6gVyWpQcE2LmNZuFDAk12ddJyJsxhluI1wGQ6y9XyqClVQ8ta+v2IawvhHUHzeVPmEQn9CRj+dX9DU19czzS/QXcsSLV+zKmlz6JD1pvQi9t9JdjP+dA5yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WFaY45VwYR6sWK6+fArlPWWBj6ZoOOjrrsZeqeJkdZ8=; b=OvUx1X/yWleIdqoGJeaaASsPzvvEXDYZsF3LZCExDYzeT4H8oXORT3SqnIccdODVwOc8Y2dBQFg0Qw12jPFIU8Czmj0K8++Cw+F07d828ugWHOI+WQHH66mVzrcE7LjWMqC3/NsiItH8XYFDgR0PaWnTTFH6V2BIppZwDK22+DpB6UswA/EN2GPsqRdS4dbd/sFRhRcU2MxkJF/TMyPc0vsCSgUVFykUgpLQjRAC1SR2MMDbYgOYdZw0WBKoHYRGnXcTHMs8fCpxHTpTXpoxbA+xfQJz1+a+fpZK6HLXQ8UrRpXhLk5kMN5kPqU9gABBLspXEPpEN2KZf6eXwDkdyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WFaY45VwYR6sWK6+fArlPWWBj6ZoOOjrrsZeqeJkdZ8=; b=K8gsqPjkeGyz/Z6MvSj+VQzp8u4EccPHJWkfB0is6xGZUSQiOBj+GmW3JACAislxR0yfViCOY1mkpFfEYDtBSQt4VOIp4oP50XMwPOPDlEfLYHq2GU9j0CmyK1HEvI7wdLoP30byarYLEYbhU1aMLc9NLIQg9Ig92FqB12fGNAo= Received: from DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) by BN6PR10MB1905.namprd10.prod.outlook.com (2603:10b6:404:ff::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Mon, 20 Jun 2022 01:14:12 +0000 Received: from DM5PR10MB1466.namprd10.prod.outlook.com ([fe80::f81d:b8ef:c5a4:9c9b]) by DM5PR10MB1466.namprd10.prod.outlook.com ([fe80::f81d:b8ef:c5a4:9c9b%3]) with mapi id 15.20.5353.018; Mon, 20 Jun 2022 01:14:12 +0000 From: Mike Christie To: hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com, mst@redhat.com, sgarzare@redhat.com, virtualization@lists.linux-foundation.org, brauner@kernel.org, ebiederm@xmission.com, linux-kernel@vger.kernel.org Cc: Mike Christie , Christoph Hellwig Subject: [PATCH v10 7/8] vhost: move worker thread fields to new struct Date: Sun, 19 Jun 2022 20:13:56 -0500 Message-Id: <20220620011357.10646-8-michael.christie@oracle.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220620011357.10646-1-michael.christie@oracle.com> References: <20220620011357.10646-1-michael.christie@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR13CA0014.namprd13.prod.outlook.com (2603:10b6:5:bc::27) To DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d9a0d4cf-aae2-4c91-fa8f-08da525a2ebe X-MS-TrafficTypeDiagnostic: BN6PR10MB1905:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /MK6u6QQwcPQ7EZzDLxIlndFl6A+61ZL4MazGCYtl6Qnqxdpg9g+F8KCIL8fLL6s89qBLzFvSR1C7Z9aOy1PCc4K8FwN4H/7nZFoJWwMGvuVl/zSKrtImpHsFF4IjNs6GL0iEC24reneG4n2RgbFJVYLu7mPrlpPU9nkvAvjTaRZIxrGkE2JAWSDlapDGHdlWLhqpI0gmcgLf0sgJhpQ5CF5BGHKjGDJoKw4BjWhWI+IKlccxdUBq5TCmAFsbZfPZ9e2uva/Zz4S5atD6YBOB7jR0rkZgqePXr0Xqjb3Hk+W0/qiynFA/jRTm5aQn3LKUUt6yX8Lyi/O2hMASpWIhN0ZgDHPgKZEU1O3yjiPGCEikRgeXZGyn+r3PmGOaHoM+TFZicUaK/DIk/Wf4ikJs4Ab+fgD8gDbxLNO9nGLabWBKv8I7vn72sRLlLVjvPg0v+v1ZhQdHaycgnoC1EyqYVFt3Fla+EIKSbu9gV0TPpgYhXWjHqfLK98n/tzy0zFzxHZZ6PrUMEt1Zg87IJcN9a+MEBfLzf/cNXNbsZm174aaT2LrRUpvw0O1vF0hCYn7szRV/NyNV/3ESpNEqrADykfl1SUqgAGg6mR7RlcBs0RustiPk2EiABqtsgfSHRZcPAgQTN/zoLFFfo0qxWMjRyKu1EqLKRtkqEv3v5/SvyRp3ot/vl8b+ENWK8ljCVLArIiI2q8PhS/Z9sQ/bnsQGA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR10MB1466.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(38100700002)(5660300002)(2616005)(7416002)(6512007)(2906002)(6506007)(6666004)(38350700002)(26005)(86362001)(52116002)(66946007)(83380400001)(66556008)(36756003)(66476007)(8676002)(4326008)(498600001)(1076003)(6486002)(8936002)(316002)(186003)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kPMviPcxXUBYr2V+ltLrt5fk58j3ldrVDr21KWVTIN1c0Z8Ck/vmkY7HW9I+?= =?us-ascii?Q?LKLtBA6L9wWz/s+pU3qHZ/SAk1+OHOxszCvjps0b9adWSm1rvx2G22BII2oy?= =?us-ascii?Q?yZ5/UARYhIWXwJWAblz7gq56hE473lC2Qb1pi2wbVfJfaPyCuocYuCfIO6+A?= =?us-ascii?Q?4HVGCd0lp3zRf7o9S2smXlmyBb85RAtZt/11Avoyky5MOT8j893qncqqZwly?= =?us-ascii?Q?nf7jBQwDHsQ1RGJCs9j8CqGKg+/6KYeg7AnB8ie2z596644U3nPNtDzJfFtU?= =?us-ascii?Q?1s4K0AqzmjttRm+WGrdtXoXiWxE9HDMh795qPFYF47jdwf4znNfBfHiWGpCF?= =?us-ascii?Q?+jHkB7SbY7yE7Mv0D8VlDXVrCGGXlt9au18wljQUpTwO8CPiRH4J2rkzDAQa?= =?us-ascii?Q?NWuQUNDPG5GJX7+AkCIUPBmZhUxg0QpISPdGkX3N2tNesaFpcvQibjit1E4u?= =?us-ascii?Q?LP1RtD3kEeYxgYAW1hOSgQLefNvLq+ZWR5In1SuCB5XWN2wcQtM7sgJ8uvie?= =?us-ascii?Q?S7wRQCClXSv2v8JgP6JvvrqZM/s5lC6raQoKgmTb2NKXQXjkVaQqNNFxKPdf?= =?us-ascii?Q?/8Hqu5I2hnX9IlfQZpGPa+j+w12baIll3xPuibWTYSMyjL3smeiPSjdUrkvR?= =?us-ascii?Q?WkVSf1hY+NCKmGedLZCO9X+7f6U1OA/aaUOcQXOCqrdBVkRsM4OLi+hrfAf+?= =?us-ascii?Q?lfAMw5xelP4HF98ZHb/F092BWNPNLo77N+x2af0rRVvOp4Xy5+lzZW3JXx5z?= =?us-ascii?Q?pRhF4LGCm0+ZJcaEcP597c7K1KA4DW+qNw8/KgCo6bV2loGecVZfQaeLYKcy?= =?us-ascii?Q?1Fjyr9P3kc7QMgd5DdvM7PcetoRe0wXe5mnLcQwonvvZ03wahEhG5BS+OcFU?= =?us-ascii?Q?9cPI/wdhqgl/wCGUcgIbbIy8MCaQFvsyaRW0mMYy2lMNEjzhWmocxKt90EZl?= =?us-ascii?Q?1Xr9EOmRJL7rFKOyx3Ces1qJoWaBmVVylFeVRLSsq0++R/buMGlM31cO0Cck?= =?us-ascii?Q?3qx6/d0jkxHvFHdxtR4VdJ3jk3j5cXktn0rpO2PF18IWLGf9KLpFwn6s9Gif?= =?us-ascii?Q?Gul7mfuN6iOmPnZgeQEzizPxt99HElwsD0McI2w3PlHHbH96CcBPlyHC8XKY?= =?us-ascii?Q?Os7xpx6bjYx1bwjqdgVOPnbZnQv3IwyU8hj/eE8wbpWVQylHaZCz/ne/Xuf+?= =?us-ascii?Q?iT4CyNYD7/emuas3RuJiGCJTKeS8dEMuDcd0yYofc8kfZhENaiosdenf4PPt?= =?us-ascii?Q?q69EusujS9pPPN1uMnftUUgXWnBARxnzxKZ8Ojos8V2o5H0PefryYwNai4Ez?= =?us-ascii?Q?n75TJc8NH8qv7bhWIIrVbq3i3NoA7F5MKSrKn0CqyQSRHqM/rywIO8OFviEi?= =?us-ascii?Q?YMRp7JvMFai5PXTn3T8In1lyr+SR080udkSOmSMlPXFzRl/7ES7TmfetPgpg?= =?us-ascii?Q?yJicTOHITeb0YhNWNc09rUDBxKb91ZeEqUWIWXPg/LBI4O+4pWhIjvoRtuwI?= =?us-ascii?Q?2TqnJZ+3w3fKabxC1YGi/wPDAi71iXmdZIkLMUn9I+5THWGNt58n8GyjNmo9?= =?us-ascii?Q?2Lq2Vdmk5P2usTLtU8cZOJugOAR3/QyYbS6V9F/etKsf8ix7KlVrvQX3aotn?= =?us-ascii?Q?73oQxX7bW5Gffz5wYYuwSjH0Ga3n/IjZMEj4SCZlcbAtnMsfrXAAv+7tYi4O?= =?us-ascii?Q?nQol72t03gxLXUt+GpOE+q2Ml6vXI1twTmp35fplOJS+Iq67AFxwbTiWuYOx?= =?us-ascii?Q?xVc2x0ISpx2cOmvQt0f+evS87F7IT4s=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9a0d4cf-aae2-4c91-fa8f-08da525a2ebe X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 01:14:11.2867 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 68jV+6ieihgm7eo5VgaveYJ06oR/PQNzXsdpA00CYeSlxsYwxnQBI7VJp91o5N3YXa4nKC775o/xbq29Y8k6MNip99SpZpALUWxx6PhI/po= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1905 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883 definitions=2022-06-19_12:2022-06-17,2022-06-19 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0 mlxscore=0 phishscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206200004 X-Proofpoint-GUID: cmKmpt8Y186bwgMnlii1zYLOE6x2EyOs X-Proofpoint-ORIG-GUID: cmKmpt8Y186bwgMnlii1zYLOE6x2EyOs Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This is just a prep patch. It moves the worker related fields to a new vhost_worker struct and moves the code around to create some helpers that will be used in the next patch. Signed-off-by: Mike Christie Reviewed-by: Stefan Hajnoczi Acked-by: Michael S. Tsirkin Reviewed-by: Christoph Hellwig --- drivers/vhost/vhost.c | 98 ++++++++++++++++++++++++++++--------------- drivers/vhost/vhost.h | 11 +++-- 2 files changed, 72 insertions(+), 37 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 40097826cff0..4e17ac40c08c 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -255,8 +255,8 @@ void vhost_work_queue(struct vhost_dev *dev, struct vho= st_work *work) * sure it was not in the list. * test_and_set_bit() implies a memory barrier. */ - llist_add(&work->node, &dev->work_list); - wake_up_process(dev->worker); + llist_add(&work->node, &dev->worker->work_list); + wake_up_process(dev->worker->task); } } EXPORT_SYMBOL_GPL(vhost_work_queue); @@ -264,7 +264,7 @@ EXPORT_SYMBOL_GPL(vhost_work_queue); /* A lockless hint for busy polling code to exit the loop */ bool vhost_has_work(struct vhost_dev *dev) { - return !llist_empty(&dev->work_list); + return dev->worker && !llist_empty(&dev->worker->work_list); } EXPORT_SYMBOL_GPL(vhost_has_work); =20 @@ -335,7 +335,8 @@ static void vhost_vq_reset(struct vhost_dev *dev, =20 static int vhost_worker(void *data) { - struct vhost_dev *dev =3D data; + struct vhost_worker *worker =3D data; + struct vhost_dev *dev =3D worker->dev; struct vhost_work *work, *work_next; struct llist_node *node; =20 @@ -350,7 +351,7 @@ static int vhost_worker(void *data) break; } =20 - node =3D llist_del_all(&dev->work_list); + node =3D llist_del_all(&worker->work_list); if (!node) schedule(); =20 @@ -360,7 +361,7 @@ static int vhost_worker(void *data) llist_for_each_entry_safe(work, work_next, node, node) { clear_bit(VHOST_WORK_QUEUED, &work->flags); __set_current_state(TASK_RUNNING); - kcov_remote_start_common(dev->kcov_handle); + kcov_remote_start_common(worker->kcov_handle); work->fn(work); kcov_remote_stop(); if (need_resched()) @@ -479,7 +480,6 @@ void vhost_dev_init(struct vhost_dev *dev, dev->byte_weight =3D byte_weight; dev->use_worker =3D use_worker; dev->msg_handler =3D msg_handler; - init_llist_head(&dev->work_list); init_waitqueue_head(&dev->wait); INIT_LIST_HEAD(&dev->read_list); INIT_LIST_HEAD(&dev->pending_list); @@ -571,10 +571,60 @@ static void vhost_detach_mm(struct vhost_dev *dev) dev->mm =3D NULL; } =20 +static void vhost_worker_free(struct vhost_dev *dev) +{ + struct vhost_worker *worker =3D dev->worker; + + if (!worker) + return; + + dev->worker =3D NULL; + WARN_ON(!llist_empty(&worker->work_list)); + kthread_stop(worker->task); + kfree(worker); +} + +static int vhost_worker_create(struct vhost_dev *dev) +{ + struct vhost_worker *worker; + struct task_struct *task; + int ret; + + worker =3D kzalloc(sizeof(*worker), GFP_KERNEL_ACCOUNT); + if (!worker) + return -ENOMEM; + + dev->worker =3D worker; + worker->dev =3D dev; + worker->kcov_handle =3D kcov_common_handle(); + init_llist_head(&worker->work_list); + + task =3D kthread_create(vhost_worker, worker, "vhost-%d", current->pid); + if (IS_ERR(task)) { + ret =3D PTR_ERR(task); + goto free_worker; + } + + worker->task =3D task; + wake_up_process(task); /* avoid contributing to loadavg */ + + ret =3D vhost_attach_cgroups(dev); + if (ret) + goto stop_worker; + + return 0; + +stop_worker: + kthread_stop(worker->task); +free_worker: + kfree(worker); + dev->worker =3D NULL; + return ret; +} + /* Caller should have device mutex */ long vhost_dev_set_owner(struct vhost_dev *dev) { - struct task_struct *worker; int err; =20 /* Is there an owner already? */ @@ -585,36 +635,21 @@ long vhost_dev_set_owner(struct vhost_dev *dev) =20 vhost_attach_mm(dev); =20 - dev->kcov_handle =3D kcov_common_handle(); if (dev->use_worker) { - worker =3D kthread_create(vhost_worker, dev, - "vhost-%d", current->pid); - if (IS_ERR(worker)) { - err =3D PTR_ERR(worker); - goto err_worker; - } - - dev->worker =3D worker; - wake_up_process(worker); /* avoid contributing to loadavg */ - - err =3D vhost_attach_cgroups(dev); + err =3D vhost_worker_create(dev); if (err) - goto err_cgroup; + goto err_worker; } =20 err =3D vhost_dev_alloc_iovecs(dev); if (err) - goto err_cgroup; + goto err_iovecs; =20 return 0; -err_cgroup: - if (dev->worker) { - kthread_stop(dev->worker); - dev->worker =3D NULL; - } +err_iovecs: + vhost_worker_free(dev); err_worker: vhost_detach_mm(dev); - dev->kcov_handle =3D 0; err_mm: return err; } @@ -704,12 +739,7 @@ void vhost_dev_cleanup(struct vhost_dev *dev) dev->iotlb =3D NULL; vhost_clear_msg(dev); wake_up_interruptible_poll(&dev->wait, EPOLLIN | EPOLLRDNORM); - WARN_ON(!llist_empty(&dev->work_list)); - if (dev->worker) { - kthread_stop(dev->worker); - dev->worker =3D NULL; - dev->kcov_handle =3D 0; - } + vhost_worker_free(dev); vhost_detach_mm(dev); } EXPORT_SYMBOL_GPL(vhost_dev_cleanup); diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h index d9109107af08..2f6beab93784 100644 --- a/drivers/vhost/vhost.h +++ b/drivers/vhost/vhost.h @@ -25,6 +25,13 @@ struct vhost_work { unsigned long flags; }; =20 +struct vhost_worker { + struct task_struct *task; + struct llist_head work_list; + struct vhost_dev *dev; + u64 kcov_handle; +}; + /* Poll a file (eventfd or socket) */ /* Note: there's nothing vhost specific about this structure. */ struct vhost_poll { @@ -147,8 +154,7 @@ struct vhost_dev { struct vhost_virtqueue **vqs; int nvqs; struct eventfd_ctx *log_ctx; - struct llist_head work_list; - struct task_struct *worker; + struct vhost_worker *worker; struct vhost_iotlb *umem; struct vhost_iotlb *iotlb; spinlock_t iotlb_lock; @@ -158,7 +164,6 @@ struct vhost_dev { int iov_limit; int weight; int byte_weight; - u64 kcov_handle; bool use_worker; int (*msg_handler)(struct vhost_dev *dev, u32 asid, struct vhost_iotlb_msg *msg); --=20 2.25.1 From nobody Mon Apr 27 01:52:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 488BFCCA47A for ; Mon, 20 Jun 2022 01:14:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232936AbiFTBOt (ORCPT ); Sun, 19 Jun 2022 21:14:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234637AbiFTBOg (ORCPT ); Sun, 19 Jun 2022 21:14:36 -0400 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 316F1AE56 for ; Sun, 19 Jun 2022 18:14:34 -0700 (PDT) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25JGMllR018105; Mon, 20 Jun 2022 01:14:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=1KRUDfUPo+LLJbbs1Hnq4JIM4YvRLAh2veNYL8Uax/Q=; b=PjVKjRz/LxpyoDNgtBOFgt26KiUcr9tK7DRbM3IkdQAcdPkRpEqorAO2BP21A9o4pvbK 0zba6uRGkKXaAJTjaKrjKWijeHbyapSxziBPbUZFN0jhs7r1n+14jpPv5ztQPIKmF/WG E7DhuzRadhPhX8bVNTEEpo+djjNyY4OcFegSvWHD7xf8weYSTYtH0urik5LggRhSE8Ku cld7jjmh1FJ7sjncq601/7i3gq4F6k4OAHU37TIDfXPimohfaIbtIblwRGiC9+C46bzo FmF01Rh1blragUJO5lB0e1brz/OfFjGrHiG7+J4zYs/ep/joJ5J4T+m+d6r/fUDLD0A4 vw== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3gs5g1t12j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Jun 2022 01:14:15 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 25K19qKu038388; Mon, 20 Jun 2022 01:14:14 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2040.outbound.protection.outlook.com [104.47.73.40]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3gtbu5tbfn-5 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Jun 2022 01:14:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VUC2rxflk9wlKY7lt60b1wWsSWBk7Hox9hVq+GS6VBRK9g5j4YEN/xwmw94s/MYHUwbXrq4FSB6Y6KVNqYtWKkxNjvk8Ysy4WKkYB+3Qpm5S1t+qgUqnqcfzTToqWgZ7+EeJ4l3hW156kgWZVr9S9bc3sixMu7sAvcJG2mxcclz9ECsJNnbaYrZePPHayWqKSePqEEKu96ZjoWJ+K9gTuO5M1cGgy5gLVk+h9V1y6ITMCVRCIEVdE56QhnTxYbeNMCxIG2umCOwIi0hzYErQAwlJrAYoe59x8ikgsn6z/r9ncTCG86BowvTJvLCfuMkcbS5wgokfCZn25zT5MuKqGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1KRUDfUPo+LLJbbs1Hnq4JIM4YvRLAh2veNYL8Uax/Q=; b=NQ5ACiQdkTqLW45F4POZ1wj2jYbbWCm4RnykfGbLldZQUBR1sPWir1/+cNOHzMNlPiKlmnq91lrbLXJRvvh76Cj6Jjz5D20BEZztXuL4GPVkhwOlENdcs9pKCZg9pXzf1S8UQut17MCuorLSKKmil/7U5GMGXRjqMV4tZl7Qp9L6WkwpYMwsv7q60ZN0/n3ca3g3mlpouNmmhroxtYEZIHYu5gs6kH4ze03kB++y3O9dE5ldXLcaLewD0dLZWmuR51hGxaT4jjiSzOYoF2+Dy/4ICQMlpMBfc1+vv+HQl6bLcQxtdj5DcXstknN5OX2t8GbVcCT993fL4MHrl/SKjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1KRUDfUPo+LLJbbs1Hnq4JIM4YvRLAh2veNYL8Uax/Q=; b=cJ7a8L6sOf8heeptLHVIvvyViEnCnnooyTmizAJjpnaOCxx5TXJvZE06EAhE/TQ4q0RPwpY8VZJztRzFVE3HnOaSf3tpd1ip0TWy2mLVwxOXzZ1WiM6VNRUaiER7QsE7Aa5jZO8MTyvqsHVQRZ88PYg7W2u3nL9RK/Z+arNmns0= Received: from DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) by BN6PR10MB1905.namprd10.prod.outlook.com (2603:10b6:404:ff::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Mon, 20 Jun 2022 01:14:12 +0000 Received: from DM5PR10MB1466.namprd10.prod.outlook.com ([fe80::f81d:b8ef:c5a4:9c9b]) by DM5PR10MB1466.namprd10.prod.outlook.com ([fe80::f81d:b8ef:c5a4:9c9b%3]) with mapi id 15.20.5353.018; Mon, 20 Jun 2022 01:14:12 +0000 From: Mike Christie To: hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com, mst@redhat.com, sgarzare@redhat.com, virtualization@lists.linux-foundation.org, brauner@kernel.org, ebiederm@xmission.com, linux-kernel@vger.kernel.org Cc: Mike Christie Subject: [PATCH v10 8/8] vhost: use vhost_tasks for worker threads Date: Sun, 19 Jun 2022 20:13:57 -0500 Message-Id: <20220620011357.10646-9-michael.christie@oracle.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220620011357.10646-1-michael.christie@oracle.com> References: <20220620011357.10646-1-michael.christie@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR13CA0014.namprd13.prod.outlook.com (2603:10b6:5:bc::27) To DM5PR10MB1466.namprd10.prod.outlook.com (2603:10b6:3:b::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 942dce6c-067e-4349-b6ed-08da525a2f3f X-MS-TrafficTypeDiagnostic: BN6PR10MB1905:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TMw/0BpiFH76eE+p3FhWaSvHf+jAcj8H954vaXVX3XOMjvPzgTn0yBQDnrPe4st8VOAqxepHzTHZNLEQ0/+2lo6WgXsRyPoJE9jPtwdRzNcyLxVCS2SdoPHUbRMkv2eQ+Xg2MxyxtKzPlKvpn0JmoaIDrFhBvasMKF3dSe+dHPOwNl9J7AweELaPiRSJ+eqgIISzd5pJAeu3f/sWp/ewufz6brm4PuSTXhJZGNZaIxfSRx6Q0D1Df5aelUe8ZFphQNdLcOjTXtRvsE+0hHNgEaAALEyC2PLnhCFmt0omCKqNTtKWYYtyGAUhWwweLZl1DJLonaKlcoBRJY51XbVg9DfKMdmx8Xo72PANPnQm6teUo67Ab4ypj5ixjxS3wzmMwXSbPYdWvGHlTqKOYYDRvnYXr+nEA3fN7ABv12kkCKtQTl16QUTxiqa4sx7VbJn98JSpc9wl16uuLZpJErxoqBMKrziN+6ajQdz7TNZUACJlUuWJ/f/P/h0uVM0LtEtTzOh3jXnPlA8Z3HraZYBD/jlPAH9ehdu15Be5BeqVcHE/5ish4MbuelmnlgCQCFE+WzLAr0fBuiaISpDGVzkWExcDF0ICp2R5xucA3AWdutHtmO8L6UxXYhp/WN8Ob0g8/6VKCx3pZbx0Pp9L+1k8YqTbziXVYoJbGaMEsA1Jz/MFqvDY8xPjHI02BHu60YnVRcNI4bwINEn8kRw5S++cbg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR10MB1466.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(107886003)(38100700002)(5660300002)(2616005)(6512007)(2906002)(6506007)(6666004)(38350700002)(26005)(86362001)(52116002)(66946007)(83380400001)(66556008)(36756003)(66476007)(8676002)(4326008)(498600001)(1076003)(6486002)(8936002)(316002)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?J+3u+BZ1H/+i7mJPbhRjWbwlobLeySeuG72J1kn0eD282qpLtLCk3hMnKlNN?= =?us-ascii?Q?uZOAGY3oB0SUEGICWvj2151ZdFppfKJbxbh7AnKaFFCQ8ssZk9YhU7HSbA1V?= =?us-ascii?Q?287Wa37VMqTrnne2zpYpoBZ4skCvs1DVH275AUrUSAIIUWT7QkrAZsprvxxG?= =?us-ascii?Q?E06f9gIfb5RMjb9G/1R3qAd9G0zFmvHVm6jCpYdLylBYjjaeSn6Ir5oOiHLx?= =?us-ascii?Q?vDnWoIHQloFC0lLaAuegRCfi359S3Jk6g0yUFkoOobdLZGPFauFqlMegPbME?= =?us-ascii?Q?AYscIyFUX4vWDaT2Qmb4qYyegzZf4PD8Om9kxzFmwhNhraaoCkf0uD9spfqq?= =?us-ascii?Q?C6Wdm3An9fEyNIBNkBpaCSQ/e+kzdBX21OcTIck6X1ysLNenIWCvmpu0Wg3D?= =?us-ascii?Q?IX2FTYnnhjsO6mxz2nUclUwro4Mc7vJXlWVVFhJNFPgKA3FLbQh+zZSfZqtE?= =?us-ascii?Q?NYo2djOpG/Cjub/GTrME+OIr/xm0kJMqFix4nR8CMSzStVcqUxDNDoxRbd8h?= =?us-ascii?Q?c8Q+KU2Ffq1zsakCZ8mcDHzUKOX6KA4Mdh63ideY9fe9bZQGzG+VNzRoury1?= =?us-ascii?Q?mytZsSqgZktZBZ9l2v+S45lTsSv9ZF6tZfYihhEwiHEE2WP+m3kMuFem93rV?= =?us-ascii?Q?EPIkfEOTNPi2YLkTTY4bIoqIyfOZENXGAj1z72rIrQTEYymP9EtDUS0CaMSu?= =?us-ascii?Q?bgncQD/IKuDV5+0DJsxCgYLs4YRhSOgKcB8b7Fv8tsw1ganIvbAEn77MT12j?= =?us-ascii?Q?tpshJyav1pNfF4SA55gAET6dUeXXzvFF0xVzzczH+esgrKY7QebnZGOqjvbw?= =?us-ascii?Q?e3bPElAtsF3Q+DvSh/6+XuDg6ziEW1mpPoH1kXkQXv2pxO/iprBNxrBbBqFo?= =?us-ascii?Q?t1poWa0Tdy1hpFVFHV0EbsQP83m/03bs2cIIgX5LeFW9NPfQ8E4RZUFbgSc0?= =?us-ascii?Q?B5Vamg1xbUhl+ODa1a+AGb1yODWjYhGXNvanPoNpwD/MDjOzdYmcNG9bUyRB?= =?us-ascii?Q?iaDPeLpuLaLsNj8WlsQ1cT8LjEl5QGTF5IJ6KriYbEHU5jrEG8DgtK2XLbe7?= =?us-ascii?Q?ATqD7yWrmvv0htBG8JzaN2hslpZB0zE1RBF18jBXQdcLfcKtDqkwPgEiYY4U?= =?us-ascii?Q?Vb21TrK67dh8Aip4dRv+gkjVM5xkCn+McQ08h9T3qdtNwSsSOhz6DOi1IxfF?= =?us-ascii?Q?J8qu1pjxx8PhHukHKCoD8orWeAmbrzrrNHw3iyDIGBvHNzBppbgg+UFsJrgE?= =?us-ascii?Q?0Y23HmM7PSUB2XXpsns83LeuvVEVEZkvV5UdR4TthsDcAi0+POI0+unKgMbv?= =?us-ascii?Q?p5TRtK6yjc/28hmyZWIc28LS2I97zeMdrk0MmGqnxEkWf+n1jAhEatZD6/2u?= =?us-ascii?Q?ZoEEN8opqX1hg6DruWuTTss/QqcPhoEkKtRWAe+9W8Vz8c/U6dlF15nhk/7i?= =?us-ascii?Q?hvsaTB+1D09cTtMYliUdNe8hvmdPHUo8QVXvq3vzPqT2xLA+Y8RMKGduPUjw?= =?us-ascii?Q?4AlhR9ASWAOdtvU8Xv2+/aQsfMGUKrGwmOVD+3jkjaWLkjF2P666WMRN0xws?= =?us-ascii?Q?fzM9iIA+DHRB27Bd1jBENzuiumJUz20oi7u+sjWOa5vP1QfXKoojadQPhgL0?= =?us-ascii?Q?/BRDoWt0QZemoTf5cdZVL0k7xnr2A9JWcZNpU/sVouibSXM2nfB792BwOr/j?= =?us-ascii?Q?exSDSCVrAtU6hVvJGnDexYVXIhiyeBtlFAa0s7vKeXIoAiAjCfGlWoDpuMjZ?= =?us-ascii?Q?ej48sLpf+jXpvtjV1iLpx2GXOSU0NyA=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 942dce6c-067e-4349-b6ed-08da525a2f3f X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 01:14:12.1147 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w3NrBvaM0Hs3RWwDnO8Cn+bdl6YVRNiSsz4YZykMyKCAXtPcI/ZIDrLDdK4dBLswLmFaYlyVvnVz8NAHEBXLeqb0DuP/H1mM7NLh6PevM14= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1905 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883 definitions=2022-06-19_12:2022-06-17,2022-06-19 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0 mlxscore=0 phishscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206200004 X-Proofpoint-GUID: 4IZbkA0yqHA1OUFwCJBoutuj_Q5TbWH_ X-Proofpoint-ORIG-GUID: 4IZbkA0yqHA1OUFwCJBoutuj_Q5TbWH_ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" For vhost workers we use the kthread API which inherit's its values from and checks against the kthreadd thread. This results in the wrong RLIMITs being checked, so while tools like libvirt try to control the number of threads based on the nproc rlimit setting we can end up creating more threads than the user wanted. This patch has us use the vhost_task helpers which will inherit its values/checks from the thread that owns the device similar to if we did a clone in userspace. The vhost threads will now be counted in the nproc rlimits. And we get features like cgroups and mm sharing automatically, so we can remove those calls. Signed-off-by: Mike Christie Acked-by: Michael S. Tsirkin --- drivers/vhost/vhost.c | 58 ++++++++----------------------------------- drivers/vhost/vhost.h | 4 +-- 2 files changed, 13 insertions(+), 49 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 4e17ac40c08c..c6aa0a45357d 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -22,11 +22,11 @@ #include #include #include -#include #include #include #include #include +#include #include #include #include @@ -256,7 +256,7 @@ void vhost_work_queue(struct vhost_dev *dev, struct vho= st_work *work) * test_and_set_bit() implies a memory barrier. */ llist_add(&work->node, &dev->worker->work_list); - wake_up_process(dev->worker->task); + wake_up_process(dev->worker->vtsk->task); } } EXPORT_SYMBOL_GPL(vhost_work_queue); @@ -336,17 +336,14 @@ static void vhost_vq_reset(struct vhost_dev *dev, static int vhost_worker(void *data) { struct vhost_worker *worker =3D data; - struct vhost_dev *dev =3D worker->dev; struct vhost_work *work, *work_next; struct llist_node *node; =20 - kthread_use_mm(dev->mm); - for (;;) { /* mb paired w/ kthread_stop */ set_current_state(TASK_INTERRUPTIBLE); =20 - if (kthread_should_stop()) { + if (vhost_task_should_stop(worker->vtsk)) { __set_current_state(TASK_RUNNING); break; } @@ -368,7 +365,7 @@ static int vhost_worker(void *data) schedule(); } } - kthread_unuse_mm(dev->mm); + return 0; } =20 @@ -509,31 +506,6 @@ long vhost_dev_check_owner(struct vhost_dev *dev) } EXPORT_SYMBOL_GPL(vhost_dev_check_owner); =20 -struct vhost_attach_cgroups_struct { - struct vhost_work work; - struct task_struct *owner; - int ret; -}; - -static void vhost_attach_cgroups_work(struct vhost_work *work) -{ - struct vhost_attach_cgroups_struct *s; - - s =3D container_of(work, struct vhost_attach_cgroups_struct, work); - s->ret =3D cgroup_attach_task_all(s->owner, current); -} - -static int vhost_attach_cgroups(struct vhost_dev *dev) -{ - struct vhost_attach_cgroups_struct attach; - - attach.owner =3D current; - vhost_work_init(&attach.work, vhost_attach_cgroups_work); - vhost_work_queue(dev, &attach.work); - vhost_dev_flush(dev); - return attach.ret; -} - /* Caller should have device mutex */ bool vhost_dev_has_owner(struct vhost_dev *dev) { @@ -580,14 +552,14 @@ static void vhost_worker_free(struct vhost_dev *dev) =20 dev->worker =3D NULL; WARN_ON(!llist_empty(&worker->work_list)); - kthread_stop(worker->task); + vhost_task_stop(worker->vtsk); kfree(worker); } =20 static int vhost_worker_create(struct vhost_dev *dev) { struct vhost_worker *worker; - struct task_struct *task; + struct vhost_task *vtsk; int ret; =20 worker =3D kzalloc(sizeof(*worker), GFP_KERNEL_ACCOUNT); @@ -595,27 +567,19 @@ static int vhost_worker_create(struct vhost_dev *dev) return -ENOMEM; =20 dev->worker =3D worker; - worker->dev =3D dev; worker->kcov_handle =3D kcov_common_handle(); init_llist_head(&worker->work_list); =20 - task =3D kthread_create(vhost_worker, worker, "vhost-%d", current->pid); - if (IS_ERR(task)) { - ret =3D PTR_ERR(task); + vtsk =3D vhost_task_create(vhost_worker, worker, NUMA_NO_NODE); + if (!vtsk) { + ret =3D -ENOMEM; goto free_worker; } =20 - worker->task =3D task; - wake_up_process(task); /* avoid contributing to loadavg */ - - ret =3D vhost_attach_cgroups(dev); - if (ret) - goto stop_worker; - + worker->vtsk =3D vtsk; + vhost_task_start(vtsk, "vhost-%d", current->pid); return 0; =20 -stop_worker: - kthread_stop(worker->task); free_worker: kfree(worker); dev->worker =3D NULL; diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h index 2f6beab93784..3af59c65025e 100644 --- a/drivers/vhost/vhost.h +++ b/drivers/vhost/vhost.h @@ -16,6 +16,7 @@ #include =20 struct vhost_work; +struct vhost_task; typedef void (*vhost_work_fn_t)(struct vhost_work *work); =20 #define VHOST_WORK_QUEUED 1 @@ -26,9 +27,8 @@ struct vhost_work { }; =20 struct vhost_worker { - struct task_struct *task; + struct vhost_task *vtsk; struct llist_head work_list; - struct vhost_dev *dev; u64 kcov_handle; }; =20 --=20 2.25.1