From nobody Mon Apr 27 04:36:10 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF0C9C433EF for ; Fri, 17 Jun 2022 08:05:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380782AbiFQIFl (ORCPT ); Fri, 17 Jun 2022 04:05:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380252AbiFQIFk (ORCPT ); Fri, 17 Jun 2022 04:05:40 -0400 Received: from m15113.mail.126.com (m15113.mail.126.com [220.181.15.113]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2954647052 for ; Fri, 17 Jun 2022 01:05:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=6hHSq JJtvj2gXC96rqDa7qDMN11c7zQ1mP+RJraEK9o=; b=Z6soNT8ycgZZEqp9j5xAu 3qSelUpbBFUjwYHL8Lq50VOFX8zGklRg5jIQTVV7dlmMy6odEz9+nJcIWzbwheCa 6gvoshjgX/XbLM2RdxBbjPNnDrcOLaZrq8UfoeUaGDgTRIzOEwLYb0cvSq8xgEWy 8npL4v72GUVzGBMp3nrQJ0= Received: from localhost.localdomain (unknown [124.16.139.61]) by smtp3 (Coremail) with SMTP id DcmowACXMJKYNaxic+FcDg--.36620S2; Fri, 17 Jun 2022 16:04:41 +0800 (CST) From: Liang He To: mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, nick.child@ibm.com, npiggin@gmail.com, christophe.leroy@csgroup.eu Cc: windhl@126.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] powerpc: powernv: Fix refcount leak in opal Date: Fri, 17 Jun 2022 16:04:39 +0800 Message-Id: <20220617080439.4010786-1-windhl@126.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: DcmowACXMJKYNaxic+FcDg--.36620S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7Xw43XFW7Wry8ZF1ruw48WFg_yoW3Zrg_tw n7XayDur4rJr4vy3yDZw4fGFnrC3sxWF4DXr12q3W2kw13ta9xG39rtrW7G3WUurWjyrW3 GFWDJrWDZaySvjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRM3kuJUUUUU== X-Originating-IP: [124.16.139.61] X-CM-SenderInfo: hzlqvxbo6rjloofrz/1tbi3BkjF1pEDvTRHwAAsb Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In opal_imc_init_dev(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: Liang He ---=20 arch/powerpc/platforms/powernv/opal.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms= /powernv/opal.c index 55a8fbfdb5b2..d86cc48a10aa 100644 --- a/arch/powerpc/platforms/powernv/opal.c +++ b/arch/powerpc/platforms/powernv/opal.c @@ -952,6 +952,7 @@ static void __init opal_imc_init_dev(void) np =3D of_find_compatible_node(NULL, NULL, IMC_DTB_COMPAT); if (np) of_platform_device_create(np, NULL, NULL); + of_node_put(np); } =20 static int kopald(void *unused) --=20 2.25.1