From nobody Mon Apr 27 06:26:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0E6BC43334 for ; Thu, 16 Jun 2022 04:50:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358694AbiFPEuT (ORCPT ); Thu, 16 Jun 2022 00:50:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358740AbiFPEtt (ORCPT ); Thu, 16 Jun 2022 00:49:49 -0400 Received: from mail-m963.mail.126.com (mail-m963.mail.126.com [123.126.96.3]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 501F85A0A2 for ; Wed, 15 Jun 2022 21:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=1pCJ5 nuqf9rZ6vZLpt9IaeTJgUV4nj1fGxyJJfDr68s=; b=QzCApHmgqspl/NhthqSmc xNtqRp6k0Mnw0o3UnafJxG4PEEEoeoCC04wbN5QhN2LdXgQLj3NiGudk89a0cm+P mJ6j/3PrWm/k+1r2nvb+FqIp3VpTS9lpgn8nWkDeIr5yyq/lnFed4XdCnQ93O0QS Pm8Qzo2m8YDhuIRmp0oyIE= Received: from localhost.localdomain (unknown [124.16.139.61]) by smtp8 (Coremail) with SMTP id NORpCgBXWJVMtqpiiJrqFg--.28738S2; Thu, 16 Jun 2022 12:49:18 +0800 (CST) From: Liang He To: palmer@dabbelt.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu Cc: windhl@126.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kernel test robot Subject: [PATCH v2] soc: sifive: (sifive_l2_cache) Add missing of_node_put() Date: Thu, 16 Jun 2022 12:49:15 +0800 Message-Id: <20220616044915.3978097-1-windhl@126.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: NORpCgBXWJVMtqpiiJrqFg--.28738S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7ur4DAr47AryxJF1fCFW5Awb_yoW8ZFW3pr WxXryavry8Gwn7Wr9xJ3Z8ZFyF9wn293y3KFyI9wn8ur17GrWqvr4SyFyUZF9xCrW09rsx tr4jkF1DC3W8uFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0p_ucMdUUUUU= X-Originating-IP: [124.16.139.61] X-CM-SenderInfo: hzlqvxbo6rjloofrz/xtbBGgYiF1-HZTt0IAAAs7 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In sifive_l2_init(), of_find_matching_node() will return a node pointer with refcount incremented. We should use of_node_put() in each fail path or when it is not used anymore. Reported-by: kernel test robot Signed-off-by: Liang He --- changelog:=20 v2: (1) fix bug, introduced by v1 patch, reporeted by kernel-test-robot v1: fix missing bug ps: Because of many local commit, when using --base for format-patch, there are too many prerequest-patch-id. I wonder if it will lead to ot= her=20 problems. So now, I send this commit still without --base. drivers/soc/sifive/sifive_l2_cache.c | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/soc/sifive/sifive_l2_cache.c b/drivers/soc/sifive/sifi= ve_l2_cache.c index 59640a1d0b28..e0e3d8b64c25 100644 --- a/drivers/soc/sifive/sifive_l2_cache.c +++ b/drivers/soc/sifive/sifive_l2_cache.c @@ -202,17 +202,22 @@ static int __init sifive_l2_init(void) if (!np) return -ENODEV; =20 - if (of_address_to_resource(np, 0, &res)) - return -ENODEV; + if (of_address_to_resource(np, 0, &res)) { + ret =3D -ENODEV; + goto out_put; + } =20 l2_base =3D ioremap(res.start, resource_size(&res)); - if (!l2_base) - return -ENOMEM; + if (!l2_base) { + ret =3D -ENOMEM; + goto out_put; + } =20 intr_num =3D of_property_count_u32_elems(np, "interrupts"); if (!intr_num) { pr_err("L2CACHE: no interrupts property\n"); - return -ENODEV; + ret =3D -ENODEV; + goto out_put; } =20 for (i =3D 0; i < intr_num; i++) { @@ -220,7 +225,8 @@ static int __init sifive_l2_init(void) rc =3D request_irq(g_irq[i], l2_int_handler, 0, "l2_ecc", NULL); if (rc) { pr_err("L2CACHE: Could not request IRQ %d\n", g_irq[i]); - return rc; + ret =3D rc; + goto out_put; } } =20 @@ -232,6 +238,10 @@ static int __init sifive_l2_init(void) #ifdef CONFIG_DEBUG_FS setup_sifive_debug(); #endif - return 0; + ret =3D 0; + +out_put: + of_node_put(np); + return ret; } device_initcall(sifive_l2_init); --=20 2.25.1