From nobody Mon Apr 27 06:25:31 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62A8AC43334 for ; Thu, 16 Jun 2022 04:15:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358585AbiFPEP4 (ORCPT ); Thu, 16 Jun 2022 00:15:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350334AbiFPEPy (ORCPT ); Thu, 16 Jun 2022 00:15:54 -0400 Received: from m15112.mail.126.com (m15112.mail.126.com [220.181.15.112]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 41A92580DA for ; Wed, 15 Jun 2022 21:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=WJip1 vdgwZXINHeE4TBvMkdfJp3JSJgbKQrJ7sW+WsI=; b=FSQQC3GR7nh2uSAXSLmC8 GVUawLYN0Ki25I1+Ph9ghmMhgy6jqlDyUmUNdNYR7OmsXFec7iQSaN3mPA+BDUS0 S23f5t5odAVfjmTJEgb9la5dHz1FIIftebNVA6y15VqkUdP/IMreOCbZRBET8SBd 6RpAqxE67pFo/hkEF8DLV4= Received: from localhost.localdomain (unknown [124.16.139.61]) by smtp2 (Coremail) with SMTP id DMmowABHtABnrqpiWINpDQ--.64829S2; Thu, 16 Jun 2022 12:15:36 +0800 (CST) From: Liang He To: linus.walleij@linaro.org, linux@armlinux.org.uk Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, windhl@126.com Subject: [PATCH v2] mach-ux500: (pm_domain) Add missing of_node_put() Date: Thu, 16 Jun 2022 12:15:34 +0800 Message-Id: <20220616041534.3977606-1-windhl@126.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: DMmowABHtABnrqpiWINpDQ--.64829S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7JFyUCr15GrW3ZryDJF17trb_yoWkCFbEvr WxWanxGa18t3WkWrs7ur13Wrn29ws7Grn2v34Fvw17tr18uF1rCFsavr4Sywnrury2vrW7 JF9rCFyaywnF9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7sRtWrXJUUUUU== X-Originating-IP: [124.16.139.61] X-CM-SenderInfo: hzlqvxbo6rjloofrz/1tbi7QgiF1pEANUMfQAAsq Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In ux500_pm_domains_init(), of_find_matching_node() will return a node pointer with refcount incremented. We should use of_node_put() in fail path or when it is not used anymore. Signed-off-by: Liang He --- changelog: v2: use real name for Sob v1: fix missing bug arch/arm/mach-ux500/pm_domains.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-ux500/pm_domains.c b/arch/arm/mach-ux500/pm_doma= ins.c index 427b9ac4af6c..81926b197e51 100644 --- a/arch/arm/mach-ux500/pm_domains.c +++ b/arch/arm/mach-ux500/pm_domains.c @@ -65,8 +65,10 @@ int __init ux500_pm_domains_init(void) return -ENODEV; =20 genpd_data =3D kzalloc(sizeof(*genpd_data), GFP_KERNEL); - if (!genpd_data) + if (!genpd_data) { + of_node_put(np); return -ENOMEM; + } =20 genpd_data->domains =3D ux500_pm_domains; genpd_data->num_domains =3D ARRAY_SIZE(ux500_pm_domains); @@ -75,5 +77,6 @@ int __init ux500_pm_domains_init(void) pm_genpd_init(ux500_pm_domains[i], NULL, false); =20 of_genpd_add_provider_onecell(np, genpd_data); + of_node_put(np); return 0; } --=20 2.25.1