From nobody Wed May 13 18:24:12 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3465C433EF for ; Wed, 15 Jun 2022 22:28:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350245AbiFOW2B (ORCPT ); Wed, 15 Jun 2022 18:28:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242770AbiFOW16 (ORCPT ); Wed, 15 Jun 2022 18:27:58 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 219F342A2C for ; Wed, 15 Jun 2022 15:27:53 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id k7so2220968plg.7 for ; Wed, 15 Jun 2022 15:27:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SWw7C4svPCcZdVbjnQq6e0MxP579SDS3HW9i9NBQQgI=; b=g1MwDX94oK5dCvJVt4n9Q7+WIYHOrbEJ3c4lpr5JN1O+aRMazkZzEDEk5Ph5dNMUEb rITtsRlHOWQazdFWh3a44aS/gdIM17J90Sr+Owg0SWYFRymThQgBPYLfTyUX9tA4FpK0 MxqAWqqOjYze9ZllV6s3P4s2N7BgJRdfokqM0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SWw7C4svPCcZdVbjnQq6e0MxP579SDS3HW9i9NBQQgI=; b=d1acoyQrhDndGIzIk8opVv9KVd++tVXeJHn6Lq8zqcLLau6G+DONiZxr123xCjgpZ3 msaYtIXLdFoqPXtbWaGfUItiwSZF+DNbO5qUAlYeYhxB2AaAsR/TXwq1Nxwfs/8liJKM KwpdB6CeYR2ZHRl8Nj9Iu1kdH/Vch0gLkxPNFNRfuCjkvP+5HBBn0hKvl5JaueaLE6pC Xz8XadqeKKDk65Jxlu74xdJsnUfm7rjPNYDu25xYLC+++SMSrTt6n48neZoEcRSuMore 7msWhb1X9HmqQUKAH99YpBLKHT1WpbVuB+CzIZhUBLmLHALw6/ck/uifGfG/pRLOVXZG YphQ== X-Gm-Message-State: AJIora9+itYNxpZlk4IENwAhE3eLON0Q4uEu4HiI4+vp4xUM1eUhEAQL eQkPhXfrYpXaASz6sllislTJhA== X-Google-Smtp-Source: AGRyM1vc5NUeJeAtQh0U1IylvikvZ87mlFgEYKxVhW0CpA1ax0o5L40V3snxgPcc4vGHBldaOaTZtA== X-Received: by 2002:a17:90b:3b4c:b0:1e8:5e4d:ed83 with SMTP id ot12-20020a17090b3b4c00b001e85e4ded83mr12595158pjb.19.1655332072591; Wed, 15 Jun 2022 15:27:52 -0700 (PDT) Received: from localhost ([2620:15c:202:201:342:e7bd:5391:5d5b]) by smtp.gmail.com with UTF8SMTPSA id p2-20020a62b802000000b00522af870b5dsm147789pfe.56.2022.06.15.15.27.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jun 2022 15:27:51 -0700 (PDT) From: Brian Norris To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot Cc: Ben Segall , linux-kernel@vger.kernel.org, Dietmar Eggemann , Daniel Bristot de Oliveira , Mel Gorman , Valentin Schneider , Steven Rostedt , Brian Norris Subject: [PATCH] sched: Drop outdated compile-optimization comment Date: Wed, 15 Jun 2022 15:27:45 -0700 Message-Id: <20220615222745.3371892-1-briannorris@chromium.org> X-Mailer: git-send-email 2.36.1.476.g0c4daa206d-goog MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Looks like this exists from way back in 2011 (commit 095c0aa83e52 ("sched: adjust scheduler cpu power for stolen time")), when there was a little more aggressive use of #if around these variables. That #if is gone, and the comment just confuses the reader now. (For one, we don't call sched_rt_avg_update() directly any more either.) Signed-off-by: Brian Norris --- kernel/sched/core.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index bfa7452ca92e..6dbe52d90bef 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -679,10 +679,6 @@ struct rq *task_rq_lock(struct task_struct *p, struct = rq_flags *rf) =20 static void update_rq_clock_task(struct rq *rq, s64 delta) { -/* - * In theory, the compile should just see 0 here, and optimize out the call - * to sched_rt_avg_update. But I don't trust it... - */ s64 __maybe_unused steal =3D 0, irq_delta =3D 0; =20 #ifdef CONFIG_IRQ_TIME_ACCOUNTING --=20 2.36.1.476.g0c4daa206d-goog