From nobody Wed May 13 18:17:46 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87700C433EF for ; Wed, 15 Jun 2022 22:25:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348103AbiFOWZP (ORCPT ); Wed, 15 Jun 2022 18:25:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347056AbiFOWZM (ORCPT ); Wed, 15 Jun 2022 18:25:12 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 305AD313A1 for ; Wed, 15 Jun 2022 15:25:11 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id y19so25908254ejq.6 for ; Wed, 15 Jun 2022 15:25:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=OPpdUjGRZZkJcBOgKvfJS/uuetRCNbFJlRDAPw4R+Yk=; b=kSsI9SMqHAQ1CDKJbcb3BpS5M8YGxijeJP/J5mMfyxoebkxevCW5/dqT+Vbq7+QhSC Ts2SFYywtP0SqCV4d12ODyi44me1JaplsF/6eTMNzuJ1jasothkrun2lnpxYkARUf35w YiP9vxT2AObIEM5y7KD12/+ef+ROn+gapoS21WqKTPEExvUKtCklqNu8dpHX8ONTdnum sMzzjgEvrXOOR/CsqfgnQ6wgBjiOHHFlZywo0Rlk/0iWhwmMzrLKelefffBEmnA+IXoA kqYODG0IcP9tFxeEFXf3BAOFuoaB96wax/oMv58PvVdn1AxDIEPKB4AyH8wnEDPZszTu HZBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=OPpdUjGRZZkJcBOgKvfJS/uuetRCNbFJlRDAPw4R+Yk=; b=uvbL+KnoH9PEkDsNCN5FQ4pqPPe2wuDNSdj+SX+CdW5nRtEV548zjnMPuKJnrVp6Dv t1vGRfD6HFllMBq63IcN1utDpVuJJZP86jKbccUR8H+MVPQjMiPYP5M9J0dTmI+QPa6X pvEPj7ghmkvXDkgZygeyEfhHrGGq8a1Ad7Op7/7t0sHaUUKYWL59VDk/In9Jt1yRGTqH QadgBe9W0dsS8k1wDqpCdgOFnH6gbjwIzOhDSG4pdSKYnJ5YijLkug3Za2rd938kkVl3 et2PUDyJYGEeVcm3pBWh57su7PbyvbP13nqDJbiapxd9QT3x0r23sEFc+CoryxSX59Ra HN2A== X-Gm-Message-State: AJIora+AKLsiFuCjIU9tCRox2A4YeeqZBX+YXQwE/w3yWfgta+VQZHSm DAcXy/6qbUN0dF334nRbVz8= X-Google-Smtp-Source: AGRyM1vI/D+O4LZ4ySsC2+t6KUGm2z97f1pkIxRNL4gT7CNUTTTXahnM/pWVAC43Oc7OnBhS3MbFNA== X-Received: by 2002:a17:906:73d4:b0:715:701c:ae96 with SMTP id n20-20020a17090673d400b00715701cae96mr1829346ejl.50.1655331909687; Wed, 15 Jun 2022 15:25:09 -0700 (PDT) Received: from debian.home (90-180-208-18.rcn.o2.cz. [90.180.208.18]) by smtp.gmail.com with ESMTPSA id y3-20020a056402358300b0042dc25fdf5bsm350427edc.29.2022.06.15.15.25.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jun 2022 15:25:09 -0700 (PDT) From: Jiri Vanek To: Andrzej Hajda , Neil Armstrong , Robert Foss Cc: Vinay Simha B N , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jiri Vanek Subject: [PATCH 1/2] drm/bridge/tc358775: Return before displaying inappropriate error message Date: Thu, 16 Jun 2022 00:22:20 +0200 Message-Id: <20220615222221.1501-2-jirivanek1@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220615222221.1501-1-jirivanek1@gmail.com> References: <20220615222221.1501-1-jirivanek1@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Function for reading from i2c device register displays error message even if reading ends correctly. Add return to avoid falling through into the fail label. Signed-off-by: Jiri Vanek --- drivers/gpu/drm/bridge/tc358775.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc3= 58775.c index 62a7ef352daa..cd2721ab02a9 100644 --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -339,6 +339,7 @@ static void d2l_read(struct i2c_client *i2c, u16 addr, = u32 *val) goto fail; =20 pr_debug("d2l: I2C : addr:%04x value:%08x\n", addr, *val); + return; =20 fail: dev_err(&i2c->dev, "Error %d reading from subaddress 0x%x\n", --=20 2.30.2 From nobody Wed May 13 18:17:46 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D21EEC43334 for ; Wed, 15 Jun 2022 22:25:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350137AbiFOWZ2 (ORCPT ); Wed, 15 Jun 2022 18:25:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348838AbiFOWZQ (ORCPT ); Wed, 15 Jun 2022 18:25:16 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 062142FFF2 for ; Wed, 15 Jun 2022 15:25:15 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id u12so25870722eja.8 for ; Wed, 15 Jun 2022 15:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=EqzQW4bvuiA6pvJtGB4rjgOdvlv8E2OoMiyxcMbYrTc=; b=JSDW99nkzGyW3xICFnKaivNYgZ++b2aFROAcUyNdGBKm2s/+IJcAqkaFBg0XmZ2/at edM8wEefSZDksc/lyQB8aMS2rfc9PHBogmCkD0C28dfFHNWeHdX2doEMJ2WflhmFU6T5 blyVH1ZWFdRN/Ja1usyOpD77t4Gzm8VRRbVYxcznxBulPSb2Rg4XrbBthfBXfH3v6Wf5 4+gtdlhnHVpbJJ6lTB5wI7oyMLMavx+gBQ0uW6j/E6LKOih2kqRk1EiTCGWrocgUDsTJ pe8/Vzs97c3I+qE2ezj9xETPih6I6gJesyK/m3sf7ZybpEZiCtO4vJjtL42JwFhjEExG r0rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=EqzQW4bvuiA6pvJtGB4rjgOdvlv8E2OoMiyxcMbYrTc=; b=rXu6MJBuo1Hzt7bU4tuezWecGRMDKDGqNA7ahV3bOQMW/L8baaxY7QD7/HpZsWh5Ho KEk5a7DwFaXRYhIGQGJ250lAgBFnDw4UglanTQHRAFM0W6z/vAX2KjJ7g6YjDFC8LGb7 enwo6Hjv+Ck8dnTNb9JcPSgsSv50/SEBbyr6qAELP5FO84euZN1y3GHVyF5Xlkv1y1WQ noLyXl1X6H+R+HX25Gb0kIOL1E4OokcmocccbcprmB8w1IDhS9PmZJctn/t+crIXqjCg uy7ebLnYHNGNwHexUSP62NvK6auG6RO5IL3yHo0hxiPZ7j4cMbcjlmJ75QOdCbdxmHQR j42A== X-Gm-Message-State: AJIora+9uhFxQ7ALZzfkTmMA1xWQX6SbBcbILSM7CYa0HThjhiO1H1KB 5HszlqKx5WNvY3jbbFKaZZU= X-Google-Smtp-Source: AGRyM1vecP0FSol4KwYKeB+9vu236BPxycyySMJXvkigqrEt5XtwuYhjnuoaB3hP+TSVK07JAymodQ== X-Received: by 2002:a17:906:14d5:b0:711:c55a:998 with SMTP id y21-20020a17090614d500b00711c55a0998mr1798067ejc.708.1655331913477; Wed, 15 Jun 2022 15:25:13 -0700 (PDT) Received: from debian.home (90-180-208-18.rcn.o2.cz. [90.180.208.18]) by smtp.gmail.com with ESMTPSA id y3-20020a056402358300b0042dc25fdf5bsm350427edc.29.2022.06.15.15.25.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jun 2022 15:25:13 -0700 (PDT) From: Jiri Vanek To: Andrzej Hajda , Neil Armstrong , Robert Foss Cc: Vinay Simha B N , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jiri Vanek Subject: [PATCH 2/2] drm/bridge/tc358775: Fix DSI clock division for vsync delay calculation Date: Thu, 16 Jun 2022 00:22:21 +0200 Message-Id: <20220615222221.1501-3-jirivanek1@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220615222221.1501-1-jirivanek1@gmail.com> References: <20220615222221.1501-1-jirivanek1@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Use the same PCLK divide option (divide DSI clock to generate pixel clock) which is set to LVDS Configuration Register (LVCFG) also for a VSync delay calculation. Without this change an auxiliary variable could underflow during the calculation for some dual-link LVDS panels and then calculated VSync delay is wrong. This leads to a shifted picture on a panel. Tested-by: Jiri Vanek Signed-off-by: Jiri Vanek --- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc3= 58775.c index cd2721ab02a9..fecb8558b49a 100644 --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -430,7 +430,7 @@ static void tc_bridge_enable(struct drm_bridge *bridge) val =3D TC358775_VPCTRL_MSF(1); =20 dsiclk =3D mode->crtc_clock * 3 * tc->bpc / tc->num_dsi_lanes / 1000; - clkdiv =3D dsiclk / DIVIDE_BY_3 * tc->lvds_link; + clkdiv =3D dsiclk / (tc->lvds_link =3D=3D DUAL_LINK ? DIVIDE_BY_6 : DIVID= E_BY_3); byteclk =3D dsiclk / 4; t1 =3D hactive * (tc->bpc * 3 / 8) / tc->num_dsi_lanes; t2 =3D ((100000 / clkdiv)) * (hactive + hback_porch + hsync_len + hfront_= porch) / 1000; --=20 2.30.2