From nobody Mon Apr 27 07:48:14 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E75F8C433EF for ; Wed, 15 Jun 2022 14:04:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356018AbiFOOEJ (ORCPT ); Wed, 15 Jun 2022 10:04:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356195AbiFOOEA (ORCPT ); Wed, 15 Jun 2022 10:04:00 -0400 Received: from mail-m965.mail.126.com (mail-m965.mail.126.com [123.126.96.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 61FA814020 for ; Wed, 15 Jun 2022 07:03:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=xGjqN 1CzFGgxxXJufcBxFeGfgDwPCWB316shxSNIbJs=; b=JVHxeNujKk5t7no8ctG1Q xSBB2a0rzeK6LpMG1MP7z2IcKj8wzgC8R/tMRRAbUPk14+EZTngtMMnb7ES9AfpX ACciMZcwt021YJhkv6pYS/wgRzd3ZxE8wER2KbbNjjPCh36ARQ1eKeoMLewvDNte tIV5FyITVMya3u22tGtURU= Received: from localhost.localdomain (unknown [124.16.139.61]) by smtp10 (Coremail) with SMTP id NuRpCgDHFmt45qliXpPJEg--.48216S2; Wed, 15 Jun 2022 22:02:33 +0800 (CST) From: Liang He To: f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, windhl@126.com Subject: [PATCH] drivers: soc: bcm: brcmstb: Add missing of_node_put() in biuctrl.c Date: Wed, 15 Jun 2022 22:02:31 +0800 Message-Id: <20220615140231.3968187-1-windhl@126.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: NuRpCgDHFmt45qliXpPJEg--.48216S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrZr1rCry8Gw15XFykWr18uFg_yoWkZwcEgF 93Xr9rXr4UZw48XFyDCw4fZas7uFs8XFs7ZFyIqa43CF92qw1DJrWkZr9xCw4kWrWvkFy7 Cw4qgrW0vr1UGjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xR_znQ7UUUUU== X-Originating-IP: [124.16.139.61] X-CM-SenderInfo: hzlqvxbo6rjloofrz/1tbizhkhF18RPTF-wQAAsd Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In brcmstb_biuctrl_init(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() in each fail path or when it is not used anymore. Signed-off-by: Liang He --- drivers/soc/bcm/brcmstb/biuctrl.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/soc/bcm/brcmstb/biuctrl.c b/drivers/soc/bcm/brcmstb/bi= uctrl.c index 2c975d79fe8e..1467bbd59690 100644 --- a/drivers/soc/bcm/brcmstb/biuctrl.c +++ b/drivers/soc/bcm/brcmstb/biuctrl.c @@ -340,12 +340,12 @@ static int __init brcmstb_biuctrl_init(void) =20 ret =3D setup_hifcpubiuctrl_regs(np); if (ret) - return ret; + goto out_put; =20 ret =3D mcp_write_pairing_set(); if (ret) { pr_err("MCP: Unable to disable write pairing!\n"); - return ret; + goto out_put; } =20 a72_b53_rac_enable_all(np); @@ -353,6 +353,9 @@ static int __init brcmstb_biuctrl_init(void) #ifdef CONFIG_PM_SLEEP register_syscore_ops(&brcmstb_cpu_credit_syscore_ops); #endif - return 0; + ret =3D 0; +out_put: + of_node_put(np); + return ret; } early_initcall(brcmstb_biuctrl_init); --=20 2.25.1