From nobody Mon Apr 27 08:44:47 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C4A0C43334 for ; Wed, 15 Jun 2022 07:54:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244091AbiFOHyX (ORCPT ); Wed, 15 Jun 2022 03:54:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234338AbiFOHyM (ORCPT ); Wed, 15 Jun 2022 03:54:12 -0400 Received: from mail.nfschina.com (unknown [IPv6:2400:dd01:100f:2:72e2:84ff:fe10:5f45]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B4481427F8 for ; Wed, 15 Jun 2022 00:54:11 -0700 (PDT) Received: from localhost (unknown [127.0.0.1]) by mail.nfschina.com (Postfix) with ESMTP id 12E6E1E80D27; Wed, 15 Jun 2022 15:52:43 +0800 (CST) X-Virus-Scanned: amavisd-new at test.com Received: from mail.nfschina.com ([127.0.0.1]) by localhost (mail.nfschina.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V5N6kuqPlSIw; Wed, 15 Jun 2022 15:52:40 +0800 (CST) Received: from localhost.localdomain (unknown [180.167.10.98]) (Authenticated sender: liqiong@nfschina.com) by mail.nfschina.com (Postfix) with ESMTPA id A37F11E80CFF; Wed, 15 Jun 2022 15:52:39 +0800 (CST) From: Li Qiong To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, yuzhe@nfschina.com, renyu@nfschina.com, Li Qiong Subject: [PATCH] drm: check for allocation failure of kstrdup_const() Date: Wed, 15 Jun 2022 15:53:09 +0800 Message-Id: <20220615075309.18955-1-liqiong@nfschina.com> X-Mailer: git-send-email 2.11.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" As the possible failure of the kstrdup_const(), it should be better to check it and handle it. Signed-off-by: Li Qiong --- drivers/gpu/drm/drm_managed.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/drm_managed.c b/drivers/gpu/drm/drm_managed.c index 4cf214de50c4..d9bd4a9da559 100644 --- a/drivers/gpu/drm/drm_managed.c +++ b/drivers/gpu/drm/drm_managed.c @@ -151,6 +151,8 @@ int __drmm_add_action(struct drm_device *dev, } =20 dr->node.name =3D kstrdup_const(name, GFP_KERNEL); + if (!dr->node.name) + return -ENOMEM; if (data) { void_ptr =3D (void **)&dr->data; *void_ptr =3D data; @@ -197,6 +199,8 @@ void *drmm_kmalloc(struct drm_device *dev, size_t size,= gfp_t gfp) return NULL; } dr->node.name =3D kstrdup_const("kmalloc", GFP_KERNEL); + if (!dr->node.name) + return NULL; =20 add_dr(dev, dr); =20 --=20 2.25.1