From nobody Mon Apr 27 08:43:42 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 476B1C43334 for ; Wed, 15 Jun 2022 03:11:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345906AbiFODLp (ORCPT ); Tue, 14 Jun 2022 23:11:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231685AbiFODLm (ORCPT ); Tue, 14 Jun 2022 23:11:42 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC7164C414 for ; Tue, 14 Jun 2022 20:11:41 -0700 (PDT) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LN9H90T2wzRjYq; Wed, 15 Jun 2022 11:08:21 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 15 Jun 2022 11:11:23 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 15 Jun 2022 11:11:22 +0800 From: Yang Yingliang To: , CC: , Subject: [PATCH -next] powerpc/fsl_rio: add missing of_node_put() in fsl_rio_setup() Date: Wed, 15 Jun 2022 11:21:37 +0800 Message-ID: <20220615032137.1878219-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" of_find_compatible_node() and for_each_child_of_node() will increase the refcount of 'np', so add of_node_put() after using it to avoid refcount leak. Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- arch/powerpc/sysdev/fsl_rio.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/powerpc/sysdev/fsl_rio.c b/arch/powerpc/sysdev/fsl_rio.c index 1bfc9afa8a1a..97bbecb259dc 100644 --- a/arch/powerpc/sysdev/fsl_rio.c +++ b/arch/powerpc/sysdev/fsl_rio.c @@ -542,9 +542,11 @@ int fsl_rio_setup(struct platform_device *dev) if (!dt_range) { pr_err("%pOF: unable to find 'reg' property\n", np); + of_node_put(np); rc =3D -ENOMEM; goto err_pw; } + of_node_put(np); range_start =3D of_read_number(dt_range, aw); dbell->dbell_regs =3D (struct rio_dbell_regs *)(rmu_regs_win + (u32)range_start); @@ -570,9 +572,11 @@ int fsl_rio_setup(struct platform_device *dev) if (!dt_range) { pr_err("%pOF: unable to find 'reg' property\n", np); + of_node_put(np); rc =3D -ENOMEM; goto err; } + of_node_put(np); range_start =3D of_read_number(dt_range, aw); pw->pw_regs =3D (struct rio_pw_regs *)(rmu_regs_win + (u32)range_start); =20 @@ -582,6 +586,7 @@ int fsl_rio_setup(struct platform_device *dev) if (!port_index) { dev_err(&dev->dev, "Can't get %pOF property 'cell-index'\n", np); + of_node_put(np); continue; } =20 @@ -589,6 +594,7 @@ int fsl_rio_setup(struct platform_device *dev) if (!dt_range) { dev_err(&dev->dev, "Can't get %pOF property 'ranges'\n", np); + of_node_put(np); continue; } =20 @@ -611,6 +617,7 @@ int fsl_rio_setup(struct platform_device *dev) =20 dev_info(&dev->dev, "%pOF: LAW start 0x%016llx, size 0x%016llx.\n", np, range_start, range_size); + of_node_put(np); =20 port =3D kzalloc(sizeof(struct rio_mport), GFP_KERNEL); if (!port) --=20 2.25.1