From nobody Mon Apr 27 15:22:40 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62488C43334 for ; Mon, 13 Jun 2022 06:35:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235032AbiFMGfh (ORCPT ); Mon, 13 Jun 2022 02:35:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231917AbiFMGfa (ORCPT ); Mon, 13 Jun 2022 02:35:30 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6892BC81; Sun, 12 Jun 2022 23:35:27 -0700 (PDT) Received: from kwepemi500014.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LM1wp1jX5zgYXn; Mon, 13 Jun 2022 14:33:30 +0800 (CST) Received: from huawei.com (10.67.174.157) by kwepemi500014.china.huawei.com (7.221.188.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 13 Jun 2022 14:35:25 +0800 From: Li Zhengyu To: , CC: , , , , Subject: [PATCH] clk: qcom: clk-rpmh: Remove redundant if statement Date: Mon, 13 Jun 2022 14:33:27 +0800 Message-ID: <20220613063327.89320-1-lizhengyu3@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.67.174.157] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemi500014.china.huawei.com (7.221.188.232) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" By the clk framework already reference counts prepare/unprepare, this if statement should be never true. Signed-off-by: Li Zhengyu Reviewed-by: Stephen Boyd --- Previous threads:=20 https://lore.kernel.org/all/20220531094539.252642-1-lizhengyu3@huawei.com/ drivers/clk/qcom/clk-rpmh.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c index aed907982344..249146947923 100644 --- a/drivers/clk/qcom/clk-rpmh.c +++ b/drivers/clk/qcom/clk-rpmh.c @@ -195,10 +195,6 @@ static int clk_rpmh_aggregate_state_send_command(struc= t clk_rpmh *c, { int ret; =20 - /* Nothing required to be done if already off or on */ - if (enable =3D=3D c->state) - return 0; - c->state =3D enable ? c->valid_state_mask : 0; c->aggr_state =3D c->state | c->peer->state; c->peer->aggr_state =3D c->aggr_state; --=20 2.17.1