From nobody Tue Apr 28 01:14:44 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E393C43334 for ; Wed, 8 Jun 2022 09:26:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235188AbiFHJ0c (ORCPT ); Wed, 8 Jun 2022 05:26:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235193AbiFHJZs (ORCPT ); Wed, 8 Jun 2022 05:25:48 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6EC6A1BC; Wed, 8 Jun 2022 01:51:16 -0700 (PDT) Received: from dggpeml500026.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LJ18L2DV9zRj2b; Wed, 8 Jun 2022 16:48:02 +0800 (CST) Received: from dggpeml500008.china.huawei.com (7.185.36.147) by dggpeml500026.china.huawei.com (7.185.36.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 8 Jun 2022 16:51:14 +0800 Received: from huawei.com (10.67.175.34) by dggpeml500008.china.huawei.com (7.185.36.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 8 Jun 2022 16:51:14 +0800 From: Ren Zhijie To: , , CC: , , Ren Zhijie Subject: [PATCH -next] hwmon: (pmbus) fix build error unused-function Date: Wed, 8 Jun 2022 16:49:38 +0800 Message-ID: <20220608084938.173071-1-renzhijie2@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.175.34] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500008.china.huawei.com (7.185.36.147) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If CONFIG_PMBUS is y and CONFIG_DEBUG_FS is not set. make ARCH=3Darm64 CROSS_COMPILE=3Daarch64-linux-gnu-, will be failed, like = this: drivers/hwmon/pmbus/pmbus_core.c:593:13: error: =E2=80=98pmbus_check_block_= register=E2=80=99 defined but not used [-Werror=3Dunused-function] static bool pmbus_check_block_register(struct i2c_client *client, int page, ^~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[3]: *** [drivers/hwmon/pmbus/pmbus_core.o] Error 1 make[2]: *** [drivers/hwmon/pmbus] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [drivers/hwmon] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [drivers] Error 2 To fix building warning, wrap all related code with CONFIG_DEBUG_F. Reported-by: Hulk Robot Fixes: c3ffc3a1ff83("hwmon: (pmbus) add a function to check the presence of= a block register") Signed-off-by: Ren Zhijie --- drivers/hwmon/pmbus/pmbus_core.c | 56 ++++++++++++++++---------------- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_c= ore.c index 809e666cb52b..2c68ab1fe697 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -441,18 +441,6 @@ int pmbus_update_byte_data(struct i2c_client *client, = int page, u8 reg, } EXPORT_SYMBOL_NS_GPL(pmbus_update_byte_data, PMBUS); =20 -static int pmbus_read_block_data(struct i2c_client *client, int page, u8 r= eg, - char *data_buf) -{ - int rv; - - rv =3D pmbus_set_page(client, page, 0xff); - if (rv < 0) - return rv; - - return i2c_smbus_read_block_data(client, reg, data_buf); -} - static struct pmbus_sensor *pmbus_find_sensor(struct pmbus_data *data, int= page, int reg) { @@ -590,22 +578,6 @@ bool pmbus_check_word_register(struct i2c_client *clie= nt, int page, int reg) } EXPORT_SYMBOL_NS_GPL(pmbus_check_word_register, PMBUS); =20 -static bool pmbus_check_block_register(struct i2c_client *client, int page, - int reg) -{ - int rv; - struct pmbus_data *data =3D i2c_get_clientdata(client); - char data_buf[I2C_SMBUS_BLOCK_MAX + 2]; - - rv =3D pmbus_read_block_data(client, page, reg, data_buf); - if (rv >=3D 0 && !(data->flags & PMBUS_SKIP_STATUS_CHECK)) - rv =3D pmbus_check_status_cml(client); - if (rv < 0 && (data->flags & PMBUS_READ_STATUS_AFTER_FAILED_CHECK)) - data->read_status(client, -1); - pmbus_clear_fault_page(client, -1); - return rv >=3D 0; -} - const struct pmbus_driver_info *pmbus_get_driver_info(struct i2c_client *c= lient) { struct pmbus_data *data =3D i2c_get_clientdata(client); @@ -2961,6 +2933,34 @@ static int pmbus_regulator_register(struct pmbus_dat= a *data) static struct dentry *pmbus_debugfs_dir; /* pmbus debugfs directory */ =20 #if IS_ENABLED(CONFIG_DEBUG_FS) +static int pmbus_read_block_data(struct i2c_client *client, int page, u8 r= eg, + char *data_buf) +{ + int rv; + + rv =3D pmbus_set_page(client, page, 0xff); + if (rv < 0) + return rv; + + return i2c_smbus_read_block_data(client, reg, data_buf); +} + +static bool pmbus_check_block_register(struct i2c_client *client, int page, + int reg) +{ + int rv; + struct pmbus_data *data =3D i2c_get_clientdata(client); + char data_buf[I2C_SMBUS_BLOCK_MAX + 2]; + + rv =3D pmbus_read_block_data(client, page, reg, data_buf); + if (rv >=3D 0 && !(data->flags & PMBUS_SKIP_STATUS_CHECK)) + rv =3D pmbus_check_status_cml(client); + if (rv < 0 && (data->flags & PMBUS_READ_STATUS_AFTER_FAILED_CHECK)) + data->read_status(client, -1); + pmbus_clear_fault_page(client, -1); + return rv >=3D 0; +} + static int pmbus_debugfs_get(void *data, u64 *val) { int rc; --=20 2.17.1