From nobody Thu Apr 30 08:23:54 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A940C433EF for ; Tue, 7 Jun 2022 15:56:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344543AbiFGP4N (ORCPT ); Tue, 7 Jun 2022 11:56:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344631AbiFGP4J (ORCPT ); Tue, 7 Jun 2022 11:56:09 -0400 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7F9328E12 for ; Tue, 7 Jun 2022 08:56:05 -0700 (PDT) From: =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1654617363; bh=UwJaoAVoa61DCnp3vhNmUCc8wPxbMXJadrTLt8SmqCQ=; h=From:To:Cc:Subject:Date:From; b=qrntoUTld+NGDiE5Bqw7eLxramszHrt0peuvaCimeBz3YqtUbTTA+OPnBTPFsxOvW xAFMmjL6upk/fe1S282aPfDeyezCHZgCk1j1MJ9Hq0MJXUFW4B1SmzedqWbC63lU7h Xr+KWNhLEUQwNO3rOAW+51Vl1yMAXWDGytoXvPo8= To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= Subject: [PATCH] nvme: add device name to warning in uuid_show() Date: Tue, 7 Jun 2022 17:55:55 +0200 Message-Id: <20220607155555.8623-1-linux@weissschuh.net> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=ed25519-sha256; t=1654617355; l=1083; s=20211113; h=from:subject; bh=UwJaoAVoa61DCnp3vhNmUCc8wPxbMXJadrTLt8SmqCQ=; b=bg7FhTgM0Iz/uy954ZRKT/GOeWkKox3seP2mKi3+lLyDYj2x7go1RWrifrHKufOY7qmjOXAYWuMl qbOACxxkCX5BXmHEPExMMa7l1rkPmecuQiP15JaPCGZWCZx0R+M/ X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=9LP6KM4vD/8CwHW7nouRBhWLyQLcK1MkP6aTZbzUlj4= Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This provides more context to users. Old message: [ 00.000000] No UUID available providing old NGUID New message: [ 00.000000] block nvme0n1: No UUID available providing old NGUID Fixes: d934f9848a77 ("nvme: provide UUID value to userspace") Signed-off-by: Thomas Wei=C3=9Fschuh --- drivers/nvme/host/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 24165daee3c8..189bbd6c0c29 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -3285,8 +3285,7 @@ static ssize_t uuid_show(struct device *dev, struct d= evice_attribute *attr, * we have no UUID set */ if (uuid_is_null(&ids->uuid)) { - printk_ratelimited(KERN_WARNING - "No UUID available providing old NGUID\n"); + dev_warn_ratelimited(dev, "No UUID available providing old NGUID\n"); return sysfs_emit(buf, "%pU\n", ids->nguid); } return sysfs_emit(buf, "%pU\n", &ids->uuid); base-commit: e71e60cd74df9386c3f684c54888f2367050b831 --=20 2.36.1