From nobody Tue Apr 28 02:37:23 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18CC3C433EF for ; Tue, 7 Jun 2022 13:36:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244830AbiFGNgK (ORCPT ); Tue, 7 Jun 2022 09:36:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244823AbiFGNgC (ORCPT ); Tue, 7 Jun 2022 09:36:02 -0400 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B1A6D2460; Tue, 7 Jun 2022 06:35:59 -0700 (PDT) Received: (Authenticated sender: clement.leger@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id A7591FF808; Tue, 7 Jun 2022 13:35:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1654608958; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=x/2MYis5whDLEikQJTsiWgIVIR/tyXFDwtuLu2I9a4U=; b=kGiqaTcvB3zmW/DKyC1rreLfCGQGhy7BeyOgAQmz+Qn+BMfR08J6eqetbBee36z5Bq1anf 9T/Gu77nJKVBLXU0SJvH3fZB0f4amZq/KulUnH13ceMgJF3w5AuaJFuIG9csskQbk9B8Xv 3ZPOgVBYjp620dMvwTgnzshBacUqgp4oUgzhcA0PoL7FbWE5ugr5o6wii9QbmaLYMTrjLz oyg9yVu/wINe2z9DGyLf9FAcGSd5ZRk8at3lBZQ/jTdv/Kh51k48NKcSiF4z0c5zLSNv3J 4YZ38QHRzz6GnEl4c5We9zLC+7B8CaCkMajIfW9kDzy47mbftxkBgsJiffbf+Q== From: =?UTF-8?q?Cl=C3=A9ment=20L=C3=A9ger?= To: Alan Stern , Greg Kroah-Hartman , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: =?UTF-8?q?Cl=C3=A9ment=20L=C3=A9ger?= , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Thomas Petazzoni Subject: [PATCH v2] usb: host: ohci-at91: add support to enter suspend using SMC Date: Tue, 7 Jun 2022 15:34:54 +0200 Message-Id: <20220607133454.727063-1-clement.leger@bootlin.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When Linux is running under OP-TEE, the SFR is set as secured and thus the AT91_OHCIICR_USB_SUSPEND register isn't accessible. Add a SMC to do the appropriate call to suspend the controller. The SMC id is fetched from the device-tree property "microchip,suspend-smc-id". if present, then the syscon regmap is not used to enter suspend and a SMC is issued. Signed-off-by: Cl=C3=A9ment L=C3=A9ger Acked-by: Alan Stern Reviewed-by: Claudiu Beznea --- Notes: Changes in V2: - Change check order in ohci_at91_port_suspend() - Renamed smc_id to suspend_smc_id for clarity drivers/usb/host/ohci-at91.c | 69 ++++++++++++++++++++++++------------ 1 file changed, 46 insertions(+), 23 deletions(-) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index a24aea3d2759..98326465e2dc 100644 --- a/drivers/usb/host/ohci-at91.c +++ b/drivers/usb/host/ohci-at91.c @@ -13,6 +13,7 @@ * This file is licenced under the GPL. */ =20 +#include #include #include #include @@ -55,6 +56,7 @@ struct ohci_at91_priv { bool clocked; bool wakeup; /* Saved wake-up state for resume */ struct regmap *sfr_regmap; + u32 suspend_smc_id; }; /* interface and function clocks; sometimes also an AHB clock */ =20 @@ -135,6 +137,19 @@ static void at91_stop_hc(struct platform_device *pdev) =20 static void usb_hcd_at91_remove (struct usb_hcd *, struct platform_device = *); =20 +static u32 at91_dt_suspend_smc(struct device *dev) +{ + u32 suspend_smc_id; + + if (!dev->of_node) + return 0; + + if (of_property_read_u32(dev->of_node, "microchip,suspend-smc-id", &suspe= nd_smc_id)) + return 0; + + return suspend_smc_id; +} + static struct regmap *at91_dt_syscon_sfr(void) { struct regmap *regmap; @@ -215,9 +230,13 @@ static int usb_hcd_at91_probe(const struct hc_driver *= driver, goto err; } =20 - ohci_at91->sfr_regmap =3D at91_dt_syscon_sfr(); - if (!ohci_at91->sfr_regmap) - dev_dbg(dev, "failed to find sfr node\n"); + ohci_at91->suspend_smc_id =3D at91_dt_suspend_smc(dev); + if (!ohci_at91->suspend_smc_id) { + dev_dbg(dev, "failed to find sfr suspend smc id, using regmap\n"); + ohci_at91->sfr_regmap =3D at91_dt_syscon_sfr(); + if (!ohci_at91->sfr_regmap) + dev_dbg(dev, "failed to find sfr node\n"); + } =20 board =3D hcd->self.controller->platform_data; ohci =3D hcd_to_ohci(hcd); @@ -303,24 +322,30 @@ static int ohci_at91_hub_status_data(struct usb_hcd *= hcd, char *buf) return length; } =20 -static int ohci_at91_port_suspend(struct regmap *regmap, u8 set) +static int ohci_at91_port_suspend(struct ohci_at91_priv *ohci_at91, u8 set) { + struct regmap *regmap =3D ohci_at91->sfr_regmap; u32 regval; int ret; =20 - if (!regmap) - return 0; + if (ohci_at91->suspend_smc_id) { + struct arm_smccc_res res; =20 - ret =3D regmap_read(regmap, AT91_SFR_OHCIICR, ®val); - if (ret) - return ret; + arm_smccc_smc(ohci_at91->suspend_smc_id, set, 0, 0, 0, 0, 0, 0, &res); + if (res.a0) + return -EINVAL; + } else if (regmap) { + ret =3D regmap_read(regmap, AT91_SFR_OHCIICR, ®val); + if (ret) + return ret; =20 - if (set) - regval |=3D AT91_OHCIICR_USB_SUSPEND; - else - regval &=3D ~AT91_OHCIICR_USB_SUSPEND; + if (set) + regval |=3D AT91_OHCIICR_USB_SUSPEND; + else + regval &=3D ~AT91_OHCIICR_USB_SUSPEND; =20 - regmap_write(regmap, AT91_SFR_OHCIICR, regval); + regmap_write(regmap, AT91_SFR_OHCIICR, regval); + } =20 return 0; } @@ -357,9 +382,8 @@ static int ohci_at91_hub_control(struct usb_hcd *hcd, u= 16 typeReq, u16 wValue, =20 case USB_PORT_FEAT_SUSPEND: dev_dbg(hcd->self.controller, "SetPortFeat: SUSPEND\n"); - if (valid_port(wIndex) && ohci_at91->sfr_regmap) { - ohci_at91_port_suspend(ohci_at91->sfr_regmap, - 1); + if (valid_port(wIndex)) { + ohci_at91_port_suspend(ohci_at91, 1); return 0; } break; @@ -400,9 +424,8 @@ static int ohci_at91_hub_control(struct usb_hcd *hcd, u= 16 typeReq, u16 wValue, =20 case USB_PORT_FEAT_SUSPEND: dev_dbg(hcd->self.controller, "ClearPortFeature: SUSPEND\n"); - if (valid_port(wIndex) && ohci_at91->sfr_regmap) { - ohci_at91_port_suspend(ohci_at91->sfr_regmap, - 0); + if (valid_port(wIndex)) { + ohci_at91_port_suspend(ohci_at91, 0); return 0; } break; @@ -630,10 +653,10 @@ ohci_hcd_at91_drv_suspend(struct device *dev) /* flush the writes */ (void) ohci_readl (ohci, &ohci->regs->control); msleep(1); - ohci_at91_port_suspend(ohci_at91->sfr_regmap, 1); + ohci_at91_port_suspend(ohci_at91, 1); at91_stop_clock(ohci_at91); } else { - ohci_at91_port_suspend(ohci_at91->sfr_regmap, 1); + ohci_at91_port_suspend(ohci_at91, 1); } =20 return ret; @@ -645,7 +668,7 @@ ohci_hcd_at91_drv_resume(struct device *dev) struct usb_hcd *hcd =3D dev_get_drvdata(dev); struct ohci_at91_priv *ohci_at91 =3D hcd_to_ohci_at91_priv(hcd); =20 - ohci_at91_port_suspend(ohci_at91->sfr_regmap, 0); + ohci_at91_port_suspend(ohci_at91, 0); =20 if (ohci_at91->wakeup) disable_irq_wake(hcd->irq); --=20 2.36.1