From nobody Tue Apr 28 09:05:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91119C43334 for ; Fri, 3 Jun 2022 13:27:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244630AbiFCN1R (ORCPT ); Fri, 3 Jun 2022 09:27:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238620AbiFCN1P (ORCPT ); Fri, 3 Jun 2022 09:27:15 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67AEE1274A; Fri, 3 Jun 2022 06:27:14 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id d12-20020a17090abf8c00b001e2eb431ce4so7198080pjs.1; Fri, 03 Jun 2022 06:27:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=zGYGCHPMc2wMb8+o7znOSNlSgZiftTrEQzD43QCV+90=; b=i+7jqG7KVpeeNJ6V0vSnIFfrYVTh3rBccm8ii5aNFr8oAtqmONw/g0UFyZdHC+/HlS CFMib75eX8uio37b5hjw6af7cqpT+gCDcEs57LXHZoQ/5Nxl5fok9aPlsyOgpAofkSgS UA+f5V66+4EEBe6I6tCrHosahkwoXlGAwaojY4YDiZ6foQ+jH9aQs8gNwLxqCwgYHS3B P1wVqrLLMJR2WkCVGuHHiynWC2mKpRTIfpu3BsaC7Wa6PkWZFP6PeiA6HqtUV62lpa0v fnl+5xHFwdmwR5L4aEdBL1yVEABKWAZZhS/gCkAYrf6SOkV0fdHT6GMP9XFZYGPGbioG HxWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=zGYGCHPMc2wMb8+o7znOSNlSgZiftTrEQzD43QCV+90=; b=XV/ow0Nn98c6MbjE/Vz6njzFk8y4VNOFtwA9pfNIoN3yGxNGi9yZ/aLBiLJf4sG2Zh xjlAd8NkqoxDq7X9HRArWf0Ev9LYG5gZ7fAgS5TLLlqsx1aGWjr2BkSi0zsoPNyHDEjZ Cd/Yj+HBjKk0Zc2stiCwwdvhZh1qmdHqJH7nk1ew5WZOSOMUL+mXfndoV524WnVLwjU4 Wh+kfv8DJQR21SZqN7qniQ6L8e88WTQXYA3io8Pk8TDzbP9am0rO+7Mm36MX6W4dDoBH Va7HBXcgp/deN6Jfl1CRbwJvK9PDIf0NT3eoXVtEx8NAtRwFlAQTSys/8qBV0cyvza8P rk3g== X-Gm-Message-State: AOAM533kyKeCrB52fgK84cGV8EQnGxbB5VaGhZGFJHIU7HVVnqVnUBYq /as+Eqh/fWLojh1dlL05GD8= X-Google-Smtp-Source: ABdhPJzluHIhouQf927OhbZ6lRASEW4yUSiTagVN/uhD04GCE3ApYGm7UAFAiucHC3zND3JTXTWVRA== X-Received: by 2002:a17:903:22d0:b0:164:ec0:178c with SMTP id y16-20020a17090322d000b001640ec0178cmr10442663plg.127.1654262833917; Fri, 03 Jun 2022 06:27:13 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id l24-20020a17090ac59800b001e25e3ba05csm8536780pjt.2.2022.06.03.06.27.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jun 2022 06:27:13 -0700 (PDT) From: Miaoqian Lin To: Thierry Reding , David Airlie , Daniel Vetter , Jonathan Hunter , Mark Zhang , Terje Bergstrom , Dave Airlie , dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH v2] drm/tegra: dc: rgb: Fix refcount leak in tegra_dc_rgb_probe Date: Fri, 3 Jun 2022 17:27:03 +0400 Message-Id: <20220603132703.42085-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" of_get_child_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. So add of_node_put() in error paths. Fixes: d8f4a9eda006 ("drm: Add NVIDIA Tegra20 support") Signed-off-by: Miaoqian Lin --- changes in v2: - update Fixes tag. v1 Link: https://lore.kernel.org/r/20220602155615.43277-1-linmq006@gmail.com --- drivers/gpu/drm/tegra/rgb.c | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/tegra/rgb.c b/drivers/gpu/drm/tegra/rgb.c index ff8fce36d2aa..cef2b1b72385 100644 --- a/drivers/gpu/drm/tegra/rgb.c +++ b/drivers/gpu/drm/tegra/rgb.c @@ -196,12 +196,16 @@ int tegra_dc_rgb_probe(struct tegra_dc *dc) int err; =20 np =3D of_get_child_by_name(dc->dev->of_node, "rgb"); - if (!np || !of_device_is_available(np)) - return -ENODEV; + if (!np || !of_device_is_available(np)) { + err =3D -ENODEV; + goto err_put_node; + } =20 rgb =3D devm_kzalloc(dc->dev, sizeof(*rgb), GFP_KERNEL); - if (!rgb) - return -ENOMEM; + if (!rgb) { + err =3D -ENOMEM; + goto err_put_node; + } =20 rgb->output.dev =3D dc->dev; rgb->output.of_node =3D np; @@ -209,31 +213,34 @@ int tegra_dc_rgb_probe(struct tegra_dc *dc) =20 err =3D tegra_output_probe(&rgb->output); if (err < 0) - return err; + goto err_put_node; + =20 rgb->clk =3D devm_clk_get(dc->dev, NULL); if (IS_ERR(rgb->clk)) { dev_err(dc->dev, "failed to get clock\n"); - return PTR_ERR(rgb->clk); + err =3D PTR_ERR(rgb->clk); + goto err_put_node; } =20 rgb->clk_parent =3D devm_clk_get(dc->dev, "parent"); if (IS_ERR(rgb->clk_parent)) { dev_err(dc->dev, "failed to get parent clock\n"); - return PTR_ERR(rgb->clk_parent); + err =3D PTR_ERR(rgb->clk_parent); + goto err_put_node; } =20 err =3D clk_set_parent(rgb->clk, rgb->clk_parent); if (err < 0) { dev_err(dc->dev, "failed to set parent clock: %d\n", err); - return err; + goto err_put_node; } =20 rgb->pll_d_out0 =3D clk_get_sys(NULL, "pll_d_out0"); if (IS_ERR(rgb->pll_d_out0)) { err =3D PTR_ERR(rgb->pll_d_out0); dev_err(dc->dev, "failed to get pll_d_out0: %d\n", err); - return err; + goto err_put_node; } =20 if (dc->soc->has_pll_d2_out0) { @@ -241,13 +248,17 @@ int tegra_dc_rgb_probe(struct tegra_dc *dc) if (IS_ERR(rgb->pll_d2_out0)) { err =3D PTR_ERR(rgb->pll_d2_out0); dev_err(dc->dev, "failed to get pll_d2_out0: %d\n", err); - return err; + goto err_put_node; } } =20 dc->rgb =3D &rgb->output; =20 return 0; + +err_put_node: + of_node_put(np); + return err; } =20 int tegra_dc_rgb_remove(struct tegra_dc *dc) --=20 2.25.1