From nobody Thu Apr 30 09:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EA77C433EF for ; Mon, 30 May 2022 02:20:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232236AbiE3CUo (ORCPT ); Sun, 29 May 2022 22:20:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230488AbiE3CUi (ORCPT ); Sun, 29 May 2022 22:20:38 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22B7E663C8 for ; Sun, 29 May 2022 19:20:37 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id s14so9087200plk.8 for ; Sun, 29 May 2022 19:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iSUIiTx06ZERM+GKjNo7mEfUI96cbNfNRpNUyOJxVbw=; b=S9dIeOW/SSwI/GwIi6mZhRw0z049GzAk4xXrjDc2cqWoLQTSdpxbVXfo27Q0GIqgZq cFIKJFAjhKtARCcqlnJoL8+2P/4uzOZj7N8O+6KO7jEYwmYGj0WccqEJB5lLG5fiheLw kciJw4jlRP75b514zThNHbZjytgaPa7TkCW+2RH2WhaxdXOrBmYNIj3Dt3pDKa6aMuuN 6DxUT6XV+LfRZ3/Av3ieogsztDo17h6OSV/dkUspznWWKQ3fKXNKXPL0VXpCdZwARsdX wmI47fH77ypiaOSEYqcwHBc0V9Jv3bWoJjEXfCUaSof2HQTkpb27wySM7+9DQYnqDZbj vKxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iSUIiTx06ZERM+GKjNo7mEfUI96cbNfNRpNUyOJxVbw=; b=ry4yYp8/3pTKFIwmC+BUsZC1jwB5JjTn1MCxxVgfY7mF1Pu2mTHBx6LRDA3qX8IA4s HIv9mCmf0gdoobFEQADP10jWF8pCFmd48pRcZaiLtUUtavJey2nGi++AKA1zpOaO6hnA UD6Z4F5wsiuYsbNPkWNvENwrsSRLguCiTcyZIK0yAPxJ/T4aiSIvorr/70iKyGODDX1U rzUybwFbSN5udTOX/58wYALC3LCyr8TdBL7oWSpYsvmmdSeNTjmaH9vFEZ/tbf8VMKMY ZkE7Ck9ZejVJ6je/Ijyy619Mikcz4H6kZc1KC9pcEOCEi1MweCSrOjnQCtVwqLsSlELk lCLQ== X-Gm-Message-State: AOAM532j3GDqU43ms16t/C/c9xqoOXTgIBHX+qjb41BsVXr/DKyHCcPx 3aDBhJQ78RejdEoOUXitl/69Mg== X-Google-Smtp-Source: ABdhPJyyTTZFpomnyQsisyztLTQlc2LMObRARpACojyemYKaITviTQ0rcuZseaH8bYaoKPBMSzsmgg== X-Received: by 2002:a17:903:41cb:b0:161:dd9c:bed2 with SMTP id u11-20020a17090341cb00b00161dd9cbed2mr52765762ple.138.1653877236645; Sun, 29 May 2022 19:20:36 -0700 (PDT) Received: from C02CV1DAMD6P.bytedance.net ([139.177.225.237]) by smtp.gmail.com with ESMTPSA id g1-20020a170902868100b0015e8d4eb25fsm4235738plo.169.2022.05.29.19.20.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 May 2022 19:20:36 -0700 (PDT) From: Chengming Zhou To: sj@kernel.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chengming Zhou Subject: [PATCH] mm/damon: remove obsolete comments of kdamond_stop Date: Mon, 30 May 2022 10:20:16 +0800 Message-Id: <20220530022016.11771-1-zhouchengming@bytedance.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Since commit 0f91d13366a4 ("mm/damon: simplify stop mechanism") delete kdamond_stop and change to use kthread stop mechanism, these obsolete comments should be removed accordingly. Signed-off-by: Chengming Zhou Acked-by: Muchun Song Reviewed-by: SeongJae Park --- include/linux/damon.h | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index 7c62da31ce4b..fa1c2968b1dd 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -397,7 +397,6 @@ struct damon_callback { * detail. * * @kdamond: Kernel thread who does the monitoring. - * @kdamond_stop: Notifies whether kdamond should stop. * @kdamond_lock: Mutex for the synchronizations with @kdamond. * * For each monitoring context, one kernel thread for the monitoring is @@ -406,14 +405,14 @@ struct damon_callback { * Once started, the monitoring thread runs until explicitly required to be * terminated or every monitoring target is invalid. The validity of the * targets is checked via the &damon_operations.target_valid of @ops. The - * termination can also be explicitly requested by writing non-zero to - * @kdamond_stop. The thread sets @kdamond to NULL when it terminates. - * Therefore, users can know whether the monitoring is ongoing or terminat= ed by - * reading @kdamond. Reads and writes to @kdamond and @kdamond_stop from - * outside of the monitoring thread must be protected by @kdamond_lock. - * - * Note that the monitoring thread protects only @kdamond and @kdamond_sto= p via - * @kdamond_lock. Accesses to other fields must be protected by themselve= s. + * termination can also be explicitly requested by calling __damon_stop(). + * The thread sets @kdamond to NULL when it terminates. Therefore, users c= an + * know whether the monitoring is ongoing or terminated by reading @kdamon= d. + * Reads and writes to @kdamond from outside of the monitoring thread must + * be protected by @kdamond_lock. + * + * Note that the monitoring thread protects only @kdamond via @kdamond_loc= k. + * Accesses to other fields must be protected by themselves. * * @ops: Set of monitoring operations for given use cases. * @callback: Set of callbacks for monitoring events notifications. --=20 2.36.1