From nobody Tue Apr 28 23:18:04 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E3FAC433F5 for ; Fri, 27 May 2022 00:00:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345834AbiE0AAd (ORCPT ); Thu, 26 May 2022 20:00:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343755AbiE0AA2 (ORCPT ); Thu, 26 May 2022 20:00:28 -0400 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0D2B58BD06 for ; Thu, 26 May 2022 17:00:28 -0700 (PDT) Received: from sequoia.corp.microsoft.com (162-237-133-238.lightspeed.rcsntx.sbcglobal.net [162.237.133.238]) by linux.microsoft.com (Postfix) with ESMTPSA id 45BEC20B6C7C; Thu, 26 May 2022 17:00:27 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 45BEC20B6C7C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1653609627; bh=NhuOrFwDQW9Q1UcmxsEGyGirwZwzRLJvKVIm4Dfq7Go=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VEOVZWTZwwz+nwhUfw74fZ7F3of6fGhlZoWIXbWcxkU78Awwb/9fML91xtfZe7p/f RIbWgoXWZo9vACbaM7OyykfAa/A3MuHmUQEowMPqZFfQQSv1WOtIdkAy6GufgktV7c XkXbq+bxVDYr4IYAtUiy1VXIb1ET8Qj2hmlVlS4M= From: Tyler Hicks To: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet Cc: Christian Schoenebeck , Jianyong Wu , v9fs-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/5] 9p: Fix refcounting during full path walks for fid lookups Date: Thu, 26 May 2022 18:59:59 -0500 Message-Id: <20220527000003.355812-2-tyhicks@linux.microsoft.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220527000003.355812-1-tyhicks@linux.microsoft.com> References: <20220527000003.355812-1-tyhicks@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Decrement the refcount of the parent dentry's fid after walking each path component during a full path walk for a lookup. Failure to do so can lead to fids that are not clunked until the filesystem is unmounted, as indicated by this warning: 9pnet: found fid 3 not clunked The improper refcounting after walking resulted in open(2) returning -EIO on any directories underneath the mount point when using the virtio transport. When using the fd transport, there's no apparent issue until the filesytem is unmounted and the warning above is emitted to the logs. In some cases, the user may not yet be attached to the filesystem and a new root fid, associated with the user, is created and attached to the root dentry before the full path walk is performed. Increment the new root fid's refcount to two in that situation so that it can be safely decremented to one after it is used for the walk operation. The new fid will still be attached to the root dentry when v9fs_fid_lookup_with_uid() returns so a final refcount of one is correct/expected. Fixes: 6636b6dcc3db ("9p: add refcount to p9_fid struct") Cc: stable@vger.kernel.org Signed-off-by: Tyler Hicks Reviewed-by: Christian Schoenebeck --- fs/9p/fid.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/fs/9p/fid.c b/fs/9p/fid.c index 79df61fe0e59..5a469b79c1ee 100644 --- a/fs/9p/fid.c +++ b/fs/9p/fid.c @@ -152,7 +152,7 @@ static struct p9_fid *v9fs_fid_lookup_with_uid(struct d= entry *dentry, const unsigned char **wnames, *uname; int i, n, l, clone, access; struct v9fs_session_info *v9ses; - struct p9_fid *fid, *old_fid =3D NULL; + struct p9_fid *fid, *old_fid; =20 v9ses =3D v9fs_dentry2v9ses(dentry); access =3D v9ses->flags & V9FS_ACCESS_MASK; @@ -194,13 +194,12 @@ static struct p9_fid *v9fs_fid_lookup_with_uid(struct= dentry *dentry, if (IS_ERR(fid)) return fid; =20 + refcount_inc(&fid->count); v9fs_fid_add(dentry->d_sb->s_root, fid); } /* If we are root ourself just return that */ - if (dentry->d_sb->s_root =3D=3D dentry) { - refcount_inc(&fid->count); + if (dentry->d_sb->s_root =3D=3D dentry) return fid; - } /* * Do a multipath walk with attached root. * When walking parent we need to make sure we @@ -212,6 +211,7 @@ static struct p9_fid *v9fs_fid_lookup_with_uid(struct d= entry *dentry, fid =3D ERR_PTR(n); goto err_out; } + old_fid =3D fid; clone =3D 1; i =3D 0; while (i < n) { @@ -221,15 +221,8 @@ static struct p9_fid *v9fs_fid_lookup_with_uid(struct = dentry *dentry, * walk to ensure none of the patch component change */ fid =3D p9_client_walk(fid, l, &wnames[i], clone); + p9_client_clunk(old_fid); if (IS_ERR(fid)) { - if (old_fid) { - /* - * If we fail, clunk fid which are mapping - * to path component and not the last component - * of the path. - */ - p9_client_clunk(old_fid); - } kfree(wnames); goto err_out; } --=20 2.25.1 From nobody Tue Apr 28 23:18:04 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DB21C433EF for ; Fri, 27 May 2022 00:00:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348744AbiE0AAh (ORCPT ); Thu, 26 May 2022 20:00:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231754AbiE0AAa (ORCPT ); Thu, 26 May 2022 20:00:30 -0400 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 046AAFD0F for ; Thu, 26 May 2022 17:00:30 -0700 (PDT) Received: from sequoia.corp.microsoft.com (162-237-133-238.lightspeed.rcsntx.sbcglobal.net [162.237.133.238]) by linux.microsoft.com (Postfix) with ESMTPSA id 41E3B20B87F6; Thu, 26 May 2022 17:00:29 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 41E3B20B87F6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1653609629; bh=8pdt9j0YTn4gITTYumjXbqE/LEAOIMIl+jNZOjh5y9Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bqM8ydfpKp1R2Kwm8m7OBlevH7IJIMHPMoCSE1CaHbLVz/LOzrTju7Ar16s7Emix5 RmZSiXqKjPUnhD8RzfRF61Lt1SR6UQGJ7+C1F9+hczFIgvYrUEckMTPDL0y2chY7Fg AW331OC6buNm2EunSqeYeI0BDWQle8Sp9C9XhHSY= From: Tyler Hicks To: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet Cc: Christian Schoenebeck , Jianyong Wu , v9fs-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/5] 9p: Track the root fid with its own variable during lookups Date: Thu, 26 May 2022 19:00:00 -0500 Message-Id: <20220527000003.355812-3-tyhicks@linux.microsoft.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220527000003.355812-1-tyhicks@linux.microsoft.com> References: <20220527000003.355812-1-tyhicks@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Improve readability by using a new variable when dealing with the root fid. The root fid requires special handling in comparison to other fids used during fid lookup. Signed-off-by: Tyler Hicks --- fs/9p/fid.c | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/fs/9p/fid.c b/fs/9p/fid.c index 5a469b79c1ee..dae276ca7f7a 100644 --- a/fs/9p/fid.c +++ b/fs/9p/fid.c @@ -152,7 +152,7 @@ static struct p9_fid *v9fs_fid_lookup_with_uid(struct d= entry *dentry, const unsigned char **wnames, *uname; int i, n, l, clone, access; struct v9fs_session_info *v9ses; - struct p9_fid *fid, *old_fid; + struct p9_fid *fid, *root_fid, *old_fid; =20 v9ses =3D v9fs_dentry2v9ses(dentry); access =3D v9ses->flags & V9FS_ACCESS_MASK; @@ -178,8 +178,8 @@ static struct p9_fid *v9fs_fid_lookup_with_uid(struct d= entry *dentry, up_read(&v9ses->rename_sem); =20 /* start from the root and try to do a lookup */ - fid =3D v9fs_fid_find(dentry->d_sb->s_root, uid, any); - if (!fid) { + root_fid =3D v9fs_fid_find(dentry->d_sb->s_root, uid, any); + if (!root_fid) { /* the user is not attached to the fs yet */ if (access =3D=3D V9FS_ACCESS_SINGLE) return ERR_PTR(-EPERM); @@ -189,17 +189,18 @@ static struct p9_fid *v9fs_fid_lookup_with_uid(struct= dentry *dentry, else uname =3D v9ses->uname; =20 - fid =3D p9_client_attach(v9ses->clnt, NULL, uname, uid, - v9ses->aname); - if (IS_ERR(fid)) - return fid; + root_fid =3D p9_client_attach(v9ses->clnt, NULL, uname, uid, + v9ses->aname); + if (IS_ERR(root_fid)) + return root_fid; =20 - refcount_inc(&fid->count); - v9fs_fid_add(dentry->d_sb->s_root, fid); + refcount_inc(&root_fid->count); + v9fs_fid_add(dentry->d_sb->s_root, root_fid); } /* If we are root ourself just return that */ if (dentry->d_sb->s_root =3D=3D dentry) - return fid; + return root_fid; + /* * Do a multipath walk with attached root. * When walking parent we need to make sure we @@ -211,7 +212,8 @@ static struct p9_fid *v9fs_fid_lookup_with_uid(struct d= entry *dentry, fid =3D ERR_PTR(n); goto err_out; } - old_fid =3D fid; + fid =3D root_fid; + old_fid =3D root_fid; clone =3D 1; i =3D 0; while (i < n) { @@ -220,7 +222,7 @@ static struct p9_fid *v9fs_fid_lookup_with_uid(struct d= entry *dentry, * We need to hold rename lock when doing a multipath * walk to ensure none of the patch component change */ - fid =3D p9_client_walk(fid, l, &wnames[i], clone); + fid =3D p9_client_walk(old_fid, l, &wnames[i], clone); p9_client_clunk(old_fid); if (IS_ERR(fid)) { kfree(wnames); --=20 2.25.1 From nobody Tue Apr 28 23:18:04 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 184D2C433EF for ; Fri, 27 May 2022 00:00:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349642AbiE0AAm (ORCPT ); Thu, 26 May 2022 20:00:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345134AbiE0AAc (ORCPT ); Thu, 26 May 2022 20:00:32 -0400 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5686D6F494 for ; Thu, 26 May 2022 17:00:31 -0700 (PDT) Received: from sequoia.corp.microsoft.com (162-237-133-238.lightspeed.rcsntx.sbcglobal.net [162.237.133.238]) by linux.microsoft.com (Postfix) with ESMTPSA id 8D85C20B44CF; Thu, 26 May 2022 17:00:30 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8D85C20B44CF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1653609631; bh=va52FY3CxVCP4CDaqya7zxaHqwkN4nQrlRwZnNMAbec=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Zr3h0vZVzjUnKnzcwb3bRT3m50dMDGbnXvq4t+KjgU8ZKb0L9PW3wNg71DoCtZjny rlAsS83qM8837mn79cM6xnxAiFJadS3UADG4sDuga74kS4IQ1/Lr1urFiKM3/kLY1b OCvI6YQ3xrPV0ZHJNHa2LfTmVTu01U3IPteZWL2E= From: Tyler Hicks To: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet Cc: Christian Schoenebeck , Jianyong Wu , v9fs-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/5] 9p: Make the path walk logic more clear about when cloning is required Date: Thu, 26 May 2022 19:00:01 -0500 Message-Id: <20220527000003.355812-4-tyhicks@linux.microsoft.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220527000003.355812-1-tyhicks@linux.microsoft.com> References: <20220527000003.355812-1-tyhicks@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Cloning during a path component walk is only needed when the old fid used for the walk operation is the root fid. Make that clear by comparing the two fids rather than using an additional variable. Signed-off-by: Tyler Hicks --- fs/9p/fid.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/fs/9p/fid.c b/fs/9p/fid.c index dae276ca7f7a..dfe98a308612 100644 --- a/fs/9p/fid.c +++ b/fs/9p/fid.c @@ -150,7 +150,7 @@ static struct p9_fid *v9fs_fid_lookup_with_uid(struct d= entry *dentry, { struct dentry *ds; const unsigned char **wnames, *uname; - int i, n, l, clone, access; + int i, n, l, access; struct v9fs_session_info *v9ses; struct p9_fid *fid, *root_fid, *old_fid; =20 @@ -214,7 +214,6 @@ static struct p9_fid *v9fs_fid_lookup_with_uid(struct d= entry *dentry, } fid =3D root_fid; old_fid =3D root_fid; - clone =3D 1; i =3D 0; while (i < n) { l =3D min(n - i, P9_MAXWELEM); @@ -222,7 +221,8 @@ static struct p9_fid *v9fs_fid_lookup_with_uid(struct d= entry *dentry, * We need to hold rename lock when doing a multipath * walk to ensure none of the patch component change */ - fid =3D p9_client_walk(old_fid, l, &wnames[i], clone); + fid =3D p9_client_walk(old_fid, l, &wnames[i], + old_fid =3D=3D root_fid); p9_client_clunk(old_fid); if (IS_ERR(fid)) { kfree(wnames); @@ -230,7 +230,6 @@ static struct p9_fid *v9fs_fid_lookup_with_uid(struct d= entry *dentry, } old_fid =3D fid; i +=3D l; - clone =3D 0; } kfree(wnames); fid_out: --=20 2.25.1 From nobody Tue Apr 28 23:18:04 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B93BBC433F5 for ; Fri, 27 May 2022 00:00:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237350AbiE0AAt (ORCPT ); Thu, 26 May 2022 20:00:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346078AbiE0AAd (ORCPT ); Thu, 26 May 2022 20:00:33 -0400 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7F64A3617A for ; Thu, 26 May 2022 17:00:32 -0700 (PDT) Received: from sequoia.corp.microsoft.com (162-237-133-238.lightspeed.rcsntx.sbcglobal.net [162.237.133.238]) by linux.microsoft.com (Postfix) with ESMTPSA id BF81420B5B4E; Thu, 26 May 2022 17:00:31 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com BF81420B5B4E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1653609632; bh=WyWhT64EqXgi1j+9Im254CVOA49spwfGfom1V/BOPbU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bIse+ow20K7BpanHXQ49cUZmR92pHLe3BfWwyAAZ4EsY5q37ymkoDSmdVFd0TvL/Q K7+e+3sGrdKft2U3/DDB9FKWl2dsfSbjIjli2TdTUUtdC4j6TKNc4R5zav4yirSfco AMuyahFc8Kx/YQEStqu6yesnJ0mDPPL8jhvkZp6c= From: Tyler Hicks To: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet Cc: Christian Schoenebeck , Jianyong Wu , v9fs-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/5] 9p: Remove unnecessary variable for old fids while walking from d_parent Date: Thu, 26 May 2022 19:00:02 -0500 Message-Id: <20220527000003.355812-5-tyhicks@linux.microsoft.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220527000003.355812-1-tyhicks@linux.microsoft.com> References: <20220527000003.355812-1-tyhicks@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove the ofid variable that's local to the conditional block in favor of the old_fid variable that's local to the entire function. Signed-off-by: Tyler Hicks --- fs/9p/fid.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/9p/fid.c b/fs/9p/fid.c index dfe98a308612..d8c70c4cd3c2 100644 --- a/fs/9p/fid.c +++ b/fs/9p/fid.c @@ -169,10 +169,10 @@ static struct p9_fid *v9fs_fid_lookup_with_uid(struct= dentry *dentry, fid =3D v9fs_fid_find(ds, uid, any); if (fid) { /* Found the parent fid do a lookup with that */ - struct p9_fid *ofid =3D fid; + old_fid =3D fid; =20 - fid =3D p9_client_walk(ofid, 1, &dentry->d_name.name, 1); - p9_client_clunk(ofid); + fid =3D p9_client_walk(old_fid, 1, &dentry->d_name.name, 1); + p9_client_clunk(old_fid); goto fid_out; } up_read(&v9ses->rename_sem); --=20 2.25.1 From nobody Tue Apr 28 23:18:04 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 475A2C433F5 for ; Fri, 27 May 2022 00:00:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348665AbiE0AAv (ORCPT ); Thu, 26 May 2022 20:00:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347846AbiE0AAe (ORCPT ); Thu, 26 May 2022 20:00:34 -0400 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E28586F494 for ; Thu, 26 May 2022 17:00:33 -0700 (PDT) Received: from sequoia.corp.microsoft.com (162-237-133-238.lightspeed.rcsntx.sbcglobal.net [162.237.133.238]) by linux.microsoft.com (Postfix) with ESMTPSA id 2B59520B894E; Thu, 26 May 2022 17:00:33 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2B59520B894E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1653609633; bh=yXi1WGiCy9BLSBAV0/nUcn1Q6XY2f9IytAcNKCT0ldE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JPVlWctq92O8hM0R654SAHPmKsSHY42k7UK+R1Rle+ZGMvFRyNcjnfqnzJKwC7FtB IbibTty/LulnMDsB3fPAXu/X7sEGoO3s2gjZEboI8+ovK9BxzBki6QaJKvfgzP4Kh3 NtA+AMKQofdBs/1vvF9gadI0Cj0uuRGg1kjmHGnU= From: Tyler Hicks To: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet Cc: Christian Schoenebeck , Jianyong Wu , v9fs-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/5] 9p: Fix minor typo in code comment Date: Thu, 26 May 2022 19:00:03 -0500 Message-Id: <20220527000003.355812-6-tyhicks@linux.microsoft.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220527000003.355812-1-tyhicks@linux.microsoft.com> References: <20220527000003.355812-1-tyhicks@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix s/patch/path/ typo and make it clear that we're talking about multiple path components. Signed-off-by: Tyler Hicks --- fs/9p/fid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/9p/fid.c b/fs/9p/fid.c index d8c70c4cd3c2..60fc62081598 100644 --- a/fs/9p/fid.c +++ b/fs/9p/fid.c @@ -219,7 +219,7 @@ static struct p9_fid *v9fs_fid_lookup_with_uid(struct d= entry *dentry, l =3D min(n - i, P9_MAXWELEM); /* * We need to hold rename lock when doing a multipath - * walk to ensure none of the patch component change + * walk to ensure none of the path components change */ fid =3D p9_client_walk(old_fid, l, &wnames[i], old_fid =3D=3D root_fid); --=20 2.25.1