From nobody Tue May 5 10:06:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBD69C433EF for ; Wed, 25 May 2022 13:32:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233289AbiEYNcO (ORCPT ); Wed, 25 May 2022 09:32:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241594AbiEYNcN (ORCPT ); Wed, 25 May 2022 09:32:13 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70D7F222B6 for ; Wed, 25 May 2022 06:32:10 -0700 (PDT) Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id D7D0F3F1F1 for ; Wed, 25 May 2022 13:32:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1653485528; bh=gdKfbm5VrhgrnmDEpSvU9Ypgfgpc8pgNQoJ/q4vbTi8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RxNYuX6y4zgISvPtV6NT1hteh5hbQ9wJKcr+mcDMMnR8tjP00krgB6MdJCrLg4nzy IiwCncZNn3fSKKC2t/DnUnVcP5EhjxJupV0LYEyP3m9EeNZWxzxyFC4K5xlfC5zkdh juKXoXzeMnsxpTMhWEmhlLxMQO3yPhf8l+FPCpWtV53d3wF1N7DhEQIHV+BLPpy7CM uOlg05N5JGBT8shYXJLgf48vt3+018aFv2cMhNUeTKf28cTwLE7U3IALNqjQeUNCZ5 PT20ZQKRrj5ZYgFu1UoyCFWEg88+N6uAg5RpkJityx7MEY7n/atU71hQ+XEXrARcJd K60IXCuQGO/3Q== Received: by mail-ej1-f70.google.com with SMTP id b17-20020a170906491100b006feec47b64bso4502457ejq.5 for ; Wed, 25 May 2022 06:32:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gdKfbm5VrhgrnmDEpSvU9Ypgfgpc8pgNQoJ/q4vbTi8=; b=Vq7b5Gh2v3L0dI2HMrosCEfdwc2jjlcNBWLKeHqnSmQCgS/aPSUPi6uiAv1gu389lU i32KQnOGqghHodTlKVUo/XeWUYk6OaiOCtuCiWnmiJaOEhAMp3hjawlqhCse3ka5MJaK BFaaHmIoDv8u5O0CB5ShvypDWJV3sDFskkoqnZ3CHiHJSBt8uORkWvs4BsW3cf9ONAuL eY5mI1jJudEkZsp7MzPRIt6WWwZ0dUlJGXzbSLMw8++T2ajkvGMOibOiASEjxAKqHsRB faTA8BzOL+L2ITveFldp21qeC/XgK9XoR6a+uYlUo67wcBHm9sXs3CX8IOnKZf9JjTta pMlg== X-Gm-Message-State: AOAM53379Eyj74X+KeftXyBGETKuCO7sf2EsJTjkWVyaSOhJA2doM/BT KtsGmNNQ0xyyrlIkxZ5MYQa+XwZCOWKeTSEqH8OdFfWJX7a4brbVqIYNx0R6kgoaXMOTqhkLRBd rOsmCr+smbbyEDh8hGPz7c/T8A1ZnBGgJlOV1CpHyew== X-Received: by 2002:a05:6402:524d:b0:42a:f9e9:8013 with SMTP id t13-20020a056402524d00b0042af9e98013mr33748886edd.65.1653485528212; Wed, 25 May 2022 06:32:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzW/RCoTC7mCQWghNsaJYwSF/8hyQOg5CnOjXvHQm9LCGqC8/uaECRQJacSz56iPGytG9buew== X-Received: by 2002:a05:6402:524d:b0:42a:f9e9:8013 with SMTP id t13-20020a056402524d00b0042af9e98013mr33748859edd.65.1653485527886; Wed, 25 May 2022 06:32:07 -0700 (PDT) Received: from gollum.fritz.box ([194.191.244.86]) by smtp.gmail.com with ESMTPSA id d8-20020a17090694c800b006fe9209a9edsm3723388ejy.128.2022.05.25.06.32.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 May 2022 06:32:07 -0700 (PDT) From: Juerg Haefliger To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com Cc: linux-kernel@vger.kernel.org, Juerg Haefliger Subject: [PATCH 1/2] x86: Kconfig: Fix indentation and add endif comments Date: Wed, 25 May 2022 15:32:02 +0200 Message-Id: <20220525133203.52463-2-juerg.haefliger@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220525133203.52463-1-juerg.haefliger@canonical.com> References: <20220525133203.52463-1-juerg.haefliger@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The convention for indentation seems to be a single tab. Help text is further indented by an additional two whitespaces. Fix the lines that violate these rules. While add it, add missing trailing endif comments and squeeze multiple empty lines. Signed-off-by: Juerg Haefliger --- arch/x86/Kconfig | 101 +++++++++++++++++++++++------------------------ 1 file changed, 49 insertions(+), 52 deletions(-) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 4bed3abf444d..edfc4bad6f16 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -41,11 +41,11 @@ config FORCE_DYNAMIC_FTRACE depends on FUNCTION_TRACER select DYNAMIC_FTRACE help - We keep the static function tracing (!DYNAMIC_FTRACE) around - in order to test the non static function tracing in the - generic code, as other architectures still use it. But we - only need to keep it around for x86_64. No need to keep it - for x86_32. For x86_32, force DYNAMIC_FTRACE.=20 + We keep the static function tracing (!DYNAMIC_FTRACE) around + in order to test the non static function tracing in the + generic code, as other architectures still use it. But we + only need to keep it around for x86_64. No need to keep it + for x86_32. For x86_32, force DYNAMIC_FTRACE. # # Arch settings # @@ -389,9 +389,9 @@ config CC_HAS_SANE_STACKPROTECTOR default $(success,$(srctree)/scripts/gcc-x86_64-has-stack-protector.sh $(= CC)) if 64BIT default $(success,$(srctree)/scripts/gcc-x86_32-has-stack-protector.sh $(= CC)) help - We have to make sure stack protector is unconditionally disabled if - the compiler produces broken code or if it does not let us control - the segment on 32-bit kernels. + We have to make sure stack protector is unconditionally disabled if + the compiler produces broken code or if it does not let us control + the segment on 32-bit kernels. =20 menu "Processor type and features" =20 @@ -525,7 +525,7 @@ config X86_EXTENDED_PLATFORM =20 If you have one of these systems, or if you want to build a generic distribution kernel, say Y here - otherwise say N. -endif +endif # X86_32 =20 if X86_64 config X86_EXTENDED_PLATFORM @@ -544,7 +544,7 @@ config X86_EXTENDED_PLATFORM =20 If you have one of these systems, or if you want to build a generic distribution kernel, say Y here - otherwise say N. -endif +endif # X86_64 # This is an alphabetically sorted list of 64 bit extended platforms # Please maintain the alphabetic order if and when there are additions config X86_NUMACHIP @@ -592,9 +592,9 @@ config X86_GOLDFISH bool "Goldfish (Virtual Platform)" depends on X86_EXTENDED_PLATFORM help - Enable support for the Goldfish virtual platform used primarily - for Android development. Unless you are building for the Android - Goldfish emulator say N here. + Enable support for the Goldfish virtual platform used primarily + for Android development. Unless you are building for the Android + Goldfish emulator say N here. =20 config X86_INTEL_CE bool "CE4100 TV platform" @@ -878,7 +878,7 @@ config ACRN_GUEST IOT with small footprint and real-time features. More details can be found in https://projectacrn.org/. =20 -endif #HYPERVISOR_GUEST +endif # HYPERVISOR_GUEST =20 source "arch/x86/Kconfig.cpu" =20 @@ -1139,16 +1139,16 @@ config X86_MCE_INTEL prompt "Intel MCE features" depends on X86_MCE && X86_LOCAL_APIC help - Additional support for intel specific MCE features such as - the thermal monitor. + Additional support for intel specific MCE features such as + the thermal monitor. =20 config X86_MCE_AMD def_bool y prompt "AMD MCE features" depends on X86_MCE && X86_LOCAL_APIC && AMD_NB help - Additional support for AMD specific MCE features such as - the DRAM Error Threshold. + Additional support for AMD specific MCE features such as + the DRAM Error Threshold. =20 config X86_ANCIENT_MCE bool "Support for old Pentium 5 / WinChip machine checks" @@ -1226,18 +1226,18 @@ config X86_VSYSCALL_EMULATION default y depends on X86_64 help - This enables emulation of the legacy vsyscall page. Disabling - it is roughly equivalent to booting with vsyscall=3Dnone, except - that it will also disable the helpful warning if a program - tries to use a vsyscall. With this option set to N, offending - programs will just segfault, citing addresses of the form - 0xffffffffff600?00. + This enables emulation of the legacy vsyscall page. Disabling + it is roughly equivalent to booting with vsyscall=3Dnone, except + that it will also disable the helpful warning if a program + tries to use a vsyscall. With this option set to N, offending + programs will just segfault, citing addresses of the form + 0xffffffffff600?00. =20 - This option is required by many programs built before 2013, and - care should be used even with newer programs if set to N. + This option is required by many programs built before 2013, and + care should be used even with newer programs if set to N. =20 - Disabling this option saves about 7K of kernel size and - possibly 4K of additional runtime pagetable memory. + Disabling this option saves about 7K of kernel size and + possibly 4K of additional runtime pagetable memory. =20 config X86_IOPL_IOPERM bool "IOPERM and IOPL Emulation" @@ -1984,15 +1984,15 @@ config EFI_MIXED bool "EFI mixed-mode support" depends on EFI_STUB && X86_64 help - Enabling this feature allows a 64-bit kernel to be booted - on a 32-bit firmware, provided that your CPU supports 64-bit - mode. + Enabling this feature allows a 64-bit kernel to be booted + on a 32-bit firmware, provided that your CPU supports 64-bit + mode. =20 - Note that it is not possible to boot a mixed-mode enabled - kernel via the EFI boot stub - a bootloader that supports - the EFI handover protocol must be used. + Note that it is not possible to boot a mixed-mode enabled + kernel via the EFI boot stub - a bootloader that supports + the EFI handover protocol must be used. =20 - If unsure, say N. + If unsure, say N. =20 source "kernel/Kconfig.hz" =20 @@ -2217,16 +2217,16 @@ config RANDOMIZE_MEMORY select DYNAMIC_MEMORY_LAYOUT default RANDOMIZE_BASE help - Randomizes the base virtual address of kernel memory sections - (physical memory mapping, vmalloc & vmemmap). This security feature - makes exploits relying on predictable memory locations less reliable. + Randomizes the base virtual address of kernel memory sections + (physical memory mapping, vmalloc & vmemmap). This security feature + makes exploits relying on predictable memory locations less reliable. =20 - The order of allocations remains unchanged. Entropy is generated in - the same way as RANDOMIZE_BASE. Current implementation in the optimal - configuration have in average 30,000 different possible virtual - addresses for each memory section. + The order of allocations remains unchanged. Entropy is generated in + the same way as RANDOMIZE_BASE. Current implementation in the optimal + configuration have in average 30,000 different possible virtual + addresses for each memory section. =20 - If unsure, say Y. + If unsure, say Y. =20 config RANDOMIZE_MEMORY_PHYSICAL_PADDING hex "Physical memory mapping padding" if EXPERT @@ -2236,12 +2236,12 @@ config RANDOMIZE_MEMORY_PHYSICAL_PADDING range 0x1 0x40 if MEMORY_HOTPLUG range 0x0 0x40 help - Define the padding in terabytes added to the existing physical - memory size during kernel memory randomization. It is useful - for memory hotplug support but reduces the entropy available for - address randomization. + Define the padding in terabytes added to the existing physical + memory size during kernel memory randomization. It is useful + for memory hotplug support but reduces the entropy available for + address randomization. =20 - If unsure, leave at the default value. + If unsure, leave at the default value. =20 config HOTPLUG_CPU def_bool y @@ -2600,7 +2600,6 @@ source "drivers/idle/Kconfig" =20 endmenu =20 - menu "Bus options (PCI etc.)" =20 choice @@ -2824,7 +2823,6 @@ config AMD_NB =20 endmenu =20 - menu "Binary Emulations" =20 config IA32_EMULATION @@ -2876,11 +2874,10 @@ config COMPAT_FOR_U64_ALIGNMENT config SYSVIPC_COMPAT def_bool y depends on SYSVIPC -endif +endif # COMPAT =20 endmenu =20 - config HAVE_ATOMIC_IOMAP def_bool y depends on X86_32 --=20 2.32.0 From nobody Tue May 5 10:06:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D264DC433EF for ; Wed, 25 May 2022 13:32:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244319AbiEYNcT (ORCPT ); Wed, 25 May 2022 09:32:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236688AbiEYNcN (ORCPT ); Wed, 25 May 2022 09:32:13 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C318C3617D for ; Wed, 25 May 2022 06:32:10 -0700 (PDT) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 84F923F21C for ; Wed, 25 May 2022 13:32:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1653485529; bh=i0RFprlZ3Fo6m7naiO4awQduRTjU0yke/zLoaLjegbM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=q85ujQTAyDocWeFGNr8FcDq6MwLQMKyvqhVhCDOj7h0WNpJv/lMweAQXKKw+YmItx Rs6U6UiDdNTmPyTC1fNwXS/eukjXFTnN2HWHwKFpXtrDz4k6X318b2qu8WlCuRwHD8 TWMrDlqFjlRGkhg81uI7iiDqi9yWwWuUzl3zZ1uJEksqS3bG80aYJas+98uL2nVJhK cdj4ZMIMn2jqonpBjaOh1GRt1+q7dZ8yxfRHS9QtC5xvFdqC4YK9zKiq/vRRPINdll xlSZNPkvIaUSfygwiOUY6WYzf8Rna7Lj5j+06jDiaKjm/XRiUL134HTmlPH7GGwvKd 6SpK9oPR53PAA== Received: by mail-ed1-f69.google.com with SMTP id y10-20020aa7ce8a000000b0042bc52fb825so1844030edv.8 for ; Wed, 25 May 2022 06:32:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i0RFprlZ3Fo6m7naiO4awQduRTjU0yke/zLoaLjegbM=; b=G9NBcKTlLWlPNIba1LMCJS2LqiCPC3sg6jLmYr3z0Iv8yPE4il7W1YV2a9Een1x2Xa /QCRuXyjDcGg9+WDLgP/wqwJwzAl3SPh5oyOy7lm0eP0wpQ0wyg1BzbKrLaM8mqDhxAD Ky7ONkhTK38aa8WZ0jlMCrsxfL0ekrCWZ3F1fVlZOr68Xnjmwa9sea6+6ksxiEr70HXU F2O+ZJfTDr7aJkIJYAFpJaw1d2E7uFjy6N4DR3cb+qaiASaNMe03sh/KVzTDuFT26e/4 9Bn4MudetmKyONGZ4EHO7q71yquYcZuD3ru3E7zqw0Gxq1SvwstqlysFRYeKlaiA9oW3 S8LQ== X-Gm-Message-State: AOAM530EIC4GMfzexjDvKkQ45pyJ7jVRUlfJhCFOVldYDHhBCbsbgqfb TjpXf3HBW4pqiH1Q/NQz5HepiogIpS3n5qm8wmS9W4xMI5HGJa+jo7S8b4xfUTwIUu6xs/I+/Nr zUJ5XgXSafJCKNxdSPNil+EM3ETowjTXwwUEx34DcvA== X-Received: by 2002:a17:906:264d:b0:6fe:a134:59ae with SMTP id i13-20020a170906264d00b006fea13459aemr25993831ejc.56.1653485529249; Wed, 25 May 2022 06:32:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8x03FV6N2+ui4WnSukERN88yTSrtZWjeRTUi+pWnHPjJuyBdDJIg0FoG1l9Zb4HddLtnEqQ== X-Received: by 2002:a17:906:264d:b0:6fe:a134:59ae with SMTP id i13-20020a170906264d00b006fea13459aemr25993811ejc.56.1653485529026; Wed, 25 May 2022 06:32:09 -0700 (PDT) Received: from gollum.fritz.box ([194.191.244.86]) by smtp.gmail.com with ESMTPSA id d8-20020a17090694c800b006fe9209a9edsm3723388ejy.128.2022.05.25.06.32.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 May 2022 06:32:08 -0700 (PDT) From: Juerg Haefliger To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com Cc: linux-kernel@vger.kernel.org, Juerg Haefliger Subject: [PATCH 2/2] x86: Kconfig.debug: Fix indentation Date: Wed, 25 May 2022 15:32:03 +0200 Message-Id: <20220525133203.52463-3-juerg.haefliger@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220525133203.52463-1-juerg.haefliger@canonical.com> References: <20220525133203.52463-1-juerg.haefliger@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The convention for indentation seems to be a single tab. Help text is further indented by an additional two whitespaces. Fix the lines that violate these rules. Signed-off-by: Juerg Haefliger --- arch/x86/Kconfig.debug | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug index d3a6f74a94bd..7fec55aab367 100644 --- a/arch/x86/Kconfig.debug +++ b/arch/x86/Kconfig.debug @@ -73,20 +73,19 @@ config DEBUG_TLBFLUSH bool "Set upper limit of TLB entries to flush one-by-one" depends on DEBUG_KERNEL help + X86-only for now. =20 - X86-only for now. + This option allows the user to tune the amount of TLB entries the + kernel flushes one-by-one instead of doing a full TLB flush. In + certain situations, the former is cheaper. This is controlled by the + tlb_flushall_shift knob under /sys/kernel/debug/x86. If you set it + to -1, the code flushes the whole TLB unconditionally. Otherwise, + for positive values of it, the kernel will use single TLB entry + invalidating instructions according to the following formula: =20 - This option allows the user to tune the amount of TLB entries the - kernel flushes one-by-one instead of doing a full TLB flush. In - certain situations, the former is cheaper. This is controlled by the - tlb_flushall_shift knob under /sys/kernel/debug/x86. If you set it - to -1, the code flushes the whole TLB unconditionally. Otherwise, - for positive values of it, the kernel will use single TLB entry - invalidating instructions according to the following formula: + flush_entries <=3D active_tlb_entries / 2^tlb_flushall_shift =20 - flush_entries <=3D active_tlb_entries / 2^tlb_flushall_shift - - If in doubt, say "N". + If in doubt, say "N". =20 config IOMMU_DEBUG bool "Enable IOMMU debugging" @@ -119,10 +118,10 @@ config X86_DECODER_SELFTEST depends on DEBUG_KERNEL && INSTRUCTION_DECODER depends on !COMPILE_TEST help - Perform x86 instruction decoder selftests at build time. - This option is useful for checking the sanity of x86 instruction - decoder code. - If unsure, say "N". + Perform x86 instruction decoder selftests at build time. + This option is useful for checking the sanity of x86 instruction + decoder code. + If unsure, say "N". =20 choice prompt "IO delay type" --=20 2.32.0