From nobody Sat Feb 7 20:58:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C6FFC433F5 for ; Mon, 23 May 2022 17:09:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231777AbiEWRJE (ORCPT ); Mon, 23 May 2022 13:09:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239562AbiEWRH6 (ORCPT ); Mon, 23 May 2022 13:07:58 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 400185BE5F; Mon, 23 May 2022 10:07:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A0A84B81201; Mon, 23 May 2022 17:07:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06EC4C385A9; Mon, 23 May 2022 17:07:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1653325671; bh=0naOMxH3Ws/cN6Gr0znKiOXtUMhUhuBDe3no0f3cIO8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZHEsn36XfNd1dCLzp9rC0Fmi1jVRcR0QBf0HA6qfGGsc8JdZAKBTgrc3MLT9Irfmy WmcB2SPHGkxAM4Bp2vgQBhyBIHvBb20eeSnu/OTVp6dSmIPuwRBkl4H4OBcHJA2+Kf 1AoCMhHRqkScm3/PoweB3oJG1uISRP+rN8Pbwh+M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zheng Yongjun , Dmitry Torokhov , Sasha Levin Subject: [PATCH 4.14 04/33] Input: stmfts - fix reference leak in stmfts_input_open Date: Mon, 23 May 2022 19:04:53 +0200 Message-Id: <20220523165747.818755611@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220523165746.957506211@linuxfoundation.org> References: <20220523165746.957506211@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Zheng Yongjun [ Upstream commit 26623eea0da3476446909af96c980768df07bbd9 ] pm_runtime_get_sync() will increment pm usage counter even it failed. Forgetting to call pm_runtime_put_noidle will result in reference leak in stmfts_input_open, so we should fix it. Signed-off-by: Zheng Yongjun Link: https://lore.kernel.org/r/20220317131604.53538-1-zhengyongjun3@huawei= .com Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin Reported-by: Pavel Machek Reviewed-by: Pavel Machek --- drivers/input/touchscreen/stmfts.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen= /stmfts.c index d9e93dabbca2..9007027a7ad9 100644 --- a/drivers/input/touchscreen/stmfts.c +++ b/drivers/input/touchscreen/stmfts.c @@ -344,11 +344,11 @@ static int stmfts_input_open(struct input_dev *dev) =20 err =3D pm_runtime_get_sync(&sdata->client->dev); if (err < 0) - return err; + goto out; =20 err =3D i2c_smbus_write_byte(sdata->client, STMFTS_MS_MT_SENSE_ON); if (err) - return err; + goto out; =20 mutex_lock(&sdata->mutex); sdata->running =3D true; @@ -371,7 +371,9 @@ static int stmfts_input_open(struct input_dev *dev) "failed to enable touchkey\n"); } =20 - return 0; +out: + pm_runtime_put_noidle(&sdata->client->dev); + return err; } =20 static void stmfts_input_close(struct input_dev *dev) --=20 2.35.1