From nobody Mon Feb 9 19:05:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04672C433F5 for ; Mon, 23 May 2022 16:43:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239080AbiEWQnO (ORCPT ); Mon, 23 May 2022 12:43:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239036AbiEWQmq (ORCPT ); Mon, 23 May 2022 12:42:46 -0400 Received: from mail.sberdevices.ru (mail.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DBE54E38A; Mon, 23 May 2022 09:42:43 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mail.sberdevices.ru (Postfix) with ESMTP id 77E875FD06; Mon, 23 May 2022 19:42:41 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1653324161; bh=w/y5zGWnbhdYZDEscTtuIwfMTZyMSOtuJte/1COxFRY=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=R88Y2klDr/jzLfIgF1GgppV20nN2WwPkvmuegPEiMrgi74ZtgIBL4DnMXzCcmy6ft RE9bLC571xhw72hFIj601gLmP3TQj3g5EFlZDCQxz7KAGBZ701UjjNA+r6eUIgXUmV wC8UBLILDDzk0SIZL0pA703r9j5+/WhE8R7t8mxKP9L/TSbj3iUj6CgN/UKSESk+zk AkEYmeJ4MfNcYo+6f/YaEqckI660XG75RqbxS2dIpTQJoNxW9MwOSd3K7bIi6fdcO3 x5AdDEN0N/+ZdIe6RdUHds9WG80BCuElaRPdMEtwaG570bS2gcwFWAQ6NUtd6DHdG9 0lbFdeU/Dcpfw== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mail.sberdevices.ru (Postfix) with ESMTP; Mon, 23 May 2022 19:42:41 +0300 (MSK) From: Dmitry Rokosov To: "robh+dt@kernel.org" , "jic23@kernel.org" , "lars@metafoo.de" , "andy.shevchenko@gmail.com" , "lorenzo.bianconi83@gmail.com" , "linus.walleij@linaro.org" , "stephan@gerhold.net" , "hdegoede@redhat.com" , "antoniu.miclaus@analog.com" , "sean@geanix.com" , "linmq006@gmail.com" , "gwendal@chromium.org" , "yangyingliang@huawei.com" CC: "linux-iio@vger.kernel.org" , kernel , "linux-kernel@vger.kernel.org" , Dmitry Rokosov Subject: [PATCH v1 3/5] iio:accel:mxc4005: rearrange iio trigger get and register Thread-Topic: [PATCH v1 3/5] iio:accel:mxc4005: rearrange iio trigger get and register Thread-Index: AQHYbsP/RY3VWwUPpUGH4PpJIfrW1w== Date: Mon, 23 May 2022 16:41:48 +0000 Message-ID: <20220523164159.11579-4-ddrokosov@sberdevices.ru> References: <20220523164159.11579-1-ddrokosov@sberdevices.ru> In-Reply-To: <20220523164159.11579-1-ddrokosov@sberdevices.ru> Accept-Language: ru-RU, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.1.12] Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/05/23 07:03:00 #19535618 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" IIO trigger interface function iio_trigger_get() should be called after iio_trigger_register() (or its devm analogue) strictly, because of iio_trigger_get() acquires module refcnt based on the trigger->owner pointer, which is initialized inside iio_trigger_register() to THIS_MODULE. If this call order is wrong, the next iio_trigger_put() (from sysfs callbacks or rmmod) will derefence "default" module refcnt, which is completely incorrect. Signed-off-by: Dmitry Rokosov --- drivers/iio/accel/mxc4005.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/accel/mxc4005.c b/drivers/iio/accel/mxc4005.c index b3afbf064915..df600d2917c0 100644 --- a/drivers/iio/accel/mxc4005.c +++ b/drivers/iio/accel/mxc4005.c @@ -456,8 +456,6 @@ static int mxc4005_probe(struct i2c_client *client, =20 data->dready_trig->ops =3D &mxc4005_trigger_ops; iio_trigger_set_drvdata(data->dready_trig, indio_dev); - indio_dev->trig =3D data->dready_trig; - iio_trigger_get(indio_dev->trig); ret =3D devm_iio_trigger_register(&client->dev, data->dready_trig); if (ret) { @@ -465,6 +463,8 @@ static int mxc4005_probe(struct i2c_client *client, "failed to register trigger\n"); return ret; } + + indio_dev->trig =3D iio_trigger_get(data->dready_trig); } =20 return devm_iio_device_register(&client->dev, indio_dev); --=20 2.36.0