From nobody Sat May 4 01:35:13 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E52F1C4332F for ; Mon, 23 May 2022 16:43:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239076AbiEWQnA (ORCPT ); Mon, 23 May 2022 12:43:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239037AbiEWQmo (ORCPT ); Mon, 23 May 2022 12:42:44 -0400 Received: from mail.sberdevices.ru (mail.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 587CE3D48B; Mon, 23 May 2022 09:42:38 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mail.sberdevices.ru (Postfix) with ESMTP id 7A6F95FD04; Mon, 23 May 2022 19:42:36 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1653324156; bh=Kl/LSb63JUbK7RNoRz5YxXT/uLNq4eHfyU1b6BkWGiA=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=lubK/Kr5l+WqSq9qU0UbBAsKinbOj0AXCtpnJEFQ7WdL9k7HrPNctmqUveItogTMp Q7iy/YCajNNMCdUGUGkNFmlggIWafW8/R5T1Y3iGQqRRpk3kwrV042XRJwK10SvTaI qAY7cAMf4F6Mi+qoVAXZxoc7vCuxqwDCaBA4U4J/gStZ+n4T+5o06u9deeKw8CaUu9 nETlUfNnWUbUnmavRToRikNR6j0WutU6CwKEx/g3PWPDXRayquySfCJhaf5kV5kgaT kLiVF/IQP5Xo+96X5bXHodPVV/03q7cjmD56VGb1thPextGGqPehmVK98YBHyZqxKG s1Ix57/pmhQRw== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mail.sberdevices.ru (Postfix) with ESMTP; Mon, 23 May 2022 19:42:36 +0300 (MSK) From: Dmitry Rokosov To: "robh+dt@kernel.org" , "jic23@kernel.org" , "lars@metafoo.de" , "andy.shevchenko@gmail.com" , "lorenzo.bianconi83@gmail.com" , "linus.walleij@linaro.org" , "stephan@gerhold.net" , "hdegoede@redhat.com" , "antoniu.miclaus@analog.com" , "sean@geanix.com" , "linmq006@gmail.com" , "gwendal@chromium.org" , "yangyingliang@huawei.com" CC: "linux-iio@vger.kernel.org" , kernel , "linux-kernel@vger.kernel.org" , Dmitry Rokosov Subject: [PATCH v1 1/5] iio:accel:bma180: rearrange iio trigger get and register Thread-Topic: [PATCH v1 1/5] iio:accel:bma180: rearrange iio trigger get and register Thread-Index: AQHYbsP7kN5hXajN3UGcLxONjVhDxQ== Date: Mon, 23 May 2022 16:41:43 +0000 Message-ID: <20220523164159.11579-2-ddrokosov@sberdevices.ru> References: <20220523164159.11579-1-ddrokosov@sberdevices.ru> In-Reply-To: <20220523164159.11579-1-ddrokosov@sberdevices.ru> Accept-Language: ru-RU, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.1.12] Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/05/23 07:03:00 #19535618 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" IIO trigger interface function iio_trigger_get() should be called after iio_trigger_register() (or its devm analogue) strictly, because of iio_trigger_get() acquires module refcnt based on the trigger->owner pointer, which is initialized inside iio_trigger_register() to THIS_MODULE. If this call order is wrong, the next iio_trigger_put() (from sysfs callbacks or rmmod) will derefence "default" module refcnt, which is completely incorrect. Signed-off-by: Dmitry Rokosov --- drivers/iio/accel/bma180.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c index d8a454c266d5..5d0bd0fc3018 100644 --- a/drivers/iio/accel/bma180.c +++ b/drivers/iio/accel/bma180.c @@ -1006,11 +1006,12 @@ static int bma180_probe(struct i2c_client *client, =20 data->trig->ops =3D &bma180_trigger_ops; iio_trigger_set_drvdata(data->trig, indio_dev); - indio_dev->trig =3D iio_trigger_get(data->trig); =20 ret =3D iio_trigger_register(data->trig); if (ret) goto err_trigger_free; + + indio_dev->trig =3D iio_trigger_get(data->trig); } =20 ret =3D iio_triggered_buffer_setup(indio_dev, NULL, --=20 2.36.0 From nobody Sat May 4 01:35:13 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E8DBC433F5 for ; Mon, 23 May 2022 16:43:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239062AbiEWQnH (ORCPT ); Mon, 23 May 2022 12:43:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239041AbiEWQmo (ORCPT ); Mon, 23 May 2022 12:42:44 -0400 Received: from mail.sberdevices.ru (mail.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 252A6EF; Mon, 23 May 2022 09:42:42 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mail.sberdevices.ru (Postfix) with ESMTP id 738B75FD05; Mon, 23 May 2022 19:42:40 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1653324160; bh=KSNN3/SNVVoMLQgBH67pg26wUu1UyA2zzxxh/p/8KWk=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=sAvZdvCEZDnGLrdkGMijlJyGRcX3vOOJ+KKH1sddY2eE1fFw1xvrFErxiyfQIbyqm usKxK/aO10ku67HtDHTEPpqmDVMqVcaJGo/tFQMlhlTasfUsr5dg9WYEM2+mQIsrhE FB6zPuzcXmHQC3wmwF1W4nkkN6/eAB+HSLzmvhLAJQLBUZaXCYMgAGjJHXknaYoLMv wtAL9T1aRwB7bjI8XEAPtCFNmIDRslOtAwN5n/1IjZG9IPWvpB7F+JGV7U5CXOJQ/8 uuVIB1XPuwUBA5w547S6nDeh201NX7zXUnuahxnqKxk+DaAIOccuNOjGk6tNRinIdk bJI9+dBpiym8Q== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mail.sberdevices.ru (Postfix) with ESMTP; Mon, 23 May 2022 19:42:40 +0300 (MSK) From: Dmitry Rokosov To: "robh+dt@kernel.org" , "jic23@kernel.org" , "lars@metafoo.de" , "andy.shevchenko@gmail.com" , "lorenzo.bianconi83@gmail.com" , "linus.walleij@linaro.org" , "stephan@gerhold.net" , "hdegoede@redhat.com" , "antoniu.miclaus@analog.com" , "sean@geanix.com" , "linmq006@gmail.com" , "gwendal@chromium.org" , "yangyingliang@huawei.com" CC: "linux-iio@vger.kernel.org" , kernel , "linux-kernel@vger.kernel.org" , Dmitry Rokosov Subject: [PATCH v1 2/5] iio:accel:kxcjk-1013: rearrange iio trigger get and register Thread-Topic: [PATCH v1 2/5] iio:accel:kxcjk-1013: rearrange iio trigger get and register Thread-Index: AQHYbsP+NLTBqMK3pECmP2jvyza5WA== Date: Mon, 23 May 2022 16:41:47 +0000 Message-ID: <20220523164159.11579-3-ddrokosov@sberdevices.ru> References: <20220523164159.11579-1-ddrokosov@sberdevices.ru> In-Reply-To: <20220523164159.11579-1-ddrokosov@sberdevices.ru> Accept-Language: ru-RU, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.1.12] Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/05/23 07:03:00 #19535618 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" IIO trigger interface function iio_trigger_get() should be called after iio_trigger_register() (or its devm analogue) strictly, because of iio_trigger_get() acquires module refcnt based on the trigger->owner pointer, which is initialized inside iio_trigger_register() to THIS_MODULE. If this call order is wrong, the next iio_trigger_put() (from sysfs callbacks or rmmod) will derefence "default" module refcnt, which is completely incorrect. Signed-off-by: Dmitry Rokosov --- drivers/iio/accel/kxcjk-1013.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c index ac74cdcd2bc8..748b35c2f0c3 100644 --- a/drivers/iio/accel/kxcjk-1013.c +++ b/drivers/iio/accel/kxcjk-1013.c @@ -1554,12 +1554,12 @@ static int kxcjk1013_probe(struct i2c_client *clien= t, =20 data->dready_trig->ops =3D &kxcjk1013_trigger_ops; iio_trigger_set_drvdata(data->dready_trig, indio_dev); - indio_dev->trig =3D data->dready_trig; - iio_trigger_get(indio_dev->trig); ret =3D iio_trigger_register(data->dready_trig); if (ret) goto err_poweroff; =20 + indio_dev->trig =3D iio_trigger_get(data->dready_trig); + data->motion_trig->ops =3D &kxcjk1013_trigger_ops; iio_trigger_set_drvdata(data->motion_trig, indio_dev); ret =3D iio_trigger_register(data->motion_trig); --=20 2.36.0 From nobody Sat May 4 01:35:13 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04672C433F5 for ; Mon, 23 May 2022 16:43:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239080AbiEWQnO (ORCPT ); Mon, 23 May 2022 12:43:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239036AbiEWQmq (ORCPT ); Mon, 23 May 2022 12:42:46 -0400 Received: from mail.sberdevices.ru (mail.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DBE54E38A; Mon, 23 May 2022 09:42:43 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mail.sberdevices.ru (Postfix) with ESMTP id 77E875FD06; Mon, 23 May 2022 19:42:41 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1653324161; bh=w/y5zGWnbhdYZDEscTtuIwfMTZyMSOtuJte/1COxFRY=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=R88Y2klDr/jzLfIgF1GgppV20nN2WwPkvmuegPEiMrgi74ZtgIBL4DnMXzCcmy6ft RE9bLC571xhw72hFIj601gLmP3TQj3g5EFlZDCQxz7KAGBZ701UjjNA+r6eUIgXUmV wC8UBLILDDzk0SIZL0pA703r9j5+/WhE8R7t8mxKP9L/TSbj3iUj6CgN/UKSESk+zk AkEYmeJ4MfNcYo+6f/YaEqckI660XG75RqbxS2dIpTQJoNxW9MwOSd3K7bIi6fdcO3 x5AdDEN0N/+ZdIe6RdUHds9WG80BCuElaRPdMEtwaG570bS2gcwFWAQ6NUtd6DHdG9 0lbFdeU/Dcpfw== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mail.sberdevices.ru (Postfix) with ESMTP; Mon, 23 May 2022 19:42:41 +0300 (MSK) From: Dmitry Rokosov To: "robh+dt@kernel.org" , "jic23@kernel.org" , "lars@metafoo.de" , "andy.shevchenko@gmail.com" , "lorenzo.bianconi83@gmail.com" , "linus.walleij@linaro.org" , "stephan@gerhold.net" , "hdegoede@redhat.com" , "antoniu.miclaus@analog.com" , "sean@geanix.com" , "linmq006@gmail.com" , "gwendal@chromium.org" , "yangyingliang@huawei.com" CC: "linux-iio@vger.kernel.org" , kernel , "linux-kernel@vger.kernel.org" , Dmitry Rokosov Subject: [PATCH v1 3/5] iio:accel:mxc4005: rearrange iio trigger get and register Thread-Topic: [PATCH v1 3/5] iio:accel:mxc4005: rearrange iio trigger get and register Thread-Index: AQHYbsP/RY3VWwUPpUGH4PpJIfrW1w== Date: Mon, 23 May 2022 16:41:48 +0000 Message-ID: <20220523164159.11579-4-ddrokosov@sberdevices.ru> References: <20220523164159.11579-1-ddrokosov@sberdevices.ru> In-Reply-To: <20220523164159.11579-1-ddrokosov@sberdevices.ru> Accept-Language: ru-RU, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.1.12] Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/05/23 07:03:00 #19535618 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" IIO trigger interface function iio_trigger_get() should be called after iio_trigger_register() (or its devm analogue) strictly, because of iio_trigger_get() acquires module refcnt based on the trigger->owner pointer, which is initialized inside iio_trigger_register() to THIS_MODULE. If this call order is wrong, the next iio_trigger_put() (from sysfs callbacks or rmmod) will derefence "default" module refcnt, which is completely incorrect. Signed-off-by: Dmitry Rokosov --- drivers/iio/accel/mxc4005.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/accel/mxc4005.c b/drivers/iio/accel/mxc4005.c index b3afbf064915..df600d2917c0 100644 --- a/drivers/iio/accel/mxc4005.c +++ b/drivers/iio/accel/mxc4005.c @@ -456,8 +456,6 @@ static int mxc4005_probe(struct i2c_client *client, =20 data->dready_trig->ops =3D &mxc4005_trigger_ops; iio_trigger_set_drvdata(data->dready_trig, indio_dev); - indio_dev->trig =3D data->dready_trig; - iio_trigger_get(indio_dev->trig); ret =3D devm_iio_trigger_register(&client->dev, data->dready_trig); if (ret) { @@ -465,6 +463,8 @@ static int mxc4005_probe(struct i2c_client *client, "failed to register trigger\n"); return ret; } + + indio_dev->trig =3D iio_trigger_get(data->dready_trig); } =20 return devm_iio_device_register(&client->dev, indio_dev); --=20 2.36.0 From nobody Sat May 4 01:35:13 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63899C433F5 for ; Mon, 23 May 2022 16:43:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239058AbiEWQnV (ORCPT ); Mon, 23 May 2022 12:43:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239044AbiEWQms (ORCPT ); Mon, 23 May 2022 12:42:48 -0400 Received: from mail.sberdevices.ru (mail.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E54DB4E3B2; Mon, 23 May 2022 09:42:43 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mail.sberdevices.ru (Postfix) with ESMTP id 398925FD07; Mon, 23 May 2022 19:42:42 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1653324162; bh=RhiKWh0LFeh4Os0HGNlziOa6mxgE+mjMvOYWM1E4ANg=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=I5L8yM5huA3Qj0aTRL08jTqvuz8sJDYIHcT6HRwCduYxtH+95+h80yNJ89lz+nblj qcIUhMQVTlpvTufP1faA2q5Dwl2uVomwPNrQFFH449a5pcGxDAHsj7uFDVwl7qb8kb QOjUQCS1kVkVW5cuLArkd9X17+hb7go0HFwglzbiAJ6LmZEa0c1Fuds9j/jAA/qriv 6u7holUyVUoBcYbmsMVQmNvBfuDWpBMyIHe7ZBhSNjeIaiCcgghmSzM5WJBrET0zTP 3ib9YFwMj6sp40yVy/8ddqbJ9Q8LoFh4Zc5fuXRi422Ey6aBa6nYJT7HtvTM19PuHu 53G9v5fPXQgnA== Received: from S-MS-EXCH02.sberdevices.ru (S-MS-EXCH02.sberdevices.ru [172.16.1.5]) by mail.sberdevices.ru (Postfix) with ESMTP; Mon, 23 May 2022 19:42:42 +0300 (MSK) From: Dmitry Rokosov To: "robh+dt@kernel.org" , "jic23@kernel.org" , "lars@metafoo.de" , "andy.shevchenko@gmail.com" , "lorenzo.bianconi83@gmail.com" , "linus.walleij@linaro.org" , "stephan@gerhold.net" , "hdegoede@redhat.com" , "antoniu.miclaus@analog.com" , "sean@geanix.com" , "linmq006@gmail.com" , "gwendal@chromium.org" , "yangyingliang@huawei.com" CC: "linux-iio@vger.kernel.org" , kernel , "linux-kernel@vger.kernel.org" , Dmitry Rokosov Subject: [PATCH v1 4/5] iio:chemical:ccs811: rearrange iio trigger get and register Thread-Topic: [PATCH v1 4/5] iio:chemical:ccs811: rearrange iio trigger get and register Thread-Index: AQHYbsP/79XON26KwUeOeS4tvxocjw== Date: Mon, 23 May 2022 16:41:49 +0000 Message-ID: <20220523164159.11579-5-ddrokosov@sberdevices.ru> References: <20220523164159.11579-1-ddrokosov@sberdevices.ru> In-Reply-To: <20220523164159.11579-1-ddrokosov@sberdevices.ru> Accept-Language: ru-RU, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.1.12] Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/05/23 07:03:00 #19535618 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" IIO trigger interface function iio_trigger_get() should be called after iio_trigger_register() (or its devm analogue) strictly, because of iio_trigger_get() acquires module refcnt based on the trigger->owner pointer, which is initialized inside iio_trigger_register() to THIS_MODULE. If this call order is wrong, the next iio_trigger_put() (from sysfs callbacks or rmmod) will derefence "default" module refcnt, which is completely incorrect. Signed-off-by: Dmitry Rokosov --- drivers/iio/chemical/ccs811.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/chemical/ccs811.c b/drivers/iio/chemical/ccs811.c index 847194fa1e46..80ef1aa9aae3 100644 --- a/drivers/iio/chemical/ccs811.c +++ b/drivers/iio/chemical/ccs811.c @@ -499,11 +499,11 @@ static int ccs811_probe(struct i2c_client *client, =20 data->drdy_trig->ops =3D &ccs811_trigger_ops; iio_trigger_set_drvdata(data->drdy_trig, indio_dev); - indio_dev->trig =3D data->drdy_trig; - iio_trigger_get(indio_dev->trig); ret =3D iio_trigger_register(data->drdy_trig); if (ret) goto err_poweroff; + + indio_dev->trig =3D iio_trigger_get(data->drdy_trig); } =20 ret =3D iio_triggered_buffer_setup(indio_dev, NULL, --=20 2.36.0 From nobody Sat May 4 01:35:13 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27CCBC433FE for ; Mon, 23 May 2022 18:53:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240027AbiEWSxL (ORCPT ); Mon, 23 May 2022 14:53:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243446AbiEWSvr (ORCPT ); Mon, 23 May 2022 14:51:47 -0400 Received: from mail.sberdevices.ru (mail.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C4CE74DE7; Mon, 23 May 2022 11:37:27 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mail.sberdevices.ru (Postfix) with ESMTP id C70E25FD03; Mon, 23 May 2022 21:37:23 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1653331043; bh=Noow5oi6zcHI2WlvLtYK0Gx0bcKlwtT8V+5kTBP2c6I=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=O0jSIUTM4hNah88u7snuulxaVkfltJpOaEmp3UWmlDwCQgw8KYrg91PCuNIqBSuIc xt2ySfSwJOAXgl3m1fBZtfX5yMNqzxUQTBHVlv3WzhDD4x4Uxqp9NZhkMgcbR+YNXw fjmCqZPRW7WrAaQYZlMutJnGEEg0Mud6RgLY/tYSh+9Vmur/FBVIc2eH9yJtUwqIT4 0EONHD3qEXArZ39PALpqdyodu8SB1/hRg2deax/Nhf0Wxp/Eq6drfcwySKhpukal5J aUJ2tDrxeJFi0DVxQKi5Y1rjmXp7ii3jxNIb1egDPSdpaSN9eem9P43LNXjw34cmPf G2YK8F9U6Zw7Q== Received: from S-MS-EXCH02.sberdevices.ru (S-MS-EXCH02.sberdevices.ru [172.16.1.5]) by mail.sberdevices.ru (Postfix) with ESMTP; Mon, 23 May 2022 21:37:23 +0300 (MSK) From: Dmitry Rokosov To: "robh+dt@kernel.org" , "jic23@kernel.org" , "lars@metafoo.de" , "andy.shevchenko@gmail.com" , "lorenzo.bianconi83@gmail.com" CC: "linux-iio@vger.kernel.org" , kernel , "linux-kernel@vger.kernel.org" , Dmitry Rokosov Subject: [PATCH v1 5/5] iio:humidity:hts221: rearrange iio trigger get and register Thread-Topic: [PATCH v1 5/5] iio:humidity:hts221: rearrange iio trigger get and register Thread-Index: AQHYbtQFJ4IV8bnfCkSEgy51IjLtng== Date: Mon, 23 May 2022 18:36:30 +0000 Message-ID: <20220523183716.20360-1-ddrokosov@sberdevices.ru> References: <20220523164159.11579-1-ddrokosov@sberdevices.ru> In-Reply-To: <20220523164159.11579-1-ddrokosov@sberdevices.ru> Accept-Language: ru-RU, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.1.12] Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/05/23 11:48:00 #19537323 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" IIO trigger interface function iio_trigger_get() should be called after iio_trigger_register() (or its devm analogue) strictly, because of iio_trigger_get() acquires module refcnt based on the trigger->owner pointer, which is initialized inside iio_trigger_register() to THIS_MODULE. If this call order is wrong, the next iio_trigger_put() (from sysfs callbacks or rmmod) will derefence "default" module refcnt, which is completely incorrect. Signed-off-by: Dmitry Rokosov --- drivers/iio/humidity/hts221_buffer.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/iio/humidity/hts221_buffer.c b/drivers/iio/humidity/ht= s221_buffer.c index f29692b9d2db..66b32413cf5e 100644 --- a/drivers/iio/humidity/hts221_buffer.c +++ b/drivers/iio/humidity/hts221_buffer.c @@ -135,9 +135,12 @@ int hts221_allocate_trigger(struct iio_dev *iio_dev) =20 iio_trigger_set_drvdata(hw->trig, iio_dev); hw->trig->ops =3D &hts221_trigger_ops; + + err =3D devm_iio_trigger_register(hw->dev, hw->trig); + iio_dev->trig =3D iio_trigger_get(hw->trig); =20 - return devm_iio_trigger_register(hw->dev, hw->trig); + return err; } =20 static int hts221_buffer_preenable(struct iio_dev *iio_dev) --=20 2.36.0