From nobody Tue May 7 21:10:12 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 906B5C433EF for ; Mon, 23 May 2022 15:51:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238223AbiEWPvM (ORCPT ); Mon, 23 May 2022 11:51:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238186AbiEWPvH (ORCPT ); Mon, 23 May 2022 11:51:07 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 59AC12A9; Mon, 23 May 2022 08:51:01 -0700 (PDT) Received: from hillo.muru.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTP id 0D3BD80C2; Mon, 23 May 2022 15:47:00 +0000 (UTC) From: Tony Lindgren To: Greg Kroah-Hartman Cc: Daniel Starke , Gregory CLEMENT , Jiri Slaby , Johan Hovold , Zhenguo Zhao , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Carpenter Subject: [PATCH] tty: n_gsm: Debug output allocation must use GFP_ATOMIC Date: Mon, 23 May 2022 18:50:52 +0300 Message-Id: <20220523155052.57129-1-tony@atomide.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Dan Carpenter reported the following Smatch warning: drivers/tty/n_gsm.c:720 gsm_data_kick() warn: sleeping in atomic context This is because gsm_control_message() is holding a spin lock so gsm_hex_dump_bytes() needs to use GFP_ATOMIC instead of GFP_KERNEL. Fixes: 925ea0fa5277 ("tty: n_gsm: Fix packet data hex dump output") Reported-by: Dan Carpenter Signed-off-by: Tony Lindgren Reviewed-by: Gregory CLEMENT --- drivers/tty/n_gsm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c --- a/drivers/tty/n_gsm.c +++ b/drivers/tty/n_gsm.c @@ -459,7 +459,7 @@ static void gsm_hex_dump_bytes(const char *fname, const= u8 *data, return; } =20 - prefix =3D kasprintf(GFP_KERNEL, "%s: ", fname); + prefix =3D kasprintf(GFP_ATOMIC, "%s: ", fname); if (!prefix) return; print_hex_dump(KERN_INFO, prefix, DUMP_PREFIX_OFFSET, 16, 1, data, len, --=20 2.36.1