From nobody Thu May 7 17:47:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BC9DC433EF for ; Sun, 22 May 2022 20:22:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345839AbiEVUWg (ORCPT ); Sun, 22 May 2022 16:22:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237346AbiEVUWd (ORCPT ); Sun, 22 May 2022 16:22:33 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8D4A3584F for ; Sun, 22 May 2022 13:22:31 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id h11so15615762eda.8 for ; Sun, 22 May 2022 13:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7lqrNM9SlTA9YcyvAhtvzC37daa5Q+RkpbW0aFJMfIU=; b=BlHfHCkJSAKtW33s8FAp1ySSMpQuboJzj6P8ieFFoaCqyf/97IBTwIK0zmtKbswleI zJ14vzYi43mf7wStH2toIiem5oJBefAQwZAOy4d6je5DUCr7wPrwREZibYRfeHNU89QB gZb9LxW7JrUb66ev6uHSbuN+KqiEcpM+HFCmg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7lqrNM9SlTA9YcyvAhtvzC37daa5Q+RkpbW0aFJMfIU=; b=4nIsk1cOrEuHwh2KW9RLZ09da3iFFr7c+GsnBirlDe2J1SpQYMnPBPF6lK+FZxEfF9 nEQuDMgnmMicgDrs1m98Gah/fopc4tNpdch3wDPYeUekzsnw3EY88Opx9qGP7Z8R/alp pSWCT5BBINECD+QCfh7/Z4/yb8uoN+RrE7BcFf3nWaIhGPxct9jm2DGcU+kUt7zW8sgm gR322W/CRASZIxD17hgbJT0NAjaVbty+HIJgWSYq00Gu49hFOG/pXJsYU36pyuwovR9s qS4KabwWDwhqXDE2MLPuutGyUBWPNBcawzUOfzJbK7Lq2enQxqP+4VTCG71Es0hJagq8 PNrg== X-Gm-Message-State: AOAM533Ir3KU/Q2Kjkvyn0RYbstSGSOHhswv0rwQN01oT9N6aEnkNG+E mxqLF4WsRnIKoj4ubZDDFA5NlqGD3jb9DA== X-Google-Smtp-Source: ABdhPJxknQT49oNOahOTUWp8iBADzAFc9ZTPcVm6YC6rBk/ExwJwN8tVFmO2fd4urytDDvswyAuiOQ== X-Received: by 2002:a05:6402:1e93:b0:42b:5134:6bf6 with SMTP id f19-20020a0564021e9300b0042b51346bf6mr6648496edf.40.1653250950259; Sun, 22 May 2022 13:22:30 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-80-116-90-174.pool80116.interbusiness.it. [80.116.90.174]) by smtp.gmail.com with ESMTPSA id r17-20020a056402019100b0042abf2affebsm7269876edv.67.2022.05.22.13.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 May 2022 13:22:29 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Michael Trimarchi , Dario Binacchi , Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Vinod Koul , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] dmaengine: mxs: fix driver registering Date: Sun, 22 May 2022 22:22:23 +0200 Message-Id: <20220522202223.1343109-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Driver registration fails on SOC imx8mn as its supplier, the clock control module, is not ready. Since platform_driver_probe(), as reported by its description, is incompatible with deferred probing, we have to use platform_driver_register(). Fixes: a580b8c5429a ("dmaengine: mxs-dma: add dma support for i.MX23/28") Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- drivers/dma/mxs-dma.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c index 994fc4d2aca4..b8a3e692330d 100644 --- a/drivers/dma/mxs-dma.c +++ b/drivers/dma/mxs-dma.c @@ -670,7 +670,7 @@ static enum dma_status mxs_dma_tx_status(struct dma_cha= n *chan, return mxs_chan->status; } =20 -static int __init mxs_dma_init(struct mxs_dma_engine *mxs_dma) +static int mxs_dma_init(struct mxs_dma_engine *mxs_dma) { int ret; =20 @@ -741,7 +741,7 @@ static struct dma_chan *mxs_dma_xlate(struct of_phandle= _args *dma_spec, ofdma->of_node); } =20 -static int __init mxs_dma_probe(struct platform_device *pdev) +static int mxs_dma_probe(struct platform_device *pdev) { struct device_node *np =3D pdev->dev.of_node; const struct mxs_dma_type *dma_type; @@ -839,10 +839,7 @@ static struct platform_driver mxs_dma_driver =3D { .name =3D "mxs-dma", .of_match_table =3D mxs_dma_dt_ids, }, + .probe =3D mxs_dma_probe, }; =20 -static int __init mxs_dma_module_init(void) -{ - return platform_driver_probe(&mxs_dma_driver, mxs_dma_probe); -} -subsys_initcall(mxs_dma_module_init); +module_platform_driver(mxs_dma_driver); --=20 2.32.0