From nobody Thu May 7 17:44:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C3C3C433F5 for ; Sun, 22 May 2022 11:55:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343843AbiEVLzN (ORCPT ); Sun, 22 May 2022 07:55:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343763AbiEVLzF (ORCPT ); Sun, 22 May 2022 07:55:05 -0400 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2069.outbound.protection.outlook.com [40.107.220.69]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31BA52CE06; Sun, 22 May 2022 04:55:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=an5cVrYRH9o/AenNFFI35hGyOteKZ5IBDSClMN+0afXEh8zNo/bpdXO8wf1RvN9SEzt/LVdwD+nrT1uOnGSpBz1gtaExyq8UrhFPvgrVCKXFYSsdSNRwlfslZfdlLhWYeNobqx2vNOL3Xu4muVyb9bNn1aCd7ORVJRz/93zMc2NQ9N0cffMbvL1PZ5aZDQl5URKnMNVUKaDOGvcGGBVbiwPaq7vFWT2hs4MF4V2UuwsSwfg5SLntvtjWj76ZJhAVicCab23xJbWHi0OR+QJ71RQNKIvV8bbNSRoBoudUSpbyKaDoz4Wn5zf3I7fvsU2L111T+Gmh+ErRlWFxL/CDfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EX2QXIj8acGQe+kLPliSKrmQ+ig8p/ZJIgFM6FJmS/Q=; b=l3wbeK0UINS1fD6BG2JCb3Xx6EVluVTIQco8mwnc3IGMCKWbrGEwkyU6cHeK0/XNG9w+09rwr81ZI3HLa36exOFvYlQcmpuQYysG54MpWuN8n87j3N40VVURP+z/qiJmCF/0yUYVkuNfvL4rlXk9okrIKA6vO0r04f4HCp9GTPhU604FlbXtDWTzaSQsqBS8/GrMwdP7k3CWf0nMPt6/9FogGhkG4vvA/9EyFo3AITwwcL3v/T1zRJO+Hs5f0bj1GjJ5gtixMHbPjOgApLQshwv21cfYIPAYTAOtpDRyR6f79Z3AhYT6qel/ZfRbZllNvQ1ELyw24pcAVT6kbRgReg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linuxfoundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EX2QXIj8acGQe+kLPliSKrmQ+ig8p/ZJIgFM6FJmS/Q=; b=Vsy0hQmpCArWevuKZ3MKRtL4YdNI+d31GFsFc0AppKlVnwJG2d6qFqD2L5ftMfJaj21PW3gZd0lllArugdM6TPYt+sOLSDDuQVNCZP+NSamXe+/2qISuO7V7Uqi8PEe1DRskQCQ0R4TKEqSNL8k0eK+ZDb91TgKyTgEK7zHGKuc= Received: from BN9PR03CA0921.namprd03.prod.outlook.com (2603:10b6:408:107::26) by DM5PR12MB4663.namprd12.prod.outlook.com (2603:10b6:4:a9::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Sun, 22 May 2022 11:55:00 +0000 Received: from BN8NAM11FT011.eop-nam11.prod.protection.outlook.com (2603:10b6:408:107:cafe::ce) by BN9PR03CA0921.outlook.office365.com (2603:10b6:408:107::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22 via Frontend Transport; Sun, 22 May 2022 11:55:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT011.mail.protection.outlook.com (10.13.176.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Sun, 22 May 2022 11:55:00 +0000 Received: from jasmine-meng.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sun, 22 May 2022 06:54:56 -0500 From: Meng Li To: Shuah Khan , Huang Rui , CC: "Rafael J . Wysocki" , Nathan Fontenot , Deepak Sharma , "Alex Deucher" , Mario Limonciello , Jinzhou Su , Perry Yuan , Xiaojian Du , Viresh Kumar , Borislav Petkov , , Meng Li Subject: [PATCH V7 1/4] cpufreq: amd-pstate: Expose struct amd_cpudata Date: Sun, 22 May 2022 19:54:20 +0800 Message-ID: <20220522115423.1147282-2-li.meng@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220522115423.1147282-1-li.meng@amd.com> References: <20220522115423.1147282-1-li.meng@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d787dd4e-e516-4be1-f1cb-08da3be9e66b X-MS-TrafficTypeDiagnostic: DM5PR12MB4663:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V/gF7hXz4V3i3GMrkN++5KJuSpWVRexlU5kPyEU50TJpktB3CxlhhKAubh7xbnYCG0VWNm3JAL+fImHppBdmMr0qI0NURI2GqP3W8R486XjCOdR/4J+hxHkI/58mc2NZCCaRCkkjrSBuiiOJ8JeAXoFLWL+yrHHWziwI9UGpFgxVT93ur/zPWEtfhjYwTnjG4mjgq7MdJxECfDLCus9XMEIP6abEP1xYFRmS+UoAAuZdgNczjPm9QLicNfIXTte7Gdb57NiBIQi5M2R3dype5MTr0WA5oJhZdv25hYij9qERWPiBKWZ9Fjv2afw8RzJPxd/N5NqIbXd67LpQI7OfymNw3Ca3KXjuFBHrJX88irmdGv0XF3AN6FDnXXtBdP+cL81/GitwlkM5eFS1OqSy/7nBTwqNiCLnQmUnz8vRPqKYAHEpdtwszjOLiLHdSapNRaiUp7Ao3JIaz5DKXE/6kjU9GBUipCC15DPQhWjJzfz3QqPKRFGEnr8V04ZPtCkXgibKSaOEpEPNBKBF13BKi4RwG+33dcyR0sCSwRarV2J477gzkGAbty1+n3M2ocILRRSG4iTq4f+1sUfJF7PQRIPpjDULf7sAaZWr3QliIXu1DC32S5DZzC17mwMPoemiS1/wSEgo2cW1oSsFG0EWLdUwHQzjDdOn/BdZlYBYMrPvFzvRCeUCeWXsNEcApENhGC76YK1t9ju6u2bJCHz88Q== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(47076005)(26005)(316002)(426003)(8676002)(5660300002)(4326008)(336012)(86362001)(70206006)(2906002)(70586007)(36860700001)(36756003)(356005)(82310400005)(7696005)(81166007)(2616005)(40460700003)(110136005)(8936002)(54906003)(16526019)(6666004)(508600001)(1076003)(186003)(83380400001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2022 11:55:00.4974 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d787dd4e-e516-4be1-f1cb-08da3be9e66b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT011.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB4663 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Expose struct amd_cpudata to AMD P-State unit test module. This data struct will be used on the following AMD P-State unit test (amd-pstate-ut) module. The amd-pstate-ut module can get some AMD infomations by this data struct. For example: highest perf, nominal perf, boost supported etc. Signed-off-by: Meng Li Acked-by: Huang Rui Acked-by: Shuah Khan --- MAINTAINERS | 1 + drivers/cpufreq/amd-pstate.c | 60 +--------------------------- include/linux/amd-pstate.h | 77 ++++++++++++++++++++++++++++++++++++ 3 files changed, 79 insertions(+), 59 deletions(-) create mode 100644 include/linux/amd-pstate.h diff --git a/MAINTAINERS b/MAINTAINERS index edc96cdb85e8..c2e5299b0051 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1021,6 +1021,7 @@ L: linux-pm@vger.kernel.org S: Supported F: Documentation/admin-guide/pm/amd-pstate.rst F: drivers/cpufreq/amd-pstate* +F: include/linux/amd-pstate.h F: tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py =20 AMD PTDMA DRIVER diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 7be38bc6a673..5f7a00a64f76 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -36,6 +36,7 @@ #include #include #include +#include =20 #include #include @@ -65,65 +66,6 @@ MODULE_PARM_DESC(shared_mem, =20 static struct cpufreq_driver amd_pstate_driver; =20 -/** - * struct amd_aperf_mperf - * @aperf: actual performance frequency clock count - * @mperf: maximum performance frequency clock count - * @tsc: time stamp counter - */ -struct amd_aperf_mperf { - u64 aperf; - u64 mperf; - u64 tsc; -}; - -/** - * struct amd_cpudata - private CPU data for AMD P-State - * @cpu: CPU number - * @req: constraint request to apply - * @cppc_req_cached: cached performance request hints - * @highest_perf: the maximum performance an individual processor may reac= h, - * assuming ideal conditions - * @nominal_perf: the maximum sustained performance level of the processor, - * assuming ideal operating conditions - * @lowest_nonlinear_perf: the lowest performance level at which nonlinear= power - * savings are achieved - * @lowest_perf: the absolute lowest performance level of the processor - * @max_freq: the frequency that mapped to highest_perf - * @min_freq: the frequency that mapped to lowest_perf - * @nominal_freq: the frequency that mapped to nominal_perf - * @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_p= erf - * @cur: Difference of Aperf/Mperf/tsc count between last and current samp= le - * @prev: Last Aperf/Mperf/tsc count value read from register - * @freq: current cpu frequency value - * @boost_supported: check whether the Processor or SBIOS supports boost m= ode - * - * The amd_cpudata is key private data for each CPU thread in AMD P-State,= and - * represents all the attributes and goals that AMD P-State requests at ru= ntime. - */ -struct amd_cpudata { - int cpu; - - struct freq_qos_request req[2]; - u64 cppc_req_cached; - - u32 highest_perf; - u32 nominal_perf; - u32 lowest_nonlinear_perf; - u32 lowest_perf; - - u32 max_freq; - u32 min_freq; - u32 nominal_freq; - u32 lowest_nonlinear_freq; - - struct amd_aperf_mperf cur; - struct amd_aperf_mperf prev; - - u64 freq; - bool boost_supported; -}; - static inline int pstate_enable(bool enable) { return wrmsrl_safe(MSR_AMD_CPPC_ENABLE, enable); diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h new file mode 100644 index 000000000000..1c4b8659f171 --- /dev/null +++ b/include/linux/amd-pstate.h @@ -0,0 +1,77 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * linux/include/linux/amd-pstate.h + * + * Copyright (C) 2022 Advanced Micro Devices, Inc. + * + * Author: Meng Li + */ + +#ifndef _LINUX_AMD_PSTATE_H +#define _LINUX_AMD_PSTATE_H + +#include + +/********************************************************************* + * AMD P-state INTERFACE * + *********************************************************************/ +/** + * struct amd_aperf_mperf + * @aperf: actual performance frequency clock count + * @mperf: maximum performance frequency clock count + * @tsc: time stamp counter + */ +struct amd_aperf_mperf { + u64 aperf; + u64 mperf; + u64 tsc; +}; + +/** + * struct amd_cpudata - private CPU data for AMD P-State + * @cpu: CPU number + * @req: constraint request to apply + * @cppc_req_cached: cached performance request hints + * @highest_perf: the maximum performance an individual processor may reac= h, + * assuming ideal conditions + * @nominal_perf: the maximum sustained performance level of the processor, + * assuming ideal operating conditions + * @lowest_nonlinear_perf: the lowest performance level at which nonlinear= power + * savings are achieved + * @lowest_perf: the absolute lowest performance level of the processor + * @max_freq: the frequency that mapped to highest_perf + * @min_freq: the frequency that mapped to lowest_perf + * @nominal_freq: the frequency that mapped to nominal_perf + * @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_p= erf + * @cur: Difference of Aperf/Mperf/tsc count between last and current samp= le + * @prev: Last Aperf/Mperf/tsc count value read from register + * @freq: current cpu frequency value + * @boost_supported: check whether the Processor or SBIOS supports boost m= ode + * + * The amd_cpudata is key private data for each CPU thread in AMD P-State,= and + * represents all the attributes and goals that AMD P-State requests at ru= ntime. + */ +struct amd_cpudata { + int cpu; + + struct freq_qos_request req[2]; + u64 cppc_req_cached; + + u32 highest_perf; + u32 nominal_perf; + u32 lowest_nonlinear_perf; + u32 lowest_perf; + + u32 max_freq; + u32 min_freq; + u32 nominal_freq; + u32 lowest_nonlinear_freq; + + struct amd_aperf_mperf cur; + struct amd_aperf_mperf prev; + + u64 freq; + bool boost_supported; +}; + +#endif /* _LINUX_AMD_PSTATE_H */ --=20 2.25.1 From nobody Thu May 7 17:44:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38B36C433F5 for ; Sun, 22 May 2022 11:55:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244241AbiEVLzr (ORCPT ); Sun, 22 May 2022 07:55:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343961AbiEVLzZ (ORCPT ); Sun, 22 May 2022 07:55:25 -0400 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2043.outbound.protection.outlook.com [40.107.220.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EF243BBEA; Sun, 22 May 2022 04:55:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hRafQVAqXkpWxsC5pW5Rsh75Qm6pd0owEIVwSbh/+2cNdyHHaIUQpQMeXKslVOyOgG4CCN2jr5ZXi/raWPjJ0FCnzPlWp/3W1fOErwdZWwTMieUEkIoVu/p6jGiQcB3zVlogs98vyNZqdDSVAtOOaI++mw7UBq6lBYHpxiYQnfKBGxl9dphNWb9uYilKdgdUciM78D78wpCGFsssxxMCDDHgPNqEG/RI2PTXvkgjpTjd859to7VVefqtDeC40+zEPFk91U44J+K7M0eHm1xVKJ6P5M/WHaCicYUYSD+dwho8X+kHIBOAJzEGqf2z3T/s36x6/xvtrzVtbHP2VvhW+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b4N2UESOa6AJ/VFZ7FNjVjH9sDzY+t5wWuFxVmLnIcY=; b=VuWfpAtocqPeHN6XkOph/656qO++e4DFOKKE++sTkF2zol9QejxGbN4lw/zj3lq5Jn6QlWIcB/gfP/PCvPzBQAqTJBDpOJHTD2Kp6NK2/6GwnR9+4pGKef4enQApHNGhEiaIMAAVjJdzKA00sdxffrqaGPpgMZuGqxtgfyNQ7qLt36VOJnyXj5pJw2Yl0E0W9kNOopLxro/m5NSjYWenyfe2iLmQ59mC5k/K2zrx9CTcD1zu+3pHjnLfIuicivgF9HnAfqYcaWxWNSdNwuDfOuI8sA+iqBCpzcXu5BMJLMsPbg6gE52x0JjaWRqUpDXqZmAZom1snjsnjRhhyu5QDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linuxfoundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b4N2UESOa6AJ/VFZ7FNjVjH9sDzY+t5wWuFxVmLnIcY=; b=Io5Uin3TXgvFvLV2erSGVRG+ezv4VBomOxeQkO83uUajMPBaSwmxhjkuBhGwROcQcCvP2HO9hP+yLexJ0KD6ZPuNz+l0VVTLgpa9P8/7Wpp1nB3oyqxISX2jVH64lm0vGOwszX1mtTRT8/f3ViGxMalBURxiPJda7+FVKp0t2Yg= Received: from BN0PR03CA0017.namprd03.prod.outlook.com (2603:10b6:408:e6::22) by SJ1PR12MB6243.namprd12.prod.outlook.com (2603:10b6:a03:456::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Sun, 22 May 2022 11:55:05 +0000 Received: from BN8NAM11FT026.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e6:cafe::17) by BN0PR03CA0017.outlook.office365.com (2603:10b6:408:e6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13 via Frontend Transport; Sun, 22 May 2022 11:55:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT026.mail.protection.outlook.com (10.13.177.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Sun, 22 May 2022 11:55:04 +0000 Received: from jasmine-meng.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sun, 22 May 2022 06:55:00 -0500 From: Meng Li To: Shuah Khan , Huang Rui , CC: "Rafael J . Wysocki" , Nathan Fontenot , Deepak Sharma , "Alex Deucher" , Mario Limonciello , Jinzhou Su , Perry Yuan , Xiaojian Du , Viresh Kumar , Borislav Petkov , , Meng Li Subject: [PATCH V7 2/4] cpufreq: amd-pstate: Add test module for amd-pstate driver Date: Sun, 22 May 2022 19:54:21 +0800 Message-ID: <20220522115423.1147282-3-li.meng@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220522115423.1147282-1-li.meng@amd.com> References: <20220522115423.1147282-1-li.meng@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2e99c513-750d-4ef9-cd28-08da3be9e8b9 X-MS-TrafficTypeDiagnostic: SJ1PR12MB6243:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bsD8k4XATwHpUWBUdf7dPZQWVfWepPLX15RQ2DrCj/BfnX98Xww1P7EEDw0SBX4n6lO71wr1tluTHiNnRS4Xy4PeXyFuwyw6wqrJj3q7GrXw00Rj0loOEVejzbBfs8EeDPkhID0i0gJQ0fbYhOAbiqY/WjLVtCTHF9M+czGSLYFCS0ZqeCLX8usPZz5CuXYspZtFTj9cTc+A6KXThxR0x4CQU136D7eI0gs8icZ8WLtBY9EcU1Jo6j+JHrFAPtlvBK5mnyVrB1xIvioCH4UHrQFvVF00+6kGb7etyI1s8tPpDJj9f5rZuSsIJwJj9E747x4FglVwN9PbtmcEckQULHuW8bbS07kC3Q9OoTnCjs/RD0H+UX0e6RFK2+h4MwTY6Ximp0V20nacTRvMPe3E/cT4kltUHzPQ1YhSF8n3O9xE7duF54oNCR+Kb4FL08RXdNG3B3oSizZ8JPXNZX0H24c+WUvHtb6xLtMJb97lr/DWQQHXWa5eLzQx3xe6k0EHqc4QxD3vMCjovUCCZseIfdiTLdCdZj5VQV9MrnR25PtLTjqZQRz+OCvzyI9+nP41ua/eSShFkjP7N0zTUz+A0MBcmcEUfV7i0msHuDQ35aIN+3E8/k/YBuUlm7I1KkzEY30HAlawnmNzrxAKj934BMpcAIEgRTeROZ08HSbfmNd8UVogmgU1vjo+IWgdH9ULHYmwK6Y9X2VsGhe5Gax/2Q== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(6666004)(508600001)(2616005)(110136005)(1076003)(54906003)(426003)(40460700003)(47076005)(336012)(2906002)(7696005)(186003)(16526019)(26005)(86362001)(316002)(36860700001)(8676002)(81166007)(36756003)(5660300002)(8936002)(30864003)(70586007)(70206006)(82310400005)(83380400001)(356005)(4326008)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2022 11:55:04.3474 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2e99c513-750d-4ef9-cd28-08da3be9e8b9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT026.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6243 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add amd-pstate-ut module, which is conceptually out-of-tree module and provides ways for selftests/amd-pstate driver to test various kernel module-related functionality. This module will be expected by some of selftests to be present and loaded. Signed-off-by: Meng Li Acked-by: Huang Rui Reviewed-by: Shuah Khan --- drivers/cpufreq/Kconfig.x86 | 7 + drivers/cpufreq/Makefile | 1 + drivers/cpufreq/amd-pstate-ut.c | 293 ++++++++++++++++++++++++++++++++ 3 files changed, 301 insertions(+) create mode 100644 drivers/cpufreq/amd-pstate-ut.c diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86 index 55516043b656..fdd819069d72 100644 --- a/drivers/cpufreq/Kconfig.x86 +++ b/drivers/cpufreq/Kconfig.x86 @@ -51,6 +51,13 @@ config X86_AMD_PSTATE =20 If in doubt, say N. =20 +config X86_AMD_PSTATE_UT + tristate "selftest for AMD Processor P-State driver" + depends on X86 && ACPI_PROCESSOR + default n + help + This kernel module is used for testing. It's safe to say M here. + config X86_ACPI_CPUFREQ tristate "ACPI Processor P-States driver" depends on ACPI_PROCESSOR diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile index 285de70af877..49b98c62c5af 100644 --- a/drivers/cpufreq/Makefile +++ b/drivers/cpufreq/Makefile @@ -30,6 +30,7 @@ amd_pstate-y :=3D amd-pstate.o amd-pstate-trace.o =20 obj-$(CONFIG_X86_ACPI_CPUFREQ) +=3D acpi-cpufreq.o obj-$(CONFIG_X86_AMD_PSTATE) +=3D amd_pstate.o +obj-$(CONFIG_X86_AMD_PSTATE_UT) +=3D amd-pstate-ut.o obj-$(CONFIG_X86_POWERNOW_K8) +=3D powernow-k8.o obj-$(CONFIG_X86_PCC_CPUFREQ) +=3D pcc-cpufreq.o obj-$(CONFIG_X86_POWERNOW_K6) +=3D powernow-k6.o diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-u= t.c new file mode 100644 index 000000000000..a8d2783d98b5 --- /dev/null +++ b/drivers/cpufreq/amd-pstate-ut.c @@ -0,0 +1,293 @@ +// SPDX-License-Identifier: GPL-1.0-or-later +/* + * AMD Processor P-state Frequency Driver Unit Test + * + * Copyright (C) 2022 Advanced Micro Devices, Inc. All Rights Reserved. + * + * Author: Meng Li + * + * The AMD P-State Unit Test is a test module for testing the amd-pstate + * driver. 1) It can help all users to verify their processor support + * (SBIOS/Firmware or Hardware). 2) Kernel can have a basic function + * test to avoid the kernel regression during the update. 3) We can + * introduce more functional or performance tests to align the result + * together, it will benefit power and performance scale optimization. + * + * This driver implements basic framework with plans to enhance it with + * additional test cases to improve the depth and coverage of the test. + * + * See Documentation/admin-guide/pm/amd-pstate.rst Unit Tests for + * amd-pstate to get more detail. + */ + +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + +#include +#include +#include +#include +#include + +#include + +/* + * Abbreviations: + * amd_pstate_ut: used as a shortform for AMD P-State unit test. + * It helps to keep variable names smaller, simpler + */ +enum amd_pstate_ut_result { + AMD_PSTATE_UT_RESULT_PASS, + AMD_PSTATE_UT_RESULT_FAIL, +}; + +struct amd_pstate_ut_struct { + const char *name; + void (*func)(u32 index); + enum amd_pstate_ut_result result; +}; + +/* + * Kernel module for testing the AMD P-State unit test + */ +static void amd_pstate_ut_acpi_cpc_valid(u32 index); +static void amd_pstate_ut_check_enabled(u32 index); +static void amd_pstate_ut_check_perf(u32 index); +static void amd_pstate_ut_check_freq(u32 index); + +static struct amd_pstate_ut_struct amd_pstate_ut_cases[] =3D { + {"amd_pstate_ut_acpi_cpc_valid", amd_pstate_ut_acpi_cpc_valid }, + {"amd_pstate_ut_check_enabled", amd_pstate_ut_check_enabled }, + {"amd_pstate_ut_check_perf", amd_pstate_ut_check_perf }, + {"amd_pstate_ut_check_freq", amd_pstate_ut_check_freq } +}; + +static bool get_shared_mem(void) +{ + bool result =3D false; + char path[] =3D "/sys/module/amd_pstate/parameters/shared_mem"; + char buf[5] =3D {0}; + struct file *filp =3D NULL; + loff_t pos =3D 0; + ssize_t ret; + + if (!boot_cpu_has(X86_FEATURE_CPPC)) { + filp =3D filp_open(path, FMODE_PREAD, 0); + if (IS_ERR(filp)) + pr_err("%s unable to open %s file!\n", __func__, path); + else { + ret =3D kernel_read(filp, &buf, sizeof(buf), &pos); + if (ret < 0) + pr_err("%s read %s file fail ret=3D%ld!\n", + __func__, path, (long)ret); + filp_close(filp, NULL); + } + + if ('Y' =3D=3D *buf) + result =3D true; + } + + return result; +} + +/* + * check the _CPC object is present in SBIOS. + */ +static void amd_pstate_ut_acpi_cpc_valid(u32 index) +{ + if (acpi_cpc_valid()) + amd_pstate_ut_cases[index].result =3D AMD_PSTATE_UT_RESULT_PASS; + else { + amd_pstate_ut_cases[index].result =3D AMD_PSTATE_UT_RESULT_FAIL; + pr_err("%s the _CPC object is not present in SBIOS!\n", __func__); + } +} + +static void amd_pstate_ut_pstate_enable(u32 index) +{ + int ret =3D 0; + u64 cppc_enable =3D 0; + + ret =3D rdmsrl_safe(MSR_AMD_CPPC_ENABLE, &cppc_enable); + if (ret) { + amd_pstate_ut_cases[index].result =3D AMD_PSTATE_UT_RESULT_FAIL; + pr_err("%s rdmsrl_safe MSR_AMD_CPPC_ENABLE ret=3D%d error!\n", __func__,= ret); + return; + } + if (cppc_enable) + amd_pstate_ut_cases[index].result =3D AMD_PSTATE_UT_RESULT_PASS; + else { + amd_pstate_ut_cases[index].result =3D AMD_PSTATE_UT_RESULT_FAIL; + pr_err("%s amd pstate must be enabled!\n", __func__); + } +} + +/* + * check if amd pstate is enabled + */ +static void amd_pstate_ut_check_enabled(u32 index) +{ + if (get_shared_mem()) + amd_pstate_ut_cases[index].result =3D AMD_PSTATE_UT_RESULT_PASS; + else + amd_pstate_ut_pstate_enable(index); +} + +/* + * check if performance values are reasonable. + * highest_perf >=3D nominal_perf > lowest_nonlinear_perf > lowest_perf > 0 + */ +static void amd_pstate_ut_check_perf(u32 index) +{ + int cpu =3D 0, ret =3D 0; + u32 highest_perf =3D 0, nominal_perf =3D 0, lowest_nonlinear_perf =3D 0, = lowest_perf =3D 0; + u64 cap1 =3D 0; + struct cppc_perf_caps cppc_perf; + struct cpufreq_policy *policy =3D NULL; + struct amd_cpudata *cpudata =3D NULL; + + highest_perf =3D amd_get_highest_perf(); + + for_each_possible_cpu(cpu) { + policy =3D cpufreq_cpu_get(cpu); + if (!policy) + break; + cpudata =3D policy->driver_data; + + if (get_shared_mem()) { + ret =3D cppc_get_perf_caps(cpu, &cppc_perf); + if (ret) { + amd_pstate_ut_cases[index].result =3D AMD_PSTATE_UT_RESULT_FAIL; + pr_err("%s cppc_get_perf_caps ret=3D%d error!\n", __func__, ret); + return; + } + + nominal_perf =3D cppc_perf.nominal_perf; + lowest_nonlinear_perf =3D cppc_perf.lowest_nonlinear_perf; + lowest_perf =3D cppc_perf.lowest_perf; + } else { + ret =3D rdmsrl_safe_on_cpu(cpu, MSR_AMD_CPPC_CAP1, &cap1); + if (ret) { + amd_pstate_ut_cases[index].result =3D AMD_PSTATE_UT_RESULT_FAIL; + pr_err("%s read CPPC_CAP1 ret=3D%d error!\n", __func__, ret); + return; + } + + nominal_perf =3D AMD_CPPC_NOMINAL_PERF(cap1); + lowest_nonlinear_perf =3D AMD_CPPC_LOWNONLIN_PERF(cap1); + lowest_perf =3D AMD_CPPC_LOWEST_PERF(cap1); + } + + if ((highest_perf !=3D READ_ONCE(cpudata->highest_perf)) || + (nominal_perf !=3D READ_ONCE(cpudata->nominal_perf)) || + (lowest_nonlinear_perf !=3D READ_ONCE(cpudata->lowest_nonlinear_perf)) = || + (lowest_perf !=3D READ_ONCE(cpudata->lowest_perf))) { + amd_pstate_ut_cases[index].result =3D AMD_PSTATE_UT_RESULT_FAIL; + pr_err("%s cpu%d highest=3D%d %d nominal=3D%d %d lowest_nonlinear=3D%d = %d lowest=3D%d %d, they should be equal!\n", + __func__, cpu, highest_perf, cpudata->highest_perf, + nominal_perf, cpudata->nominal_perf, + lowest_nonlinear_perf, cpudata->lowest_nonlinear_perf, + lowest_perf, cpudata->lowest_perf); + return; + } + + if (!((highest_perf >=3D nominal_perf) && + (nominal_perf > lowest_nonlinear_perf) && + (lowest_nonlinear_perf > lowest_perf) && + (lowest_perf > 0))) { + amd_pstate_ut_cases[index].result =3D AMD_PSTATE_UT_RESULT_FAIL; + pr_err("%s cpu%d highest=3D%d >=3D nominal=3D%d > lowest_nonlinear=3D%d= > lowest=3D%d > 0, the formula is incorrect!\n", + __func__, cpu, highest_perf, nominal_perf, + lowest_nonlinear_perf, lowest_perf); + return; + } + } + + amd_pstate_ut_cases[index].result =3D AMD_PSTATE_UT_RESULT_PASS; +} + +/* + * Check if frequency values are reasonable. + * max_freq >=3D nominal_freq > lowest_nonlinear_freq > min_freq > 0 + * check max freq when set support boost mode. + */ +static void amd_pstate_ut_check_freq(u32 index) +{ + int cpu =3D 0; + struct cpufreq_policy *policy =3D NULL; + struct amd_cpudata *cpudata =3D NULL; + + for_each_possible_cpu(cpu) { + policy =3D cpufreq_cpu_get(cpu); + if (!policy) + break; + cpudata =3D policy->driver_data; + + if (!((cpudata->max_freq >=3D cpudata->nominal_freq) && + (cpudata->nominal_freq > cpudata->lowest_nonlinear_freq) && + (cpudata->lowest_nonlinear_freq > cpudata->min_freq) && + (cpudata->min_freq > 0))) { + amd_pstate_ut_cases[index].result =3D AMD_PSTATE_UT_RESULT_FAIL; + pr_err("%s cpu%d max=3D%d >=3D nominal=3D%d > lowest_nonlinear=3D%d > m= in=3D%d > 0, the formula is incorrect!\n", + __func__, cpu, cpudata->max_freq, cpudata->nominal_freq, + cpudata->lowest_nonlinear_freq, cpudata->min_freq); + return; + } + + if (cpudata->min_freq !=3D policy->min) { + amd_pstate_ut_cases[index].result =3D AMD_PSTATE_UT_RESULT_FAIL; + pr_err("%s cpu%d cpudata_min_freq=3D%d policy_min=3D%d, they should be = equal!\n", + __func__, cpu, cpudata->min_freq, policy->min); + return; + } + + if (cpudata->boost_supported) { + if ((policy->max =3D=3D cpudata->max_freq) || + (policy->max =3D=3D cpudata->nominal_freq)) + amd_pstate_ut_cases[index].result =3D AMD_PSTATE_UT_RESULT_PASS; + else { + amd_pstate_ut_cases[index].result =3D AMD_PSTATE_UT_RESULT_FAIL; + pr_err("%s cpu%d policy_max=3D%d should be equal cpu_max=3D%d or cpu_n= ominal=3D%d !\n", + __func__, cpu, policy->max, cpudata->max_freq, + cpudata->nominal_freq); + return; + } + } else { + amd_pstate_ut_cases[index].result =3D AMD_PSTATE_UT_RESULT_FAIL; + pr_err("%s cpu%d must support boost!\n", __func__, cpu); + return; + } + } + + amd_pstate_ut_cases[index].result =3D AMD_PSTATE_UT_RESULT_PASS; +} + +static int __init amd_pstate_ut_init(void) +{ + u32 i =3D 0, arr_size =3D ARRAY_SIZE(amd_pstate_ut_cases); + + for (i =3D 0; i < arr_size; i++) { + amd_pstate_ut_cases[i].func(i); + switch (amd_pstate_ut_cases[i].result) { + case AMD_PSTATE_UT_RESULT_PASS: + pr_info("%-4d %-20s\t success!\n", i+1, amd_pstate_ut_cases[i].name); + break; + case AMD_PSTATE_UT_RESULT_FAIL: + default: + pr_info("%-4d %-20s\t fail!\n", i+1, amd_pstate_ut_cases[i].name); + break; + } + } + + return 0; +} + +static void __exit amd_pstate_ut_exit(void) +{ +} + +module_init(amd_pstate_ut_init); +module_exit(amd_pstate_ut_exit); + +MODULE_AUTHOR("Meng Li "); +MODULE_DESCRIPTION("Kselftest for AMD P-state driver"); +MODULE_LICENSE("GPL"); --=20 2.25.1 From nobody Thu May 7 17:44:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A353BC433F5 for ; Sun, 22 May 2022 11:55:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344180AbiEVLza (ORCPT ); Sun, 22 May 2022 07:55:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343855AbiEVLzN (ORCPT ); Sun, 22 May 2022 07:55:13 -0400 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2060.outbound.protection.outlook.com [40.107.220.60]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 010DE2CDD0; Sun, 22 May 2022 04:55:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IROfwf1SdwVts3jLKw5oWS9FafI/CGBF7j/3k8hx4XQqk6+cNgsxjUZ9PLe+UFBUAODOoQsnQ5emk6uG0YWDRHDA8VjBa6hsbX5pl0JZ6+0WeeufsNh6IcKhpGwgGqbjLuoG2sawc3TydGqf9SCv4dcW7fL6/Y5zkHqSYLt4QBd+ep+7PeKsArH7J5FMQ5KjfTzFdR0WhuQEPXHZx62poPCLBSAjU+T/+36N2CGQMTtcrtHMQDyVDE6Awt852D9yDOdMJVaNcj57eWvZ5tmsFem865DTtt0YI6Yx9YagyHBJpfpfCtJOUp2NjE3vPZzTGQNNozRfvEi8Fue60D8GMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W7L4MROqeoaltJjpkJ2a3yrAGFgtSA1wgwNyomYl7Wg=; b=jwIbP4ghKwf2RSZXLmFR/mt4jKkQo7UDdzlWRMv0f36bFLkvRDLSrCwpruV96KmyDFVMWbfWEdFf1PAwksddKaBa3sCMTIJUVmPcn/74ALD3V3/cCVds9sGddtffA0hYPN1zStWE8iAwKx8TeTkGVKujDPR0l1cHd5vdGFToczyxbeAENxXsuwWufpZZ8il77T7xK9Ev3xpTryoUM6zgDepU7GNmsuTVc+LXYHU0fbO4wehP4JMUC4PbyqyNBsPDR24zXSnEt0R/JRaqey2YSsO6j0/LeXoMQGLIBztpMm9t9YDuA3Q7kH+C92Sypny5Bli/0nvX9rctyC0tvkEDSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linuxfoundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W7L4MROqeoaltJjpkJ2a3yrAGFgtSA1wgwNyomYl7Wg=; b=lQF8dF/Ff61gdiULgo+uFsufWDqK6L2LNgIDqj3c3DFKTJqg4+lpuX0+QBfi5rVdmLjNDgAHWPylq6lOLhbzF2nS3TfsNYjn+YA57qSdLaFNRItuAOzeKSGlfrBLyZMsK4Dq0aah+lgtOpN/FXOndjpcxhcVnvv28cZKHmlx8a4= Received: from BN0PR04CA0001.namprd04.prod.outlook.com (2603:10b6:408:ee::6) by BN7PR12MB2740.namprd12.prod.outlook.com (2603:10b6:408:23::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.19; Sun, 22 May 2022 11:55:08 +0000 Received: from BN8NAM11FT056.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ee:cafe::2e) by BN0PR04CA0001.outlook.office365.com (2603:10b6:408:ee::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15 via Frontend Transport; Sun, 22 May 2022 11:55:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT056.mail.protection.outlook.com (10.13.177.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Sun, 22 May 2022 11:55:08 +0000 Received: from jasmine-meng.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sun, 22 May 2022 06:55:04 -0500 From: Meng Li To: Shuah Khan , Huang Rui , CC: "Rafael J . Wysocki" , Nathan Fontenot , Deepak Sharma , "Alex Deucher" , Mario Limonciello , Jinzhou Su , Perry Yuan , Xiaojian Du , Viresh Kumar , Borislav Petkov , , Meng Li Subject: [PATCH V7 3/4] selftests: amd-pstate: Add test trigger for amd-pstate driver Date: Sun, 22 May 2022 19:54:22 +0800 Message-ID: <20220522115423.1147282-4-li.meng@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220522115423.1147282-1-li.meng@amd.com> References: <20220522115423.1147282-1-li.meng@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f70d7a8a-51cf-4d82-0b9b-08da3be9eb08 X-MS-TrafficTypeDiagnostic: BN7PR12MB2740:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D87cSkroi4HB6dKg3jeKeOT6/LJyDrsc2O/2tTc/jI9J7GDPH8hIslBL9jAACYAEJRwXzIbx5pSezdEo9T332XWE40vfNN8qCnmXyuEgTcr8T7E+BWOzFK5tVx1yoh0z2iZK/PvB6F20F0Mh1tQTH6EV2XC8Xo4i9UhDw+7/XR1Loin90SVmUZg/QKUucqFQ4gezcbA0lkyDFugMtsV6R9Gcj7HLj6dVkrUePD2R4xOQ19ENqMICWMai9b6Bzqed2sVSJ8pOFuG68/ZOlcWdjsHprJFzGE8vF3vA5P31GIhsJ8Er4w00cveATQ6srNQDI0HEuPDXDtK8Y5ITHuPIFu9krQntCPsatSei2WemUUeggWIEKQMRs7p5EidkJcbNjZHJwyepBiXusq+OLPFPNkbKlBq1e83YgVaLfNoQT7XIiMrQETmiuKyneuFs2hUSQ+DOgsihIoCCK9E9Qce51hBjuNY+Vvk3OSAr5lmpGcrMitXoJymHP/gJUL4nMJGKs8j6kNQ4NoccnIxuXyE6F/wPBhvLrMpmxJASSFmRYdKiPhzwQHRKQAVpbfG8aRbjg+WIuLfOUh0/3/7i72yD4ap68aSnktacZeBTnBoEIgrYg+G7Q8DL3SQTq7S92V7VvLuQocRQHgoZC1Jk/F/U7VmLeJc3p2GCS+xx2i9LsP/6IIqCRoCMOhv5y+QxYd6sfw+aXLkmGaMjRw2WH+/cfw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(316002)(4326008)(54906003)(8676002)(70586007)(70206006)(2906002)(336012)(426003)(47076005)(40460700003)(36756003)(110136005)(36860700001)(82310400005)(186003)(16526019)(7696005)(2616005)(6666004)(26005)(5660300002)(508600001)(8936002)(83380400001)(81166007)(86362001)(356005)(1076003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2022 11:55:08.2157 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f70d7a8a-51cf-4d82-0b9b-08da3be9eb08 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT056.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR12MB2740 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add amd-pstate test trigger in kselftest, it will load/unload amd-pstate-ut module to test some cases etc. Signed-off-by: Meng Li Acked-by: Huang Rui Reviewed-by: Shuah Khan --- tools/testing/selftests/Makefile | 1 + tools/testing/selftests/amd-pstate/Makefile | 9 +++ .../selftests/amd-pstate/amd-pstate-ut.sh | 55 +++++++++++++++++++ tools/testing/selftests/amd-pstate/config | 1 + 4 files changed, 66 insertions(+) create mode 100644 tools/testing/selftests/amd-pstate/Makefile create mode 100755 tools/testing/selftests/amd-pstate/amd-pstate-ut.sh create mode 100644 tools/testing/selftests/amd-pstate/config diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Mak= efile index 2319ec87f53d..975c13368286 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 TARGETS +=3D alsa +TARGETS +=3D amd-pstate TARGETS +=3D arm64 TARGETS +=3D bpf TARGETS +=3D breakpoints diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/se= lftests/amd-pstate/Makefile new file mode 100644 index 000000000000..199867f44b32 --- /dev/null +++ b/tools/testing/selftests/amd-pstate/Makefile @@ -0,0 +1,9 @@ +# SPDX-License-Identifier: GPL-2.0-only +# Makefile for amd-pstate/ function selftests + +# No binaries, but make sure arg-less "make" doesn't trigger "run_tests" +all: + +TEST_PROGS :=3D amd-pstate-ut.sh + +include ../lib.mk diff --git a/tools/testing/selftests/amd-pstate/amd-pstate-ut.sh b/tools/te= sting/selftests/amd-pstate/amd-pstate-ut.sh new file mode 100755 index 000000000000..273364650285 --- /dev/null +++ b/tools/testing/selftests/amd-pstate/amd-pstate-ut.sh @@ -0,0 +1,55 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 + +# amd-pstate-ut is a test module for testing the amd-pstate driver. +# It can only run on x86 architectures and current cpufreq driver +# must be amd-pstate. +# (1) It can help all users to verify their processor support +# (SBIOS/Firmware or Hardware). +# (2) Kernel can have a basic function test to avoid the kernel +# regression during the update. +# (3) We can introduce more functional or performance tests to align +# the result together, it will benefit power and performance scale optimiz= ation. + +# Kselftest framework requirement - SKIP code is 4. +ksft_skip=3D4 + +# amd-pstate-ut only run on x86/x86_64 AMD systems. +ARCH=3D$(uname -m 2>/dev/null | sed -e 's/i.86/x86/' -e 's/x86_64/x86/') +VENDOR=3D$(cat /proc/cpuinfo | grep -m 1 'vendor_id' | awk '{print $NF}') + +if ! echo "$ARCH" | grep -q x86; then + echo "$0 # Skipped: Test can only run on x86 architectures." + exit $ksft_skip +fi + +if ! echo "$VENDOR" | grep -iq amd; then + echo "$0 # Skipped: Test can only run on AMD CPU." + echo "$0 # Current cpu vendor is $VENDOR." + exit $ksft_skip +fi + +scaling_driver=3D$(cat /sys/devices/system/cpu/cpufreq/policy0/scaling_dri= ver) +if [ "$scaling_driver" !=3D "amd-pstate" ]; then + echo "$0 # Skipped: Test can only run on amd-pstate driver." + echo "$0 # Current cpufreq scaling drvier is $scaling_driver." + exit $ksft_skip +fi + +msg=3D"Skip all tests:" +if [ ! -w /dev ]; then + echo $msg please run this as root >&2 + exit $ksft_skip +fi + +if ! /sbin/modprobe -q -n amd-pstate-ut; then + echo "amd-pstate-ut: module amd-pstate-ut is not found [SKIP]" + exit $ksft_skip +fi +if /sbin/modprobe -q amd-pstate-ut; then + /sbin/modprobe -q -r amd-pstate-ut + echo "amd-pstate-ut: ok" +else + echo "amd-pstate-ut: [FAIL]" + exit 1 +fi diff --git a/tools/testing/selftests/amd-pstate/config b/tools/testing/self= tests/amd-pstate/config new file mode 100644 index 000000000000..f43103c9adc4 --- /dev/null +++ b/tools/testing/selftests/amd-pstate/config @@ -0,0 +1 @@ +CONFIG_X86_AMD_PSTATE_UT=3Dm --=20 2.25.1 From nobody Thu May 7 17:44:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61F86C433EF for ; Sun, 22 May 2022 11:55:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344083AbiEVLzh (ORCPT ); Sun, 22 May 2022 07:55:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343884AbiEVLz0 (ORCPT ); Sun, 22 May 2022 07:55:26 -0400 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2068.outbound.protection.outlook.com [40.107.220.68]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A62D93C70D; Sun, 22 May 2022 04:55:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KlGHjVaaGPtzcayYg6bVmgakTdO5jsEQ4FfodDCHYpPAlzVyvlGW/RZ3646PBvvl2zNKb9/9jrHXN5opu/VyQQv3Mdtcm58XpMlgQyTiStL86DrVJFrYwxqfn6OlTdM0OL7QQ7emEvMfutTGZAkG98thCiUXX/U96IfCypTBb99QKWHHm6Yyhq9V3WZrJug3Eln7JAJ7H716kVBvEpz/xtb+CxJXplYIg1SBj/FnZK+pK9KeWWdkFhy+xOzB8U1RmfhqeJ2fZD0fKrScJgBXjlAHiB+9ZFi2cHTO/GlF09BLMgObE4aBOQntB6hX6BEm0Cq99WfAC2pX5C27ZH38Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fd2JK34WkxM19if/uquLUPTM8R7MNjHeR5olxZBm3Pk=; b=OFi0aafra3Xfc14NlLQifExHIBok8nI83quhoh2wSEBImLT3fmxz2cEd8+/kjwdORahh4qbQeFUfWnHcYkavBS7ZrINNOfGzznjBHJhKPn0rjeGPvjBJTk6YDdy6TqEz6v/awmWepCAOkGLpKyK7EMtL9iOYGxj3CVtYMQNoAmTLHAYN9nC8JgI2iOGzBAfCNIIJwBJD24H5w/0ecHSwPt8eiaBFpneDaYJ9IRU2rjDvNqb4DqZ6Fu3MzBiqqeTJg4HsWrpzlLE0GKb0xN+zEc3uVpxFj4N010y1E71N0fbJGLTxBUAZrptHPUo19W5RP1i7Ifikt+1sziux8OTxzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linuxfoundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fd2JK34WkxM19if/uquLUPTM8R7MNjHeR5olxZBm3Pk=; b=1JBY4kYDyUOha6hjeSU0LvPfVWSMo5SrErmLKXFsg4p3VeT5+rd8wEa42h5gNkxOR8844hiSFB407wMm/2Mftk6EVWAtvE+v7XWA8ovuehb7D/yC5QEXG6T+MGqEymc2IFy3oQAVDSrtuDlaJ9zCUG117HegyYU5h5PCtR5siPU= Received: from BN6PR13CA0044.namprd13.prod.outlook.com (2603:10b6:404:13e::30) by DM6PR12MB4578.namprd12.prod.outlook.com (2603:10b6:5:2a9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Sun, 22 May 2022 11:55:12 +0000 Received: from BN8NAM11FT007.eop-nam11.prod.protection.outlook.com (2603:10b6:404:13e:cafe::b3) by BN6PR13CA0044.outlook.office365.com (2603:10b6:404:13e::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.6 via Frontend Transport; Sun, 22 May 2022 11:55:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT007.mail.protection.outlook.com (10.13.177.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Sun, 22 May 2022 11:55:11 +0000 Received: from jasmine-meng.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sun, 22 May 2022 06:55:07 -0500 From: Meng Li To: Shuah Khan , Huang Rui , CC: "Rafael J . Wysocki" , Nathan Fontenot , Deepak Sharma , "Alex Deucher" , Mario Limonciello , Jinzhou Su , Perry Yuan , Xiaojian Du , Viresh Kumar , Borislav Petkov , , Meng Li Subject: [PATCH V7 4/4] Documentation: amd-pstate: Add unit test introduction Date: Sun, 22 May 2022 19:54:23 +0800 Message-ID: <20220522115423.1147282-5-li.meng@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220522115423.1147282-1-li.meng@amd.com> References: <20220522115423.1147282-1-li.meng@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4b1fef3e-d5c7-4690-eaa3-08da3be9ed41 X-MS-TrafficTypeDiagnostic: DM6PR12MB4578:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eW6Jxj56yDPnGrLqml4VDGfM0YGffCbbAmQrzOAeTfSq3t3si0hSa5CeMzg3jI4zewk4/KxpkWod6dLuOwKvxh/kMsa1j9P3BEZ6Jq1mmB732Y+MyiXAsT/51nzvtZ21n72WT7t8AslDAOCAkILqfBd8fk6RloSzsvsOG4v+kGsv9kesCC1rbcm+9ib6qf9v1z9MQVQgnquux7790RLhFKPAdQiT4JVimWErNYW+mmeym2lp7hOF6e0hIMxs2ZRP8np+ykLs4g5OAGh40fUz40/5hh4OnDR+WVomQGoq2NyAdDdZI/AaBPExHthYqXrXQGIoVLUlTwGkdtNL701sX+FcJfSS261yfmRTLnJD2uDeDFojzwvTTJHd8ZNA+mlDmcjzagAGwGUy3p1/NWvYdkh/3xifGHDEIH0nnoSKHgHDoSBK+3dD4YGqKb2P6nftRCtExvZR25631Mr9+cxmtAiAdyyxHrLVdDsIPj8RkjleHEDOggwtLNW/K4iS5yicih1ibN2E4ZEURdnWJC8NAmXBzqJBykbvat+jw9qPwK8DpIncWLCiicUdXLzlZBz+qz6Sj2G6zq29IEomjF+qZAAcuuq8MzEyvV2u0AV6JTqY+4I368caUvXuaHcNXYPvqG2P+AKlSKbcy8nT0FnJg/sF+Tlk5qmIxTpnefMy6k1mHc7dkPY1+P822b5TQzFcBnJ/4AYQXqP453jq25ZgO4IqwleK8NjeAt0XM1iwoeX5zz2qlqtC8bTwD7xlzRYEa61Fj0XwHDXJsWHWEYEX14fP4f/w7aAlycGqwrn9nSIKcCwgq/g3f+Z9e31azyPw9Fmzd9aFpqBf9U9NCsXuhw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(86362001)(47076005)(336012)(54906003)(8936002)(16526019)(1076003)(2616005)(70206006)(70586007)(2906002)(426003)(186003)(4326008)(110136005)(8676002)(36756003)(83380400001)(5660300002)(316002)(26005)(508600001)(82310400005)(6666004)(7696005)(81166007)(40460700003)(966005)(356005)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2022 11:55:11.9504 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4b1fef3e-d5c7-4690-eaa3-08da3be9ed41 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT007.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4578 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Introduce the AMD P-State unit test module design and implementation. Signed-off-by: Meng Li Acked-by: Huang Rui Reviewed-by: Shuah Khan --- Documentation/admin-guide/pm/amd-pstate.rst | 76 +++++++++++++++++++++ 1 file changed, 76 insertions(+) diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/ad= min-guide/pm/amd-pstate.rst index 83b58eb4ab4d..c2b8693601aa 100644 --- a/Documentation/admin-guide/pm/amd-pstate.rst +++ b/Documentation/admin-guide/pm/amd-pstate.rst @@ -182,6 +182,7 @@ to the ``struct sugov_cpu`` that the utilization update= belongs to. Then, ``amd-pstate`` updates the desired performance according to the CPU scheduler assigned. =20 +.. _processor_support: =20 Processor Support =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D @@ -282,6 +283,8 @@ efficiency frequency management method on AMD processor= s. Kernel Module Options for ``amd-pstate`` =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 +.. _shared_mem: + ``shared_mem`` Use a module param (shared_mem) to enable related processors manually with **amd_pstate.shared_mem=3D1**. @@ -393,6 +396,76 @@ about part of the output. :: CPU_005 712 116384 39 49 166 0.75= 65 9645075 2214891 38431470 25.1 11.646 469 2.496 = kworker/5:0-40 CPU_006 712 116408 39 49 166 0.67= 69 8950227 1839034 37192089 24.06 11.272 470 2.496 = kworker/6:0-1264 =20 +Unit Tests for amd-pstate +------------------------- + +``amd-pstate-ut`` is a test module for testing the ``amd-pstate`` driver. + + * It can help all users to verify their processor support (SBIOS/Firmware= or Hardware). + + * Kernel can have a basic function test to avoid the kernel regression du= ring the update. + + * We can introduce more functional or performance tests to align the resu= lt together, it will benefit power and performance scale optimization. + +1. Test case decriptions + + +---------+--------------------------------+----------------------= --------------------------------------------------------------+ + | Index | Functions | Description = | + +=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D+ + | 0 | amd_pstate_ut_acpi_cpc_valid || Check whether the _C= PC object is present in SBIOS. | + | | || = | + | | || The detail refer to = `Processor Support `_. | + +---------+--------------------------------+----------------------= --------------------------------------------------------------+ + | 1 | amd_pstate_ut_check_enabled || Check whether AMD P-= State is enabled. | + | | || = | + | | || AMD P-States and ACP= I hardware P-States always can be supported in one processor. | + | | | But AMD P-States has = the higher priority and if it is enabled with | + | | | :c:macro:`MSR_AMD_CPP= C_ENABLE` or ``cppc_set_enable``, it will respond to the | + | | | request from AMD P-St= ates. | + +---------+--------------------------------+----------------------= --------------------------------------------------------------+ + | 2 | amd_pstate_ut_check_perf || Check if the each pe= rformance values are reasonable. | + | | || highest_perf >=3D no= minal_perf > lowest_nonlinear_perf > lowest_perf > 0. | + +---------+--------------------------------+----------------------= --------------------------------------------------------------+ + | 3 | amd_pstate_ut_check_freq || Check if the each fr= equency values and max freq when set support boost mode | + | | | are reasonable. = | + | | || max_freq >=3D nomina= l_freq > lowest_nonlinear_freq > min_freq > 0 | + | | || If boost is not acti= ve but supported, this maximum frequency will be larger than | + | | | the one in ``cpuinfo`= `. | + +---------+--------------------------------+----------------------= --------------------------------------------------------------+ + +#. How to execute the tests + + We use test module in the kselftest frameworks to implement it. + We create amd-pstate-ut module and tie it into kselftest.(for + details refer to Linux Kernel Selftests [4]_). + + 1. Build + + + open the :c:macro:`CONFIG_X86_AMD_PSTATE` configuration option. + + set the :c:macro:`CONFIG_X86_AMD_PSTATE_UT` configuration option= to M. + + make project + + make selftest :: + + jasminemeng@jasmine-meng:~/amd-brahma$ cd linux + jasminemeng@jasmine-meng:~/amd-brahma/linux$ make -C tools/tes= ting/selftests + + #. Installation & Steps :: + + jasmine@jasmine-meng:~/amd-brahma/linux$ make -C tools/testing/sel= ftests install INSTALL_PATH=3D~/kselftest + jasmine@jasmine-meng:~$ sudo ./kselftest/run_kselftest.sh -c amd-p= state + TAP version 13 + 1..1 + # selftests: amd-pstate: amd-pstate-ut.sh + # amd-pstate-ut: ok + ok 1 selftests: amd-pstate: amd-pstate-ut.sh + + #. Results :: + + jasmine@jasmine-meng:~$ dmesg | grep "amd_pstate_ut" | tee log.txt + [12977.570663] amd_pstate_ut: 1 amd_pstate_ut_acpi_cpc_valid = success! + [12977.570673] amd_pstate_ut: 2 amd_pstate_ut_check_enabled = success! + [12977.571207] amd_pstate_ut: 3 amd_pstate_ut_check_perf = success! + [12977.571212] amd_pstate_ut: 4 amd_pstate_ut_check_freq = success! =20 Reference =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D @@ -405,3 +478,6 @@ Reference =20 .. [3] Processor Programming Reference (PPR) for AMD Family 19h Model 51h,= Revision A1 Processors https://www.amd.com/system/files/TechDocs/56569-A1-PUB.zip + +.. [4] Linux Kernel Selftests, + https://www.kernel.org/doc/html/latest/dev-tools/kselftest.html --=20 2.25.1