From nobody Thu May 7 19:05:59 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BAD9C433FE for ; Fri, 20 May 2022 11:38:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348608AbiETLiI (ORCPT ); Fri, 20 May 2022 07:38:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348565AbiETLh7 (ORCPT ); Fri, 20 May 2022 07:37:59 -0400 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC2568BD04 for ; Fri, 20 May 2022 04:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653046676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fPztGPOmOg22h4lw1Ah2H1abI9PuYR4Jvou0MyiUX9A=; b=kzGOtMLO9ygA3UsV8soVGtLzUKxOcFpwlbgZmIEOGKs7L3LK5ZWC2+mxXAEEsqDutA6Bvt b01Dli2KwA8iQ4Z+priCCEQ9TiCohQR04vN+2ba2b76Xgp24Vl38JUku3dbeKutiLPN7Lk VXy8hZw+WW2yyLexEJ/vVgKedxJn5vI= Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2055.outbound.protection.outlook.com [104.47.1.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-9-TTL6mofeNoOY2KjEBUMtqw-1; Fri, 20 May 2022 13:37:53 +0200 X-MC-Unique: TTL6mofeNoOY2KjEBUMtqw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AKlNeV7K9jl7cv9+l60wL/QnkN8bm4Vxpse0I5aNXbb08hfQWhfhxgug9fq8sOIKJtZTmsT1bue+xwIdPn+82XtpBggrK4ccsPR0LLdkJyk2yMkSiJGUE2g3xm/dZhz8SWhBLsnt6bpZj//rhKqlfKgayvLp/d1CreJnCUpmSaAd4/2Hl3jy0YpfOTcdJzGwbJ8y5vRCUZlHyJz1UZA89xs429mkbGj2V/16AyHFXa+AI1H7+fVUl0mloYuMoIYLwH7C15kkGD/IM887G9PPPwYb0fjmCOGhOo2cOCNy2aF0rmqtTv3KIUGRdUpR2KHP3Hk9yKLbY9WQVWeIBlZDkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OEukA+AtXRqePaCqfqV1aq1pcpfZqW8JaLZRGnc8ka4=; b=Xbam+rvDUrIpKHCiLVu3aEueAOBR0VXMG8FXeAOvaKjh3I2bb00Z57vLaYyq25MXPLdulxFsdwT/LJQJjfDdrlgKgRswJYvAqpOWnUKrjvXY1Q+2XBonIforvlcEkIgfTyFk1vUxsmY5LkFtDE1XXkF5MaS1d1izchX/4OBsbunp1wVVKkcLxCvhj6enimHfhmQtnatreILIeeZHtlmeMFL0nQodiL9N48fu1AR46OnNZX4zapT3LoW5e0yIPFUVJaqLJuQz60rWDXL5AKXVLxgcZUNvToOx0J2o2R45vxXwODG8ikPEUs/BzhelUVZoRX1O5J1MfWcJvUhFVyvFuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DB9PR04MB8107.eurprd04.prod.outlook.com (2603:10a6:10:243::20) by VI1PR0402MB3712.eurprd04.prod.outlook.com (2603:10a6:803:1c::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Fri, 20 May 2022 11:37:51 +0000 Received: from DB9PR04MB8107.eurprd04.prod.outlook.com ([fe80::40a2:1b77:8319:a7fa]) by DB9PR04MB8107.eurprd04.prod.outlook.com ([fe80::40a2:1b77:8319:a7fa%5]) with mapi id 15.20.5273.016; Fri, 20 May 2022 11:37:51 +0000 From: Shung-Hsi Yu To: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org CC: Shung-Hsi Yu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh Subject: [PATCH bpf-next 1/4] bpf: verifier: update resolve_pseudo_ldimm64() comment Date: Fri, 20 May 2022 19:37:25 +0800 Message-ID: <20220520113728.12708-2-shung-hsi.yu@suse.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220520113728.12708-1-shung-hsi.yu@suse.com> References: <20220520113728.12708-1-shung-hsi.yu@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR04CA0061.eurprd04.prod.outlook.com (2603:10a6:20b:48b::15) To DB9PR04MB8107.eurprd04.prod.outlook.com (2603:10a6:10:243::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 44398e4f-cc32-47a2-ceaf-08da3a552c11 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3712:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s8QFGhEDh5purFPmsreZk9Fcek/VhXEuBrIkYEVa64V8XCHhF8lJ5LeoYeyuINL7taqcczHeVZABA2R5Ct6btRvFBWgxcqgb7tqe+GPQwObMeqfSje7TDoYk8gpmAXKlAC5/Rp3SNKlhYnhWQc1GtDbkjMKWFNtDlHcMJcdCF2nu39BKKE2VehviwKQ90cJBVA9LwIIfZUyb4IjIk+LzMgfhyxkPyJ2o2v4j1DudStsMD7y6FEgTisU2OW3e7ALKMN7HQsX6hpQlYHf5ACYqZUL0MQyo1Xn/3nPBdxc7V5pop6oEOWrI4wYcs6ysuhSQkCTM8GQqDLJKoo42ptYKcjCB+fv5+wn9TczA5czpHnLOkBlTWNtDYZuFJdURazWnmxwGZtMXexzfPZObzdlfBynjkrdRf5Ubrg6l5pgHJIXsyC70vte9wRloNwqlEIbvFsl0m3xW6PNUIiSqyEoRGrSMNycVOuK7bkRAkucQW97uMThujlGkiEwNRRsk464JZkYLG6M1T7qRAub5E05VxOruIHDHlkDVrntTSKUJRH2QmY7TrSRgKCFyVkoN1l4eEWKXKzMnSIOfyg7xnSOcIBTqphTI2eKYHcE+XHEw5CSAlX8key5q8q4TlrETyd9iXcbgQBfsJ/Q08tL4mqTiUw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8107.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(8936002)(6486002)(26005)(2616005)(4744005)(2906002)(1076003)(186003)(5660300002)(36756003)(6506007)(6512007)(6666004)(7416002)(83380400001)(15650500001)(54906003)(316002)(8676002)(66946007)(66476007)(66556008)(86362001)(4326008)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Y0jicYKnZ3kD+T0zbHJqYdlCr2RXVd279w7vmEuedVQl6G9R6Y/upi3KmpjP?= =?us-ascii?Q?OD9n+l8vJfHmKCXh/9mCmbIfqKJnVTepY9kUtLr5dHz7tJpgq5WWhQ5HwpPV?= =?us-ascii?Q?rSwZFheHKZAzMWclXqSLoRV1qo55EPsLWA4L59WeSupsvnmiFhQmyMCCB5yU?= =?us-ascii?Q?M87E8LkTcG7JUyAt/nGBw+B7oUnSkv6NtTK2w5ZFjQHiajSFKfb9N5A8T6CU?= =?us-ascii?Q?tQHdPE9PJW2J3IuFmw+LuAKc1K8hP3FV/WaAiI5fA1SWDv1Vz3JdRQ1JTAmM?= =?us-ascii?Q?m/F+AP1Grkb/Pj/sF3JvC175IMQhhm3wknCFrEFgVml7XUUmw+q7SCX9+Pwc?= =?us-ascii?Q?YDL1PNkU8Qt4pLVtpPd8hkvK/g2T51YfoRE9itode1WdZZJnd4wd99/NmIlE?= =?us-ascii?Q?ThJMCQ5gDUjFWT4ilIpD9UGGQreQ8A5tSUHuC1fZUqr3287WnPZoz2CgJanC?= =?us-ascii?Q?qPRN1Ngo8IaBttqGD0D/+hhzZrxQi9eU7mduEWRpR/fJpu90oZj1romYLKIA?= =?us-ascii?Q?dLmwVrxJo7Dyi8EF1sGpFQf/ZnmCEh4QRzdqDr5sWDf9qiM2jppAWjxk/DMr?= =?us-ascii?Q?a0I6JpQhQ/pw+sSv4rSeZ5mGIi2XjorGjPNMhggqF+3WeunDA5kZ4WnBPV+T?= =?us-ascii?Q?HdjD6fme4mlGOSXo7yedagWsx91M36BOwk0uP7TU0gWVv6NkZ+BUPTWY7fgY?= =?us-ascii?Q?gFAzogb9XyFxRxbfmmA7pthWV/l4YhzEKQgYO9/U5X8/Kq6S97H8Xbe57JHv?= =?us-ascii?Q?9Jv2hyahpMdRu+Wq8wbNOdlD9jAyScGChGUtaU6aMylvm4HhPlrTPSUuUC/l?= =?us-ascii?Q?O7igZzZyyMtO93ZxF6tjJTc3lA9Q1wmsbv+i5rJFaMiZiOB778zHvB+rvZNJ?= =?us-ascii?Q?zqDAm9ZHdcUjSVdTxR+I7HUl8p+F5BVPH2K9wCYN+QyIuE55rKxvLiSPpYl1?= =?us-ascii?Q?K+Cn3nYNbT37JGMKvK2+QOPVXlUGJXjmDN5VcPJbz0ufMS5ChIbBj34m4kzB?= =?us-ascii?Q?Qkp34SRT2wnejkdLhFPjMNh135GLEK5qp4QzZ9KiYDMxVgu1HHP+2lfTqQN5?= =?us-ascii?Q?GoyA8KA8OowMmMYi9RDDmDTyihir6BFlc3eZw2PJS+mXCwFO65UktPuBwfe6?= =?us-ascii?Q?bHIhdkbNTrzPYjQ6vT97Ov5pQ1Lp36fYfMhF1heWmhy1OiE3WQjTRu5nAZ4t?= =?us-ascii?Q?YPSqBXt+yj+tODbhsgLWLYrUVnXCjCVbJJmGSEOBQLWOFickV28XBLFGkJCj?= =?us-ascii?Q?Ai83UG8Cv56QvOyziIaTkdDvcTXR+BK2Bt2O6dL1LIuUUZDcB83aIgcYPPMD?= =?us-ascii?Q?1DQHHh8Kz48slavffM01zejhuIXn5OuX0PVT4yis9SyZvAgb253TsyyasK3I?= =?us-ascii?Q?idf6qJ+SW/ChRJbeV7MeMeoXscuV57/YI+C/eL6LVeC4+u6xqoZ01yDaoZ+n?= =?us-ascii?Q?ohRVZDSXYiVOGK9dQtEv2babaUx8AEu2/hF6jWdS0fsFJ2OryWbPStu631+D?= =?us-ascii?Q?6V+yA68Z2L5/nv9SuBGwPIuCK6oipSq4IEL0UQGVmWOkTrIeoMQ0X2bnRaQC?= =?us-ascii?Q?DgNJNblOGq0kKicoYrVAd7FfY3mwGC/gkLrEl0i/9O2MChxAD9RxKPnZqMlz?= =?us-ascii?Q?kML2nI1z1vAk04SYyLEsIii4oNcVCv/9pYG2uRirXrpMQbjuLom/etZ7CAul?= =?us-ascii?Q?WogFukzp1jaz1kSk50p144X7PfJqR8J7pJAIB2qkFTibNzpI6fBLDVs/iIuE?= =?us-ascii?Q?HVdv/6vyAA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44398e4f-cc32-47a2-ceaf-08da3a552c11 X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8107.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 11:37:51.6560 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: enBoXXtB4sqf6TiEPahiGUaOQcwnolbGMAuFY0JqMPfJXACfxtm90vap0HbkmEyQpLlSGZtfvsps7GRc0ysdiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3712 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Since commit 5e581dad4fec ("bpf: make unknown opcode handling more robust") the verifier also checks for opcode validity while resolving file descriptor, update the comment to reflect such fact. Signed-off-by: Shung-Hsi Yu --- kernel/bpf/verifier.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 9b59581026f8..79a2695ee2e2 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -12350,7 +12350,8 @@ static bool bpf_map_is_cgroup_storage(struct bpf_ma= p *map) map->map_type =3D=3D BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE); } =20 -/* find and rewrite pseudo imm in ld_imm64 instructions: +/* check the opcodes of all instructions, and find and rewrite pseudo imm = in + * ld_imm64 instructions: * * 1. if it accesses map FD, replace it with actual map pointer. * 2. if it accesses btf_id of a VAR, replace it with pointer to the var. --=20 2.36.1 From nobody Thu May 7 19:05:59 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD49CC433F5 for ; Fri, 20 May 2022 11:38:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245205AbiETLi2 (ORCPT ); Fri, 20 May 2022 07:38:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348599AbiETLiC (ORCPT ); Fri, 20 May 2022 07:38:02 -0400 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 736F8A5013 for ; Fri, 20 May 2022 04:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653046679; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pdKUfi4l4rSLwtlUmzGsGCFvVvE2oJIhV/wygh4mIpo=; b=juqwbdpOGRM9tvX0jgsdfA/c5LzD4cdf6jYHKK0BoCxApRX7jkpH8G30RWUI9rzdbcx/Jv LxG19APREE0GLTehASWhBVMBY4P5XResKmuGMVbtx4wlrDF08kpd2rQQ94ksT04J6n9jHt 7GBgyKtc5UFMuW+DmkSzC05ShPby4UU= Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-15-c3eyB47XMUGOHX439qwigQ-2; Fri, 20 May 2022 13:37:58 +0200 X-MC-Unique: c3eyB47XMUGOHX439qwigQ-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MS9zlRjL56gb1vEf/KA97ZAmY6A6D/Yrd4qOKN+ejr9mBk7Vix0RHd8tudCxwkZ4ubcmvse6uAOReRZ6LB/3Iflnt91L/sSLKzdXVvG1Ch9XgIAp9sITbx5XR4NuIgv+rGOlT2Kk7nD0MVFMVvgNZDumOhZHK4czdSQRfrS6NYmR3h94sNsoFJMnP7mzkbB6cBXNNIwKV/fF6x6xM+Y0LP+jGWpJd+N2bzvt7pKkY7dLv7uV6FrTYHKJ137c1SZPXjTjIpx+0HYzpKrOuAnBLXFD0EoNtnCXHWs6nH3shZCaQ8Zj1sxFQyYK9NYYXV42pEK7R3xkU2ggodT3u4h7xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lLPug2Nzp0WH84UFjUq7M3TokQjw/w9qo9KxZ/ei0hk=; b=e7XdN26A/R9705GTsxOC9CEpFJNbza275iLy+59bFKfwE51hSS84w+lYwPedl6QKbYP4RAm6prAmrYCkII7ple6oOJYgcT5urznCPs36r77V7xV7aYDj8UWQnzV8BBUFtXV8+SJ+qycNO70F2np9VJeY2cJkw23TzMzAdnvARQB43sQ23MSNVQuwsP1vihwqvl2umBIBSRQyIcrGT+89cuVTUF9qe8amK0NOKHi6eEZ3e6ZMpA/gIMJ2k0FlGcQW8KNrW2aUKlOzhwbSYmySUVyx+2JjRReSo/sFCk2qLXhu8kGjSCjn7mns7+QwT9FWRTz0LBmV+zH7FXsso76ezg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DB9PR04MB8107.eurprd04.prod.outlook.com (2603:10a6:10:243::20) by DB6PR04MB3253.eurprd04.prod.outlook.com (2603:10a6:6:4::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Fri, 20 May 2022 11:37:56 +0000 Received: from DB9PR04MB8107.eurprd04.prod.outlook.com ([fe80::40a2:1b77:8319:a7fa]) by DB9PR04MB8107.eurprd04.prod.outlook.com ([fe80::40a2:1b77:8319:a7fa%5]) with mapi id 15.20.5273.016; Fri, 20 May 2022 11:37:56 +0000 From: Shung-Hsi Yu To: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org CC: Shung-Hsi Yu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh Subject: [PATCH bpf-next 2/4] bpf: verifier: explain opcode check in check_ld_imm() Date: Fri, 20 May 2022 19:37:26 +0800 Message-ID: <20220520113728.12708-3-shung-hsi.yu@suse.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220520113728.12708-1-shung-hsi.yu@suse.com> References: <20220520113728.12708-1-shung-hsi.yu@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR04CA0080.eurprd04.prod.outlook.com (2603:10a6:20b:48b::28) To DB9PR04MB8107.eurprd04.prod.outlook.com (2603:10a6:10:243::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d3d3a47b-e156-4503-f524-08da3a552ec9 X-MS-TrafficTypeDiagnostic: DB6PR04MB3253:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ffo7w+TXODKNiLvqrB7xXgddsoZLRIuIlJ1HEQf5IsILOYsHfU01UZERaTJk9adpFVBpTTvn3LHD5OAtoIO0udBQKBjhaCfmN4um+9+xhfKhEb+GkPMuJl4DvICZjNp7rngMA1CdbN68eWwiF2qY2mlbQTW/9CGH1APyIVQU6TsykvxHMPL8UYenm3pWczekPfF2q3lTv6tg0fqTxoIXs5XyvziAj3qRJGsKq/IUNE4m1S/JH2mJucQYFJKaH56eHF7WEuTEAl0ev13lR8ZvtPQnh2Vq6guuagcza8tUKD54C4oUwi74t/aYrcIq1A98ErEGDh8FTwWWhLaV5Yd+6INwHJNfao9uTeITIFfJxu6t9T8FLwT/N0XAfb32Za2qe/Sh0sslJf++OvnKkx1QBc8zsNTsi6tPUYXKWX7GBt4MUp7ZTjF2HLCTgUu5zcNDaVBObqXu9w33kVVsOKjQmP2F0/XeAOeiJILIyJKUCfrFPlmFv3oGyFxJHML6iwHdHa53jlUVjS/6tEj09koMLgauzD0YbVpdtXr92zOkhaPw4PqDC1Wy7efoaxdHlrTvcy/QCU84AKbL74yDBas29esqS8ITzvG2QPwfvDf++5HfVclNBLmrQMzb+lPw3yLzCGfVhPJ23oe4euRRlPuVVg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8107.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(7416002)(316002)(5660300002)(66946007)(66476007)(66556008)(6512007)(26005)(508600001)(86362001)(1076003)(2616005)(8676002)(6506007)(54906003)(36756003)(4326008)(186003)(6666004)(2906002)(6486002)(8936002)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2gJ05teQjU4KSUTff8mCtagtPpZgEbIjgl7I7MXD0LgaK8aSv7LdOfbyVP1U?= =?us-ascii?Q?VmBRX0DiZlBhuLiznPb6JPxMzW3Xijj4o0D4SmpCsZF4091cFUiE+lw8xe/u?= =?us-ascii?Q?gkiI78yyK68f1oxM+E19G5aI7idsxBL0s0PNMmHyxxMlRLXI6aGPGgRLRsTg?= =?us-ascii?Q?rf92pa8rgFhWACEQOu4NZEQ2Ehr1IUKY9Sy0a26kWv0sP1TeLiYef5rVJLlE?= =?us-ascii?Q?SO0u/a87gs0zGRCTP6ubzsouAyAX+XuWkjH6ck6vWx3JD06pKlP9e/XSuaJk?= =?us-ascii?Q?Sncc8C3dLslM8W9Pe0iq3H0ETFNtT92ZvDB4swzzC93EBNb01gSaplqGAcR5?= =?us-ascii?Q?l70YvaIxzOZkjBXKi0JxFsM9sWHVoItlYq5u8UyK0WmmyKI6mSmKax4NF39v?= =?us-ascii?Q?xYh+scn57QzD1gJIw43xmgduQ/9cESH5YA5VstoB9EiPOESej45CGaXG0apM?= =?us-ascii?Q?+LG0rSE0nuICFtnktAGdJnHBYyYajVjomzLtvMyxGxCXWEAJQsqeMAdsTAbg?= =?us-ascii?Q?mlg6njE2e18oE31OA5y7sj4ikGxz3ie7b0F/NUyvTw4BmLbxXYTdLULbFGBM?= =?us-ascii?Q?CRNjjiMRGzZan5SmQLTB6bZUUV3wjD75xJipFBWDrEsR4T8KED+oYelapxDx?= =?us-ascii?Q?1xiZUYhhfsgKlHE6gYH2Z6iR7F6DKQsKit5APvKb+1kG5dafS8rAKS4QlsA7?= =?us-ascii?Q?mCniiHFb0looMmIulkX9EYICCaYnUG7V0AZbx4mQ/YZMCesTh5xOtDL3mQf2?= =?us-ascii?Q?RKm32su000yOCW+N60xCL1/lbLFURVOx+WGJykTWi6Ppxo00RCrc/dPhuxD1?= =?us-ascii?Q?Nrv260oBclEgc5+nG6fMJkNw0tHJdQOcPbQCuhWfH3c3ftf+lIHP/lFIEag1?= =?us-ascii?Q?JXmgfyRgZZmZj73ljcfn+NVt2pjndxvg6+2IpoGwL5gj47yFD/tyHDgnnbtA?= =?us-ascii?Q?Wj9DaSAye20ESJmu0aIoeduqW7mo+pQ9s/8WLjVQcrTL10lBVfHkeYCYPTJl?= =?us-ascii?Q?Hf4tJMzug/01tSywF8zoQb7VtLMG/AUzXSEV8kyQfb44+DGUWMCbmMkv1pOt?= =?us-ascii?Q?isx/nGS99bAFcLnvHkSfFeR35U0YUrybeeQnUnjkdvBITAd/3HEVNrf0hi5D?= =?us-ascii?Q?+o4W+WV0706ycK1C8n4RVgGlBha8hhBzB1BR2luiTuQfJxHJ/0cqtIC6vjud?= =?us-ascii?Q?UAIwWuTqBrk7gAg+wI9BX9RVzBUDUKMCHJP32mXnjVcDk9+XX+IUcpm2Vrw1?= =?us-ascii?Q?WMqvMtFrnPW0Xqpu2vZa9agMQfFUAj2boY1wWykD14l0gMQwubAPbXiTlbbp?= =?us-ascii?Q?tdHPcfXN3jTgQPWFhdiFGcNMtQXla9fbFiclzMh+Z4S8pwUG04CnO3A4OOf3?= =?us-ascii?Q?RRONUnpGYLM3rz5++fLnL48YycxdHiftl1K6DUPuGJ7ujq6T22r3YpZ8syMx?= =?us-ascii?Q?2Z9+z/NPdlXYOdaf8ybfKNMUW4zM1RpHVVDiDcrLqHuUTXVdp8ey1ZPUnQg5?= =?us-ascii?Q?e9mAjEXizjkO6YI2BtnSjndUncbeTzqzMTelD2vpwhF1Bi6brLUyBkmPYmkf?= =?us-ascii?Q?RQF091kdQ9BG7UBHt6yqdPVKeH70l8NMEM73LKS1y+CWBvk/CKHLiCSejXVz?= =?us-ascii?Q?DIuXozteNH3yCWwET3d+I6GGUu8LrYHwHjb0zWd2LcsSW9G8D4aM9eLjER12?= =?us-ascii?Q?AD40KiT5NQAiNQPB7IL/X7SVIhg6dRgWW5hk7mLj3dpBm6gDWDe6tp+PAZPF?= =?us-ascii?Q?KJNALQqVJw=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3d3a47b-e156-4503-f524-08da3a552ec9 X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8107.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 11:37:56.0933 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WA03VNJyUWJ9gpmt0KRV5Uzh+kUkVcs3FwiTx6DR54X1hZXWVNRoDciQU9QPP9nr6x7bVXs7Q7JHhF39BOKTDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3253 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The BPF_SIZE check in the beginning of check_ld_imm() actually guard against program with JMP instructions that goes to the second instruction of BPF_LD_IMM64, but may be easily dismissed as an simple opcode check that's duplicating the effort of bpf_opcode_in_insntable(). Add comment to better reflect the importance of the check. Signed-off-by: Shung-Hsi Yu --- kernel/bpf/verifier.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 79a2695ee2e2..133929751f80 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -9921,6 +9921,10 @@ static int check_ld_imm(struct bpf_verifier_env *env= , struct bpf_insn *insn) struct bpf_map *map; int err; =20 + /* checks that this is not the second part of BPF_LD_IMM64, which is + * skipped over during opcode check, but a JMP with invalid offset may + * cause check_ld_imm() to be called upon it. + */ if (BPF_SIZE(insn->code) !=3D BPF_DW) { verbose(env, "invalid BPF_LD_IMM insn\n"); return -EINVAL; --=20 2.36.1 From nobody Thu May 7 19:05:59 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 669CDC433F5 for ; Fri, 20 May 2022 11:38:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348607AbiETLiQ (ORCPT ); Fri, 20 May 2022 07:38:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348619AbiETLiI (ORCPT ); Fri, 20 May 2022 07:38:08 -0400 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7995F15A75D for ; Fri, 20 May 2022 04:38:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653046684; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PHnRwheJspQkmn76le7EVGLtzqEbStJTDz8H7sbZgVw=; b=A3t/xGb03rY1kTN1ZQGPO0DKdQxLmNPJzbz27u+LueqJeQO2r04TwZN+38LmBtc4/zzcN2 s4it6w+ykDhm3/6HBHVar/7pcXLrt4/yQM2NrJrudC6AUxMLpyKh9r/VEN1QFB5jIoe3vq WjbbEN4lAMp46WNOgnZ0MiGBePz0q2o= Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-36-U6tm6fWYNpmLyj8qCHWEew-1; Fri, 20 May 2022 13:38:02 +0200 X-MC-Unique: U6tm6fWYNpmLyj8qCHWEew-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TBU9AgsdhvKGoD2Ss143EGsuOAm3wcPJQ/d31DISwnU6Yy08mlEOwYNhTribABWc7nrocxmMZ81jQdTislyBB9YNTHGKuY0Vf7/dK8fJgp9DUYUSIMNKzGYnWj+U7MOoPvCL3WYgsMbBjaexmZX8fP4rmZWreHsdsErGnNbhfSSY2YO2JlfciqeAR5DPNGS4BDdjweU/jC6hA2gPpaF2vpNwczmvBXwjN7eCrGPXb4RtCgUaQVvrOERolXTzMXDdgjK7zKVJMPkmps3BUrkRB6zBIvvhkrKsTgOof54Ktf3sBEn7vfxlh+YN2BKROQlX4+YAqoZFr/YNYq7bkOFemw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9PSMqY10e5/tV5vgnADjiHQ22OyOLc3AAhVtw02N+Dc=; b=JcdWGNdKzM2iX6eq4t21MoVQoSGKKIyNFptNy5JgDmumre8OuRRnuJ90CYUIzaLu4csP9cBHzgR8ywoUcuy7tOnObSTfZGkwq7iFmmpWdvICk54IPhOy2oQll6FLbZ2vGxqNtD5mCD6nu82U89jA19GR7UmwpuLiXAD0MJ+pTfPBhmGv22v008dgN9QoWQk0dcfnplbfaj2hcQnwytZUAhUiHEioMHB8ol10U83Um0w9i12jFi0PxAcJQTmKxWVWPwFnvsMrgW3Me6Na6bLOkQJgD81kffWykbpa7ss0LlL+99oCbh2MLCxwe/7E9AN8ZyxU+oVjBg83jUX3JBDE/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DB9PR04MB8107.eurprd04.prod.outlook.com (2603:10a6:10:243::20) by DB6PR04MB3253.eurprd04.prod.outlook.com (2603:10a6:6:4::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Fri, 20 May 2022 11:38:00 +0000 Received: from DB9PR04MB8107.eurprd04.prod.outlook.com ([fe80::40a2:1b77:8319:a7fa]) by DB9PR04MB8107.eurprd04.prod.outlook.com ([fe80::40a2:1b77:8319:a7fa%5]) with mapi id 15.20.5273.016; Fri, 20 May 2022 11:38:00 +0000 From: Shung-Hsi Yu To: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org CC: Shung-Hsi Yu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh Subject: [PATCH bpf-next 3/4] bpf: verifier: remove redundant opcode checks Date: Fri, 20 May 2022 19:37:27 +0800 Message-ID: <20220520113728.12708-4-shung-hsi.yu@suse.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220520113728.12708-1-shung-hsi.yu@suse.com> References: <20220520113728.12708-1-shung-hsi.yu@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR04CA0076.eurprd04.prod.outlook.com (2603:10a6:20b:48b::18) To DB9PR04MB8107.eurprd04.prod.outlook.com (2603:10a6:10:243::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b9124e83-b4d8-4745-ec1f-08da3a55317a X-MS-TrafficTypeDiagnostic: DB6PR04MB3253:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s+fbsS2Z5m47LoqeIAdyn43XtDtzQ363CaEw5Sr+xKSHWohVQIxJVFmAfN+2Grm51i4I/3kbusIIm9RWR121kdSltxlK+g5uSdUF6YPoBWjZb94iIfhvHP80z6SLYKGSAC5k7AY5iWww+MNypHf/qvsdzh/6huzdWjhpw2sD7PRq+vwiLQlTfUJf7DzJDiWZLy2j/v2b7M8P490JBwxo471Zk50OIEqetdW5M2rWzZABiom5zE0vFSrdvjgOrk7YBOJuZ2xJZSQgS78d2Bc3trJRfnSud6kwierOMRxlq5Jhqejus1ksXYtxo/9IJ+RGjmUnB6Blu54mUrm8Ul3/9UFAbn8fY9oDywzDCQWxMO0BMYDaQuWtnJfrGHn27ULLxVMnHDdqrXhVr7VWwpwh4LFsP2Wk9aS61l/aaVClIJfH1nS+l0DHgXZaVNry1b0VmZAvplMcGO1g8vXfrCn2uxj6R3zyeICGU2mtsqfZkGFlz/RTg80d04BX9VIqf8Zrm+zJO/ugvVXuF9jszijjIKGlFaxsJNdQw6eikLnzhCDo7YHd/TtF3NcA3wvPU93WjU+kVRfLYr1z+naNqpLBzsBEvMwSFOmB7T48eQnDeM4cN9Yrd+6tQOvAtNbHL7ImwnKuoqdXMhiz1RXR7T0ZSw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8107.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(7416002)(316002)(5660300002)(66946007)(66476007)(66556008)(6512007)(26005)(508600001)(86362001)(1076003)(2616005)(8676002)(6506007)(54906003)(36756003)(4326008)(186003)(83380400001)(6666004)(2906002)(6486002)(8936002)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?x4mJRXkZ6vlV9EWYhl/py8/IwTpfRWWa4thujcTORrvm71/iqrAoNipsWDBG?= =?us-ascii?Q?deHvVAtiZSFCCxn6gyC2m0zpttj1Yopfbkdy1HX1uLPLmpSkI958OQGOj+vX?= =?us-ascii?Q?hJkfvUuUc/i8KGeVjd6Jsnnj6X7WC6UFSYgIEJ8ocLHeliPQRPbN99FiA2Uf?= =?us-ascii?Q?DInqkD0S6meO+gkOgYZ1wMI/0MqVTsvYL0KYLLJKUYgEqX+/sQERgFGYmgjY?= =?us-ascii?Q?VATFMYu2QG0xGLYhCxNVMZaTt1Q3jzqAh8qePIznGm+9eBNkTNB144OmX6ME?= =?us-ascii?Q?bRVmA0IWHg8LcoJYnbpMcdqCn5yD6iQ9VJoVUXDbcv/Q4DPLMQxWaAD8wF1s?= =?us-ascii?Q?1Fy/4Q6pmKwlRe/LcUV36guUZv0ncy6KyV3oQRBeQvihFpgpj98IaVa7nOZC?= =?us-ascii?Q?LifL19fN0tmZkwqroyf7ee24eQsX0X2jAdIMpO/WdBaDjFaCx5732LnmVtG/?= =?us-ascii?Q?7PLnQ0QTROKTAC5xjJPpRGkZaIisSb2ADTJT8wHW00a3R0fkCO05UCXYc/w6?= =?us-ascii?Q?Fx5dFWBDY/vzMn8Q8Wp/yczHNlU71/z7iiY8g9u6z8CrDsdVYskVDhlJ7OEs?= =?us-ascii?Q?yNcnjQEYwolGorDWA3ceNyWYcOzFLQ/+MXEtX+0RoJZjTATKDbQFrxI/E+HA?= =?us-ascii?Q?P9sgyS6eltrsK72Istnky8bi4hShQwBBnNuU08gFVJV97WQiIE9NrMO0lLx+?= =?us-ascii?Q?lcOjul0VA7ZGVopK127jSBNCro/ixE65Nno8ODyjHVFf2gQ7KhZ8w0QBXnCH?= =?us-ascii?Q?d/LXIbMX7nvbak4OVjezD5wYx8Xun9URXiqgwrEfupfLufnoQSBT7pyQUX0C?= =?us-ascii?Q?ElxeZooZ2ovRyTQHyqfyGM8CVOayoD8T3g/NkH7B6EhPuPwX6/QIrqXuW5pu?= =?us-ascii?Q?6qT8yP8HVsaKS/3kv+wspaS0Vh84lfOVwWAMk10X+53O6MB0g3YozEsqde+k?= =?us-ascii?Q?HC0XTEC3c/vOxsPOk/fACLUIBVBqohIuxkMu4zbyIRlPv9bD4oVzt2t2tO9n?= =?us-ascii?Q?WsRhD3H5P5K03ZEAmXgSXsOkjHCd1TWT6bhluct9TBOptL5CzSEFxG1hFm+T?= =?us-ascii?Q?JxBl1KSxc67wkHN1k/eMf3IptN3Pk6Myu1TnHTgBJXXL/Sem48MWjjoqkh4P?= =?us-ascii?Q?lR4OzBMMLCPp06s6jd58FcDuMSz69nfVGg5sEqq29yCA3IW/AclFXWMWXqdV?= =?us-ascii?Q?33zq6EOOVGm30wUdwLssL/VwX0VtM4WA30xqnuRm90YFarjJFGiIMtfjFHi8?= =?us-ascii?Q?lm2DJ/MIosKJ4xK1BLaq8RsaAx6Iunz2nk2SZdOwgVB7+fWDY/Fel093P7Bb?= =?us-ascii?Q?hoZA6T7dnsVihAxTvkglKCr0KuGDXWTy98/sMrFJNHNLg9HMi9jPHEZHL6je?= =?us-ascii?Q?KrBaNSIQesDhGWW0fpls0SqLwDeSvi8NsujsoYimKwfc9RXn5hZ+4fHdcaIz?= =?us-ascii?Q?MKcQzxIdiyqtZCeClFFrbVo4Cdfwr9PV3MVIAkDliKrqJk/iFeE/iFGoVvfx?= =?us-ascii?Q?VsYv/n1Dkqsxajr535jTh4/1+eGBWy/IUhvPs6TaRF5gzBrpc/rdyoa0DuIG?= =?us-ascii?Q?vihGnRhc97Wv3oK4QLxjSZw7don9rZxDRJG9lDj8VG5eIUoW7pzXlGKzR3gG?= =?us-ascii?Q?AYufl/tSxJtUY/pkkLuM51wA8xuqxv68eWzojVw3CWaZqO++6pxQ4mht1Yue?= =?us-ascii?Q?9RrwD+aoH5U35YyFb/jjJM/AGluj+Yr8awg+jvKi5Ozu4u2Ux5RSFGlPixh2?= =?us-ascii?Q?Wl3V39OUDQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9124e83-b4d8-4745-ec1f-08da3a55317a X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8107.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 11:38:00.4523 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lHSqXRmBBPy7JQoYiyus/x4blOO5ezM1G0HVO1LxBoFOtL+Q2NyOigE/UdzcLWEUpm+5GdsbLUez330wPVCi8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3253 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The introduction of opcode validation with bpf_opcode_in_insntable() in commit 5e581dad4fec ("bpf: make unknown opcode handling more robust") has made opcode checks done in do_check_common() and its callees redundant, so either remove them entirely, or turn them into comments in places where the redundancy may not be clear. Opcode code check is not removed for BPF_LD_{ABS,IND} in check_ld_abs() and BPF_JMP_{JA,CALL,EXIT} in do_check() because they cover opcode validation not done in bpf_opcode_in_insntable(). Signed-off-by: Shung-Hsi Yu --- kernel/bpf/verifier.c | 26 ++++++++------------------ 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 133929751f80..d528848083b9 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -4797,11 +4797,6 @@ static int check_atomic(struct bpf_verifier_env *env= , int insn_idx, struct bpf_i return -EINVAL; } =20 - if (BPF_SIZE(insn->code) !=3D BPF_W && BPF_SIZE(insn->code) !=3D BPF_DW) { - verbose(env, "invalid atomic operand size\n"); - return -EINVAL; - } - /* check src1 operand */ err =3D check_reg_arg(env, insn->src_reg, SRC_OP); if (err) @@ -8793,8 +8788,7 @@ static int check_alu_op(struct bpf_verifier_env *env,= struct bpf_insn *insn) } } else { if (insn->src_reg !=3D BPF_REG_0 || insn->off !=3D 0 || - (insn->imm !=3D 16 && insn->imm !=3D 32 && insn->imm !=3D 64) || - BPF_CLASS(insn->code) =3D=3D BPF_ALU64) { + (insn->imm !=3D 16 && insn->imm !=3D 32 && insn->imm !=3D 64)) { verbose(env, "BPF_END uses reserved fields\n"); return -EINVAL; } @@ -11874,9 +11868,8 @@ static int do_check(struct bpf_verifier_env *env) return err; env->insn_idx++; continue; - } - - if (BPF_MODE(insn->code) !=3D BPF_MEM || insn->imm !=3D 0) { + } else if (insn->imm !=3D 0) { + /* check for mode is already done, so mode can only be BPF_MEM */ verbose(env, "BPF_STX uses reserved fields\n"); return -EINVAL; } @@ -11909,8 +11902,7 @@ static int do_check(struct bpf_verifier_env *env) } =20 } else if (class =3D=3D BPF_ST) { - if (BPF_MODE(insn->code) !=3D BPF_MEM || - insn->src_reg !=3D BPF_REG_0) { + if (insn->src_reg !=3D BPF_REG_0) { verbose(env, "BPF_ST uses reserved fields\n"); return -EINVAL; } @@ -11944,8 +11936,7 @@ static int do_check(struct bpf_verifier_env *env) (insn->src_reg !=3D BPF_REG_0 && insn->src_reg !=3D BPF_PSEUDO_CALL && insn->src_reg !=3D BPF_PSEUDO_KFUNC_CALL) || - insn->dst_reg !=3D BPF_REG_0 || - class =3D=3D BPF_JMP32) { + insn->dst_reg !=3D BPF_REG_0) { verbose(env, "BPF_CALL uses reserved fields\n"); return -EINVAL; } @@ -11968,8 +11959,7 @@ static int do_check(struct bpf_verifier_env *env) if (BPF_SRC(insn->code) !=3D BPF_K || insn->imm !=3D 0 || insn->src_reg !=3D BPF_REG_0 || - insn->dst_reg !=3D BPF_REG_0 || - class =3D=3D BPF_JMP32) { + insn->dst_reg !=3D BPF_REG_0) { verbose(env, "BPF_JA uses reserved fields\n"); return -EINVAL; } @@ -11981,8 +11971,7 @@ static int do_check(struct bpf_verifier_env *env) if (BPF_SRC(insn->code) !=3D BPF_K || insn->imm !=3D 0 || insn->src_reg !=3D BPF_REG_0 || - insn->dst_reg !=3D BPF_REG_0 || - class =3D=3D BPF_JMP32) { + insn->dst_reg !=3D BPF_REG_0) { verbose(env, "BPF_EXIT uses reserved fields\n"); return -EINVAL; } @@ -14751,6 +14740,7 @@ int bpf_check(struct bpf_prog **prog, union bpf_att= r *attr, bpfptr_t uattr) if (ret) goto skip_full_check; =20 + /* checks for validity of opcodes */ ret =3D resolve_pseudo_ldimm64(env); if (ret < 0) goto skip_full_check; --=20 2.36.1 From nobody Thu May 7 19:05:59 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55949C433EF for ; Fri, 20 May 2022 11:39:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348627AbiETLi7 (ORCPT ); Fri, 20 May 2022 07:38:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348620AbiETLiy (ORCPT ); Fri, 20 May 2022 07:38:54 -0400 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B67C15AB01 for ; Fri, 20 May 2022 04:38:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653046692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nUgKGJ3O0a2AcI0M7Li2xW8xlIFt0nekuPR5p7Jv008=; b=T5sHWe03SID1kqcVhQtS8xdX/98iuepOAqYdW/2FaiqoIYJZ8Qp+qd/l4ynJJXvMM/UgTB O+mD26GL/ITfCw9IJUPKLpgcpZaNNxah1wIgEmHymZ+g+EwJt2v1cVyMsGwxQyLKKpyRe8 XPj8BDUOdF4zN69rohbUg2LhPEwkt/c= Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2057.outbound.protection.outlook.com [104.47.14.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-20-xSRJOZfWPQaJ_cWg9diAQw-1; Fri, 20 May 2022 13:38:09 +0200 X-MC-Unique: xSRJOZfWPQaJ_cWg9diAQw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VM5Xoy+UaQPnNlVGzIO4679rwjwD7qjZRqZH3LOCdyrSFvWOlC9A0cDEwc2ehm8SYccyyLFDNF2x6irS6JiYwCsC5O64/wYNMJk8ai32VA2GAC8Z0kDUdt0Gln/7jSpXeJRIrkt+U1E9EJJD9KN2c5pdp2pU66QJ7xLTYQs3wgDSIz78Us3eHy2alDoi+K6XrF/e6OychbwK1qIzuiUUfWPscTOwggonoXlZ8H8+lN9Mpua+YJLIvdcBYcXZ5YIsxbf/WHn4h4T3Vo5xhX8Af2KwiUTCGfc7RHfsdIJnQcxt5KHGiQc6DREJo0/dppeqbo8Oh1VdIqnWz+ag+8ML6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xmzjpod21e6Cbz4kt7krDw3PSKbJIqoBQQasfgfdzH0=; b=FLnsmrU3b/QBBbmHZ3FUouMr5nacQm7ZhrTFLo1L+8VsfrBpnmLVoAksdVrpZ/PPkIvlZpnGnBzxQbwnQDrOKGod2PipBuqTKOJR3aEIi3M8hDNZjj3LHsHkbmAX9xIo82L8TwhFVzAvq1YURknLETBu/UbLkCgrT7V2ll5GEMq6Ht4LKB+up8VNcFAvCrGWx4XR25S7rEI8Dknsg9uMLYl/wFBQTEISqpcaTd/t+sAvSVRTCBHD8B5FogbOvsCgvIglk/Osxln+cbpdyDlbSJ8fUbLXpmMMCDRUab7DhYAenA+8H/n88AePc5gLOH/QlZzl0+9U4yMZeSUFtUjdVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DB9PR04MB8107.eurprd04.prod.outlook.com (2603:10a6:10:243::20) by VI1PR04MB6014.eurprd04.prod.outlook.com (2603:10a6:803:c9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 11:38:06 +0000 Received: from DB9PR04MB8107.eurprd04.prod.outlook.com ([fe80::40a2:1b77:8319:a7fa]) by DB9PR04MB8107.eurprd04.prod.outlook.com ([fe80::40a2:1b77:8319:a7fa%5]) with mapi id 15.20.5273.016; Fri, 20 May 2022 11:38:06 +0000 From: Shung-Hsi Yu To: Shung-Hsi Yu , linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org CC: Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh Subject: [PATCH bpf-next 4/4] selftests/bpf: add reason of rejection in ld_imm64 Date: Fri, 20 May 2022 19:37:28 +0800 Message-ID: <20220520113728.12708-5-shung-hsi.yu@suse.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220520113728.12708-1-shung-hsi.yu@suse.com> References: <20220520113728.12708-1-shung-hsi.yu@suse.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM5PR0502CA0010.eurprd05.prod.outlook.com (2603:10a6:203:91::20) To DB9PR04MB8107.eurprd04.prod.outlook.com (2603:10a6:10:243::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f1f51714-7f93-4ca1-63d0-08da3a5534e1 X-MS-TrafficTypeDiagnostic: VI1PR04MB6014:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3HDc22kyX/23JRo+VeW6sX8hz01WC2XlEhzFUZ5+uTPAVUuR7b3l/hvrqTCAQLALlezN9/CDan9eh8qCvZh/CUMOqCwkxm3784vcvMl1aJgNAgdAfd6KmRBiOUXtqAePr+ZoG5ohLTuMlqOBgVW2yreGcLODa19paKMwC0Q20oawS8MwYd/COuGTIOSSDscMPnKzpApfqnPmg5RDBGZcfd0blCwvgi++vnzgXONiNnHsa9x7tbrC67Bhzm+YwCQLGHlvtqLZSvivsNiw5waXS96sLTKcoNvTlx1f5BTuL0JmU8vNoQpprD5h+CNgq1mACPQPCJC3E3ktBl4tnxM0pT4igjRfu11Fe/Fj/uCoeejrgq2aj1xEQ/M+0kOaPKv0uwweJSjGjl87uINc9jq7WeWchDannPXbJW5+N3BGlZ9n9tHAoZOtu0NbNUJAZJBywo9LSPQv2+q250OZKUjqW0Wj1E41qZ6GB3JxSYvxOAP3tIMjtiSkTtlNsInRpb/wzGX0r2RhzVaUu5fuRGsP7uEjDouu0zoY9RfcoYs5T5jIQoz+iQ5Svcrv8OKoz412Wl0jKFs6umHYJoF8/3HNTGF6Ozh0adXfIjuCos/1XMt5/yodOw87XlAYK1x9tJOG+4/YEPc9lilTXBoxkcYkbw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8107.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(5660300002)(38100700002)(36756003)(66476007)(8936002)(66556008)(66946007)(7416002)(8676002)(86362001)(4326008)(186003)(6486002)(83380400001)(1076003)(2616005)(26005)(2906002)(316002)(54906003)(6512007)(6666004)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?13iNxCmyS4ttz4BJKKZxII+Y2qPXOjbPuJNuC90e5HK44O3sUPCnURwO+kkX?= =?us-ascii?Q?dCj8dU3qLFoDOiiL62zpIfHrWHIKWsJqB3fzS2mEiJy37DRTVeKCwCYzobob?= =?us-ascii?Q?pH4PnYNSITWXAq/hqqW3K/Mag8vw5RCZlHVlBdMgX/rPeY3W/qx/PWSnYspp?= =?us-ascii?Q?qeQJiei6N5g4wejGvTdBTb3rasZ9f8k5+5OsgqnDaxFBhCmYZO/ldagTPWFE?= =?us-ascii?Q?cqJzttld3EFFQJKXO/oLis/I/5zvoNM0tQK/G/n2E39gKXvJ9k0d0nJA4r32?= =?us-ascii?Q?+EPvc16NaR05c/J1M8OxlC+KIgc9JYs0qxeLumExww8nz/LAWehjcF8bgczf?= =?us-ascii?Q?/G7oAQ4VSNYhSZe2YK6nuIU3yf5BoJjEWQNAnr3omY0VR8ycYIf8d+e0oagw?= =?us-ascii?Q?ZN0bCGTg2ohAiAaO/ZTEOXYirTG8TPdYr6NptbohWNSohP9Q08ergwNZc/pN?= =?us-ascii?Q?hU9aTI3FjLSvsWhLt4JY8zAKtQhMKAc+7wB3AINritTb1cI9uEhU6wyCI37b?= =?us-ascii?Q?9u2SY9OD1Sc7Yu/Y8gl1Bo/5JZMkTnN1jkmoq1uqF1G991/62ok+Vj8qd8JE?= =?us-ascii?Q?uBywx0I7+kTUm+z5XPSpqLAbX1ffhDhhf2Hq58mqWhlrhGkumwkdWdhlI1GR?= =?us-ascii?Q?bRiATstxJVURk/wcH8cgUA0FMTute0KZ9Izu63gS6xF4Lw63IQfy8pJ6kKi5?= =?us-ascii?Q?ofTz7jtA6oyKmlaLIrZa9FRwamjR0Iz49el506FMjdUddOFqYZh2rku5+0Dm?= =?us-ascii?Q?TkWHXNvlzMTYaDmH4YXVZqpHLn+JzhZS4IyRJp4zIPf6wAzTTova78phWkqH?= =?us-ascii?Q?zXH6DD2mpeaS5dQqCzw8PKOVC+xq6m95TtBfIklEY4nvhyLBpEjUIxtCPfCb?= =?us-ascii?Q?HdKICcbpC3om7WY4NrjMJIGsHFAbmobGNOYpF0cxdgRH/CX9XqvHg2EyhNMz?= =?us-ascii?Q?+tIBJ5YWUvW/N/usbR8Zte4q3kmCmvtRKfoxeoYdWCdN3LDrg/4kyK1pvywn?= =?us-ascii?Q?sn40ey/uuUEDC9ukFq3++2Fg+uSDoZSH18m2swoovwHeFzWgP0bARF+cztVU?= =?us-ascii?Q?gAISSAnX28+zQQE9KvCj/PGpLCdC4Lp0WR9YTfh4Mrz7+ls0FVkQt1BxjNkW?= =?us-ascii?Q?9ngcDEQ3Hs9PSmsm64TbK9UIsgTIsSexEJ6u2okcX9yEP80KXESJP6jdyo00?= =?us-ascii?Q?HV2qYbNHwYxYkRTffWwTHyYDgHL4K5QJxIAZMCAqAvE1aw+GlhEVS6+9Kyq1?= =?us-ascii?Q?GAg54gNbZPsQXuKOg5yznrjhiLUQCgJon9jAycYb5K9++arJMSyvPC4tycpc?= =?us-ascii?Q?qMy90MueELrZ8s7rCZ3/6juWmDN9bn+d6NLraPb90QLlH8vkU6CWyRyQ5KXu?= =?us-ascii?Q?zXDiG8pTCSe9bomb8OxtPwv5HUFkm6S3ImxVE1en0NhjKQDXbRnZrGsEN9le?= =?us-ascii?Q?0Lz5HiJXwABnW5y9YNpay6UyuWQsK3NQizXWzFx2P2V7ShETa2tP6Tf5haiZ?= =?us-ascii?Q?v/v2AT56yoOVUEG3ZcxLUFpjv8RwtjuZX9GDZY6w7LTXlye7oyVXqWej+SOh?= =?us-ascii?Q?4W9K2ucQBUBJadAIhpO4zUYJ2nMm2c4G4uNAZpZnMZBkI2chfUQdfBSaCx/f?= =?us-ascii?Q?yI4aQQktzAXgb9JcjV9+Rfvrr+tsmZY8x3/k1Xekdb0yZVRoCSb8xnDhB//Y?= =?us-ascii?Q?NqAcHbEKu/Zbcsu7+mQBBz11Le84SfRU1WT4X5QgMe01Q+Cnh55sWHRMQ13Z?= =?us-ascii?Q?SaihelwNWA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1f51714-7f93-4ca1-63d0-08da3a5534e1 X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8107.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 11:38:06.1101 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K6aHrWjv2aPSAzCmP6OGJK2/r52hPVIny4FIJNq56hKMhFzPpJtN9uDtE51+wl93kC2Eah1eWcV7/plD5PWQpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6014 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" It may not be immediately clear why that ld_imm64 test cases are rejected, especially for test1 and test2 where JMP to the 2nd instruction of BPF_LD_IMM64 is performed. Add brief explaination of why each test case in verifier/ld_imm64.c should be rejected. Signed-off-by: Shung-Hsi Yu --- .../testing/selftests/bpf/verifier/ld_imm64.c | 20 ++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/bpf/verifier/ld_imm64.c b/tools/testin= g/selftests/bpf/verifier/ld_imm64.c index f9297900cea6..021312641aaf 100644 --- a/tools/testing/selftests/bpf/verifier/ld_imm64.c +++ b/tools/testing/selftests/bpf/verifier/ld_imm64.c @@ -1,5 +1,6 @@ +/* Note: BPF_LD_IMM64 is composed of two instructions of class BPF_LD */ { - "test1 ld_imm64", + "test1 ld_imm64: reject JMP to 2nd instruction of BPF_LD_IMM64", .insns =3D { BPF_JMP_IMM(BPF_JEQ, BPF_REG_1, 0, 1), BPF_LD_IMM64(BPF_REG_0, 0), @@ -14,7 +15,7 @@ .result =3D REJECT, }, { - "test2 ld_imm64", + "test2 ld_imm64: reject JMP to 2nd instruction of BPF_LD_IMM64", .insns =3D { BPF_JMP_IMM(BPF_JEQ, BPF_REG_1, 0, 1), BPF_LD_IMM64(BPF_REG_0, 0), @@ -28,7 +29,7 @@ .result =3D REJECT, }, { - "test3 ld_imm64", + "test3 ld_imm64: reject incomplete BPF_LD_IMM64 instruction", .insns =3D { BPF_JMP_IMM(BPF_JEQ, BPF_REG_1, 0, 1), BPF_RAW_INSN(BPF_LD | BPF_IMM | BPF_DW, 0, 0, 0, 0), @@ -42,7 +43,7 @@ .result =3D REJECT, }, { - "test4 ld_imm64", + "test4 ld_imm64: reject incomplete BPF_LD_IMM64 instruction", .insns =3D { BPF_RAW_INSN(BPF_LD | BPF_IMM | BPF_DW, 0, 0, 0, 0), BPF_EXIT_INSN(), @@ -70,7 +71,7 @@ .retval =3D 1, }, { - "test8 ld_imm64", + "test8 ld_imm64: reject 1st off!=3D0", .insns =3D { BPF_RAW_INSN(BPF_LD | BPF_IMM | BPF_DW, 0, 0, 1, 1), BPF_RAW_INSN(0, 0, 0, 0, 1), @@ -80,7 +81,7 @@ .result =3D REJECT, }, { - "test9 ld_imm64", + "test9 ld_imm64: reject 2nd off!=3D0", .insns =3D { BPF_RAW_INSN(BPF_LD | BPF_IMM | BPF_DW, 0, 0, 0, 1), BPF_RAW_INSN(0, 0, 0, 1, 1), @@ -90,7 +91,7 @@ .result =3D REJECT, }, { - "test10 ld_imm64", + "test10 ld_imm64: reject 2nd dst_reg!=3D0", .insns =3D { BPF_RAW_INSN(BPF_LD | BPF_IMM | BPF_DW, 0, 0, 0, 1), BPF_RAW_INSN(0, BPF_REG_1, 0, 0, 1), @@ -100,7 +101,7 @@ .result =3D REJECT, }, { - "test11 ld_imm64", + "test11 ld_imm64: reject 2nd src_reg!=3D0", .insns =3D { BPF_RAW_INSN(BPF_LD | BPF_IMM | BPF_DW, 0, 0, 0, 1), BPF_RAW_INSN(0, 0, BPF_REG_1, 0, 1), @@ -113,6 +114,7 @@ "test12 ld_imm64", .insns =3D { BPF_MOV64_IMM(BPF_REG_1, 0), + /* BPF_REG_1 is interpreted as BPF_PSEUDO_MAP_FD */ BPF_RAW_INSN(BPF_LD | BPF_IMM | BPF_DW, 0, BPF_REG_1, 0, 1), BPF_RAW_INSN(0, 0, 0, 0, 0), BPF_EXIT_INSN(), @@ -121,7 +123,7 @@ .result =3D REJECT, }, { - "test13 ld_imm64", + "test13 ld_imm64: 2nd src_reg!=3D0", .insns =3D { BPF_MOV64_IMM(BPF_REG_1, 0), BPF_RAW_INSN(BPF_LD | BPF_IMM | BPF_DW, 0, BPF_REG_1, 0, 1), --=20 2.36.1